From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dinh Nguyen Date: Tue, 1 Mar 2016 16:16:25 -0600 Subject: [U-Boot] placement for new clock drivers In-Reply-To: References: <56D47850.4060702@opensource.altera.com> Message-ID: <56D614B9.5090202@opensource.altera.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 02/29/2016 08:03 PM, Simon Glass wrote: >> >> I think going forward, it would make sense to place the driver to be of >> UCLASS_CLK and would go into drivers/clk/, instead of under >> arch/arm/mach-socfpga directory, Am I correct in assuming that? > > Yes. > Do you see any benefits to moving an existing clock driver that is in arch/ to drivers/clk and making it UCLASS_CLK? > > Do you have a driver for altr,clk-mgr? If not you could add a driver, > or maybe "simple-bus" to the compatible string. > > If you add a driver, see simple_bus_post_bind() for the function you > need to call to bind devices in sub-nodes. > The reason I ask is that I think I will have to create a driver for "altr,clk-mgr" for the Arria10 platform, so I'm just wondering if I should do the same for a legacy clock manager. Thanks, Dinh