From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4] OMAP3: Various: Future-proof serial platdata
Date: Wed, 2 Mar 2016 01:31:46 +0100 [thread overview]
Message-ID: <56D63472.8020806@suse.de> (raw)
In-Reply-To: <CAHCN7xLe1akh8EgQ1asLqzPHB3q4VG+3zy+DvihQebii57qHuA@mail.gmail.com>
On 02.03.16 01:05, Adam Ford wrote:
> I can only test OMAP3, and I tried to state that in the patch. I grepped
> for the platdata structure and not that manu boards aooeared. I didn't
> want to just fix the board that affects me, but I didn't want to go
> beyond the platform for fear of breaking something and not being able to
> test it.
I think in this case the change is simple enough that code review should
catch issues quickly.
I really don't think it's a good idea to convert 80% of the code base
and leave 20% for some random point in time later. It's a great recipe
for disaster :). Let's just get rid of all unnamed struct field
initializers for the serial port and call it a day.
Alex
next prev parent reply other threads:[~2016-03-02 0:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 23:23 [U-Boot] [PATCH V4] OMAP3: Various: Future-proof serial platdata Adam Ford
2016-03-02 0:01 ` Alexander Graf
2016-03-02 0:05 ` Adam Ford
2016-03-02 0:31 ` Alexander Graf [this message]
2016-03-02 11:29 ` Adam Ford
2016-03-02 15:13 ` Alexander Graf
2016-03-03 15:44 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D63472.8020806@suse.de \
--to=agraf@suse.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox