From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Wed, 2 Mar 2016 01:31:46 +0100 Subject: [U-Boot] [PATCH V4] OMAP3: Various: Future-proof serial platdata In-Reply-To: References: <1456874609-29666-1-git-send-email-aford173@gmail.com> <56D62D53.6060901@suse.de> Message-ID: <56D63472.8020806@suse.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02.03.16 01:05, Adam Ford wrote: > I can only test OMAP3, and I tried to state that in the patch. I grepped > for the platdata structure and not that manu boards aooeared. I didn't > want to just fix the board that affects me, but I didn't want to go > beyond the platform for fear of breaking something and not being able to > test it. I think in this case the change is simple enough that code review should catch issues quickly. I really don't think it's a good idea to convert 80% of the code base and leave 20% for some random point in time later. It's a great recipe for disaster :). Let's just get rid of all unnamed struct field initializers for the serial port and call it a day. Alex