public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] am33xx: Update serial platdata to update reg_offset to 0
Date: Wed, 2 Mar 2016 12:53:35 +0100	[thread overview]
Message-ID: <56D6D43F.9010909@xilinx.com> (raw)
In-Reply-To: <CAHCN7x+8v8t7Zi2Hf61mSRtMOs9-Rs-KH8RrHL1oPwYRiMBOWA@mail.gmail.com>

On 2.3.2016 12:09, Adam Ford wrote:
> On Mon, Feb 29, 2016 at 11:55 PM, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>> On Monday 29 February 2016 03:03 PM, Lokesh Vutla wrote:
>>>
>>> On Monday 29 February 2016 02:55 PM, Mugunthan V N wrote:
>>>>> With commit: d9a3bec682f9 "dm: ns16550: Add support for reg-offset property"
>>>>> reg_offset is added to the struct ns16550_platdata to be
>>>>> dt compatible with Linux kernel driver, TI AM335x evms are broken
>>>>> as the serial platdata updates wrong offsets. Correcting it with
>>>>> initializing reg_offset to zero.
>>> Acked-by: Lokesh Vutla <lokeshvutla@ti.com>
>>>
>>> This will be true for OMAP5+ platforms as well. I guess that array also
>>> needs to be updated?
>>
>> Apart from AM335x, no other platform is converted to DM for non-dt boot,
>> so there is no issues with other TI platforms.
> 
> Due to the way the structure was changed, a bunch of omap3 boards
> broke because they hard-coded the values expecting them in a certain
> order in the structure.  The patch has since been reverted.

the patch was reverting just because we are close to release not because
the patch is wrong. It will be added again in the merge window.
That's why I am asking you to define your structure right with proper
assignment or you will deal with this problem pretty soon again.
The best all these patches should come to the tree before my patch.

Thanks,
Michal

  reply	other threads:[~2016-03-02 11:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29  9:25 [U-Boot] [PATCH 1/1] am33xx: Update serial platdata to update reg_offset to 0 Mugunthan V N
2016-02-29  9:33 ` Lokesh Vutla
2016-03-01  5:55   ` Mugunthan V N
2016-03-02 11:09     ` Adam Ford
2016-03-02 11:53       ` Michal Simek [this message]
2016-03-02 12:18         ` Adam Ford
2016-03-02 12:24           ` Michal Simek
2016-03-02 12:55             ` Adam Ford
2016-03-03  4:49               ` Mugunthan V N
2016-03-08  3:23                 ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D6D43F.9010909@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox