From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Thu, 3 Mar 2016 09:58:32 -0700
Subject: [U-Boot] [PATCH 4/9] sandbox: Avoid calling commands when not
 available
In-Reply-To: <CAPnjgZ2GO9tN1U4+BhTx5bSbC+-m+NnC6EKRjqmpCoNqz-qS3Q@mail.gmail.com>
References: <1456459256-32643-1-git-send-email-sjg@chromium.org>
 <1456459256-32643-5-git-send-email-sjg@chromium.org>
 <56D4D6CE.8040703@wwwdotorg.org>
 <CAPnjgZ2GO9tN1U4+BhTx5bSbC+-m+NnC6EKRjqmpCoNqz-qS3Q@mail.gmail.com>
Message-ID: <56D86D38.7050400@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 03/02/2016 05:25 PM, Simon Glass wrote:
> Hi Stephen,
>
> On 29 February 2016 at 16:39, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 02/25/2016 09:00 PM, Simon Glass wrote:
>>>
>>> Don't try to run commands when not supported.
>>
>>
>>> diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c
>>
>>
>>> +int board_run_command(const char *cmdline)
>>> +{
>>> +       printf("## Commands are disabled. Please enable
>>> CONFIG_CMDLINE.\n");
>>> +
>>> +       return 1;
>>> +}
>>> +
>>
>>
>> Isn't this part of patch 5/9?
>
> No - this is the sandbox support. That patch merely declares the
> function in a header. Any board can implement it, and each would do so
> in a separate patch.

OK, but this patch implements the function before there's a prototype 
for it in the header. That doesn't seem like the correct order.