From: Lokesh Vutla <a0131933@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: AM57xx: Update EMIF registers
Date: Tue, 8 Mar 2016 09:04:18 +0530 [thread overview]
Message-ID: <56DE483A.6000506@ti.com> (raw)
In-Reply-To: <20160307233607.GT23166@bill-the-cat>
On Tuesday 08 March 2016 05:06 AM, Tom Rini wrote:
> On Sat, Mar 05, 2016 at 05:33:39PM +0530, Lokesh Vutla wrote:
>
>> There are certain EMIF timing failures seen on the some x15 boards. Updating
>> the EMIF settings to get rid of these timing failures.
>>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> But minor nit:
>
>> ---
>> board/ti/am57xx/board.c | 136 +++++++++++++++++++++++-------------------------
>> 1 file changed, 65 insertions(+), 71 deletions(-)
>>
>> diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c
>> index d712ab0..9a8ee00 100644
>> --- a/board/ti/am57xx/board.c
>> +++ b/board/ti/am57xx/board.c
>> @@ -64,22 +64,22 @@ void emif_get_dmm_regs(const struct dmm_lisa_map_regs **dmm_lisa_regs)
>> static const struct emif_regs beagle_x15_emif1_ddr3_532mhz_emif_regs = {
>> .sdram_config_init = 0x61851b32,
>> .sdram_config = 0x61851b32,
>> - .sdram_config2 = 0x00000000,
>> + .sdram_config2 = 0x8000000,
>
> Here and in the other spot too, this hurts readability to me, it should
> be 0x08000000
Sure, Ill update and resend.
Thanks and regards,
Lokesh
>
prev parent reply other threads:[~2016-03-08 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 12:03 [U-Boot] [PATCH] ARM: AM57xx: Update EMIF registers Lokesh Vutla
2016-03-07 23:36 ` Tom Rini
2016-03-08 3:34 ` Lokesh Vutla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DE483A.6000506@ti.com \
--to=a0131933@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox