From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 14 Mar 2016 11:06:42 -0600 Subject: [U-Boot] [PATCH v3 2/4] usb: Remove 200 ms delay in usb_hub_port_connect_change() In-Reply-To: <1457950693-564-3-git-send-email-sr@denx.de> References: <1457950693-564-1-git-send-email-sr@denx.de> <1457950693-564-3-git-send-email-sr@denx.de> Message-ID: <56E6EFA2.5040305@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/14/2016 04:18 AM, Stefan Roese wrote: > This patch removes 2 mdelay(200) calls from usb_hub_port_connect_change(). > These delays don't seem to be necessary. At least not in my tests. Here > the number for a custom x86 Bay Trail board (not in mainline yet) with > a quite large and complex USB hub infrastructure. > > Without this patch: > starting USB... > USB0: USB EHCI 1.00 > scanning bus 0 for devices... 9 USB Device(s) found > > time: 28.415 seconds > > With this patch: > starting USB... > USB0: USB EHCI 1.00 > scanning bus 0 for devices... 9 USB Device(s) found > > time: 24.003 seconds > > So ~4.5 seconds of USB scanning time reduction. > > Signed-off-by: Stefan Roese > Cc: Simon Glass > Cc: Hans de Goede > Cc: Stephen Warren > Cc: Marek Vasut > > --- > > Changes in v3: None > Changes in v2: > - Make this change unconditional > - Add Acked-by / Tested-by from Hans and Stephen I meant to mention: I think you forgot to actually do that. There aren't any acks in the commit description.