From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 08/21] usb: ulpi: Fix compile warning in read/write on 64-bit machines.
Date: Mon, 14 Mar 2016 18:24:02 +0100 [thread overview]
Message-ID: <56E6F3B2.6050101@denx.de> (raw)
In-Reply-To: <1457905004-14496-9-git-send-email-mateusz.kulikowski@gmail.com>
On 03/13/2016 10:36 PM, Mateusz Kulikowski wrote:
> ulpi_read and ulpi_write are used to read/write registers via ULPI bus.
> Code generates compilation warnings on 64-bit machines where pointer
> is cast to u32.
>
> This patch drops all but last 8 bits of register address.
> It is possible, because addresses on ULPI bus are 6- or 8-bit.
>
> It is not possible (according to ULPI 1.1 spec) to have more
> than 8-bit addressing.
>
> This patch should not cause regressions as all calls to
> ulpi_read/write use either structure pointer (@ address 0) or integer
> offsets cast to pointer - addresses requested are way below 8-bit range.
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Acked-by: Marek Vasut <marex@denx.de>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-03-14 17:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 21:36 [U-Boot] [PATCH v3 00/21] Add support for 96boards Dragonboard410C board Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 01/21] serial: Add support for Qualcomm serial port Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 02/21] gpio: Add support for Qualcomm gpio controller Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 03/21] mmc: Add support for Qualcomm SDHCI controller Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 04/21] ehci-hcd: Add init_after_reset Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 05/21] usb: ulpi: Add Kconfig options for ULPI Mateusz Kulikowski
2016-03-14 17:23 ` Marek Vasut
2016-03-13 21:36 ` [U-Boot] [PATCH v3 06/21] Migrate CONFIG_ULPI* to Kconfig Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 07/21] usb: ulpi: Fix viewport_addr type Mateusz Kulikowski
2016-03-14 17:23 ` Marek Vasut
2016-03-13 21:36 ` [U-Boot] [PATCH v3 08/21] usb: ulpi: Fix compile warning in read/write on 64-bit machines Mateusz Kulikowski
2016-03-14 17:24 ` Marek Vasut [this message]
2016-03-13 21:36 ` [U-Boot] [PATCH v3 09/21] eth: asix88179: Print packet length properly Mateusz Kulikowski
2016-03-14 17:24 ` Marek Vasut
2016-03-25 21:18 ` Joe Hershberger
2016-03-13 21:36 ` [U-Boot] [PATCH v3 10/21] usb: Rename ehci-fsl.h to ehci-ci.h Mateusz Kulikowski
2016-03-27 13:36 ` [U-Boot] [U-Boot,v3,10/21] " Tom Rini
2016-03-13 21:36 ` [U-Boot] [PATCH v3 11/21] usb: ehci-ci: Add missing registers Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 12/21] ehci-ci.h: drop generic USBCMD fields Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 13/21] ehci: Add support for Qualcomm EHCI Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 14/21] drivers: Add SPMI bus uclass Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 15/21] spmi: Add sandbox test driver Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 16/21] drivers: spmi: Add support for Qualcomm SPMI bus driver Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 17/21] pmic: Add support for Qualcomm PM8916 PMIC Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 18/21] gpio: Add support for Qualcomm PM8916 gpios Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 19/21] arm: Add support for Qualcomm Snapdragon family Mateusz Kulikowski
2016-03-13 21:36 ` [U-Boot] [PATCH v3 20/21] board: Add Qualcomm Dragonboard 410C support Mateusz Kulikowski
2016-03-27 13:36 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-03-13 21:36 ` [U-Boot] [PATCH v3 21/21] Add myself as Snapdragon and SPMI maintainer Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E6F3B2.6050101@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox