public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] spl: arm: Make sure to include u_boot_list_*_part_disk_*
Date: Wed, 16 Mar 2016 01:25:14 +0100	[thread overview]
Message-ID: <56E8A7EA.9010605@xilinx.com> (raw)
In-Reply-To: <1458080995-31049-1-git-send-email-trini@konsulko.com>

On 15.3.2016 23:29, Tom Rini wrote:
> Starting with 96e5b03 we use a linker list for partition table
> information.  However since we use this in SPL we need to make sure that
> the SPL linker scripts include these as well.
> 
> Cc: Michal Simek <michal.simek@xilinx.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reported-by: Nishanth Menon <nm@ti.com>
> Tested-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Changes in v2:
> - Drop the CONFIG_SPL_DM tests for zynq as DM is the only case for zynq
>   and while in here drop a now useless line.
> ---
>  arch/arm/cpu/armv7/omap-common/u-boot-spl.lds |    1 +
>  arch/arm/cpu/u-boot-spl.lds                   |    1 +
>  arch/arm/mach-zynq/u-boot-spl.lds             |    4 ----
>  3 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/omap-common/u-boot-spl.lds b/arch/arm/cpu/armv7/omap-common/u-boot-spl.lds
> index ccd0c83..9dccdc0 100644
> --- a/arch/arm/cpu/armv7/omap-common/u-boot-spl.lds
> +++ b/arch/arm/cpu/armv7/omap-common/u-boot-spl.lds
> @@ -35,6 +35,7 @@ SECTIONS
>  
>  	. = ALIGN(4);
>  	.u_boot_list : {
> +		KEEP(*(SORT(.u_boot_list_*_part_driver_*)));
>  		KEEP(*(SORT(.u_boot_list*_i2c_*)));
>  	} >.sram
>  
> diff --git a/arch/arm/cpu/u-boot-spl.lds b/arch/arm/cpu/u-boot-spl.lds
> index c5b4f7c..1805043 100644
> --- a/arch/arm/cpu/u-boot-spl.lds
> +++ b/arch/arm/cpu/u-boot-spl.lds
> @@ -40,6 +40,7 @@ SECTIONS
>  #endif
>  	. = .;
>  	.u_boot_list : {
> +		KEEP(*(SORT(.u_boot_list_*_part_driver_*)));
>  		KEEP(*(SORT(.u_boot_list*_i2c_*)));
>  	}
>  
> diff --git a/arch/arm/mach-zynq/u-boot-spl.lds b/arch/arm/mach-zynq/u-boot-spl.lds
> index ecdf6a0..a5c76a6 100644
> --- a/arch/arm/mach-zynq/u-boot-spl.lds
> +++ b/arch/arm/mach-zynq/u-boot-spl.lds
> @@ -38,16 +38,12 @@ SECTIONS
>  	} > .sram
>  
>  	. = ALIGN(4);
> -#ifdef CONFIG_SPL_DM
>  	.u_boot_list : {
>  		KEEP(*(SORT(.u_boot_list_*_driver_*)));
>  		KEEP(*(SORT(.u_boot_list_*_uclass_*)));
>  	} > .sram
>  
>  	. = ALIGN(4);
> -#endif
> -
> -	. = .;

This is getting more interested than I thought.
We have for zynq added two lists for driver and uclass added by Simon
but this is missing in linker script for others SoC. Does that mean that
none else is using SPL with DM? Or that we have in linker script
something what doesn't need to be there?

Regarding this patch. Zynq is not enabling partition support but I still
think that we should add also this list to zynq spl.
Maybe we didn't understand each other. I wanted to say remove that
SPL_DM and keep that part_driver lists even we are not enabling them by
default.

Thanks,
Michal

  reply	other threads:[~2016-03-16  0:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15 22:29 [U-Boot] [PATCH v2] spl: arm: Make sure to include u_boot_list_*_part_disk_* Tom Rini
2016-03-16  0:25 ` Michal Simek [this message]
2016-03-16  0:50   ` Tom Rini
2016-03-16  0:55     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E8A7EA.9010605@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox