[U-Boot] [PATCH] sunxi: video: Configure only LVDS pins instead of all LCD pins when LVDS interface selected

[U-Boot] [PATCH] sunxi: video: Configure only LVDS pins instead of all LCD pins when LVDS interface selected

[Lawrence Yu]

The behavior before this patch would attempt to configure the mux
setting for pins 0 to 27 on PORTD to all be setting 3 for LVDS.  The
LVDS interface actually only uses pins 18 to 27 and not pins 0 to 27
as in the parallel LCD interface.  This patch restricts the
configuration to only the relevant pins 18 to 27 on PORTD.

This was tested on a sun8i A33 tablet with an LVDS screen.  MMC1 has
the capability to use pins 2 to 7 on PORTD and the mux on those pins
was being inadvertently set to setting 3 for MMC functionality which
this patch corrects.

Signed-off-by: Lawrence Yu <lyu@micile.com>
---

 drivers/video/sunxi_display.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/video/sunxi_display.c b/drivers/video/sunxi_display.c
index 9fee66a..3674ae1 100644
--- a/drivers/video/sunxi_display.c
+++ b/drivers/video/sunxi_display.c
@@ -767,7 +767,11 @@ static void sunxi_lcdc_tcon0_mode_set(const struct ctfb_res_modes *mode,
 		(struct sunxi_lcdc_reg *)SUNXI_LCD0_BASE;
 	int bp, clk_delay, clk_div, clk_double, pin, total, val;
 
+#ifdef CONFIG_VIDEO_LCD_IF_LVDS
+	for (pin = SUNXI_GPD(18); pin <= SUNXI_GPD(27); pin++) {
+#else
 	for (pin = SUNXI_GPD(0); pin <= SUNXI_GPD(27); pin++) {
+#endif
 #ifdef CONFIG_VIDEO_LCD_IF_PARALLEL
 		sunxi_gpio_set_cfgpin(pin, SUNXI_GPD_LCD0);
 #endif
-- 
2.5.3

[U-Boot] sunxi: video: Configure only LVDS pins instead of all LCD pins when LVDS interface selected

[Hans de Goede]

Hi,

On 04-03-16 18:08, Lawrence Yu wrote:
> The behavior before this patch would attempt to configure the mux
> setting for pins 0 to 27 on PORTD to all be setting 3 for LVDS.  The
> LVDS interface actually only uses pins 18 to 27 and not pins 0 to 27
> as in the parallel LCD interface.  This patch restricts the
> configuration to only the relevant pins 18 to 27 on PORTD.
>
> This was tested on a sun8i A33 tablet with an LVDS screen.  MMC1 has
> the capability to use pins 2 to 7 on PORTD and the mux on those pins
> was being inadvertently set to setting 3 for MMC functionality which
> this patch corrects.
>
> Signed-off-by: Lawrence Yu <lyu@micile.com>

Thanks for the patch, the lvds using pins 18 - 27 is only true
on A23/A33 on e.g. A10 it uses pins 0-19. So I've changed the
condition to:

#if defined CONFIG_MACH_SUN8I && defined CONFIG_VIDEO_LCD_IF_LVDS

and merged the patch with that change.

Regards,

Hans


> ---
>
>   drivers/video/sunxi_display.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/video/sunxi_display.c b/drivers/video/sunxi_display.c
> index 9fee66a..3674ae1 100644
> --- a/drivers/video/sunxi_display.c
> +++ b/drivers/video/sunxi_display.c
> @@ -767,7 +767,11 @@ static void sunxi_lcdc_tcon0_mode_set(const struct ctfb_res_modes *mode,
>   		(struct sunxi_lcdc_reg *)SUNXI_LCD0_BASE;
>   	int bp, clk_delay, clk_div, clk_double, pin, total, val;
>
> +#ifdef CONFIG_VIDEO_LCD_IF_LVDS
> +	for (pin = SUNXI_GPD(18); pin <= SUNXI_GPD(27); pin++) {
> +#else
>   	for (pin = SUNXI_GPD(0); pin <= SUNXI_GPD(27); pin++) {
> +#endif
>   #ifdef CONFIG_VIDEO_LCD_IF_PARALLEL
>   		sunxi_gpio_set_cfgpin(pin, SUNXI_GPD_LCD0);
>   #endif
>