From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 16 Mar 2016 16:50:19 +0100 Subject: [U-Boot] [PATCH 14/14] usb: Correct return value in usb_stor_info() In-Reply-To: <1458135945-13385-15-git-send-email-sjg@chromium.org> References: <1458135945-13385-1-git-send-email-sjg@chromium.org> <1458135945-13385-15-git-send-email-sjg@chromium.org> Message-ID: <56E980BB.8050309@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/16/2016 02:45 PM, Simon Glass wrote: > This should return 0 on success, not 1. Fix it. > > Signed-off-by: Simon Glass Yikes. Thanks for finding this. Acked-by: Marek Vasut > --- > > common/usb_storage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/usb_storage.c b/common/usb_storage.c > index 1472824..18fdf73 100644 > --- a/common/usb_storage.c > +++ b/common/usb_storage.c > @@ -193,7 +193,7 @@ int usb_stor_info(void) > return 1; > } > > - return 1; > + return 0; > } > > static unsigned int usb_get_max_lun(struct us_data *us) > -- Best regards, Marek Vasut