From: "Andreas Färber" <afaerber@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] arm64: Add 32bit arm compatible dcache definitions
Date: Wed, 16 Mar 2016 18:55:55 +0100 [thread overview]
Message-ID: <56E99E2B.1030409@suse.de> (raw)
In-Reply-To: <1458062508-210201-2-git-send-email-agraf@suse.de>
Am 15.03.2016 um 18:21 schrieb Alexander Graf:
> We want to be able to reuse device drivers from 32bit code, so let's add
> definitions for all the dcache options that 32bit code has.
>
> While at it, fix up the DCACHE_OFF configuration. That was setting the bits
> to declare a PTE a PTE and left the MAIR index bit at 0. Drop the useless
> bits and make the index explicit.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> arch/arm/include/asm/system.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h
> index ac1173d..832c1db 100644
> --- a/arch/arm/include/asm/system.h
> +++ b/arch/arm/include/asm/system.h
> @@ -26,8 +26,12 @@ u64 get_page_table_size(void);
> #define MMU_SECTION_SHIFT 21
> #define MMU_SECTION_SIZE (1 << MMU_SECTION_SHIFT)
>
> +/* These constants need to be synced to the MT_ types in asm/armv8/mmu.h */
> enum dcache_option {
> - DCACHE_OFF = 0x3,
> + DCACHE_OFF = 0 << 2,
> + DCACHE_WRITETHROUGH = 3 << 2,
> + DCACHE_WRITEBACK = 4 << 2,
> + DCACHE_WRITEALLOC = 4 << 2,
Is it intentional that these two have the same value?
Regards,
Andreas
> };
>
> #define isb() \
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)
next prev parent reply other threads:[~2016-03-16 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 17:21 [U-Boot] [PATCH 0/5] Enable caches for the RPi2 Alexander Graf
2016-03-15 17:21 ` [U-Boot] [PATCH 1/5] arm64: Add 32bit arm compatible dcache definitions Alexander Graf
2016-03-16 17:55 ` Andreas Färber [this message]
2016-03-16 22:31 ` Alexander Graf
2016-03-15 17:21 ` [U-Boot] [PATCH 2/5] arm: Add support for HYP mode and LPAE page tables Alexander Graf
2016-03-15 17:35 ` Tom Rini
2016-03-16 8:33 ` Alexander Graf
2016-03-16 14:25 ` Tom Rini
2016-03-15 17:21 ` [U-Boot] [PATCH 3/5] lcd: Fix compile warning in 64bit mode Alexander Graf
2016-03-15 17:21 ` [U-Boot] [PATCH 4/5] RPi: Enable caches for rpi2 Alexander Graf
2016-03-15 17:21 ` [U-Boot] [PATCH 5/5] bcm2835 video: Map fb as cached Alexander Graf
2016-03-16 18:00 ` Andreas Färber
2016-03-16 22:32 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E99E2B.1030409@suse.de \
--to=afaerber@suse.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox