public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code
@ 2016-03-17 14:44 Alexander Merkle
  2016-03-17 14:44 ` [U-Boot] [PATCH 1/3] Fix typo in chosen parameter in vf610-twr.dts Alexander Merkle
                   ` (3 more replies)
  0 siblings, 4 replies; 13+ messages in thread
From: Alexander Merkle @ 2016-03-17 14:44 UTC (permalink / raw)
  To: u-boot


The dts files for NXP/Freescale Vybrid series were broken.
Fixed some other typos in comments & printfs to.


Alexander Merkle (3):
  Fix typo in chosen parameter in vf610-twr.dts
  Fix typo in chosen parameter of pcm052.dts
  Fix typo choosen in comments and printf logs

 arch/arm/dts/pcm052.dts                 | 2 +-
 arch/arm/dts/vf610-twr.dts              | 2 +-
 common/menu.c                           | 2 +-
 drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.7.0

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [PATCH 1/3] Fix typo in chosen parameter in vf610-twr.dts
  2016-03-17 14:44 [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code Alexander Merkle
@ 2016-03-17 14:44 ` Alexander Merkle
  2016-03-18  1:50   ` Bin Meng
  2016-03-27 22:25   ` [U-Boot] [U-Boot, " Tom Rini
  2016-03-17 14:44 ` [U-Boot] [PATCH 2/3] Fix typo in chosen parameter of pcm052.dts Alexander Merkle
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 13+ messages in thread
From: Alexander Merkle @ 2016-03-17 14:44 UTC (permalink / raw)
  To: u-boot

Fix typo "choosen" instead of "chosen" in vf610-twr.dts.
Fixes boot process and terminal output for Vybrid series.

Signed-off-by: Alexander Merkle <alexander.merkle@lauterbach.com>
---

 arch/arm/dts/vf610-twr.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/dts/vf610-twr.dts b/arch/arm/dts/vf610-twr.dts
index a4ccbcb..237aa8d 100644
--- a/arch/arm/dts/vf610-twr.dts
+++ b/arch/arm/dts/vf610-twr.dts
@@ -11,7 +11,7 @@
 	model = "VF610 Tower Board";
 	compatible = "fsl,vf610-twr", "fsl,vf610";
 
-	choosen {
+	chosen {
 		stdout-path = &uart1;
 	};
 
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [U-Boot] [PATCH 2/3] Fix typo in chosen parameter of pcm052.dts
  2016-03-17 14:44 [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code Alexander Merkle
  2016-03-17 14:44 ` [U-Boot] [PATCH 1/3] Fix typo in chosen parameter in vf610-twr.dts Alexander Merkle
@ 2016-03-17 14:44 ` Alexander Merkle
  2016-03-18  1:50   ` Bin Meng
  2016-03-27 22:26   ` [U-Boot] [U-Boot, " Tom Rini
  2016-03-17 14:44 ` [U-Boot] [PATCH 3/3] Fix typo choosen in comments and printf logs Alexander Merkle
  2016-03-17 15:06 ` [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code Bhuvanchandra DV
  3 siblings, 2 replies; 13+ messages in thread
From: Alexander Merkle @ 2016-03-17 14:44 UTC (permalink / raw)
  To: u-boot

Fix typo "choosen" instead of "chosen" in pcm052.dts.
Not tested but should fix boot process and terminal output.

Signed-off-by: Alexander Merkle <alexander.merkle@lauterbach.com>
---

 arch/arm/dts/pcm052.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/dts/pcm052.dts b/arch/arm/dts/pcm052.dts
index 0475f1f..0985587 100644
--- a/arch/arm/dts/pcm052.dts
+++ b/arch/arm/dts/pcm052.dts
@@ -11,7 +11,7 @@
 	model = "Phytec phyCORE-Vybrid";
 	compatible = "phytec,pcm052", "fsl,vf610";
 
-	choosen {
+	chosen {
 		stdout-path = &uart1;
 	};
 
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [U-Boot] [PATCH 3/3] Fix typo choosen in comments and printf logs
  2016-03-17 14:44 [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code Alexander Merkle
  2016-03-17 14:44 ` [U-Boot] [PATCH 1/3] Fix typo in chosen parameter in vf610-twr.dts Alexander Merkle
  2016-03-17 14:44 ` [U-Boot] [PATCH 2/3] Fix typo in chosen parameter of pcm052.dts Alexander Merkle
@ 2016-03-17 14:44 ` Alexander Merkle
  2016-03-18  1:51   ` Bin Meng
  2016-03-27 22:26   ` [U-Boot] [U-Boot, " Tom Rini
  2016-03-17 15:06 ` [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code Bhuvanchandra DV
  3 siblings, 2 replies; 13+ messages in thread
From: Alexander Merkle @ 2016-03-17 14:44 UTC (permalink / raw)
  To: u-boot

Minor change: chosen is written with one "o".
No code change here, only comment & printf.

Signed-off-by: Alexander Merkle <alexander.merkle@lauterbach.com>
---

 common/menu.c                           | 2 +-
 drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/menu.c b/common/menu.c
index eda96d6..c53030f 100644
--- a/common/menu.c
+++ b/common/menu.c
@@ -350,7 +350,7 @@ int menu_item_add(struct menu *m, char *item_key, void *item_data)
  * make it obvious what the key for each entry is.
  *
  * item_choice - If not NULL, will be called when asking the user to choose an
- * item. Returns a key string corresponding to the choosen item or NULL if
+ * item. Returns a key string corresponding to the chosen item or NULL if
  * no item has been selected.
  *
  * item_choice_data - Will be passed as the argument to the item_choice function
diff --git a/drivers/ddr/fsl/lc_common_dimm_params.c b/drivers/ddr/fsl/lc_common_dimm_params.c
index 47ad4e5..850c8f6 100644
--- a/drivers/ddr/fsl/lc_common_dimm_params.c
+++ b/drivers/ddr/fsl/lc_common_dimm_params.c
@@ -60,8 +60,8 @@ compute_cas_latency(const unsigned int ctrl_num,
 	 * 18ns for all DDR4 speed grades.
 	 */
 	if (caslat_actual * mclk_ps > taamax) {
-		printf("The choosen cas latency %d is too large\n",
-			caslat_actual);
+		printf("The chosen cas latency %d is too large\n",
+		       caslat_actual);
 	}
 	outpdimm->lowest_common_spd_caslat = caslat_actual;
 	debug("lowest_common_spd_caslat is 0x%x\n", caslat_actual);
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code
  2016-03-17 14:44 [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code Alexander Merkle
                   ` (2 preceding siblings ...)
  2016-03-17 14:44 ` [U-Boot] [PATCH 3/3] Fix typo choosen in comments and printf logs Alexander Merkle
@ 2016-03-17 15:06 ` Bhuvanchandra DV
  2016-03-17 15:20   ` Alexander Merkle
  3 siblings, 1 reply; 13+ messages in thread
From: Bhuvanchandra DV @ 2016-03-17 15:06 UTC (permalink / raw)
  To: u-boot

On 03/17/2016 08:14 PM, Alexander Merkle wrote:
>
> The dts files for NXP/Freescale Vybrid series were broken.
> Fixed some other typos in comments & printfs to.

I guess this is not typo the node name is 'chosen'.
Some documentation is here[1].

[1] 
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/chosen.txt

>
>
> Alexander Merkle (3):
>    Fix typo in chosen parameter in vf610-twr.dts
>    Fix typo in chosen parameter of pcm052.dts
>    Fix typo choosen in comments and printf logs
>
>   arch/arm/dts/pcm052.dts                 | 2 +-
>   arch/arm/dts/vf610-twr.dts              | 2 +-
>   common/menu.c                           | 2 +-
>   drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
>   4 files changed, 5 insertions(+), 5 deletions(-)
>

-- 
Best regards,
Bhuvan

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code
  2016-03-17 15:06 ` [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code Bhuvanchandra DV
@ 2016-03-17 15:20   ` Alexander Merkle
  2016-03-17 15:23     ` Bhuvanchandra DV
  0 siblings, 1 reply; 13+ messages in thread
From: Alexander Merkle @ 2016-03-17 15:20 UTC (permalink / raw)
  To: u-boot

Hi,

may be the subject is misleading. The DTS/DTB entry should be named
   "chosen"
but it was "choosen" with "oo" in the git master. Have a look to the 
commits.

diff --git a/arch/arm/dts/vf610-twr.dts b/arch/arm/dts/vf610-twr.dts
index a4ccbcb..237aa8d 100644
--- a/arch/arm/dts/vf610-twr.dts
+++ b/arch/arm/dts/vf610-twr.dts
@@ -11,7 +11,7 @@
  	model = "VF610 Tower Board";
  	compatible = "fsl,vf610-twr", "fsl,vf610";

-	choosen {
+	chosen {
  		stdout-path = &uart1;
  	};

Regards,

Alex

Alexander Merkle
System Engineer
   Lauterbach GmbH
   Altlaufstra?e 40
   85635 Hoehenkirchen-Siegertsbrunn
   Germany
Tel +49 8102 9876-147
mailto:alexander.merkle at lauterbach.com
http://www.lauterbach.com

On 17.03.2016 16:06, Bhuvanchandra DV wrote:
> On 03/17/2016 08:14 PM, Alexander Merkle wrote:
>>
>> The dts files for NXP/Freescale Vybrid series were broken.
>> Fixed some other typos in comments & printfs to.
>
> I guess this is not typo the node name is 'chosen'.
> Some documentation is here[1].
>
> [1]
> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/chosen.txt
>
>
>>
>>
>> Alexander Merkle (3):
>>    Fix typo in chosen parameter in vf610-twr.dts
>>    Fix typo in chosen parameter of pcm052.dts
>>    Fix typo choosen in comments and printf logs
>>
>>   arch/arm/dts/pcm052.dts                 | 2 +-
>>   arch/arm/dts/vf610-twr.dts              | 2 +-
>>   common/menu.c                           | 2 +-
>>   drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
>>   4 files changed, 5 insertions(+), 5 deletions(-)
>>
>

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code
  2016-03-17 15:20   ` Alexander Merkle
@ 2016-03-17 15:23     ` Bhuvanchandra DV
  0 siblings, 0 replies; 13+ messages in thread
From: Bhuvanchandra DV @ 2016-03-17 15:23 UTC (permalink / raw)
  To: u-boot

On 03/17/2016 08:50 PM, Alexander Merkle wrote:
> Hi,
>
> may be the subject is misleading. The DTS/DTB entry should be named
>    "chosen"
> but it was "choosen" with "oo" in the git master. Have a look to the
> commits.

My bad! got it.

>
> diff --git a/arch/arm/dts/vf610-twr.dts b/arch/arm/dts/vf610-twr.dts
> index a4ccbcb..237aa8d 100644
> --- a/arch/arm/dts/vf610-twr.dts
> +++ b/arch/arm/dts/vf610-twr.dts
> @@ -11,7 +11,7 @@
>       model = "VF610 Tower Board";
>       compatible = "fsl,vf610-twr", "fsl,vf610";
>
> -    choosen {
> +    chosen {
>           stdout-path = &uart1;
>       };
>
> Regards,
>
> Alex
>
> Alexander Merkle
> System Engineer
>    Lauterbach GmbH
>    Altlaufstra?e 40
>    85635 Hoehenkirchen-Siegertsbrunn
>    Germany
> Tel +49 8102 9876-147
> mailto:alexander.merkle at lauterbach.com
> http://www.lauterbach.com
>
> On 17.03.2016 16:06, Bhuvanchandra DV wrote:
>> On 03/17/2016 08:14 PM, Alexander Merkle wrote:
>>>
>>> The dts files for NXP/Freescale Vybrid series were broken.
>>> Fixed some other typos in comments & printfs to.
>>
>> I guess this is not typo the node name is 'chosen'.
>> Some documentation is here[1].
>>
>> [1]
>> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/chosen.txt
>>
>>
>>
>>>
>>>
>>> Alexander Merkle (3):
>>>    Fix typo in chosen parameter in vf610-twr.dts
>>>    Fix typo in chosen parameter of pcm052.dts
>>>    Fix typo choosen in comments and printf logs
>>>
>>>   arch/arm/dts/pcm052.dts                 | 2 +-
>>>   arch/arm/dts/vf610-twr.dts              | 2 +-
>>>   common/menu.c                           | 2 +-
>>>   drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
>>>   4 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>

-- 
Best regards,
Bhuvan

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [PATCH 1/3] Fix typo in chosen parameter in vf610-twr.dts
  2016-03-17 14:44 ` [U-Boot] [PATCH 1/3] Fix typo in chosen parameter in vf610-twr.dts Alexander Merkle
@ 2016-03-18  1:50   ` Bin Meng
  2016-03-27 22:25   ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 0 replies; 13+ messages in thread
From: Bin Meng @ 2016-03-18  1:50 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 17, 2016 at 10:44 PM, Alexander Merkle
<alexander.merkle@lauterbach.com> wrote:
> Fix typo "choosen" instead of "chosen" in vf610-twr.dts.
> Fixes boot process and terminal output for Vybrid series.
>
> Signed-off-by: Alexander Merkle <alexander.merkle@lauterbach.com>
> ---
>
>  arch/arm/dts/vf610-twr.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [PATCH 2/3] Fix typo in chosen parameter of pcm052.dts
  2016-03-17 14:44 ` [U-Boot] [PATCH 2/3] Fix typo in chosen parameter of pcm052.dts Alexander Merkle
@ 2016-03-18  1:50   ` Bin Meng
  2016-03-27 22:26   ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 0 replies; 13+ messages in thread
From: Bin Meng @ 2016-03-18  1:50 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 17, 2016 at 10:44 PM, Alexander Merkle
<alexander.merkle@lauterbach.com> wrote:
> Fix typo "choosen" instead of "chosen" in pcm052.dts.
> Not tested but should fix boot process and terminal output.
>
> Signed-off-by: Alexander Merkle <alexander.merkle@lauterbach.com>
> ---
>
>  arch/arm/dts/pcm052.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [PATCH 3/3] Fix typo choosen in comments and printf logs
  2016-03-17 14:44 ` [U-Boot] [PATCH 3/3] Fix typo choosen in comments and printf logs Alexander Merkle
@ 2016-03-18  1:51   ` Bin Meng
  2016-03-27 22:26   ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 0 replies; 13+ messages in thread
From: Bin Meng @ 2016-03-18  1:51 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 17, 2016 at 10:44 PM, Alexander Merkle
<alexander.merkle@lauterbach.com> wrote:
> Minor change: chosen is written with one "o".
> No code change here, only comment & printf.
>
> Signed-off-by: Alexander Merkle <alexander.merkle@lauterbach.com>
> ---
>
>  common/menu.c                           | 2 +-
>  drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 1/3] Fix typo in chosen parameter in vf610-twr.dts
  2016-03-17 14:44 ` [U-Boot] [PATCH 1/3] Fix typo in chosen parameter in vf610-twr.dts Alexander Merkle
  2016-03-18  1:50   ` Bin Meng
@ 2016-03-27 22:25   ` Tom Rini
  1 sibling, 0 replies; 13+ messages in thread
From: Tom Rini @ 2016-03-27 22:25 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 17, 2016 at 03:44:45PM +0100, Alexander Merkle wrote:

> Fix typo "choosen" instead of "chosen" in vf610-twr.dts.
> Fixes boot process and terminal output for Vybrid series.
> 
> Signed-off-by: Alexander Merkle <alexander.merkle@lauterbach.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160327/552e44a9/attachment.sig>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 2/3] Fix typo in chosen parameter of pcm052.dts
  2016-03-17 14:44 ` [U-Boot] [PATCH 2/3] Fix typo in chosen parameter of pcm052.dts Alexander Merkle
  2016-03-18  1:50   ` Bin Meng
@ 2016-03-27 22:26   ` Tom Rini
  1 sibling, 0 replies; 13+ messages in thread
From: Tom Rini @ 2016-03-27 22:26 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 17, 2016 at 03:44:46PM +0100, Alexander Merkle wrote:

> Fix typo "choosen" instead of "chosen" in pcm052.dts.
> Not tested but should fix boot process and terminal output.
> 
> Signed-off-by: Alexander Merkle <alexander.merkle@lauterbach.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160327/d0f57b64/attachment.sig>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 3/3] Fix typo choosen in comments and printf logs
  2016-03-17 14:44 ` [U-Boot] [PATCH 3/3] Fix typo choosen in comments and printf logs Alexander Merkle
  2016-03-18  1:51   ` Bin Meng
@ 2016-03-27 22:26   ` Tom Rini
  1 sibling, 0 replies; 13+ messages in thread
From: Tom Rini @ 2016-03-27 22:26 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 17, 2016 at 03:44:47PM +0100, Alexander Merkle wrote:

> Minor change: chosen is written with one "o".
> No code change here, only comment & printf.
> 
> Signed-off-by: Alexander Merkle <alexander.merkle@lauterbach.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160327/c4019ed4/attachment.sig>

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2016-03-27 22:26 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 14:44 [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code Alexander Merkle
2016-03-17 14:44 ` [U-Boot] [PATCH 1/3] Fix typo in chosen parameter in vf610-twr.dts Alexander Merkle
2016-03-18  1:50   ` Bin Meng
2016-03-27 22:25   ` [U-Boot] [U-Boot, " Tom Rini
2016-03-17 14:44 ` [U-Boot] [PATCH 2/3] Fix typo in chosen parameter of pcm052.dts Alexander Merkle
2016-03-18  1:50   ` Bin Meng
2016-03-27 22:26   ` [U-Boot] [U-Boot, " Tom Rini
2016-03-17 14:44 ` [U-Boot] [PATCH 3/3] Fix typo choosen in comments and printf logs Alexander Merkle
2016-03-18  1:51   ` Bin Meng
2016-03-27 22:26   ` [U-Boot] [U-Boot, " Tom Rini
2016-03-17 15:06 ` [U-Boot] [PATCH 0/3] Fix multipe typos "choosen" instead of "chosen" in dts/code Bhuvanchandra DV
2016-03-17 15:20   ` Alexander Merkle
2016-03-17 15:23     ` Bhuvanchandra DV

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox