From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 11/11] cfi_flash: return device into read array mode after reading status
Date: Tue, 22 Mar 2016 07:40:44 +0100 [thread overview]
Message-ID: <56F0E8EC.8050405@denx.de> (raw)
In-Reply-To: <CA+E=qVcB800DQ-OnB5CPEk8u28M6ZqWSxGQKUDvz89Hd1AKvKA@mail.gmail.com>
Hi Vasily,
On 21.03.2016 20:22, Vasily Khoruzhick wrote:
> On Mon, Mar 21, 2016 at 9:19 AM, Stefan Roese <sr@denx.de> wrote:
>> Hi Vasily,
>
> Hi Stefan,
>
>> On 21.03.2016 02:54, Marek Vasut wrote:
>>> On 03/21/2016 02:37 AM, Vasily Khoruzhick wrote:
>>>> Otherwise flash remains in read status mode and it's not possible
>>>> to access data on flash.
>>>>
>>>> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
>>>
>>> CCing Stefan and Scott on this one.
>>>
>>>> ---
>>>> drivers/mtd/cfi_flash.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
>>>> index 39932f4..18831c6 100644
>>>> --- a/drivers/mtd/cfi_flash.c
>>>> +++ b/drivers/mtd/cfi_flash.c
>>>> @@ -2203,6 +2203,8 @@ ulong flash_get_size (phys_addr_t base, int banknum)
>>>> flash_isset (info, sect_cnt,
>>>> FLASH_OFFSET_PROTECT,
>>>> FLASH_STATUS_PROTECT);
>>>> + flash_write_cmd(info, sect_cnt, 0,
>>>> + FLASH_CMD_RESET);
>>>> break;
>>>> case CFI_CMDSET_AMD_EXTENDED:
>>>> case CFI_CMDSET_AMD_STANDARD:
>>>>
>>
>> I can't test this patch, since I don't have such a board here
>> available right now any more. But I'm wondering if this is really
>> necessary. The driver used to work just fine on Intel Strata
>> flash chips without this patch.
>>
>> And looking at the code, a bit later (after the loop) the flash
>> is actually reset:
>
> It sends status cmd for each erase block to check if it's protected or
> not, and apparently this chip (Manufacturer ID 0x000089 Chip ID
> 0x008865) wants reset for each erase block as well.
> Otherwise it returns status data instead of actual data. Btw, that is
> exactly what Linux driver does.
I see. Okay, then:
Acked-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
next prev parent reply other threads:[~2016-03-22 6:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 1:37 [U-Boot] [PATCH 01/11] zipitz2: restore board support Vasily Khoruzhick
2016-03-21 1:37 ` [U-Boot] [PATCH 02/11] zipitz2: enable LCD rotation Vasily Khoruzhick
2016-03-21 1:47 ` Marek Vasut
2016-03-27 22:29 ` [U-Boot] [U-Boot,02/11] " Tom Rini
2016-03-21 1:37 ` [U-Boot] [PATCH 03/11] pxa_lcd: invert colors for Zipit Z2 to get white on black palette Vasily Khoruzhick
2016-03-21 1:48 ` Marek Vasut
2016-03-21 2:10 ` Vasily Khoruzhick
2016-03-21 2:14 ` Marek Vasut
2016-03-27 22:29 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-27 23:26 ` Marek Vasut
2016-03-28 0:58 ` Tom Rini
2016-03-21 1:37 ` [U-Boot] [PATCH 04/11] zipitz2: enable libfdt Vasily Khoruzhick
2016-03-21 1:48 ` Marek Vasut
2016-03-27 22:29 ` [U-Boot] [U-Boot,04/11] " Tom Rini
2016-03-21 1:37 ` [U-Boot] [PATCH 05/11] pxa-common: pxa27x has 3 OHCI ports Vasily Khoruzhick
2016-03-21 1:49 ` Marek Vasut
2016-03-27 22:29 ` [U-Boot] [U-Boot,05/11] " Tom Rini
2016-03-21 1:37 ` [U-Boot] [PATCH 06/11] zipitz2: enable USB host support Vasily Khoruzhick
2016-03-21 1:49 ` Marek Vasut
2016-03-27 22:29 ` [U-Boot] [U-Boot,06/11] " Tom Rini
2016-03-21 1:37 ` [U-Boot] [PATCH 07/11] pxa: start.S: enable SRAM clock Vasily Khoruzhick
2016-03-21 1:50 ` Marek Vasut
2016-03-27 22:29 ` [U-Boot] [U-Boot,07/11] " Tom Rini
2016-03-21 1:37 ` [U-Boot] [PATCH 08/11] pxa: add support for D- and I- caches Vasily Khoruzhick
2016-03-21 1:51 ` Marek Vasut
2016-03-27 22:29 ` [U-Boot] [U-Boot,08/11] " Tom Rini
2016-03-21 1:37 ` [U-Boot] [PATCH 09/11] pxa_lcd: make driver cache-aware Vasily Khoruzhick
2016-03-21 1:52 ` Marek Vasut
2016-03-27 22:29 ` [U-Boot] [U-Boot,09/11] " Tom Rini
2016-03-27 23:27 ` Marek Vasut
2016-03-28 0:58 ` Tom Rini
2016-03-21 1:37 ` [U-Boot] [PATCH 10/11] zipitz2: enable caches Vasily Khoruzhick
2016-03-21 1:52 ` Marek Vasut
2016-03-27 22:30 ` [U-Boot] [U-Boot,10/11] " Tom Rini
2016-03-21 1:37 ` [U-Boot] [PATCH 11/11] cfi_flash: return device into read array mode after reading status Vasily Khoruzhick
2016-03-21 1:54 ` Marek Vasut
2016-03-21 16:19 ` Stefan Roese
2016-03-21 19:22 ` Vasily Khoruzhick
2016-03-22 6:40 ` Stefan Roese [this message]
2016-03-27 22:30 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-21 1:45 ` [U-Boot] [PATCH 01/11] zipitz2: restore board support Marek Vasut
2016-03-27 22:29 ` [U-Boot] [U-Boot,01/11] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F0E8EC.8050405@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox