From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: migration of CONFIG_SPI_FLASH_BAR
Date: Tue, 22 Mar 2016 15:25:46 +0100 [thread overview]
Message-ID: <56F155EA.80505@denx.de> (raw)
In-Reply-To: <56F1557F.3010800@gmail.com>
On 03/22/2016 03:23 PM, Marek Vasut wrote:
> On 03/22/2016 10:26 AM, Bakhvalov, Denis (Nokia - PL/Wroclaw) wrote:
>
> Hi!
>
> Thanks for the patch, comments below.
>
>> CONFIG_SPI_FLASH_BAR was deleted from socfpga_common.h
>> and placed in socfpga_*_defconfig where it makes sense.
>>
>> Signed-off-by: Denis Bakhvalov <denis.bakhvalov@nokia.com>
>> Reported-by: Marek Vasut <marex@denx.de>
>
> I didn't report this stuff, so just Cc me.
>
>> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
>> ---
>> configs/socfpga_arria5_defconfig | 1 +
>> configs/socfpga_cyclone5_defconfig | 1 +
>> configs/socfpga_de0_nano_soc_defconfig | 1 +
>> configs/socfpga_mcvevk_defconfig | 1 +
>> configs/socfpga_sockit_defconfig | 1 +
>> configs/socfpga_socrates_defconfig | 1 +
>> configs/socfpga_sr1500_defconfig | 1 +
>> include/configs/socfpga_common.h | 2 --
>> 8 files changed, 7 insertions(+), 2 deletions(-)
>
> This change is fine with me.
>
> Acked-by: Marek Vasut <marex@denx.de>
The patch does not apply, so please rebase on u-boot-socfpga/master and
repost. You can keep the Ack.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-03-22 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 9:26 [U-Boot] [PATCH] arm: socfpga: migration of CONFIG_SPI_FLASH_BAR Bakhvalov, Denis
2016-03-22 14:23 ` Marek Vasut
2016-03-22 14:25 ` Marek Vasut [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-23 8:03 Bakhvalov, Denis
2016-03-23 8:06 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F155EA.80505@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox