public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 4/4] drivers:usb:common:fsl-dt-fixup: fix return value of fdt_usb_get_node_type
Date: Wed, 23 Mar 2016 09:42:21 +0100	[thread overview]
Message-ID: <56F256ED.10804@denx.de> (raw)
In-Reply-To: <DB4PR04MB055863D5441975D45370754BF5810@DB4PR04MB0558.eurprd04.prod.outlook.com>

On 03/23/2016 09:31 AM, Sriram Dash wrote:
> 
> 
>> -----Original Message-----
>> From: Marek Vasut [mailto:marex at denx.de]
>> Sent: Tuesday, March 22, 2016 12:56 PM
>> To: Sriram Dash <sriram.dash@nxp.com>; u-boot at lists.denx.de
>> Cc: york sun <york.sun@nxp.com>; Ramneek Mehresh
>> <ramneek.mehresh@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
>> Subject: Re: [PATCH v5 4/4] drivers:usb:common:fsl-dt-fixup: fix return value of
>> fdt_usb_get_node_type
>>
>> On 03/22/2016 08:10 AM, Sriram Dash wrote:
>>> Use int as it is native (and widely used) return type.
>>
>> What do you mean by "int ... is native (and widely used) return type" ?
>>
>> It's just a signed type, that's all there is to it.
>>
> 
> Ok that may sound incorrect, Shall I change the description as below:
> "Changes the return type of fdt_usb_get_node_type from char* to int"

Yeah, excellent.


-- 
Best regards,
Marek Vasut

      reply	other threads:[~2016-03-23  8:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22  7:10 [U-Boot] [PATCH v5 0/4] Make usb device-tree fixup independent of USB controller Sriram Dash
2016-03-22  7:10 ` [U-Boot] [PATCH v5 1/4] drivers:usb:common:fsl-dt-fixup: Move device-tree fixup framework to common file Sriram Dash
2016-03-22  7:24   ` Marek Vasut
2016-03-22  7:10 ` [U-Boot] [PATCH v5 2/4] drivers:usb:common:fsl-dt-fixup: Remove code duplication for fdt_usb_get_node_type Sriram Dash
2016-03-22  7:24   ` Marek Vasut
2016-03-22  7:10 ` [U-Boot] [PATCH v5 3/4] drivers:usb:common:fsl-dt-fixup: Add device-tree fixup support for xhci controller Sriram Dash
2016-03-22  7:23   ` Marek Vasut
2016-03-23  8:30     ` Sriram Dash
2016-03-23  8:41       ` Marek Vasut
2016-03-23  8:43         ` Marek Vasut
2016-03-22  7:10 ` [U-Boot] [PATCH v5 4/4] drivers:usb:common:fsl-dt-fixup: fix return value of fdt_usb_get_node_type Sriram Dash
2016-03-22  7:25   ` Marek Vasut
2016-03-23  8:31     ` Sriram Dash
2016-03-23  8:42       ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F256ED.10804@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox