[U-Boot] [PATCH 1/3] drivers: block: add block device cache

Eric Nelson
2016-03-28T14:33:24Z

Thanks Tom,

On 03/28/2016 07:16 AM, Tom Rini wrote:
> On Sun, Mar 27, 2016 at 12:00:13PM -0700, Eric Nelson wrote:
>
>> +++ b/drivers/block/blkcache.c
> [snip]
>> +static int trace;
>
> I see where you can toggle this at run-time. But do we really think
> that this will be useful outside of debug? My first reaction is that we
> should move the trace stuff into debug() statements instead.
>

Will do.

Stephen had the same comment.

> [snip]
>> +#ifdef CONFIG_CMD_BLOCK_CACHE
>
> Please split the command code into cmd/blkcache.c. And yes, this might
> require thinking harder about what to expose or making an API for some
> of it. I'm also not sure that's a bad thing as tuning the cache seems
> useful long term but dumping the stats seems more like debug work.
>

Okay. I started to do that but stopped when I looked at the number
of implementation details needed by the commands themselves.

> [snip]
>> + /* Strip off leading 'i2c' command argument */
>> + argc--;
>> + argv++;
>
> I see you borrowed from i2c here :)
>
Yep. Oops.

Regards,

Eric