[U-Boot] [PATCH V3 1/3] drivers: block: add block device cache

Eric Nelson
2016-04-02T14:17:56Z

On 04/01/2016 04:41 PM, Tom Rini wrote:
> On Fri, Apr 01, 2016 at 04:16:42PM -0700, Eric Nelson wrote:
>> Hi Stephen,
>>
>> On 04/01/2016 03:57 PM, Stephen Warren wrote:
>>> On 03/31/2016 02:24 PM, Eric Nelson wrote:
>>>> On 03/30/2016 02:57 PM, Stephen Warren wrote:
>>>>> On 03/30/2016 11:34 AM, Eric Nelson wrote:
>>>>>> On 03/30/2016 07:36 AM, Stephen Warren wrote:
>>>>>>> On 03/28/2016 11:05 AM, Eric Nelson wrote:

<snip>

>> Yes, but also that the host will cache blocks in the ums case, so
>> having the cache enabled will only slow things down slightly by
>> lots of memcpy's to cached blocks that won't be helpful.
>>
>> I think I was a bit flippant by including dfu in this statement,
>> since I haven't used it to access anything except SPI-NOR.
>>
>>> Eventually it seems better to keep the cache enabled for at least DFU to
>>> a filesystem (rather than raw block device) since presumably parsing the
>>> directory structure to write to a file for DFU would benefit from the
>>> cache just like anything else.
>>
>> I'm not in a position to comment about dfu.
>
> For the record, I think this discussion is good and important, but not a
> blocker for getting the initial functionality in.
>

I wholeheartedly agree.

I'm learning a lot and the code's better because of Stephen's feedback.

Regards,

Eric