public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] sunxi: A83T: fix 32bit overflow warning
Date: Wed, 23 Mar 2016 22:01:41 +0100	[thread overview]
Message-ID: <56F30435.1030102@redhat.com> (raw)
In-Reply-To: <1458755673-3798-1-git-send-email-vishnupatekar0510@gmail.com>

Hi,

On 23-03-16 18:54, vishnupatekar wrote:
> In mctl_channel_init, (0x50<<26) which overflows 32bit.
> It was supposed to be 0x50<<16,corrected now.
>
> Reported-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com>

Thanks, applied.

Regards,

Hans


> ---
>   arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c b/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c
> index 7c46acd..55df1b9 100644
> --- a/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c
> +++ b/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c
> @@ -280,7 +280,7 @@ static int mctl_channel_init(struct dram_para *para)
>
>   	writel(0x94be6fa3, MCTL_PROTECT);
>   	udelay(100);
> -	clrsetbits_le32(MX_UPD2, 0xfff << 16, 0x50 << 26);
> +	clrsetbits_le32(MX_UPD2, 0xfff << 16, 0x50 << 16);
>   	writel(0x0, MCTL_PROTECT);
>   	udelay(100);
>
>

      reply	other threads:[~2016-03-23 21:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 17:54 [U-Boot] [PATCH] sunxi: A83T: fix 32bit overflow warning Vishnu Patekar
2016-03-23 21:01 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F30435.1030102@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox