* [U-Boot] [PATCH] sunxi: A83T: fix 32bit overflow warning
@ 2016-03-23 17:54 Vishnu Patekar
2016-03-23 21:01 ` [U-Boot] " Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Vishnu Patekar @ 2016-03-23 17:54 UTC (permalink / raw)
To: u-boot
In mctl_channel_init, (0x50<<26) which overflows 32bit.
It was supposed to be 0x50<<16,corrected now.
Reported-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com>
---
arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c b/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c
index 7c46acd..55df1b9 100644
--- a/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c
+++ b/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c
@@ -280,7 +280,7 @@ static int mctl_channel_init(struct dram_para *para)
writel(0x94be6fa3, MCTL_PROTECT);
udelay(100);
- clrsetbits_le32(MX_UPD2, 0xfff << 16, 0x50 << 26);
+ clrsetbits_le32(MX_UPD2, 0xfff << 16, 0x50 << 16);
writel(0x0, MCTL_PROTECT);
udelay(100);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] sunxi: A83T: fix 32bit overflow warning
2016-03-23 17:54 [U-Boot] [PATCH] sunxi: A83T: fix 32bit overflow warning Vishnu Patekar
@ 2016-03-23 21:01 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2016-03-23 21:01 UTC (permalink / raw)
To: u-boot
Hi,
On 23-03-16 18:54, vishnupatekar wrote:
> In mctl_channel_init, (0x50<<26) which overflows 32bit.
> It was supposed to be 0x50<<16,corrected now.
>
> Reported-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com>
Thanks, applied.
Regards,
Hans
> ---
> arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c b/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c
> index 7c46acd..55df1b9 100644
> --- a/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c
> +++ b/arch/arm/cpu/armv7/sunxi/dram_sun8i_a83t.c
> @@ -280,7 +280,7 @@ static int mctl_channel_init(struct dram_para *para)
>
> writel(0x94be6fa3, MCTL_PROTECT);
> udelay(100);
> - clrsetbits_le32(MX_UPD2, 0xfff << 16, 0x50 << 26);
> + clrsetbits_le32(MX_UPD2, 0xfff << 16, 0x50 << 16);
> writel(0x0, MCTL_PROTECT);
> udelay(100);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-23 21:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-23 17:54 [U-Boot] [PATCH] sunxi: A83T: fix 32bit overflow warning Vishnu Patekar
2016-03-23 21:01 ` [U-Boot] " Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox