public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: mvebu: enable generic distro boot config
Date: Thu, 24 Mar 2016 09:29:40 +0100	[thread overview]
Message-ID: <56F3A574.9050302@denx.de> (raw)
In-Reply-To: <56A8677C.6090302@denx.de>

Hi Dennis,

On 27.01.2016 07:45, Stefan Roese wrote:
> Hi Dennis,
>
> On 15.01.2016 02:20, Dennis Gilmore wrote:
>> Switch all of the mvebu boards to support disto generic booting
>> This will enable Fedora, Debian and other distros to support
>> mvebu systems easier. Tested on SolidRun ClearFog
>
> Sorry for the late review. I have a few issues with this patch.
> It generates build errors on some mvebu boards:
>
> ds414 db-88f6820-gp db-mv784mp-gp
>
> Mostly because of redefined macros:
>
> This one (db-mv784mp-gp):
>
> include/configs/mv-common.h:187:0: warning: "CONFIG_PREBOOT" redefined
>   #define CONFIG_PREBOOT                  "sata init"
>   ^
> In file included from include/configs/db-mv784mp-gp.h:100:0,
>                   from include/config.h:5,
>                   from include/common.h:18,
>                   from examples/standalone/hello_world.c:8:
> include/configs/mv-common.h:61:0: note: this is the location of the previous definition
>   #define CONFIG_PREBOOT
>
>
> Or this one (db-88f6820-gp):
>
> include/configs/mv-common.h:236:0: warning: "CONFIG_EXTRA_ENV_SETTINGS" redefined
>   #define CONFIG_EXTRA_ENV_SETTINGS
>   ^
> In file included from include/config.h:5:0,
>                   from include/common.h:18,
>                   from drivers/ddr/marvell/a38x/xor.c:7:
> include/configs/db-88f6820-gp.h:108:0: note: this is the location of the previous definition
>   #define CONFIG_EXTRA_ENV_SETTINGS \
>
>
> Or this one (ds414):
>
> include/configs/ds414.h:156:0: warning: "CONFIG_BOOTCOMMAND" redefined
> #define CONFIG_BOOTCOMMAND "sf read ${loadaddr} 0xd0000 0x700000; bootm"
> ^
> In file included from include/configs/mv-common.h:204:0,
> from include/configs/ds414.h:104,
> from include/config.h:5,
> from include/common.h:18,
> from include/ubi_uboot.h:17,
> from fs/ubifs/ubifs.h:37,
> from fs/ubifs/recovery.c:45:
>
>
> Perhaps it makes sense to not move all mvebu boards to the
> generic distro booting. But only the Marvell eval boards and
> the community boards, like the clearfog (and not the ds414
> for example).
>
> What do you think?

Did you find the time to look into this?

Thanks,
Stefan

      reply	other threads:[~2016-03-24  8:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15  1:20 [U-Boot] [PATCH] arm: mvebu: enable generic distro boot config Dennis Gilmore
2016-01-27  6:45 ` Stefan Roese
2016-03-24  8:29   ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F3A574.9050302@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox