From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Thu, 24 Mar 2016 09:29:40 +0100
Subject: [U-Boot] [PATCH] arm: mvebu: enable generic distro boot config
In-Reply-To: <56A8677C.6090302@denx.de>
References: <1452820850-12020-1-git-send-email-dennis@ausil.us>
 <56A8677C.6090302@denx.de>
Message-ID: <56F3A574.9050302@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Dennis,

On 27.01.2016 07:45, Stefan Roese wrote:
> Hi Dennis,
>
> On 15.01.2016 02:20, Dennis Gilmore wrote:
>> Switch all of the mvebu boards to support disto generic booting
>> This will enable Fedora, Debian and other distros to support
>> mvebu systems easier. Tested on SolidRun ClearFog
>
> Sorry for the late review. I have a few issues with this patch.
> It generates build errors on some mvebu boards:
>
> ds414 db-88f6820-gp db-mv784mp-gp
>
> Mostly because of redefined macros:
>
> This one (db-mv784mp-gp):
>
> include/configs/mv-common.h:187:0: warning: "CONFIG_PREBOOT" redefined
>   #define CONFIG_PREBOOT                  "sata init"
>   ^
> In file included from include/configs/db-mv784mp-gp.h:100:0,
>                   from include/config.h:5,
>                   from include/common.h:18,
>                   from examples/standalone/hello_world.c:8:
> include/configs/mv-common.h:61:0: note: this is the location of the previous definition
>   #define CONFIG_PREBOOT
>
>
> Or this one (db-88f6820-gp):
>
> include/configs/mv-common.h:236:0: warning: "CONFIG_EXTRA_ENV_SETTINGS" redefined
>   #define CONFIG_EXTRA_ENV_SETTINGS
>   ^
> In file included from include/config.h:5:0,
>                   from include/common.h:18,
>                   from drivers/ddr/marvell/a38x/xor.c:7:
> include/configs/db-88f6820-gp.h:108:0: note: this is the location of the previous definition
>   #define CONFIG_EXTRA_ENV_SETTINGS \
>
>
> Or this one (ds414):
>
> include/configs/ds414.h:156:0: warning: "CONFIG_BOOTCOMMAND" redefined
> #define CONFIG_BOOTCOMMAND "sf read ${loadaddr} 0xd0000 0x700000; bootm"
> ^
> In file included from include/configs/mv-common.h:204:0,
> from include/configs/ds414.h:104,
> from include/config.h:5,
> from include/common.h:18,
> from include/ubi_uboot.h:17,
> from fs/ubifs/ubifs.h:37,
> from fs/ubifs/recovery.c:45:
>
>
> Perhaps it makes sense to not move all mvebu boards to the
> generic distro booting. But only the Marvell eval boards and
> the community boards, like the clearfog (and not the ds414
> for example).
>
> What do you think?

Did you find the time to look into this?

Thanks,
Stefan