From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] kirkwood_nand: claim MPP pins on the fly
Date: Thu, 24 Mar 2016 09:40:44 +0100 [thread overview]
Message-ID: <56F3A80C.9020706@denx.de> (raw)
In-Reply-To: <1454369709-5459-1-git-send-email-judge.packham@gmail.com>
On 02.02.2016 00:35, Chris Packham wrote:
> Claim the MPP pins for the NAND flash controller only when it's actually
> being used. This allows the pins to be shared with the SPI interface
> which already supports an equivalent on-access MPP reconfiguration.
>
> Reviewed-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> I haven't wrapped this with a configuration option because I think it
> should be safe to enable by default. It will either re-apply the same
> MPP configuration that has already been done in the board init or put
> the MPP pins into the correct mode to access NAND.
>
> I've only got access to one kirkwood based board with NAND flash so I'd
> appreciate some feedback from someone with access to a few different
> boards.
>
> From the datasheets I have access to it looks like there is only one
> possible MPP configuration for NF_IO[0-7] so that is what I've
> implemented. I'm not aware of anything using this driver that needs a
> different MPP config.
>
> Changes in v2:
> - make nand_config static const
Scott, are you okay with this patch in v2? If yes, will you pull it?
Or should I include it in a marvell pull request?
Thanks,
Stefan
next prev parent reply other threads:[~2016-03-24 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 4:22 [U-Boot] [RFC PATCH v1] kirkwood_nand: claim MPP pins on the fly Chris Packham
2016-01-22 20:11 ` Scott Wood
2016-01-23 8:44 ` Chris Packham
2016-02-01 23:35 ` [U-Boot] [PATCH v2] " Chris Packham
2016-03-24 8:40 ` Stefan Roese [this message]
2016-04-04 22:48 ` Scott Wood
2016-04-06 13:42 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F3A80C.9020706@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox