public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 0/4] net: phy: Force master mode for RTL8211C on some boards
Date: Thu, 24 Mar 2016 11:58:25 +0100	[thread overview]
Message-ID: <56F3C851.6040508@redhat.com> (raw)
In-Reply-To: <1458801986-21625-1-git-send-email-haas@computerlinguist.org>

Hi Michael,

On 24-03-16 07:46, Michael Haas wrote:
>
> This patch is required to get reliable 1000BASE-T operation on some
> boards using the RTL8211C(L) PHY.
>
> Following discussions on v2 of this patch, I have removed the incorrect
> check for the RTL8211C(L). Affected boards now have to define
> CONFIG_RTL8211X_PHY_FORCE_MASTER to benefit from the fix.
>
> Note that this patch requires Karsten Merkers '[PATCH] net: phy: Realtek
> RTL8211B/C PHY ID fix' as well as Hans de Goede's recent u-boot-sunxi
> pull request, specifically 1eae8f66ff749409eb96e2f3f3387c56232d0b8a and
> fc8991c61c393ce6a9d3dfc97cb56dbbd9e8cbba.

Thanks for this patch series. I believe you should
squash patch 4 into patch 1, as that is where it belongs
IMHO.

Also note that patch 2/3 will not do anything unless patch 4
is also applied setting CONFIG_FOO in a defconfig does not do
anything unless CONFIG_FOO is defined in Kconfig.

Regards,

Hans



>
> Michael
>
>
> Changes in v3:
>   - Remove incorrect detection of RTL8211CL and use #ifdef instead
>     (thanks to Karsten Merker)
>   - Introduced constants for register bits
>
> Changes in v2:
>   - Removed accidental inclusion of Karsten's patch in my first submission of this series.
>   - Fix a typo in the code: 6 -> &
>
> Michael Haas (4):
>    net: phy: Optionally force master mode for RTL PHY
>    net: phy: Force master mode for A20-Olimex-SOM-EVB
>    net: phy: Force master mode A20-OLinuXino-Lime2
>    net: phy: Add RTL8211X_PHY_FORCE_MASTER to Kconfig
>
>   configs/A20-OLinuXino-Lime2_defconfig |  1 +
>   configs/A20-Olimex-SOM-EVB_defconfig  |  1 +
>   drivers/net/Kconfig                   | 17 +++++++++++++++++
>   drivers/net/phy/realtek.c             | 13 ++++++++++++-
>   4 files changed, 31 insertions(+), 1 deletion(-)
>

  parent reply	other threads:[~2016-03-24 10:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24  6:46 [U-Boot] [PATCH v3 0/4] net: phy: Force master mode for RTL8211C on some boards Michael Haas
2016-03-24  6:46 ` [U-Boot] [PATCH v3 1/4] net: phy: Optionally force master mode for RTL PHY Michael Haas
2016-03-24  6:46 ` [U-Boot] [PATCH v3 2/4] net: phy: Force master mode for A20-Olimex-SOM-EVB Michael Haas
2016-03-25 21:11   ` Joe Hershberger
2016-03-24  6:46 ` [U-Boot] [PATCH v3 3/4] net: phy: Force master mode A20-OLinuXino-Lime2 Michael Haas
2016-03-25 21:12   ` Joe Hershberger
2016-03-25 23:46   ` Iain Paton
2016-03-26  5:38     ` Michael Haas
2016-03-24  6:46 ` [U-Boot] [PATCH v3 4/4] net: phy: Add RTL8211X_PHY_FORCE_MASTER to Kconfig Michael Haas
2016-03-24 10:58 ` Hans de Goede [this message]
2016-03-24 12:44 ` [U-Boot] [PATCH v3 0/4] net: phy: Force master mode for RTL8211C on some boards Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F3C851.6040508@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox