From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Thu, 24 Mar 2016 11:58:25 +0100 Subject: [U-Boot] [PATCH v3 0/4] net: phy: Force master mode for RTL8211C on some boards In-Reply-To: <1458801986-21625-1-git-send-email-haas@computerlinguist.org> References: <1458801986-21625-1-git-send-email-haas@computerlinguist.org> Message-ID: <56F3C851.6040508@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Michael, On 24-03-16 07:46, Michael Haas wrote: > > This patch is required to get reliable 1000BASE-T operation on some > boards using the RTL8211C(L) PHY. > > Following discussions on v2 of this patch, I have removed the incorrect > check for the RTL8211C(L). Affected boards now have to define > CONFIG_RTL8211X_PHY_FORCE_MASTER to benefit from the fix. > > Note that this patch requires Karsten Merkers '[PATCH] net: phy: Realtek > RTL8211B/C PHY ID fix' as well as Hans de Goede's recent u-boot-sunxi > pull request, specifically 1eae8f66ff749409eb96e2f3f3387c56232d0b8a and > fc8991c61c393ce6a9d3dfc97cb56dbbd9e8cbba. Thanks for this patch series. I believe you should squash patch 4 into patch 1, as that is where it belongs IMHO. Also note that patch 2/3 will not do anything unless patch 4 is also applied setting CONFIG_FOO in a defconfig does not do anything unless CONFIG_FOO is defined in Kconfig. Regards, Hans > > Michael > > > Changes in v3: > - Remove incorrect detection of RTL8211CL and use #ifdef instead > (thanks to Karsten Merker) > - Introduced constants for register bits > > Changes in v2: > - Removed accidental inclusion of Karsten's patch in my first submission of this series. > - Fix a typo in the code: 6 -> & > > Michael Haas (4): > net: phy: Optionally force master mode for RTL PHY > net: phy: Force master mode for A20-Olimex-SOM-EVB > net: phy: Force master mode A20-OLinuXino-Lime2 > net: phy: Add RTL8211X_PHY_FORCE_MASTER to Kconfig > > configs/A20-OLinuXino-Lime2_defconfig | 1 + > configs/A20-Olimex-SOM-EVB_defconfig | 1 + > drivers/net/Kconfig | 17 +++++++++++++++++ > drivers/net/phy/realtek.c | 13 ++++++++++++- > 4 files changed, 31 insertions(+), 1 deletion(-) >