public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric@nelint.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3] fsl: esdhc: support driver model
Date: Sun, 27 Mar 2016 11:18:00 -0700	[thread overview]
Message-ID: <56F823D8.5030803@nelint.com> (raw)
In-Reply-To: <20160327145735.GA26070@linux-7smt.suse>

Hi Peng,

On 03/27/2016 07:57 AM, Peng Fan wrote:
> On Fri, Mar 25, 2016 at 01:12:39PM -0700, Eric Nelson wrote:
>> On 03/24/2016 11:16 PM, Peng Fan wrote:
>>> Support Driver Model for fsl esdhc driver.
>>>
>>> 1. Introduce a new structure struct fsl_esdhc_priv
>>> 2. Refactor fsl_esdhc_initialize which is originally used by board code.
>>>    - Introduce fsl_esdhc_init to be common usage for DM and non-DM
>>>    - Introduce fsl_esdhc_cfg_to_priv to build the bridge for non-DM part.
>>>    - The original API for board code is still there, but we use
>>>      'fsl_esdhc_cfg_to_priv' and 'fsl_esdhc_init' to serve it.
>>> 3. All the functions are changed to use 'struct fsl_esdhc_priv', except
>>>    fsl_esdhc_initialize.
>>> 4. Since clk driver is not implemented, use mxc_get_clock to geth
>>>    the clk and fill 'priv->sdhc_clk'.
>>>
>>> Has been tested on i.MX6UL 14X14 EVK board:
>>> "
>>> =>dm tree
>>> ....
>>>  simple_bus  [ + ]    |   `-- aips-bus at 02100000
>>>   mmc        [ + ]    |       |-- usdhc at 02190000
>>>   mmc        [ + ]    |       |-- usdhc at 02194000
>>> ....
>>> => mmc list
>>> FSL_SDHC: 0 (SD) 
>>> FSL_SDHC: 1 (SD)
>>> "
>>>
>>
>> After pulling in device tree files from the mainline kernel, I was able
>> to test this on a SABRE Lite, so you can add my:
>>
>> Tested-By: Eric Nelson <eric@nelint.com>
> 
> Thanks, Eric.
> 

Thank you for adding this support.

>>
>> Is somebody prepping patches to pull in support for i.MX6DQ?
> 
> I can not follow you on this? you mean adding dts files for i.MX6DQ or else?
>

Yes, or at least the .dtsi and .h files from arch/arm/boot/dts/.

Your i.MX6UL patch pulled in the files needed for UL, and the same
is needed for i.MX6DQ, i.MX6SX and such.

I have a patch pulling i.MX6DQ files from linux-stable (4.4), but
don't want to jump in the middle if somebody else is doing this.

Regards,


Eric

  reply	other threads:[~2016-03-27 18:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25  6:16 [U-Boot] [PATCH V3] fsl: esdhc: support driver model Peng Fan
2016-03-25 20:12 ` Eric Nelson
2016-03-27 14:57   ` Peng Fan
2016-03-27 18:18     ` Eric Nelson [this message]
2016-03-28  1:14       ` Peng Fan
2016-03-28 17:26         ` [U-Boot] [PATCH 1/9] imx: imx6qdl: add device tree files for i.MX6DQ Eric Nelson
2016-03-28 17:44           ` Eric Nelson
2016-03-27 14:59 ` [U-Boot] [PATCH V3] fsl: esdhc: support driver model Peng Fan
2016-03-27 16:58   ` york sun
2016-03-28 17:55   ` york sun
2016-03-28 23:56     ` Peng Fan
2016-04-06 17:21 ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F823D8.5030803@nelint.com \
    --to=eric@nelint.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox