From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Date: Thu, 31 Mar 2016 10:27:31 -0500 Subject: [U-Boot] [RFC PATCH 1/2] net: phy: ti: Allow the driver to be more configurable In-Reply-To: <20160331141103.GE23166@bill-the-cat> References: <1459428160-6862-1-git-send-email-dmurphy@ti.com> <20160331141103.GE23166@bill-the-cat> Message-ID: <56FD41E3.4040701@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Tom On 03/31/2016 09:11 AM, Tom Rini wrote: > On Thu, Mar 31, 2016 at 07:42:39AM -0500, Dan Murphy wrote: > >> Not all devices use the same internal delay or fifo depth. >> Add the ability to set the internal delay for rx or tx and the >> fifo depth via the config file. If the value is not set in the >> config file then set the delay to the default. >> >> Signed-off-by: Dan Murphy >> --- >> drivers/net/phy/ti.c | 71 ++++++++++++++++++++++++++++++++---- >> include/dt-bindings/net/ti-dp83867.h | 35 ++++++++++++++++++ > I don't think this is taking things down the right path. If it's a DT > binding, it comes from the device tree (which is fine and good!) but > that means the binding needs to meet the usual reviews and not just come > in via U-Boot like this. We really don't want to add a DT binding that > gets values from the config.h file. > This binding file I created that is already part of the Mainline kernel. I just brought it in to use #defines and once the drivers are ported to use DT then the bindings will already be available. And the config.h should be getting its values from the dt-binding. Dan -- ------------------ Dan Murphy