From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Nelson Date: Sat, 2 Apr 2016 07:17:56 -0700 Subject: [U-Boot] [PATCH V3 1/3] drivers: block: add block device cache In-Reply-To: <20160401234149.GJ23166@bill-the-cat> References: <1459182290-14656-1-git-send-email-eric@nelint.com> <1459184744-15101-1-git-send-email-eric@nelint.com> <56FBE465.8010800@wwwdotorg.org> <56FC0E11.1080203@nelint.com> <56FC4BCC.4020507@wwwdotorg.org> <56FD8782.5060607@nelint.com> <56FEFCD1.50507@wwwdotorg.org> <56FF015A.2010304@nelint.com> <20160401234149.GJ23166@bill-the-cat> Message-ID: <56FFD494.8090609@nelint.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/01/2016 04:41 PM, Tom Rini wrote: > On Fri, Apr 01, 2016 at 04:16:42PM -0700, Eric Nelson wrote: >> Hi Stephen, >> >> On 04/01/2016 03:57 PM, Stephen Warren wrote: >>> On 03/31/2016 02:24 PM, Eric Nelson wrote: >>>> On 03/30/2016 02:57 PM, Stephen Warren wrote: >>>>> On 03/30/2016 11:34 AM, Eric Nelson wrote: >>>>>> On 03/30/2016 07:36 AM, Stephen Warren wrote: >>>>>>> On 03/28/2016 11:05 AM, Eric Nelson wrote: >> Yes, but also that the host will cache blocks in the ums case, so >> having the cache enabled will only slow things down slightly by >> lots of memcpy's to cached blocks that won't be helpful. >> >> I think I was a bit flippant by including dfu in this statement, >> since I haven't used it to access anything except SPI-NOR. >> >>> Eventually it seems better to keep the cache enabled for at least DFU to >>> a filesystem (rather than raw block device) since presumably parsing the >>> directory structure to write to a file for DFU would benefit from the >>> cache just like anything else. >> >> I'm not in a position to comment about dfu. > > For the record, I think this discussion is good and important, but not a > blocker for getting the initial functionality in. > I wholeheartedly agree. I'm learning a lot and the code's better because of Stephen's feedback. Regards, Eric