From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: gadget: Move CONFIG_USB_GADGET to Kconfig
Date: Sat, 2 Apr 2016 20:41:56 -0600 [thread overview]
Message-ID: <570082F4.8070801@wwwdotorg.org> (raw)
In-Reply-To: <CAKaJLVtEC7NHOyD8KhbAiuyDBVHxacpkqqW4HOxNkwckO=hG6g@mail.gmail.com>
On 03/24/2016 10:21 AM, Sam Protsenko wrote:
> On Tue, Mar 22, 2016 at 11:37 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 03/22/2016 01:59 PM, Semen Protsenko wrote:
>>>
>>> From: Sam Protsenko <semen.protsenko@linaro.org>
>>>
>>> The description was borrowed from kernel. "tristate" type was changed
>>> to "bool" (I believe we don't support modules for u-boot yet, right?).
>>> CONFIG_USB_GADGET requires CONFIG_USB to be defined too, so add it along
>>> as well.
>>>
>>> Some platforms weren't ported though:
>>>
>>> include/configs/e2220-1170.h
>>> include/configs/sunxi-common.h
>>> include/configs/xilinx_zynqmp.h
>>>
>>> CONFIG_USB_GADGET remains in those files as there is no corresponding
>>> defconfig files for those and I don't want to break anything.
>>
>>
>> That's not true; configs/e2220-1170_defconfig has existed for months. Did
>> you base this change on the latest u-boot/master?
>
> Yes, you are right. I was assuming that each defconfig file must
> define CONFIG_TARGET_ in order to tie itself to corresponding
> include/configs/*.h header. It turns out it's not true and I obviously
> need to check ".config" file for CONFIG_TARGET_* definition after
> doing "make ..._defconfig". This is because some defconfig files
> doesn't have CONFIG_TARGET_ definition, but it's enabled as
> dependency, or as default value, or whatever.
FYI, for unrelated reasons, I checked why e2220-1170_defconfig is the
way it is. It's because there's a Kconfig menu in
arch/arm/mach-tegra/tegra210/Kconfig, and CONFIG_TARGET_E2220_1170 is
indeed the first, and hence default, value.
prev parent reply other threads:[~2016-04-03 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 19:59 [U-Boot] [PATCH] usb: gadget: Move CONFIG_USB_GADGET to Kconfig Semen Protsenko
2016-03-22 21:37 ` Stephen Warren
2016-03-24 16:21 ` Sam Protsenko
2016-04-03 2:41 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570082F4.8070801@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox