[U-Boot] [RESEND PATCH V3 1/6] dm: gpio: add a default gpio xlate routine

Stephen Warren
2016-04-21T17:03:57Z

On 04/20/2016 09:37 AM, Eric Nelson wrote:
> Many drivers use a common form of offset + flags for device
> tree nodes. e.g.:
> <&gpio1 2 GPIO_ACTIVE_LOW>
>
> This patch adds a common implementation of this type of parsing
> and calls it when a gpio driver doesn't supply its' own xlate
> routine.
>
> This will allow removal of the driver-specific versions in a
> handful of drivers and simplify the addition of new drivers.

> diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c

> +int gpio_xlate_offs_flags(struct udevice *dev,
> + struct gpio_desc *desc,
> + struct fdtdec_phandle_args *args)
> +{
> + if (args->args_count < 1)
> + return -EINVAL;
> +
> + desc->offset = args->args[0];
> +
> + if (args->args_count < 2)
> + return 0;

Nit: There's an indentation inconsistency there.

Aside from that, the series,
Reviewed-by: Stephen Warren <swarren@nvidia.com>