public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] rpi: remove redundant board files
Date: Sun, 3 Apr 2016 17:41:39 +0200	[thread overview]
Message-ID: <570139B3.70704@suse.de> (raw)
In-Reply-To: <1459655770-6051-1-git-send-email-swarren@wwwdotorg.org>

Am 03.04.2016 um 05:56 schrieb Stephen Warren:
> Now that rpi_*defconfig and Kconfig rather than the config header file,

"rpi*_defconfig"?

Also the sentence seems to be missing a verb - "Now that we use ..."?

> provide the identify of the build, we don't need to separate config

"identity"?

> headers and board directories for each RPi variant. Set CONFIG_SYS_BOARD
> and CONFIG_SYS_CONFIG_NAME so that we can get rid of the duplication. This
> requires a tiny number of extra ifdefs in the config header.
> 
> The only disadvantage of this approach is that the $board/$board_name
> environment variables aren't as descriptive as they used to be. This isn't
> really an issue because those only exist to allow scripts to create DTB
> filenames at runtime. However, the RPi board code already sets $fdtfile to
> something more accurate based on FW-reported board ID anyway.
> 
> While at it, unify some Kconfig select options, and add a MAINTAINERS
> entry for bcm283x too.
> 
> Partially-suggested-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)

  parent reply	other threads:[~2016-04-03 15:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-03  3:56 [U-Boot] [PATCH] rpi: remove redundant board files Stephen Warren
2016-04-03 14:46 ` Tom Rini
2016-04-03 15:41 ` Andreas Färber [this message]
2016-04-04 15:36   ` Stephen Warren
2016-04-04 15:46     ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570139B3.70704@suse.de \
    --to=afaerber@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox