From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v3, 5/9] Drop command-processing code when CONFIG_CMDLINE is disabled
Date: Mon, 4 Apr 2016 12:16:14 +0200 [thread overview]
Message-ID: <57023EEE.3020301@denx.de> (raw)
In-Reply-To: <20160402015547.GP23166@bill-the-cat>
Hi Simon, Hi Tom!
On 02.04.2016 03:55, Tom Rini wrote:
> On Sat, Mar 19, 2016 at 02:18:38AM -0600, Simon Glass wrote:
>
>> Command parsing and processing code is not needed when the command line is
>> disabled. Remove this code in that case.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> Applied to u-boot/master, thanks!
I just noticed that this patch breaks U-Boot on some boards. All that
don't have CONFIG_SYS_HUSH_PARSER or CONFIG_CMDLINE enabled (e.g.
some MVEBU board, like the "db-mv784mp-gp".
How should this be solved? Should we enable CONFIG_CMDLINE per
default (via config_defaults.h ?)? Or should we enable CONFIG_CMDLINE
in all board config headers that are currently missing it?
Thanks,
Stefan
next prev parent reply other threads:[~2016-04-04 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 8:18 [U-Boot] [PATCH v3 5/9] Drop command-processing code when CONFIG_CMDLINE is disabled Simon Glass
2016-04-02 1:55 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-04-04 10:16 ` Stefan Roese [this message]
2016-04-04 13:18 ` Simon Glass
2016-04-04 13:38 ` Stefan Roese
2016-04-04 14:05 ` Simon Glass
2016-04-04 14:29 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57023EEE.3020301@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox