From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 4 Apr 2016 12:16:14 +0200 Subject: [U-Boot] [U-Boot, v3, 5/9] Drop command-processing code when CONFIG_CMDLINE is disabled In-Reply-To: <20160402015547.GP23166@bill-the-cat> References: <1458375522-23219-6-git-send-email-sjg@chromium.org> <20160402015547.GP23166@bill-the-cat> Message-ID: <57023EEE.3020301@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, Hi Tom! On 02.04.2016 03:55, Tom Rini wrote: > On Sat, Mar 19, 2016 at 02:18:38AM -0600, Simon Glass wrote: > >> Command parsing and processing code is not needed when the command line is >> disabled. Remove this code in that case. >> >> Signed-off-by: Simon Glass >> Reviewed-by: Tom Rini > > Applied to u-boot/master, thanks! I just noticed that this patch breaks U-Boot on some boards. All that don't have CONFIG_SYS_HUSH_PARSER or CONFIG_CMDLINE enabled (e.g. some MVEBU board, like the "db-mv784mp-gp". How should this be solved? Should we enable CONFIG_CMDLINE per default (via config_defaults.h ?)? Or should we enable CONFIG_CMDLINE in all board config headers that are currently missing it? Thanks, Stefan