public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375
@ 2016-03-15 16:35 Stefan Roese
  2016-03-15 16:35 ` [U-Boot] [PATCH 2/6] net: mvpp2.c: Add Marvell mvpp2 network driver " Stefan Roese
                   ` (6 more replies)
  0 siblings, 7 replies; 16+ messages in thread
From: Stefan Roese @ 2016-03-15 16:35 UTC (permalink / raw)
  To: u-boot

This enables this driver for the Marvell Armada 375 SoC.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Luka Perkov <luka.perkov@sartura.hr>
Cc: Jagan Teki <jteki@openedev.com>
---
 drivers/spi/kirkwood_spi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
index 7890796..80cdbd0 100644
--- a/drivers/spi/kirkwood_spi.c
+++ b/drivers/spi/kirkwood_spi.c
@@ -315,6 +315,7 @@ static const struct dm_spi_ops mvebu_spi_ops = {
 };
 
 static const struct udevice_id mvebu_spi_ids[] = {
+	{ .compatible = "marvell,armada-375-spi" },
 	{ .compatible = "marvell,armada-380-spi" },
 	{ .compatible = "marvell,armada-xp-spi" },
 	{ }
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 2/6] net: mvpp2.c: Add Marvell mvpp2 network driver for Armada 375
  2016-03-15 16:35 [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375 Stefan Roese
@ 2016-03-15 16:35 ` Stefan Roese
  2016-03-18 14:29   ` Stefan Roese
  2016-03-22 19:10   ` Joe Hershberger
  2016-03-15 16:35 ` [U-Boot] [PATCH 3/6] dt-bindings: Add include/dt-bindings/phy/phy.h from Linux v4.4 Stefan Roese
                   ` (5 subsequent siblings)
  6 siblings, 2 replies; 16+ messages in thread
From: Stefan Roese @ 2016-03-15 16:35 UTC (permalink / raw)
  To: u-boot

This patch adds support for the mvpp2 ethernet controller which is integrated
in the Marvell Armada 375 SoC. This port is based on the Linux driver (v4.4),
which has been stripped of the in U-Boot unused portions.

Tested on the Marvell Armada 375 eval board db-88f6720.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Luka Perkov <luka.perkov@sartura.hr>
Cc: Joe Hershberger <joe.hershberger@gmail.com>
---
 drivers/net/Kconfig  |    8 +
 drivers/net/Makefile |    1 +
 drivers/net/mvpp2.c  | 4222 ++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 4231 insertions(+)
 create mode 100644 drivers/net/mvpp2.c

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index bc2f51d..bcb4c96 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -94,6 +94,14 @@ config ETH_DESIGNWARE
 	  100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
 	  provide the PHY (physical media interface).
 
+config MVPP2
+	bool "Marvell Armada 375 network interface support"
+	depends on ARMADA_375
+	select PHYLIB
+	help
+	  This driver supports the network interface units in the
+	  Marvell ARMADA 375 SoC.
+
 config PCH_GBE
 	bool "Intel Platform Controller Hub EG20T GMAC driver"
 	depends on DM_ETH && DM_PCI
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 33a81ee..fbedd04 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -42,6 +42,7 @@ obj-$(CONFIG_MPC5xxx_FEC) += mpc5xxx_fec.o
 obj-$(CONFIG_MPC512x_FEC) += mpc512x_fec.o
 obj-$(CONFIG_MVGBE) += mvgbe.o
 obj-$(CONFIG_MVNETA) += mvneta.o
+obj-$(CONFIG_MVPP2) += mvpp2.o
 obj-$(CONFIG_NATSEMI) += natsemi.o
 obj-$(CONFIG_DRIVER_NE2000) += ne2000.o ne2000_base.o
 obj-$(CONFIG_DRIVER_AX88796L) += ax88796.o ne2000_base.o
diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
new file mode 100644
index 0000000..09dfc7e
--- /dev/null
+++ b/drivers/net/mvpp2.c
@@ -0,0 +1,4222 @@
+/*
+ * Driver for Marvell PPv2 network controller for Armada 375 SoC.
+ *
+ * Copyright (C) 2014 Marvell
+ *
+ * Marcin Wojtas <mw@semihalf.com>
+ *
+ * U-Boot version:
+ * Copyright (C) 2016 Stefan Roese <sr@denx.de>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <dm/device-internal.h>
+#include <dm/lists.h>
+#include <net.h>
+#include <netdev.h>
+#include <config.h>
+#include <malloc.h>
+#include <asm/io.h>
+#include <asm/errno.h>
+#include <phy.h>
+#include <miiphy.h>
+#include <watchdog.h>
+#include <asm/arch/cpu.h>
+#include <asm/arch/soc.h>
+#include <linux/compat.h>
+#include <linux/mbus.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#if !defined(CONFIG_PHYLIB)
+# error Marvell mvpp2 requires PHYLIB
+#endif
+
+/* Some linux -> U-Boot compatibility stuff */
+#define netdev_err(dev, fmt, args...)		\
+	printf(fmt, ##args)
+#define netdev_warn(dev, fmt, args...)		\
+	printf(fmt, ##args)
+#define netdev_info(dev, fmt, args...)		\
+	printf(fmt, ##args)
+#define netdev_dbg(dev, fmt, args...)		\
+	printf(fmt, ##args)
+
+#define ETH_ALEN	6		/* Octets in one ethernet addr	*/
+
+#define ETH_P_IP	0x0800		/* Internet Protocol packet     */
+#define ETH_P_PPP_SES	0x8864		/* PPPoE session messages	*/
+#define ETH_P_ARP	0x0806		/* Address Resolution packet	*/
+#define ETH_P_IPV6	0x86DD		/* IPv6 over bluebook		*/
+
+#define __verify_pcpu_ptr(ptr)						\
+do {									\
+	const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL;	\
+	(void)__vpp_verify;						\
+} while (0)
+
+#define VERIFY_PERCPU_PTR(__p)						\
+({									\
+	__verify_pcpu_ptr(__p);						\
+	(typeof(*(__p)) __kernel __force *)(__p);			\
+})
+
+#define per_cpu_ptr(ptr, cpu)	({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
+#define smp_processor_id()	0
+#define num_present_cpus()	1
+#define for_each_present_cpu(cpu)			\
+	for ((cpu) = 0; (cpu) < 1; (cpu)++)
+
+#define NET_SKB_PAD	max(32, MVPP2_CPU_D_CACHE_LINE_SIZE)
+
+#define CONFIG_NR_CPUS		1
+#define ETH_HLEN		14	/* Total octets in header */
+
+/* 2(HW hdr) 14(MAC hdr) 4(CRC) 32(extra for cache prefetch) */
+#define WRAP			(2 + ETH_HLEN + 4 + 32)
+#define MTU			1500
+#define RX_BUFFER_SIZE		(ALIGN(MTU + WRAP, ARCH_DMA_MINALIGN))
+
+#define MVPP2_SMI_TIMEOUT			10000
+
+/* RX Fifo Registers */
+#define MVPP2_RX_DATA_FIFO_SIZE_REG(port)	(0x00 + 4 * (port))
+#define MVPP2_RX_ATTR_FIFO_SIZE_REG(port)	(0x20 + 4 * (port))
+#define MVPP2_RX_MIN_PKT_SIZE_REG		0x60
+#define MVPP2_RX_FIFO_INIT_REG			0x64
+
+/* RX DMA Top Registers */
+#define MVPP2_RX_CTRL_REG(port)			(0x140 + 4 * (port))
+#define     MVPP2_RX_LOW_LATENCY_PKT_SIZE(s)	(((s) & 0xfff) << 16)
+#define     MVPP2_RX_USE_PSEUDO_FOR_CSUM_MASK	BIT(31)
+#define MVPP2_POOL_BUF_SIZE_REG(pool)		(0x180 + 4 * (pool))
+#define     MVPP2_POOL_BUF_SIZE_OFFSET		5
+#define MVPP2_RXQ_CONFIG_REG(rxq)		(0x800 + 4 * (rxq))
+#define     MVPP2_SNOOP_PKT_SIZE_MASK		0x1ff
+#define     MVPP2_SNOOP_BUF_HDR_MASK		BIT(9)
+#define     MVPP2_RXQ_POOL_SHORT_OFFS		20
+#define     MVPP2_RXQ_POOL_SHORT_MASK		0x700000
+#define     MVPP2_RXQ_POOL_LONG_OFFS		24
+#define     MVPP2_RXQ_POOL_LONG_MASK		0x7000000
+#define     MVPP2_RXQ_PACKET_OFFSET_OFFS	28
+#define     MVPP2_RXQ_PACKET_OFFSET_MASK	0x70000000
+#define     MVPP2_RXQ_DISABLE_MASK		BIT(31)
+
+/* Parser Registers */
+#define MVPP2_PRS_INIT_LOOKUP_REG		0x1000
+#define     MVPP2_PRS_PORT_LU_MAX		0xf
+#define     MVPP2_PRS_PORT_LU_MASK(port)	(0xff << ((port) * 4))
+#define     MVPP2_PRS_PORT_LU_VAL(port, val)	((val) << ((port) * 4))
+#define MVPP2_PRS_INIT_OFFS_REG(port)		(0x1004 + ((port) & 4))
+#define     MVPP2_PRS_INIT_OFF_MASK(port)	(0x3f << (((port) % 4) * 8))
+#define     MVPP2_PRS_INIT_OFF_VAL(port, val)	((val) << (((port) % 4) * 8))
+#define MVPP2_PRS_MAX_LOOP_REG(port)		(0x100c + ((port) & 4))
+#define     MVPP2_PRS_MAX_LOOP_MASK(port)	(0xff << (((port) % 4) * 8))
+#define     MVPP2_PRS_MAX_LOOP_VAL(port, val)	((val) << (((port) % 4) * 8))
+#define MVPP2_PRS_TCAM_IDX_REG			0x1100
+#define MVPP2_PRS_TCAM_DATA_REG(idx)		(0x1104 + (idx) * 4)
+#define     MVPP2_PRS_TCAM_INV_MASK		BIT(31)
+#define MVPP2_PRS_SRAM_IDX_REG			0x1200
+#define MVPP2_PRS_SRAM_DATA_REG(idx)		(0x1204 + (idx) * 4)
+#define MVPP2_PRS_TCAM_CTRL_REG			0x1230
+#define     MVPP2_PRS_TCAM_EN_MASK		BIT(0)
+
+/* Classifier Registers */
+#define MVPP2_CLS_MODE_REG			0x1800
+#define     MVPP2_CLS_MODE_ACTIVE_MASK		BIT(0)
+#define MVPP2_CLS_PORT_WAY_REG			0x1810
+#define     MVPP2_CLS_PORT_WAY_MASK(port)	(1 << (port))
+#define MVPP2_CLS_LKP_INDEX_REG			0x1814
+#define     MVPP2_CLS_LKP_INDEX_WAY_OFFS	6
+#define MVPP2_CLS_LKP_TBL_REG			0x1818
+#define     MVPP2_CLS_LKP_TBL_RXQ_MASK		0xff
+#define     MVPP2_CLS_LKP_TBL_LOOKUP_EN_MASK	BIT(25)
+#define MVPP2_CLS_FLOW_INDEX_REG		0x1820
+#define MVPP2_CLS_FLOW_TBL0_REG			0x1824
+#define MVPP2_CLS_FLOW_TBL1_REG			0x1828
+#define MVPP2_CLS_FLOW_TBL2_REG			0x182c
+#define MVPP2_CLS_OVERSIZE_RXQ_LOW_REG(port)	(0x1980 + ((port) * 4))
+#define     MVPP2_CLS_OVERSIZE_RXQ_LOW_BITS	3
+#define     MVPP2_CLS_OVERSIZE_RXQ_LOW_MASK	0x7
+#define MVPP2_CLS_SWFWD_P2HQ_REG(port)		(0x19b0 + ((port) * 4))
+#define MVPP2_CLS_SWFWD_PCTRL_REG		0x19d0
+#define     MVPP2_CLS_SWFWD_PCTRL_MASK(port)	(1 << (port))
+
+/* Descriptor Manager Top Registers */
+#define MVPP2_RXQ_NUM_REG			0x2040
+#define MVPP2_RXQ_DESC_ADDR_REG			0x2044
+#define MVPP2_RXQ_DESC_SIZE_REG			0x2048
+#define     MVPP2_RXQ_DESC_SIZE_MASK		0x3ff0
+#define MVPP2_RXQ_STATUS_UPDATE_REG(rxq)	(0x3000 + 4 * (rxq))
+#define     MVPP2_RXQ_NUM_PROCESSED_OFFSET	0
+#define     MVPP2_RXQ_NUM_NEW_OFFSET		16
+#define MVPP2_RXQ_STATUS_REG(rxq)		(0x3400 + 4 * (rxq))
+#define     MVPP2_RXQ_OCCUPIED_MASK		0x3fff
+#define     MVPP2_RXQ_NON_OCCUPIED_OFFSET	16
+#define     MVPP2_RXQ_NON_OCCUPIED_MASK		0x3fff0000
+#define MVPP2_RXQ_THRESH_REG			0x204c
+#define     MVPP2_OCCUPIED_THRESH_OFFSET	0
+#define     MVPP2_OCCUPIED_THRESH_MASK		0x3fff
+#define MVPP2_RXQ_INDEX_REG			0x2050
+#define MVPP2_TXQ_NUM_REG			0x2080
+#define MVPP2_TXQ_DESC_ADDR_REG			0x2084
+#define MVPP2_TXQ_DESC_SIZE_REG			0x2088
+#define     MVPP2_TXQ_DESC_SIZE_MASK		0x3ff0
+#define MVPP2_AGGR_TXQ_UPDATE_REG		0x2090
+#define MVPP2_TXQ_THRESH_REG			0x2094
+#define     MVPP2_TRANSMITTED_THRESH_OFFSET	16
+#define     MVPP2_TRANSMITTED_THRESH_MASK	0x3fff0000
+#define MVPP2_TXQ_INDEX_REG			0x2098
+#define MVPP2_TXQ_PREF_BUF_REG			0x209c
+#define     MVPP2_PREF_BUF_PTR(desc)		((desc) & 0xfff)
+#define     MVPP2_PREF_BUF_SIZE_4		(BIT(12) | BIT(13))
+#define     MVPP2_PREF_BUF_SIZE_16		(BIT(12) | BIT(14))
+#define     MVPP2_PREF_BUF_THRESH(val)		((val) << 17)
+#define     MVPP2_TXQ_DRAIN_EN_MASK		BIT(31)
+#define MVPP2_TXQ_PENDING_REG			0x20a0
+#define     MVPP2_TXQ_PENDING_MASK		0x3fff
+#define MVPP2_TXQ_INT_STATUS_REG		0x20a4
+#define MVPP2_TXQ_SENT_REG(txq)			(0x3c00 + 4 * (txq))
+#define     MVPP2_TRANSMITTED_COUNT_OFFSET	16
+#define     MVPP2_TRANSMITTED_COUNT_MASK	0x3fff0000
+#define MVPP2_TXQ_RSVD_REQ_REG			0x20b0
+#define     MVPP2_TXQ_RSVD_REQ_Q_OFFSET		16
+#define MVPP2_TXQ_RSVD_RSLT_REG			0x20b4
+#define     MVPP2_TXQ_RSVD_RSLT_MASK		0x3fff
+#define MVPP2_TXQ_RSVD_CLR_REG			0x20b8
+#define     MVPP2_TXQ_RSVD_CLR_OFFSET		16
+#define MVPP2_AGGR_TXQ_DESC_ADDR_REG(cpu)	(0x2100 + 4 * (cpu))
+#define MVPP2_AGGR_TXQ_DESC_SIZE_REG(cpu)	(0x2140 + 4 * (cpu))
+#define     MVPP2_AGGR_TXQ_DESC_SIZE_MASK	0x3ff0
+#define MVPP2_AGGR_TXQ_STATUS_REG(cpu)		(0x2180 + 4 * (cpu))
+#define     MVPP2_AGGR_TXQ_PENDING_MASK		0x3fff
+#define MVPP2_AGGR_TXQ_INDEX_REG(cpu)		(0x21c0 + 4 * (cpu))
+
+/* MBUS bridge registers */
+#define MVPP2_WIN_BASE(w)			(0x4000 + ((w) << 2))
+#define MVPP2_WIN_SIZE(w)			(0x4020 + ((w) << 2))
+#define MVPP2_WIN_REMAP(w)			(0x4040 + ((w) << 2))
+#define MVPP2_BASE_ADDR_ENABLE			0x4060
+
+/* Interrupt Cause and Mask registers */
+#define MVPP2_ISR_RX_THRESHOLD_REG(rxq)		(0x5200 + 4 * (rxq))
+#define MVPP2_ISR_RXQ_GROUP_REG(rxq)		(0x5400 + 4 * (rxq))
+#define MVPP2_ISR_ENABLE_REG(port)		(0x5420 + 4 * (port))
+#define     MVPP2_ISR_ENABLE_INTERRUPT(mask)	((mask) & 0xffff)
+#define     MVPP2_ISR_DISABLE_INTERRUPT(mask)	(((mask) << 16) & 0xffff0000)
+#define MVPP2_ISR_RX_TX_CAUSE_REG(port)		(0x5480 + 4 * (port))
+#define     MVPP2_CAUSE_RXQ_OCCUP_DESC_ALL_MASK	0xffff
+#define     MVPP2_CAUSE_TXQ_OCCUP_DESC_ALL_MASK	0xff0000
+#define     MVPP2_CAUSE_RX_FIFO_OVERRUN_MASK	BIT(24)
+#define     MVPP2_CAUSE_FCS_ERR_MASK		BIT(25)
+#define     MVPP2_CAUSE_TX_FIFO_UNDERRUN_MASK	BIT(26)
+#define     MVPP2_CAUSE_TX_EXCEPTION_SUM_MASK	BIT(29)
+#define     MVPP2_CAUSE_RX_EXCEPTION_SUM_MASK	BIT(30)
+#define     MVPP2_CAUSE_MISC_SUM_MASK		BIT(31)
+#define MVPP2_ISR_RX_TX_MASK_REG(port)		(0x54a0 + 4 * (port))
+#define MVPP2_ISR_PON_RX_TX_MASK_REG		0x54bc
+#define     MVPP2_PON_CAUSE_RXQ_OCCUP_DESC_ALL_MASK	0xffff
+#define     MVPP2_PON_CAUSE_TXP_OCCUP_DESC_ALL_MASK	0x3fc00000
+#define     MVPP2_PON_CAUSE_MISC_SUM_MASK		BIT(31)
+#define MVPP2_ISR_MISC_CAUSE_REG		0x55b0
+
+/* Buffer Manager registers */
+#define MVPP2_BM_POOL_BASE_REG(pool)		(0x6000 + ((pool) * 4))
+#define     MVPP2_BM_POOL_BASE_ADDR_MASK	0xfffff80
+#define MVPP2_BM_POOL_SIZE_REG(pool)		(0x6040 + ((pool) * 4))
+#define     MVPP2_BM_POOL_SIZE_MASK		0xfff0
+#define MVPP2_BM_POOL_READ_PTR_REG(pool)	(0x6080 + ((pool) * 4))
+#define     MVPP2_BM_POOL_GET_READ_PTR_MASK	0xfff0
+#define MVPP2_BM_POOL_PTRS_NUM_REG(pool)	(0x60c0 + ((pool) * 4))
+#define     MVPP2_BM_POOL_PTRS_NUM_MASK		0xfff0
+#define MVPP2_BM_BPPI_READ_PTR_REG(pool)	(0x6100 + ((pool) * 4))
+#define MVPP2_BM_BPPI_PTRS_NUM_REG(pool)	(0x6140 + ((pool) * 4))
+#define     MVPP2_BM_BPPI_PTR_NUM_MASK		0x7ff
+#define     MVPP2_BM_BPPI_PREFETCH_FULL_MASK	BIT(16)
+#define MVPP2_BM_POOL_CTRL_REG(pool)		(0x6200 + ((pool) * 4))
+#define     MVPP2_BM_START_MASK			BIT(0)
+#define     MVPP2_BM_STOP_MASK			BIT(1)
+#define     MVPP2_BM_STATE_MASK			BIT(4)
+#define     MVPP2_BM_LOW_THRESH_OFFS		8
+#define     MVPP2_BM_LOW_THRESH_MASK		0x7f00
+#define     MVPP2_BM_LOW_THRESH_VALUE(val)	((val) << \
+						MVPP2_BM_LOW_THRESH_OFFS)
+#define     MVPP2_BM_HIGH_THRESH_OFFS		16
+#define     MVPP2_BM_HIGH_THRESH_MASK		0x7f0000
+#define     MVPP2_BM_HIGH_THRESH_VALUE(val)	((val) << \
+						MVPP2_BM_HIGH_THRESH_OFFS)
+#define MVPP2_BM_INTR_CAUSE_REG(pool)		(0x6240 + ((pool) * 4))
+#define     MVPP2_BM_RELEASED_DELAY_MASK	BIT(0)
+#define     MVPP2_BM_ALLOC_FAILED_MASK		BIT(1)
+#define     MVPP2_BM_BPPE_EMPTY_MASK		BIT(2)
+#define     MVPP2_BM_BPPE_FULL_MASK		BIT(3)
+#define     MVPP2_BM_AVAILABLE_BP_LOW_MASK	BIT(4)
+#define MVPP2_BM_INTR_MASK_REG(pool)		(0x6280 + ((pool) * 4))
+#define MVPP2_BM_PHY_ALLOC_REG(pool)		(0x6400 + ((pool) * 4))
+#define     MVPP2_BM_PHY_ALLOC_GRNTD_MASK	BIT(0)
+#define MVPP2_BM_VIRT_ALLOC_REG			0x6440
+#define MVPP2_BM_PHY_RLS_REG(pool)		(0x6480 + ((pool) * 4))
+#define     MVPP2_BM_PHY_RLS_MC_BUFF_MASK	BIT(0)
+#define     MVPP2_BM_PHY_RLS_PRIO_EN_MASK	BIT(1)
+#define     MVPP2_BM_PHY_RLS_GRNTD_MASK		BIT(2)
+#define MVPP2_BM_VIRT_RLS_REG			0x64c0
+#define MVPP2_BM_MC_RLS_REG			0x64c4
+#define     MVPP2_BM_MC_ID_MASK			0xfff
+#define     MVPP2_BM_FORCE_RELEASE_MASK		BIT(12)
+
+/* TX Scheduler registers */
+#define MVPP2_TXP_SCHED_PORT_INDEX_REG		0x8000
+#define MVPP2_TXP_SCHED_Q_CMD_REG		0x8004
+#define     MVPP2_TXP_SCHED_ENQ_MASK		0xff
+#define     MVPP2_TXP_SCHED_DISQ_OFFSET		8
+#define MVPP2_TXP_SCHED_CMD_1_REG		0x8010
+#define MVPP2_TXP_SCHED_PERIOD_REG		0x8018
+#define MVPP2_TXP_SCHED_MTU_REG			0x801c
+#define     MVPP2_TXP_MTU_MAX			0x7FFFF
+#define MVPP2_TXP_SCHED_REFILL_REG		0x8020
+#define     MVPP2_TXP_REFILL_TOKENS_ALL_MASK	0x7ffff
+#define     MVPP2_TXP_REFILL_PERIOD_ALL_MASK	0x3ff00000
+#define     MVPP2_TXP_REFILL_PERIOD_MASK(v)	((v) << 20)
+#define MVPP2_TXP_SCHED_TOKEN_SIZE_REG		0x8024
+#define     MVPP2_TXP_TOKEN_SIZE_MAX		0xffffffff
+#define MVPP2_TXQ_SCHED_REFILL_REG(q)		(0x8040 + ((q) << 2))
+#define     MVPP2_TXQ_REFILL_TOKENS_ALL_MASK	0x7ffff
+#define     MVPP2_TXQ_REFILL_PERIOD_ALL_MASK	0x3ff00000
+#define     MVPP2_TXQ_REFILL_PERIOD_MASK(v)	((v) << 20)
+#define MVPP2_TXQ_SCHED_TOKEN_SIZE_REG(q)	(0x8060 + ((q) << 2))
+#define     MVPP2_TXQ_TOKEN_SIZE_MAX		0x7fffffff
+#define MVPP2_TXQ_SCHED_TOKEN_CNTR_REG(q)	(0x8080 + ((q) << 2))
+#define     MVPP2_TXQ_TOKEN_CNTR_MAX		0xffffffff
+
+/* TX general registers */
+#define MVPP2_TX_SNOOP_REG			0x8800
+#define MVPP2_TX_PORT_FLUSH_REG			0x8810
+#define     MVPP2_TX_PORT_FLUSH_MASK(port)	(1 << (port))
+
+/* LMS registers */
+#define MVPP2_SRC_ADDR_MIDDLE			0x24
+#define MVPP2_SRC_ADDR_HIGH			0x28
+#define MVPP2_PHY_AN_CFG0_REG			0x34
+#define     MVPP2_PHY_AN_STOP_SMI0_MASK		BIT(7)
+#define MVPP2_MIB_COUNTERS_BASE(port)		(0x1000 + ((port) >> 1) * \
+						0x400 + (port) * 0x400)
+#define     MVPP2_MIB_LATE_COLLISION		0x7c
+#define MVPP2_ISR_SUM_MASK_REG			0x220c
+#define MVPP2_MNG_EXTENDED_GLOBAL_CTRL_REG	0x305c
+#define MVPP2_EXT_GLOBAL_CTRL_DEFAULT		0x27
+
+/* Per-port registers */
+#define MVPP2_GMAC_CTRL_0_REG			0x0
+#define      MVPP2_GMAC_PORT_EN_MASK		BIT(0)
+#define      MVPP2_GMAC_MAX_RX_SIZE_OFFS	2
+#define      MVPP2_GMAC_MAX_RX_SIZE_MASK	0x7ffc
+#define      MVPP2_GMAC_MIB_CNTR_EN_MASK	BIT(15)
+#define MVPP2_GMAC_CTRL_1_REG			0x4
+#define      MVPP2_GMAC_PERIODIC_XON_EN_MASK	BIT(1)
+#define      MVPP2_GMAC_GMII_LB_EN_MASK		BIT(5)
+#define      MVPP2_GMAC_PCS_LB_EN_BIT		6
+#define      MVPP2_GMAC_PCS_LB_EN_MASK		BIT(6)
+#define      MVPP2_GMAC_SA_LOW_OFFS		7
+#define MVPP2_GMAC_CTRL_2_REG			0x8
+#define      MVPP2_GMAC_INBAND_AN_MASK		BIT(0)
+#define      MVPP2_GMAC_PCS_ENABLE_MASK		BIT(3)
+#define      MVPP2_GMAC_PORT_RGMII_MASK		BIT(4)
+#define      MVPP2_GMAC_PORT_RESET_MASK		BIT(6)
+#define MVPP2_GMAC_AUTONEG_CONFIG		0xc
+#define      MVPP2_GMAC_FORCE_LINK_DOWN		BIT(0)
+#define      MVPP2_GMAC_FORCE_LINK_PASS		BIT(1)
+#define      MVPP2_GMAC_CONFIG_MII_SPEED	BIT(5)
+#define      MVPP2_GMAC_CONFIG_GMII_SPEED	BIT(6)
+#define      MVPP2_GMAC_AN_SPEED_EN		BIT(7)
+#define      MVPP2_GMAC_FC_ADV_EN		BIT(9)
+#define      MVPP2_GMAC_CONFIG_FULL_DUPLEX	BIT(12)
+#define      MVPP2_GMAC_AN_DUPLEX_EN		BIT(13)
+#define MVPP2_GMAC_PORT_FIFO_CFG_1_REG		0x1c
+#define      MVPP2_GMAC_TX_FIFO_MIN_TH_OFFS	6
+#define      MVPP2_GMAC_TX_FIFO_MIN_TH_ALL_MASK	0x1fc0
+#define      MVPP2_GMAC_TX_FIFO_MIN_TH_MASK(v)	(((v) << 6) & \
+					MVPP2_GMAC_TX_FIFO_MIN_TH_ALL_MASK)
+
+#define MVPP2_CAUSE_TXQ_SENT_DESC_ALL_MASK	0xff
+
+/* Descriptor ring Macros */
+#define MVPP2_QUEUE_NEXT_DESC(q, index) \
+	(((index) < (q)->last_desc) ? ((index) + 1) : 0)
+
+/* SMI: 0xc0054 -> offset 0x54 to lms_base */
+#define MVPP2_SMI				0x0054
+#define     MVPP2_PHY_REG_MASK			0x1f
+/* SMI register fields */
+#define     MVPP2_SMI_DATA_OFFS			0	/* Data */
+#define     MVPP2_SMI_DATA_MASK			(0xffff << MVPP2_SMI_DATA_OFFS)
+#define     MVPP2_SMI_DEV_ADDR_OFFS		16	/* PHY device address */
+#define     MVPP2_SMI_REG_ADDR_OFFS		21	/* PHY device reg addr*/
+#define     MVPP2_SMI_OPCODE_OFFS		26	/* Write/Read opcode */
+#define     MVPP2_SMI_OPCODE_READ		(1 << MVPP2_SMI_OPCODE_OFFS)
+#define     MVPP2_SMI_READ_VALID		(1 << 27)	/* Read Valid */
+#define     MVPP2_SMI_BUSY			(1 << 28)	/* Busy */
+
+#define     MVPP2_PHY_ADDR_MASK			0x1f
+#define     MVPP2_PHY_REG_MASK			0x1f
+
+/* Various constants */
+
+/* Coalescing */
+#define MVPP2_TXDONE_COAL_PKTS_THRESH	15
+#define MVPP2_TXDONE_HRTIMER_PERIOD_NS	1000000UL
+#define MVPP2_RX_COAL_PKTS		32
+#define MVPP2_RX_COAL_USEC		100
+
+/* The two bytes Marvell header. Either contains a special value used
+ * by Marvell switches when a specific hardware mode is enabled (not
+ * supported by this driver) or is filled automatically by zeroes on
+ * the RX side. Those two bytes being at the front of the Ethernet
+ * header, they allow to have the IP header aligned on a 4 bytes
+ * boundary automatically: the hardware skips those two bytes on its
+ * own.
+ */
+#define MVPP2_MH_SIZE			2
+#define MVPP2_ETH_TYPE_LEN		2
+#define MVPP2_PPPOE_HDR_SIZE		8
+#define MVPP2_VLAN_TAG_LEN		4
+
+/* Lbtd 802.3 type */
+#define MVPP2_IP_LBDT_TYPE		0xfffa
+
+#define MVPP2_CPU_D_CACHE_LINE_SIZE	32
+#define MVPP2_TX_CSUM_MAX_SIZE		9800
+
+/* Timeout constants */
+#define MVPP2_TX_DISABLE_TIMEOUT_MSEC	1000
+#define MVPP2_TX_PENDING_TIMEOUT_MSEC	1000
+
+#define MVPP2_TX_MTU_MAX		0x7ffff
+
+/* Maximum number of T-CONTs of PON port */
+#define MVPP2_MAX_TCONT			16
+
+/* Maximum number of supported ports */
+#define MVPP2_MAX_PORTS			4
+
+/* Maximum number of TXQs used by single port */
+#define MVPP2_MAX_TXQ			8
+
+/* Maximum number of RXQs used by single port */
+#define MVPP2_MAX_RXQ			8
+
+/* Default number of TXQs in use */
+#define MVPP2_DEFAULT_TXQ		1
+
+/* Dfault number of RXQs in use */
+#define MVPP2_DEFAULT_RXQ		1
+#define CONFIG_MV_ETH_RXQ		8	/* increment by 8 */
+
+/* Total number of RXQs available to all ports */
+#define MVPP2_RXQ_TOTAL_NUM		(MVPP2_MAX_PORTS * MVPP2_MAX_RXQ)
+
+/* Max number of Rx descriptors */
+#define MVPP2_MAX_RXD			16
+
+/* Max number of Tx descriptors */
+#define MVPP2_MAX_TXD			16
+
+/* Amount of Tx descriptors that can be reserved@once by CPU */
+#define MVPP2_CPU_DESC_CHUNK		64
+
+/* Max number of Tx descriptors in each aggregated queue */
+#define MVPP2_AGGR_TXQ_SIZE		256
+
+/* Descriptor aligned size */
+#define MVPP2_DESC_ALIGNED_SIZE		32
+
+/* Descriptor alignment mask */
+#define MVPP2_TX_DESC_ALIGN		(MVPP2_DESC_ALIGNED_SIZE - 1)
+
+/* RX FIFO constants */
+#define MVPP2_RX_FIFO_PORT_DATA_SIZE	0x2000
+#define MVPP2_RX_FIFO_PORT_ATTR_SIZE	0x80
+#define MVPP2_RX_FIFO_PORT_MIN_PKT	0x80
+
+/* RX buffer constants */
+#define MVPP2_SKB_SHINFO_SIZE \
+	0
+
+#define MVPP2_RX_PKT_SIZE(mtu) \
+	ALIGN((mtu) + MVPP2_MH_SIZE + MVPP2_VLAN_TAG_LEN + \
+	      ETH_HLEN + ETH_FCS_LEN, MVPP2_CPU_D_CACHE_LINE_SIZE)
+
+#define MVPP2_RX_BUF_SIZE(pkt_size)	((pkt_size) + NET_SKB_PAD)
+#define MVPP2_RX_TOTAL_SIZE(buf_size)	((buf_size) + MVPP2_SKB_SHINFO_SIZE)
+#define MVPP2_RX_MAX_PKT_SIZE(total_size) \
+	((total_size) - NET_SKB_PAD - MVPP2_SKB_SHINFO_SIZE)
+
+#define MVPP2_BIT_TO_BYTE(bit)		((bit) / 8)
+
+/* IPv6 max L3 address size */
+#define MVPP2_MAX_L3_ADDR_SIZE		16
+
+/* Port flags */
+#define MVPP2_F_LOOPBACK		BIT(0)
+
+/* Marvell tag types */
+enum mvpp2_tag_type {
+	MVPP2_TAG_TYPE_NONE = 0,
+	MVPP2_TAG_TYPE_MH   = 1,
+	MVPP2_TAG_TYPE_DSA  = 2,
+	MVPP2_TAG_TYPE_EDSA = 3,
+	MVPP2_TAG_TYPE_VLAN = 4,
+	MVPP2_TAG_TYPE_LAST = 5
+};
+
+/* Parser constants */
+#define MVPP2_PRS_TCAM_SRAM_SIZE	256
+#define MVPP2_PRS_TCAM_WORDS		6
+#define MVPP2_PRS_SRAM_WORDS		4
+#define MVPP2_PRS_FLOW_ID_SIZE		64
+#define MVPP2_PRS_FLOW_ID_MASK		0x3f
+#define MVPP2_PRS_TCAM_ENTRY_INVALID	1
+#define MVPP2_PRS_TCAM_DSA_TAGGED_BIT	BIT(5)
+#define MVPP2_PRS_IPV4_HEAD		0x40
+#define MVPP2_PRS_IPV4_HEAD_MASK	0xf0
+#define MVPP2_PRS_IPV4_MC		0xe0
+#define MVPP2_PRS_IPV4_MC_MASK		0xf0
+#define MVPP2_PRS_IPV4_BC_MASK		0xff
+#define MVPP2_PRS_IPV4_IHL		0x5
+#define MVPP2_PRS_IPV4_IHL_MASK		0xf
+#define MVPP2_PRS_IPV6_MC		0xff
+#define MVPP2_PRS_IPV6_MC_MASK		0xff
+#define MVPP2_PRS_IPV6_HOP_MASK		0xff
+#define MVPP2_PRS_TCAM_PROTO_MASK	0xff
+#define MVPP2_PRS_TCAM_PROTO_MASK_L	0x3f
+#define MVPP2_PRS_DBL_VLANS_MAX		100
+
+/* Tcam structure:
+ * - lookup ID - 4 bits
+ * - port ID - 1 byte
+ * - additional information - 1 byte
+ * - header data - 8 bytes
+ * The fields are represented by MVPP2_PRS_TCAM_DATA_REG(5)->(0).
+ */
+#define MVPP2_PRS_AI_BITS			8
+#define MVPP2_PRS_PORT_MASK			0xff
+#define MVPP2_PRS_LU_MASK			0xf
+#define MVPP2_PRS_TCAM_DATA_BYTE(offs)		\
+				    (((offs) - ((offs) % 2)) * 2 + ((offs) % 2))
+#define MVPP2_PRS_TCAM_DATA_BYTE_EN(offs)	\
+					      (((offs) * 2) - ((offs) % 2)  + 2)
+#define MVPP2_PRS_TCAM_AI_BYTE			16
+#define MVPP2_PRS_TCAM_PORT_BYTE		17
+#define MVPP2_PRS_TCAM_LU_BYTE			20
+#define MVPP2_PRS_TCAM_EN_OFFS(offs)		((offs) + 2)
+#define MVPP2_PRS_TCAM_INV_WORD			5
+/* Tcam entries ID */
+#define MVPP2_PE_DROP_ALL		0
+#define MVPP2_PE_FIRST_FREE_TID		1
+#define MVPP2_PE_LAST_FREE_TID		(MVPP2_PRS_TCAM_SRAM_SIZE - 31)
+#define MVPP2_PE_IP6_EXT_PROTO_UN	(MVPP2_PRS_TCAM_SRAM_SIZE - 30)
+#define MVPP2_PE_MAC_MC_IP6		(MVPP2_PRS_TCAM_SRAM_SIZE - 29)
+#define MVPP2_PE_IP6_ADDR_UN		(MVPP2_PRS_TCAM_SRAM_SIZE - 28)
+#define MVPP2_PE_IP4_ADDR_UN		(MVPP2_PRS_TCAM_SRAM_SIZE - 27)
+#define MVPP2_PE_LAST_DEFAULT_FLOW	(MVPP2_PRS_TCAM_SRAM_SIZE - 26)
+#define MVPP2_PE_FIRST_DEFAULT_FLOW	(MVPP2_PRS_TCAM_SRAM_SIZE - 19)
+#define MVPP2_PE_EDSA_TAGGED		(MVPP2_PRS_TCAM_SRAM_SIZE - 18)
+#define MVPP2_PE_EDSA_UNTAGGED		(MVPP2_PRS_TCAM_SRAM_SIZE - 17)
+#define MVPP2_PE_DSA_TAGGED		(MVPP2_PRS_TCAM_SRAM_SIZE - 16)
+#define MVPP2_PE_DSA_UNTAGGED		(MVPP2_PRS_TCAM_SRAM_SIZE - 15)
+#define MVPP2_PE_ETYPE_EDSA_TAGGED	(MVPP2_PRS_TCAM_SRAM_SIZE - 14)
+#define MVPP2_PE_ETYPE_EDSA_UNTAGGED	(MVPP2_PRS_TCAM_SRAM_SIZE - 13)
+#define MVPP2_PE_ETYPE_DSA_TAGGED	(MVPP2_PRS_TCAM_SRAM_SIZE - 12)
+#define MVPP2_PE_ETYPE_DSA_UNTAGGED	(MVPP2_PRS_TCAM_SRAM_SIZE - 11)
+#define MVPP2_PE_MH_DEFAULT		(MVPP2_PRS_TCAM_SRAM_SIZE - 10)
+#define MVPP2_PE_DSA_DEFAULT		(MVPP2_PRS_TCAM_SRAM_SIZE - 9)
+#define MVPP2_PE_IP6_PROTO_UN		(MVPP2_PRS_TCAM_SRAM_SIZE - 8)
+#define MVPP2_PE_IP4_PROTO_UN		(MVPP2_PRS_TCAM_SRAM_SIZE - 7)
+#define MVPP2_PE_ETH_TYPE_UN		(MVPP2_PRS_TCAM_SRAM_SIZE - 6)
+#define MVPP2_PE_VLAN_DBL		(MVPP2_PRS_TCAM_SRAM_SIZE - 5)
+#define MVPP2_PE_VLAN_NONE		(MVPP2_PRS_TCAM_SRAM_SIZE - 4)
+#define MVPP2_PE_MAC_MC_ALL		(MVPP2_PRS_TCAM_SRAM_SIZE - 3)
+#define MVPP2_PE_MAC_PROMISCUOUS	(MVPP2_PRS_TCAM_SRAM_SIZE - 2)
+#define MVPP2_PE_MAC_NON_PROMISCUOUS	(MVPP2_PRS_TCAM_SRAM_SIZE - 1)
+
+/* Sram structure
+ * The fields are represented by MVPP2_PRS_TCAM_DATA_REG(3)->(0).
+ */
+#define MVPP2_PRS_SRAM_RI_OFFS			0
+#define MVPP2_PRS_SRAM_RI_WORD			0
+#define MVPP2_PRS_SRAM_RI_CTRL_OFFS		32
+#define MVPP2_PRS_SRAM_RI_CTRL_WORD		1
+#define MVPP2_PRS_SRAM_RI_CTRL_BITS		32
+#define MVPP2_PRS_SRAM_SHIFT_OFFS		64
+#define MVPP2_PRS_SRAM_SHIFT_SIGN_BIT		72
+#define MVPP2_PRS_SRAM_UDF_OFFS			73
+#define MVPP2_PRS_SRAM_UDF_BITS			8
+#define MVPP2_PRS_SRAM_UDF_MASK			0xff
+#define MVPP2_PRS_SRAM_UDF_SIGN_BIT		81
+#define MVPP2_PRS_SRAM_UDF_TYPE_OFFS		82
+#define MVPP2_PRS_SRAM_UDF_TYPE_MASK		0x7
+#define MVPP2_PRS_SRAM_UDF_TYPE_L3		1
+#define MVPP2_PRS_SRAM_UDF_TYPE_L4		4
+#define MVPP2_PRS_SRAM_OP_SEL_SHIFT_OFFS	85
+#define MVPP2_PRS_SRAM_OP_SEL_SHIFT_MASK	0x3
+#define MVPP2_PRS_SRAM_OP_SEL_SHIFT_ADD		1
+#define MVPP2_PRS_SRAM_OP_SEL_SHIFT_IP4_ADD	2
+#define MVPP2_PRS_SRAM_OP_SEL_SHIFT_IP6_ADD	3
+#define MVPP2_PRS_SRAM_OP_SEL_UDF_OFFS		87
+#define MVPP2_PRS_SRAM_OP_SEL_UDF_BITS		2
+#define MVPP2_PRS_SRAM_OP_SEL_UDF_MASK		0x3
+#define MVPP2_PRS_SRAM_OP_SEL_UDF_ADD		0
+#define MVPP2_PRS_SRAM_OP_SEL_UDF_IP4_ADD	2
+#define MVPP2_PRS_SRAM_OP_SEL_UDF_IP6_ADD	3
+#define MVPP2_PRS_SRAM_OP_SEL_BASE_OFFS		89
+#define MVPP2_PRS_SRAM_AI_OFFS			90
+#define MVPP2_PRS_SRAM_AI_CTRL_OFFS		98
+#define MVPP2_PRS_SRAM_AI_CTRL_BITS		8
+#define MVPP2_PRS_SRAM_AI_MASK			0xff
+#define MVPP2_PRS_SRAM_NEXT_LU_OFFS		106
+#define MVPP2_PRS_SRAM_NEXT_LU_MASK		0xf
+#define MVPP2_PRS_SRAM_LU_DONE_BIT		110
+#define MVPP2_PRS_SRAM_LU_GEN_BIT		111
+
+/* Sram result info bits assignment */
+#define MVPP2_PRS_RI_MAC_ME_MASK		0x1
+#define MVPP2_PRS_RI_DSA_MASK			0x2
+#define MVPP2_PRS_RI_VLAN_MASK			0xc
+#define MVPP2_PRS_RI_VLAN_NONE			~(BIT(2) | BIT(3))
+#define MVPP2_PRS_RI_VLAN_SINGLE		BIT(2)
+#define MVPP2_PRS_RI_VLAN_DOUBLE		BIT(3)
+#define MVPP2_PRS_RI_VLAN_TRIPLE		(BIT(2) | BIT(3))
+#define MVPP2_PRS_RI_CPU_CODE_MASK		0x70
+#define MVPP2_PRS_RI_CPU_CODE_RX_SPEC		BIT(4)
+#define MVPP2_PRS_RI_L2_CAST_MASK		0x600
+#define MVPP2_PRS_RI_L2_UCAST			~(BIT(9) | BIT(10))
+#define MVPP2_PRS_RI_L2_MCAST			BIT(9)
+#define MVPP2_PRS_RI_L2_BCAST			BIT(10)
+#define MVPP2_PRS_RI_PPPOE_MASK			0x800
+#define MVPP2_PRS_RI_L3_PROTO_MASK		0x7000
+#define MVPP2_PRS_RI_L3_UN			~(BIT(12) | BIT(13) | BIT(14))
+#define MVPP2_PRS_RI_L3_IP4			BIT(12)
+#define MVPP2_PRS_RI_L3_IP4_OPT			BIT(13)
+#define MVPP2_PRS_RI_L3_IP4_OTHER		(BIT(12) | BIT(13))
+#define MVPP2_PRS_RI_L3_IP6			BIT(14)
+#define MVPP2_PRS_RI_L3_IP6_EXT			(BIT(12) | BIT(14))
+#define MVPP2_PRS_RI_L3_ARP			(BIT(13) | BIT(14))
+#define MVPP2_PRS_RI_L3_ADDR_MASK		0x18000
+#define MVPP2_PRS_RI_L3_UCAST			~(BIT(15) | BIT(16))
+#define MVPP2_PRS_RI_L3_MCAST			BIT(15)
+#define MVPP2_PRS_RI_L3_BCAST			(BIT(15) | BIT(16))
+#define MVPP2_PRS_RI_IP_FRAG_MASK		0x20000
+#define MVPP2_PRS_RI_UDF3_MASK			0x300000
+#define MVPP2_PRS_RI_UDF3_RX_SPECIAL		BIT(21)
+#define MVPP2_PRS_RI_L4_PROTO_MASK		0x1c00000
+#define MVPP2_PRS_RI_L4_TCP			BIT(22)
+#define MVPP2_PRS_RI_L4_UDP			BIT(23)
+#define MVPP2_PRS_RI_L4_OTHER			(BIT(22) | BIT(23))
+#define MVPP2_PRS_RI_UDF7_MASK			0x60000000
+#define MVPP2_PRS_RI_UDF7_IP6_LITE		BIT(29)
+#define MVPP2_PRS_RI_DROP_MASK			0x80000000
+
+/* Sram additional info bits assignment */
+#define MVPP2_PRS_IPV4_DIP_AI_BIT		BIT(0)
+#define MVPP2_PRS_IPV6_NO_EXT_AI_BIT		BIT(0)
+#define MVPP2_PRS_IPV6_EXT_AI_BIT		BIT(1)
+#define MVPP2_PRS_IPV6_EXT_AH_AI_BIT		BIT(2)
+#define MVPP2_PRS_IPV6_EXT_AH_LEN_AI_BIT	BIT(3)
+#define MVPP2_PRS_IPV6_EXT_AH_L4_AI_BIT		BIT(4)
+#define MVPP2_PRS_SINGLE_VLAN_AI		0
+#define MVPP2_PRS_DBL_VLAN_AI_BIT		BIT(7)
+
+/* DSA/EDSA type */
+#define MVPP2_PRS_TAGGED		true
+#define MVPP2_PRS_UNTAGGED		false
+#define MVPP2_PRS_EDSA			true
+#define MVPP2_PRS_DSA			false
+
+/* MAC entries, shadow udf */
+enum mvpp2_prs_udf {
+	MVPP2_PRS_UDF_MAC_DEF,
+	MVPP2_PRS_UDF_MAC_RANGE,
+	MVPP2_PRS_UDF_L2_DEF,
+	MVPP2_PRS_UDF_L2_DEF_COPY,
+	MVPP2_PRS_UDF_L2_USER,
+};
+
+/* Lookup ID */
+enum mvpp2_prs_lookup {
+	MVPP2_PRS_LU_MH,
+	MVPP2_PRS_LU_MAC,
+	MVPP2_PRS_LU_DSA,
+	MVPP2_PRS_LU_VLAN,
+	MVPP2_PRS_LU_L2,
+	MVPP2_PRS_LU_PPPOE,
+	MVPP2_PRS_LU_IP4,
+	MVPP2_PRS_LU_IP6,
+	MVPP2_PRS_LU_FLOWS,
+	MVPP2_PRS_LU_LAST,
+};
+
+/* L3 cast enum */
+enum mvpp2_prs_l3_cast {
+	MVPP2_PRS_L3_UNI_CAST,
+	MVPP2_PRS_L3_MULTI_CAST,
+	MVPP2_PRS_L3_BROAD_CAST
+};
+
+/* Classifier constants */
+#define MVPP2_CLS_FLOWS_TBL_SIZE	512
+#define MVPP2_CLS_FLOWS_TBL_DATA_WORDS	3
+#define MVPP2_CLS_LKP_TBL_SIZE		64
+
+/* BM constants */
+#define MVPP2_BM_POOLS_NUM		1
+#define MVPP2_BM_LONG_BUF_NUM		16
+#define MVPP2_BM_SHORT_BUF_NUM		16
+#define MVPP2_BM_POOL_SIZE_MAX		(16*1024 - MVPP2_BM_POOL_PTR_ALIGN/4)
+#define MVPP2_BM_POOL_PTR_ALIGN		128
+#define MVPP2_BM_SWF_LONG_POOL(port)	0
+
+/* BM cookie (32 bits) definition */
+#define MVPP2_BM_COOKIE_POOL_OFFS	8
+#define MVPP2_BM_COOKIE_CPU_OFFS	24
+
+/* BM short pool packet size
+ * These value assure that for SWF the total number
+ * of bytes allocated for each buffer will be 512
+ */
+#define MVPP2_BM_SHORT_PKT_SIZE		MVPP2_RX_MAX_PKT_SIZE(512)
+
+enum mvpp2_bm_type {
+	MVPP2_BM_FREE,
+	MVPP2_BM_SWF_LONG,
+	MVPP2_BM_SWF_SHORT
+};
+
+/* Definitions */
+
+/* Shared Packet Processor resources */
+struct mvpp2 {
+	/* Shared registers' base addresses */
+	void __iomem *base;
+	void __iomem *lms_base;
+
+	/* List of pointers to port structures */
+	struct mvpp2_port **port_list;
+
+	/* Aggregated TXQs */
+	struct mvpp2_tx_queue *aggr_txqs;
+
+	/* BM pools */
+	struct mvpp2_bm_pool *bm_pools;
+
+	/* PRS shadow table */
+	struct mvpp2_prs_shadow *prs_shadow;
+	/* PRS auxiliary table for double vlan entries control */
+	bool *prs_double_vlans;
+
+	/* Tclk value */
+	u32 tclk;
+
+	struct mii_dev *bus;
+};
+
+struct mvpp2_pcpu_stats {
+	u64	rx_packets;
+	u64	rx_bytes;
+	u64	tx_packets;
+	u64	tx_bytes;
+};
+
+struct mvpp2_port {
+	u8 id;
+
+	int irq;
+
+	struct mvpp2 *priv;
+
+	/* Per-port registers' base address */
+	void __iomem *base;
+
+	struct mvpp2_rx_queue **rxqs;
+	struct mvpp2_tx_queue **txqs;
+
+	int pkt_size;
+
+	u32 pending_cause_rx;
+
+	/* Per-CPU port control */
+	struct mvpp2_port_pcpu __percpu *pcpu;
+
+	/* Flags */
+	unsigned long flags;
+
+	u16 tx_ring_size;
+	u16 rx_ring_size;
+	struct mvpp2_pcpu_stats __percpu *stats;
+
+	struct phy_device *phy_dev;
+	phy_interface_t phy_interface;
+	int phy_node;
+	int phyaddr;
+	int init;
+	unsigned int link;
+	unsigned int duplex;
+	unsigned int speed;
+
+	struct mvpp2_bm_pool *pool_long;
+	struct mvpp2_bm_pool *pool_short;
+
+	/* Index of first port's physical RXQ */
+	u8 first_rxq;
+
+	u8 dev_addr[ETH_ALEN];
+};
+
+/* The mvpp2_tx_desc and mvpp2_rx_desc structures describe the
+ * layout of the transmit and reception DMA descriptors, and their
+ * layout is therefore defined by the hardware design
+ */
+
+#define MVPP2_TXD_L3_OFF_SHIFT		0
+#define MVPP2_TXD_IP_HLEN_SHIFT		8
+#define MVPP2_TXD_L4_CSUM_FRAG		BIT(13)
+#define MVPP2_TXD_L4_CSUM_NOT		BIT(14)
+#define MVPP2_TXD_IP_CSUM_DISABLE	BIT(15)
+#define MVPP2_TXD_PADDING_DISABLE	BIT(23)
+#define MVPP2_TXD_L4_UDP		BIT(24)
+#define MVPP2_TXD_L3_IP6		BIT(26)
+#define MVPP2_TXD_L_DESC		BIT(28)
+#define MVPP2_TXD_F_DESC		BIT(29)
+
+#define MVPP2_RXD_ERR_SUMMARY		BIT(15)
+#define MVPP2_RXD_ERR_CODE_MASK		(BIT(13) | BIT(14))
+#define MVPP2_RXD_ERR_CRC		0x0
+#define MVPP2_RXD_ERR_OVERRUN		BIT(13)
+#define MVPP2_RXD_ERR_RESOURCE		(BIT(13) | BIT(14))
+#define MVPP2_RXD_BM_POOL_ID_OFFS	16
+#define MVPP2_RXD_BM_POOL_ID_MASK	(BIT(16) | BIT(17) | BIT(18))
+#define MVPP2_RXD_HWF_SYNC		BIT(21)
+#define MVPP2_RXD_L4_CSUM_OK		BIT(22)
+#define MVPP2_RXD_IP4_HEADER_ERR	BIT(24)
+#define MVPP2_RXD_L4_TCP		BIT(25)
+#define MVPP2_RXD_L4_UDP		BIT(26)
+#define MVPP2_RXD_L3_IP4		BIT(28)
+#define MVPP2_RXD_L3_IP6		BIT(30)
+#define MVPP2_RXD_BUF_HDR		BIT(31)
+
+struct mvpp2_tx_desc {
+	u32 command;		/* Options used by HW for packet transmitting.*/
+	u8  packet_offset;	/* the offset from the buffer beginning	*/
+	u8  phys_txq;		/* destination queue ID			*/
+	u16 data_size;		/* data size of transmitted packet in bytes */
+	u32 buf_phys_addr;	/* physical addr of transmitted buffer	*/
+	u32 buf_cookie;		/* cookie for access to TX buffer in tx path */
+	u32 reserved1[3];	/* hw_cmd (for future use, BM, PON, PNC) */
+	u32 reserved2;		/* reserved (for future use)		*/
+};
+
+struct mvpp2_rx_desc {
+	u32 status;		/* info about received packet		*/
+	u16 reserved1;		/* parser_info (for future use, PnC)	*/
+	u16 data_size;		/* size of received packet in bytes	*/
+	u32 buf_phys_addr;	/* physical address of the buffer	*/
+	u32 buf_cookie;		/* cookie for access to RX buffer in rx path */
+	u16 reserved2;		/* gem_port_id (for future use, PON)	*/
+	u16 reserved3;		/* csum_l4 (for future use, PnC)	*/
+	u8  reserved4;		/* bm_qset (for future use, BM)		*/
+	u8  reserved5;
+	u16 reserved6;		/* classify_info (for future use, PnC)	*/
+	u32 reserved7;		/* flow_id (for future use, PnC) */
+	u32 reserved8;
+};
+
+/* Per-CPU Tx queue control */
+struct mvpp2_txq_pcpu {
+	int cpu;
+
+	/* Number of Tx DMA descriptors in the descriptor ring */
+	int size;
+
+	/* Number of currently used Tx DMA descriptor in the
+	 * descriptor ring
+	 */
+	int count;
+
+	/* Number of Tx DMA descriptors reserved for each CPU */
+	int reserved_num;
+
+	/* Index of last TX DMA descriptor that was inserted */
+	int txq_put_index;
+
+	/* Index of the TX DMA descriptor to be cleaned up */
+	int txq_get_index;
+};
+
+struct mvpp2_tx_queue {
+	/* Physical number of this Tx queue */
+	u8 id;
+
+	/* Logical number of this Tx queue */
+	u8 log_id;
+
+	/* Number of Tx DMA descriptors in the descriptor ring */
+	int size;
+
+	/* Number of currently used Tx DMA descriptor in the descriptor ring */
+	int count;
+
+	/* Per-CPU control of physical Tx queues */
+	struct mvpp2_txq_pcpu __percpu *pcpu;
+
+	u32 done_pkts_coal;
+
+	/* Virtual address of thex Tx DMA descriptors array */
+	struct mvpp2_tx_desc *descs;
+
+	/* DMA address of the Tx DMA descriptors array */
+	dma_addr_t descs_phys;
+
+	/* Index of the last Tx DMA descriptor */
+	int last_desc;
+
+	/* Index of the next Tx DMA descriptor to process */
+	int next_desc_to_proc;
+};
+
+struct mvpp2_rx_queue {
+	/* RX queue number, in the range 0-31 for physical RXQs */
+	u8 id;
+
+	/* Num of rx descriptors in the rx descriptor ring */
+	int size;
+
+	u32 pkts_coal;
+	u32 time_coal;
+
+	/* Virtual address of the RX DMA descriptors array */
+	struct mvpp2_rx_desc *descs;
+
+	/* DMA address of the RX DMA descriptors array */
+	dma_addr_t descs_phys;
+
+	/* Index of the last RX DMA descriptor */
+	int last_desc;
+
+	/* Index of the next RX DMA descriptor to process */
+	int next_desc_to_proc;
+
+	/* ID of port to which physical RXQ is mapped */
+	int port;
+
+	/* Port's logic RXQ number to which physical RXQ is mapped */
+	int logic_rxq;
+};
+
+union mvpp2_prs_tcam_entry {
+	u32 word[MVPP2_PRS_TCAM_WORDS];
+	u8  byte[MVPP2_PRS_TCAM_WORDS * 4];
+};
+
+union mvpp2_prs_sram_entry {
+	u32 word[MVPP2_PRS_SRAM_WORDS];
+	u8  byte[MVPP2_PRS_SRAM_WORDS * 4];
+};
+
+struct mvpp2_prs_entry {
+	u32 index;
+	union mvpp2_prs_tcam_entry tcam;
+	union mvpp2_prs_sram_entry sram;
+};
+
+struct mvpp2_prs_shadow {
+	bool valid;
+	bool finish;
+
+	/* Lookup ID */
+	int lu;
+
+	/* User defined offset */
+	int udf;
+
+	/* Result info */
+	u32 ri;
+	u32 ri_mask;
+};
+
+struct mvpp2_cls_flow_entry {
+	u32 index;
+	u32 data[MVPP2_CLS_FLOWS_TBL_DATA_WORDS];
+};
+
+struct mvpp2_cls_lookup_entry {
+	u32 lkpid;
+	u32 way;
+	u32 data;
+};
+
+struct mvpp2_bm_pool {
+	/* Pool number in the range 0-7 */
+	int id;
+	enum mvpp2_bm_type type;
+
+	/* Buffer Pointers Pool External (BPPE) size */
+	int size;
+	/* Number of buffers for this pool */
+	int buf_num;
+	/* Pool buffer size */
+	int buf_size;
+	/* Packet size */
+	int pkt_size;
+
+	/* BPPE virtual base address */
+	u32 *virt_addr;
+	/* BPPE physical base address */
+	dma_addr_t phys_addr;
+
+	/* Ports using BM pool */
+	u32 port_map;
+
+	/* Occupied buffers indicator */
+	int in_use_thresh;
+};
+
+struct mvpp2_buff_hdr {
+	u32 next_buff_phys_addr;
+	u32 next_buff_virt_addr;
+	u16 byte_count;
+	u16 info;
+	u8  reserved1;		/* bm_qset (for future use, BM)		*/
+};
+
+/* Buffer header info bits */
+#define MVPP2_B_HDR_INFO_MC_ID_MASK	0xfff
+#define MVPP2_B_HDR_INFO_MC_ID(info)	((info) & MVPP2_B_HDR_INFO_MC_ID_MASK)
+#define MVPP2_B_HDR_INFO_LAST_OFFS	12
+#define MVPP2_B_HDR_INFO_LAST_MASK	BIT(12)
+#define MVPP2_B_HDR_INFO_IS_LAST(info) \
+	   ((info & MVPP2_B_HDR_INFO_LAST_MASK) >> MVPP2_B_HDR_INFO_LAST_OFFS)
+
+/* Static declaractions */
+
+/* Number of RXQs used by single port */
+static int rxq_number = MVPP2_DEFAULT_RXQ;
+/* Number of TXQs used by single port */
+static int txq_number = MVPP2_DEFAULT_TXQ;
+
+#define MVPP2_DRIVER_NAME "mvpp2"
+#define MVPP2_DRIVER_VERSION "1.0"
+
+/*
+ * U-Boot internal data, mostly uncached buffers for descriptors and data
+ */
+struct buffer_location {
+	struct mvpp2_tx_desc *aggr_tx_descs;
+	struct mvpp2_tx_desc *tx_descs;
+	struct mvpp2_rx_desc *rx_descs;
+	u32 *bm_pool[MVPP2_BM_POOLS_NUM];
+	u32 *rx_buffer[MVPP2_BM_LONG_BUF_NUM];
+	struct mvpp2 *priv;
+	int first_rxq;
+};
+
+/*
+ * All 4 interfaces use the same global buffer, since only one interface
+ * can be enabled at once
+ */
+static struct buffer_location buffer_loc;
+
+/*
+ * Page table entries are set to 1MB, or multiples of 1MB
+ * (not < 1MB). driver uses less bd's so use 1MB bdspace.
+ */
+#define BD_SPACE	(1 << 20)
+
+/* Utility/helper methods */
+
+static void mvpp2_write(struct mvpp2 *priv, u32 offset, u32 data)
+{
+	writel(data, priv->base + offset);
+}
+
+static u32 mvpp2_read(struct mvpp2 *priv, u32 offset)
+{
+	return readl(priv->base + offset);
+}
+
+static void mvpp2_txq_inc_get(struct mvpp2_txq_pcpu *txq_pcpu)
+{
+	txq_pcpu->txq_get_index++;
+	if (txq_pcpu->txq_get_index == txq_pcpu->size)
+		txq_pcpu->txq_get_index = 0;
+}
+
+/* Get number of physical egress port */
+static inline int mvpp2_egress_port(struct mvpp2_port *port)
+{
+	return MVPP2_MAX_TCONT + port->id;
+}
+
+/* Get number of physical TXQ */
+static inline int mvpp2_txq_phys(int port, int txq)
+{
+	return (MVPP2_MAX_TCONT + port) * MVPP2_MAX_TXQ + txq;
+}
+
+/* Parser configuration routines */
+
+/* Update parser tcam and sram hw entries */
+static int mvpp2_prs_hw_write(struct mvpp2 *priv, struct mvpp2_prs_entry *pe)
+{
+	int i;
+
+	if (pe->index > MVPP2_PRS_TCAM_SRAM_SIZE - 1)
+		return -EINVAL;
+
+	/* Clear entry invalidation bit */
+	pe->tcam.word[MVPP2_PRS_TCAM_INV_WORD] &= ~MVPP2_PRS_TCAM_INV_MASK;
+
+	/* Write tcam index - indirect access */
+	mvpp2_write(priv, MVPP2_PRS_TCAM_IDX_REG, pe->index);
+	for (i = 0; i < MVPP2_PRS_TCAM_WORDS; i++)
+		mvpp2_write(priv, MVPP2_PRS_TCAM_DATA_REG(i), pe->tcam.word[i]);
+
+	/* Write sram index - indirect access */
+	mvpp2_write(priv, MVPP2_PRS_SRAM_IDX_REG, pe->index);
+	for (i = 0; i < MVPP2_PRS_SRAM_WORDS; i++)
+		mvpp2_write(priv, MVPP2_PRS_SRAM_DATA_REG(i), pe->sram.word[i]);
+
+	return 0;
+}
+
+/* Read tcam entry from hw */
+static int mvpp2_prs_hw_read(struct mvpp2 *priv, struct mvpp2_prs_entry *pe)
+{
+	int i;
+
+	if (pe->index > MVPP2_PRS_TCAM_SRAM_SIZE - 1)
+		return -EINVAL;
+
+	/* Write tcam index - indirect access */
+	mvpp2_write(priv, MVPP2_PRS_TCAM_IDX_REG, pe->index);
+
+	pe->tcam.word[MVPP2_PRS_TCAM_INV_WORD] = mvpp2_read(priv,
+			      MVPP2_PRS_TCAM_DATA_REG(MVPP2_PRS_TCAM_INV_WORD));
+	if (pe->tcam.word[MVPP2_PRS_TCAM_INV_WORD] & MVPP2_PRS_TCAM_INV_MASK)
+		return MVPP2_PRS_TCAM_ENTRY_INVALID;
+
+	for (i = 0; i < MVPP2_PRS_TCAM_WORDS; i++)
+		pe->tcam.word[i] = mvpp2_read(priv, MVPP2_PRS_TCAM_DATA_REG(i));
+
+	/* Write sram index - indirect access */
+	mvpp2_write(priv, MVPP2_PRS_SRAM_IDX_REG, pe->index);
+	for (i = 0; i < MVPP2_PRS_SRAM_WORDS; i++)
+		pe->sram.word[i] = mvpp2_read(priv, MVPP2_PRS_SRAM_DATA_REG(i));
+
+	return 0;
+}
+
+/* Invalidate tcam hw entry */
+static void mvpp2_prs_hw_inv(struct mvpp2 *priv, int index)
+{
+	/* Write index - indirect access */
+	mvpp2_write(priv, MVPP2_PRS_TCAM_IDX_REG, index);
+	mvpp2_write(priv, MVPP2_PRS_TCAM_DATA_REG(MVPP2_PRS_TCAM_INV_WORD),
+		    MVPP2_PRS_TCAM_INV_MASK);
+}
+
+/* Enable shadow table entry and set its lookup ID */
+static void mvpp2_prs_shadow_set(struct mvpp2 *priv, int index, int lu)
+{
+	priv->prs_shadow[index].valid = true;
+	priv->prs_shadow[index].lu = lu;
+}
+
+/* Update ri fields in shadow table entry */
+static void mvpp2_prs_shadow_ri_set(struct mvpp2 *priv, int index,
+				    unsigned int ri, unsigned int ri_mask)
+{
+	priv->prs_shadow[index].ri_mask = ri_mask;
+	priv->prs_shadow[index].ri = ri;
+}
+
+/* Update lookup field in tcam sw entry */
+static void mvpp2_prs_tcam_lu_set(struct mvpp2_prs_entry *pe, unsigned int lu)
+{
+	int enable_off = MVPP2_PRS_TCAM_EN_OFFS(MVPP2_PRS_TCAM_LU_BYTE);
+
+	pe->tcam.byte[MVPP2_PRS_TCAM_LU_BYTE] = lu;
+	pe->tcam.byte[enable_off] = MVPP2_PRS_LU_MASK;
+}
+
+/* Update mask for single port in tcam sw entry */
+static void mvpp2_prs_tcam_port_set(struct mvpp2_prs_entry *pe,
+				    unsigned int port, bool add)
+{
+	int enable_off = MVPP2_PRS_TCAM_EN_OFFS(MVPP2_PRS_TCAM_PORT_BYTE);
+
+	if (add)
+		pe->tcam.byte[enable_off] &= ~(1 << port);
+	else
+		pe->tcam.byte[enable_off] |= 1 << port;
+}
+
+/* Update port map in tcam sw entry */
+static void mvpp2_prs_tcam_port_map_set(struct mvpp2_prs_entry *pe,
+					unsigned int ports)
+{
+	unsigned char port_mask = MVPP2_PRS_PORT_MASK;
+	int enable_off = MVPP2_PRS_TCAM_EN_OFFS(MVPP2_PRS_TCAM_PORT_BYTE);
+
+	pe->tcam.byte[MVPP2_PRS_TCAM_PORT_BYTE] = 0;
+	pe->tcam.byte[enable_off] &= ~port_mask;
+	pe->tcam.byte[enable_off] |= ~ports & MVPP2_PRS_PORT_MASK;
+}
+
+/* Obtain port map from tcam sw entry */
+static unsigned int mvpp2_prs_tcam_port_map_get(struct mvpp2_prs_entry *pe)
+{
+	int enable_off = MVPP2_PRS_TCAM_EN_OFFS(MVPP2_PRS_TCAM_PORT_BYTE);
+
+	return ~(pe->tcam.byte[enable_off]) & MVPP2_PRS_PORT_MASK;
+}
+
+/* Set byte of data and its enable bits in tcam sw entry */
+static void mvpp2_prs_tcam_data_byte_set(struct mvpp2_prs_entry *pe,
+					 unsigned int offs, unsigned char byte,
+					 unsigned char enable)
+{
+	pe->tcam.byte[MVPP2_PRS_TCAM_DATA_BYTE(offs)] = byte;
+	pe->tcam.byte[MVPP2_PRS_TCAM_DATA_BYTE_EN(offs)] = enable;
+}
+
+/* Get byte of data and its enable bits from tcam sw entry */
+static void mvpp2_prs_tcam_data_byte_get(struct mvpp2_prs_entry *pe,
+					 unsigned int offs, unsigned char *byte,
+					 unsigned char *enable)
+{
+	*byte = pe->tcam.byte[MVPP2_PRS_TCAM_DATA_BYTE(offs)];
+	*enable = pe->tcam.byte[MVPP2_PRS_TCAM_DATA_BYTE_EN(offs)];
+}
+
+/* Set ethertype in tcam sw entry */
+static void mvpp2_prs_match_etype(struct mvpp2_prs_entry *pe, int offset,
+				  unsigned short ethertype)
+{
+	mvpp2_prs_tcam_data_byte_set(pe, offset + 0, ethertype >> 8, 0xff);
+	mvpp2_prs_tcam_data_byte_set(pe, offset + 1, ethertype & 0xff, 0xff);
+}
+
+/* Set bits in sram sw entry */
+static void mvpp2_prs_sram_bits_set(struct mvpp2_prs_entry *pe, int bit_num,
+				    int val)
+{
+	pe->sram.byte[MVPP2_BIT_TO_BYTE(bit_num)] |= (val << (bit_num % 8));
+}
+
+/* Clear bits in sram sw entry */
+static void mvpp2_prs_sram_bits_clear(struct mvpp2_prs_entry *pe, int bit_num,
+				      int val)
+{
+	pe->sram.byte[MVPP2_BIT_TO_BYTE(bit_num)] &= ~(val << (bit_num % 8));
+}
+
+/* Update ri bits in sram sw entry */
+static void mvpp2_prs_sram_ri_update(struct mvpp2_prs_entry *pe,
+				     unsigned int bits, unsigned int mask)
+{
+	unsigned int i;
+
+	for (i = 0; i < MVPP2_PRS_SRAM_RI_CTRL_BITS; i++) {
+		int ri_off = MVPP2_PRS_SRAM_RI_OFFS;
+
+		if (!(mask & BIT(i)))
+			continue;
+
+		if (bits & BIT(i))
+			mvpp2_prs_sram_bits_set(pe, ri_off + i, 1);
+		else
+			mvpp2_prs_sram_bits_clear(pe, ri_off + i, 1);
+
+		mvpp2_prs_sram_bits_set(pe, MVPP2_PRS_SRAM_RI_CTRL_OFFS + i, 1);
+	}
+}
+
+/* Update ai bits in sram sw entry */
+static void mvpp2_prs_sram_ai_update(struct mvpp2_prs_entry *pe,
+				     unsigned int bits, unsigned int mask)
+{
+	unsigned int i;
+	int ai_off = MVPP2_PRS_SRAM_AI_OFFS;
+
+	for (i = 0; i < MVPP2_PRS_SRAM_AI_CTRL_BITS; i++) {
+
+		if (!(mask & BIT(i)))
+			continue;
+
+		if (bits & BIT(i))
+			mvpp2_prs_sram_bits_set(pe, ai_off + i, 1);
+		else
+			mvpp2_prs_sram_bits_clear(pe, ai_off + i, 1);
+
+		mvpp2_prs_sram_bits_set(pe, MVPP2_PRS_SRAM_AI_CTRL_OFFS + i, 1);
+	}
+}
+
+/* Read ai bits from sram sw entry */
+static int mvpp2_prs_sram_ai_get(struct mvpp2_prs_entry *pe)
+{
+	u8 bits;
+	int ai_off = MVPP2_BIT_TO_BYTE(MVPP2_PRS_SRAM_AI_OFFS);
+	int ai_en_off = ai_off + 1;
+	int ai_shift = MVPP2_PRS_SRAM_AI_OFFS % 8;
+
+	bits = (pe->sram.byte[ai_off] >> ai_shift) |
+	       (pe->sram.byte[ai_en_off] << (8 - ai_shift));
+
+	return bits;
+}
+
+/* In sram sw entry set lookup ID field of the tcam key to be used in the next
+ * lookup interation
+ */
+static void mvpp2_prs_sram_next_lu_set(struct mvpp2_prs_entry *pe,
+				       unsigned int lu)
+{
+	int sram_next_off = MVPP2_PRS_SRAM_NEXT_LU_OFFS;
+
+	mvpp2_prs_sram_bits_clear(pe, sram_next_off,
+				  MVPP2_PRS_SRAM_NEXT_LU_MASK);
+	mvpp2_prs_sram_bits_set(pe, sram_next_off, lu);
+}
+
+/* In the sram sw entry set sign and value of the next lookup offset
+ * and the offset value generated to the classifier
+ */
+static void mvpp2_prs_sram_shift_set(struct mvpp2_prs_entry *pe, int shift,
+				     unsigned int op)
+{
+	/* Set sign */
+	if (shift < 0) {
+		mvpp2_prs_sram_bits_set(pe, MVPP2_PRS_SRAM_SHIFT_SIGN_BIT, 1);
+		shift = 0 - shift;
+	} else {
+		mvpp2_prs_sram_bits_clear(pe, MVPP2_PRS_SRAM_SHIFT_SIGN_BIT, 1);
+	}
+
+	/* Set value */
+	pe->sram.byte[MVPP2_BIT_TO_BYTE(MVPP2_PRS_SRAM_SHIFT_OFFS)] =
+							   (unsigned char)shift;
+
+	/* Reset and set operation */
+	mvpp2_prs_sram_bits_clear(pe, MVPP2_PRS_SRAM_OP_SEL_SHIFT_OFFS,
+				  MVPP2_PRS_SRAM_OP_SEL_SHIFT_MASK);
+	mvpp2_prs_sram_bits_set(pe, MVPP2_PRS_SRAM_OP_SEL_SHIFT_OFFS, op);
+
+	/* Set base offset as current */
+	mvpp2_prs_sram_bits_clear(pe, MVPP2_PRS_SRAM_OP_SEL_BASE_OFFS, 1);
+}
+
+/* In the sram sw entry set sign and value of the user defined offset
+ * generated to the classifier
+ */
+static void mvpp2_prs_sram_offset_set(struct mvpp2_prs_entry *pe,
+				      unsigned int type, int offset,
+				      unsigned int op)
+{
+	/* Set sign */
+	if (offset < 0) {
+		mvpp2_prs_sram_bits_set(pe, MVPP2_PRS_SRAM_UDF_SIGN_BIT, 1);
+		offset = 0 - offset;
+	} else {
+		mvpp2_prs_sram_bits_clear(pe, MVPP2_PRS_SRAM_UDF_SIGN_BIT, 1);
+	}
+
+	/* Set value */
+	mvpp2_prs_sram_bits_clear(pe, MVPP2_PRS_SRAM_UDF_OFFS,
+				  MVPP2_PRS_SRAM_UDF_MASK);
+	mvpp2_prs_sram_bits_set(pe, MVPP2_PRS_SRAM_UDF_OFFS, offset);
+	pe->sram.byte[MVPP2_BIT_TO_BYTE(MVPP2_PRS_SRAM_UDF_OFFS +
+					MVPP2_PRS_SRAM_UDF_BITS)] &=
+	      ~(MVPP2_PRS_SRAM_UDF_MASK >> (8 - (MVPP2_PRS_SRAM_UDF_OFFS % 8)));
+	pe->sram.byte[MVPP2_BIT_TO_BYTE(MVPP2_PRS_SRAM_UDF_OFFS +
+					MVPP2_PRS_SRAM_UDF_BITS)] |=
+				(offset >> (8 - (MVPP2_PRS_SRAM_UDF_OFFS % 8)));
+
+	/* Set offset type */
+	mvpp2_prs_sram_bits_clear(pe, MVPP2_PRS_SRAM_UDF_TYPE_OFFS,
+				  MVPP2_PRS_SRAM_UDF_TYPE_MASK);
+	mvpp2_prs_sram_bits_set(pe, MVPP2_PRS_SRAM_UDF_TYPE_OFFS, type);
+
+	/* Set offset operation */
+	mvpp2_prs_sram_bits_clear(pe, MVPP2_PRS_SRAM_OP_SEL_UDF_OFFS,
+				  MVPP2_PRS_SRAM_OP_SEL_UDF_MASK);
+	mvpp2_prs_sram_bits_set(pe, MVPP2_PRS_SRAM_OP_SEL_UDF_OFFS, op);
+
+	pe->sram.byte[MVPP2_BIT_TO_BYTE(MVPP2_PRS_SRAM_OP_SEL_UDF_OFFS +
+					MVPP2_PRS_SRAM_OP_SEL_UDF_BITS)] &=
+					     ~(MVPP2_PRS_SRAM_OP_SEL_UDF_MASK >>
+				    (8 - (MVPP2_PRS_SRAM_OP_SEL_UDF_OFFS % 8)));
+
+	pe->sram.byte[MVPP2_BIT_TO_BYTE(MVPP2_PRS_SRAM_OP_SEL_UDF_OFFS +
+					MVPP2_PRS_SRAM_OP_SEL_UDF_BITS)] |=
+			     (op >> (8 - (MVPP2_PRS_SRAM_OP_SEL_UDF_OFFS % 8)));
+
+	/* Set base offset as current */
+	mvpp2_prs_sram_bits_clear(pe, MVPP2_PRS_SRAM_OP_SEL_BASE_OFFS, 1);
+}
+
+/* Find parser flow entry */
+static struct mvpp2_prs_entry *mvpp2_prs_flow_find(struct mvpp2 *priv, int flow)
+{
+	struct mvpp2_prs_entry *pe;
+	int tid;
+
+	pe = kzalloc(sizeof(*pe), GFP_KERNEL);
+	if (!pe)
+		return NULL;
+	mvpp2_prs_tcam_lu_set(pe, MVPP2_PRS_LU_FLOWS);
+
+	/* Go through the all entires with MVPP2_PRS_LU_FLOWS */
+	for (tid = MVPP2_PRS_TCAM_SRAM_SIZE - 1; tid >= 0; tid--) {
+		u8 bits;
+
+		if (!priv->prs_shadow[tid].valid ||
+		    priv->prs_shadow[tid].lu != MVPP2_PRS_LU_FLOWS)
+			continue;
+
+		pe->index = tid;
+		mvpp2_prs_hw_read(priv, pe);
+		bits = mvpp2_prs_sram_ai_get(pe);
+
+		/* Sram store classification lookup ID in AI bits [5:0] */
+		if ((bits & MVPP2_PRS_FLOW_ID_MASK) == flow)
+			return pe;
+	}
+	kfree(pe);
+
+	return NULL;
+}
+
+/* Return first free tcam index, seeking from start to end */
+static int mvpp2_prs_tcam_first_free(struct mvpp2 *priv, unsigned char start,
+				     unsigned char end)
+{
+	int tid;
+
+	if (start > end)
+		swap(start, end);
+
+	if (end >= MVPP2_PRS_TCAM_SRAM_SIZE)
+		end = MVPP2_PRS_TCAM_SRAM_SIZE - 1;
+
+	for (tid = start; tid <= end; tid++) {
+		if (!priv->prs_shadow[tid].valid)
+			return tid;
+	}
+
+	return -EINVAL;
+}
+
+/* Enable/disable dropping all mac da's */
+static void mvpp2_prs_mac_drop_all_set(struct mvpp2 *priv, int port, bool add)
+{
+	struct mvpp2_prs_entry pe;
+
+	if (priv->prs_shadow[MVPP2_PE_DROP_ALL].valid) {
+		/* Entry exist - update port only */
+		pe.index = MVPP2_PE_DROP_ALL;
+		mvpp2_prs_hw_read(priv, &pe);
+	} else {
+		/* Entry doesn't exist - create new */
+		memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+		mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_MAC);
+		pe.index = MVPP2_PE_DROP_ALL;
+
+		/* Non-promiscuous mode for all ports - DROP unknown packets */
+		mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_DROP_MASK,
+					 MVPP2_PRS_RI_DROP_MASK);
+
+		mvpp2_prs_sram_bits_set(&pe, MVPP2_PRS_SRAM_LU_GEN_BIT, 1);
+		mvpp2_prs_sram_next_lu_set(&pe, MVPP2_PRS_LU_FLOWS);
+
+		/* Update shadow table */
+		mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_MAC);
+
+		/* Mask all ports */
+		mvpp2_prs_tcam_port_map_set(&pe, 0);
+	}
+
+	/* Update port mask */
+	mvpp2_prs_tcam_port_set(&pe, port, add);
+
+	mvpp2_prs_hw_write(priv, &pe);
+}
+
+/* Set port to promiscuous mode */
+static void mvpp2_prs_mac_promisc_set(struct mvpp2 *priv, int port, bool add)
+{
+	struct mvpp2_prs_entry pe;
+
+	/* Promiscuous mode - Accept unknown packets */
+
+	if (priv->prs_shadow[MVPP2_PE_MAC_PROMISCUOUS].valid) {
+		/* Entry exist - update port only */
+		pe.index = MVPP2_PE_MAC_PROMISCUOUS;
+		mvpp2_prs_hw_read(priv, &pe);
+	} else {
+		/* Entry doesn't exist - create new */
+		memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+		mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_MAC);
+		pe.index = MVPP2_PE_MAC_PROMISCUOUS;
+
+		/* Continue - set next lookup */
+		mvpp2_prs_sram_next_lu_set(&pe, MVPP2_PRS_LU_DSA);
+
+		/* Set result info bits */
+		mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L2_UCAST,
+					 MVPP2_PRS_RI_L2_CAST_MASK);
+
+		/* Shift to ethertype */
+		mvpp2_prs_sram_shift_set(&pe, 2 * ETH_ALEN,
+					 MVPP2_PRS_SRAM_OP_SEL_SHIFT_ADD);
+
+		/* Mask all ports */
+		mvpp2_prs_tcam_port_map_set(&pe, 0);
+
+		/* Update shadow table */
+		mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_MAC);
+	}
+
+	/* Update port mask */
+	mvpp2_prs_tcam_port_set(&pe, port, add);
+
+	mvpp2_prs_hw_write(priv, &pe);
+}
+
+/* Accept multicast */
+static void mvpp2_prs_mac_multi_set(struct mvpp2 *priv, int port, int index,
+				    bool add)
+{
+	struct mvpp2_prs_entry pe;
+	unsigned char da_mc;
+
+	/* Ethernet multicast address first byte is
+	 * 0x01 for IPv4 and 0x33 for IPv6
+	 */
+	da_mc = (index == MVPP2_PE_MAC_MC_ALL) ? 0x01 : 0x33;
+
+	if (priv->prs_shadow[index].valid) {
+		/* Entry exist - update port only */
+		pe.index = index;
+		mvpp2_prs_hw_read(priv, &pe);
+	} else {
+		/* Entry doesn't exist - create new */
+		memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+		mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_MAC);
+		pe.index = index;
+
+		/* Continue - set next lookup */
+		mvpp2_prs_sram_next_lu_set(&pe, MVPP2_PRS_LU_DSA);
+
+		/* Set result info bits */
+		mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L2_MCAST,
+					 MVPP2_PRS_RI_L2_CAST_MASK);
+
+		/* Update tcam entry data first byte */
+		mvpp2_prs_tcam_data_byte_set(&pe, 0, da_mc, 0xff);
+
+		/* Shift to ethertype */
+		mvpp2_prs_sram_shift_set(&pe, 2 * ETH_ALEN,
+					 MVPP2_PRS_SRAM_OP_SEL_SHIFT_ADD);
+
+		/* Mask all ports */
+		mvpp2_prs_tcam_port_map_set(&pe, 0);
+
+		/* Update shadow table */
+		mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_MAC);
+	}
+
+	/* Update port mask */
+	mvpp2_prs_tcam_port_set(&pe, port, add);
+
+	mvpp2_prs_hw_write(priv, &pe);
+}
+
+/* Parser per-port initialization */
+static void mvpp2_prs_hw_port_init(struct mvpp2 *priv, int port, int lu_first,
+				   int lu_max, int offset)
+{
+	u32 val;
+
+	/* Set lookup ID */
+	val = mvpp2_read(priv, MVPP2_PRS_INIT_LOOKUP_REG);
+	val &= ~MVPP2_PRS_PORT_LU_MASK(port);
+	val |=  MVPP2_PRS_PORT_LU_VAL(port, lu_first);
+	mvpp2_write(priv, MVPP2_PRS_INIT_LOOKUP_REG, val);
+
+	/* Set maximum number of loops for packet received from port */
+	val = mvpp2_read(priv, MVPP2_PRS_MAX_LOOP_REG(port));
+	val &= ~MVPP2_PRS_MAX_LOOP_MASK(port);
+	val |= MVPP2_PRS_MAX_LOOP_VAL(port, lu_max);
+	mvpp2_write(priv, MVPP2_PRS_MAX_LOOP_REG(port), val);
+
+	/* Set initial offset for packet header extraction for the first
+	 * searching loop
+	 */
+	val = mvpp2_read(priv, MVPP2_PRS_INIT_OFFS_REG(port));
+	val &= ~MVPP2_PRS_INIT_OFF_MASK(port);
+	val |= MVPP2_PRS_INIT_OFF_VAL(port, offset);
+	mvpp2_write(priv, MVPP2_PRS_INIT_OFFS_REG(port), val);
+}
+
+/* Default flow entries initialization for all ports */
+static void mvpp2_prs_def_flow_init(struct mvpp2 *priv)
+{
+	struct mvpp2_prs_entry pe;
+	int port;
+
+	for (port = 0; port < MVPP2_MAX_PORTS; port++) {
+		memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+		mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_FLOWS);
+		pe.index = MVPP2_PE_FIRST_DEFAULT_FLOW - port;
+
+		/* Mask all ports */
+		mvpp2_prs_tcam_port_map_set(&pe, 0);
+
+		/* Set flow ID*/
+		mvpp2_prs_sram_ai_update(&pe, port, MVPP2_PRS_FLOW_ID_MASK);
+		mvpp2_prs_sram_bits_set(&pe, MVPP2_PRS_SRAM_LU_DONE_BIT, 1);
+
+		/* Update shadow table and hw entry */
+		mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_FLOWS);
+		mvpp2_prs_hw_write(priv, &pe);
+	}
+}
+
+/* Set default entry for Marvell Header field */
+static void mvpp2_prs_mh_init(struct mvpp2 *priv)
+{
+	struct mvpp2_prs_entry pe;
+
+	memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+
+	pe.index = MVPP2_PE_MH_DEFAULT;
+	mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_MH);
+	mvpp2_prs_sram_shift_set(&pe, MVPP2_MH_SIZE,
+				 MVPP2_PRS_SRAM_OP_SEL_SHIFT_ADD);
+	mvpp2_prs_sram_next_lu_set(&pe, MVPP2_PRS_LU_MAC);
+
+	/* Unmask all ports */
+	mvpp2_prs_tcam_port_map_set(&pe, MVPP2_PRS_PORT_MASK);
+
+	/* Update shadow table and hw entry */
+	mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_MH);
+	mvpp2_prs_hw_write(priv, &pe);
+}
+
+/* Set default entires (place holder) for promiscuous, non-promiscuous and
+ * multicast MAC addresses
+ */
+static void mvpp2_prs_mac_init(struct mvpp2 *priv)
+{
+	struct mvpp2_prs_entry pe;
+
+	memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+
+	/* Non-promiscuous mode for all ports - DROP unknown packets */
+	pe.index = MVPP2_PE_MAC_NON_PROMISCUOUS;
+	mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_MAC);
+
+	mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_DROP_MASK,
+				 MVPP2_PRS_RI_DROP_MASK);
+	mvpp2_prs_sram_bits_set(&pe, MVPP2_PRS_SRAM_LU_GEN_BIT, 1);
+	mvpp2_prs_sram_next_lu_set(&pe, MVPP2_PRS_LU_FLOWS);
+
+	/* Unmask all ports */
+	mvpp2_prs_tcam_port_map_set(&pe, MVPP2_PRS_PORT_MASK);
+
+	/* Update shadow table and hw entry */
+	mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_MAC);
+	mvpp2_prs_hw_write(priv, &pe);
+
+	/* place holders only - no ports */
+	mvpp2_prs_mac_drop_all_set(priv, 0, false);
+	mvpp2_prs_mac_promisc_set(priv, 0, false);
+	mvpp2_prs_mac_multi_set(priv, MVPP2_PE_MAC_MC_ALL, 0, false);
+	mvpp2_prs_mac_multi_set(priv, MVPP2_PE_MAC_MC_IP6, 0, false);
+}
+
+/* Match basic ethertypes */
+static int mvpp2_prs_etype_init(struct mvpp2 *priv)
+{
+	struct mvpp2_prs_entry pe;
+	int tid;
+
+	/* Ethertype: PPPoE */
+	tid = mvpp2_prs_tcam_first_free(priv, MVPP2_PE_FIRST_FREE_TID,
+					MVPP2_PE_LAST_FREE_TID);
+	if (tid < 0)
+		return tid;
+
+	memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+	mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_L2);
+	pe.index = tid;
+
+	mvpp2_prs_match_etype(&pe, 0, ETH_P_PPP_SES);
+
+	mvpp2_prs_sram_shift_set(&pe, MVPP2_PPPOE_HDR_SIZE,
+				 MVPP2_PRS_SRAM_OP_SEL_SHIFT_ADD);
+	mvpp2_prs_sram_next_lu_set(&pe, MVPP2_PRS_LU_PPPOE);
+	mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_PPPOE_MASK,
+				 MVPP2_PRS_RI_PPPOE_MASK);
+
+	/* Update shadow table and hw entry */
+	mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_L2);
+	priv->prs_shadow[pe.index].udf = MVPP2_PRS_UDF_L2_DEF;
+	priv->prs_shadow[pe.index].finish = false;
+	mvpp2_prs_shadow_ri_set(priv, pe.index, MVPP2_PRS_RI_PPPOE_MASK,
+				MVPP2_PRS_RI_PPPOE_MASK);
+	mvpp2_prs_hw_write(priv, &pe);
+
+	/* Ethertype: ARP */
+	tid = mvpp2_prs_tcam_first_free(priv, MVPP2_PE_FIRST_FREE_TID,
+					MVPP2_PE_LAST_FREE_TID);
+	if (tid < 0)
+		return tid;
+
+	memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+	mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_L2);
+	pe.index = tid;
+
+	mvpp2_prs_match_etype(&pe, 0, ETH_P_ARP);
+
+	/* Generate flow in the next iteration*/
+	mvpp2_prs_sram_next_lu_set(&pe, MVPP2_PRS_LU_FLOWS);
+	mvpp2_prs_sram_bits_set(&pe, MVPP2_PRS_SRAM_LU_GEN_BIT, 1);
+	mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L3_ARP,
+				 MVPP2_PRS_RI_L3_PROTO_MASK);
+	/* Set L3 offset */
+	mvpp2_prs_sram_offset_set(&pe, MVPP2_PRS_SRAM_UDF_TYPE_L3,
+				  MVPP2_ETH_TYPE_LEN,
+				  MVPP2_PRS_SRAM_OP_SEL_UDF_ADD);
+
+	/* Update shadow table and hw entry */
+	mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_L2);
+	priv->prs_shadow[pe.index].udf = MVPP2_PRS_UDF_L2_DEF;
+	priv->prs_shadow[pe.index].finish = true;
+	mvpp2_prs_shadow_ri_set(priv, pe.index, MVPP2_PRS_RI_L3_ARP,
+				MVPP2_PRS_RI_L3_PROTO_MASK);
+	mvpp2_prs_hw_write(priv, &pe);
+
+	/* Ethertype: LBTD */
+	tid = mvpp2_prs_tcam_first_free(priv, MVPP2_PE_FIRST_FREE_TID,
+					MVPP2_PE_LAST_FREE_TID);
+	if (tid < 0)
+		return tid;
+
+	memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+	mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_L2);
+	pe.index = tid;
+
+	mvpp2_prs_match_etype(&pe, 0, MVPP2_IP_LBDT_TYPE);
+
+	/* Generate flow in the next iteration*/
+	mvpp2_prs_sram_next_lu_set(&pe, MVPP2_PRS_LU_FLOWS);
+	mvpp2_prs_sram_bits_set(&pe, MVPP2_PRS_SRAM_LU_GEN_BIT, 1);
+	mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_CPU_CODE_RX_SPEC |
+				 MVPP2_PRS_RI_UDF3_RX_SPECIAL,
+				 MVPP2_PRS_RI_CPU_CODE_MASK |
+				 MVPP2_PRS_RI_UDF3_MASK);
+	/* Set L3 offset */
+	mvpp2_prs_sram_offset_set(&pe, MVPP2_PRS_SRAM_UDF_TYPE_L3,
+				  MVPP2_ETH_TYPE_LEN,
+				  MVPP2_PRS_SRAM_OP_SEL_UDF_ADD);
+
+	/* Update shadow table and hw entry */
+	mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_L2);
+	priv->prs_shadow[pe.index].udf = MVPP2_PRS_UDF_L2_DEF;
+	priv->prs_shadow[pe.index].finish = true;
+	mvpp2_prs_shadow_ri_set(priv, pe.index, MVPP2_PRS_RI_CPU_CODE_RX_SPEC |
+				MVPP2_PRS_RI_UDF3_RX_SPECIAL,
+				MVPP2_PRS_RI_CPU_CODE_MASK |
+				MVPP2_PRS_RI_UDF3_MASK);
+	mvpp2_prs_hw_write(priv, &pe);
+
+	/* Ethertype: IPv4 without options */
+	tid = mvpp2_prs_tcam_first_free(priv, MVPP2_PE_FIRST_FREE_TID,
+					MVPP2_PE_LAST_FREE_TID);
+	if (tid < 0)
+		return tid;
+
+	memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+	mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_L2);
+	pe.index = tid;
+
+	mvpp2_prs_match_etype(&pe, 0, ETH_P_IP);
+	mvpp2_prs_tcam_data_byte_set(&pe, MVPP2_ETH_TYPE_LEN,
+				     MVPP2_PRS_IPV4_HEAD | MVPP2_PRS_IPV4_IHL,
+				     MVPP2_PRS_IPV4_HEAD_MASK |
+				     MVPP2_PRS_IPV4_IHL_MASK);
+
+	mvpp2_prs_sram_next_lu_set(&pe, MVPP2_PRS_LU_IP4);
+	mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L3_IP4,
+				 MVPP2_PRS_RI_L3_PROTO_MASK);
+	/* Skip eth_type + 4 bytes of IP header */
+	mvpp2_prs_sram_shift_set(&pe, MVPP2_ETH_TYPE_LEN + 4,
+				 MVPP2_PRS_SRAM_OP_SEL_SHIFT_ADD);
+	/* Set L3 offset */
+	mvpp2_prs_sram_offset_set(&pe, MVPP2_PRS_SRAM_UDF_TYPE_L3,
+				  MVPP2_ETH_TYPE_LEN,
+				  MVPP2_PRS_SRAM_OP_SEL_UDF_ADD);
+
+	/* Update shadow table and hw entry */
+	mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_L2);
+	priv->prs_shadow[pe.index].udf = MVPP2_PRS_UDF_L2_DEF;
+	priv->prs_shadow[pe.index].finish = false;
+	mvpp2_prs_shadow_ri_set(priv, pe.index, MVPP2_PRS_RI_L3_IP4,
+				MVPP2_PRS_RI_L3_PROTO_MASK);
+	mvpp2_prs_hw_write(priv, &pe);
+
+	/* Ethertype: IPv4 with options */
+	tid = mvpp2_prs_tcam_first_free(priv, MVPP2_PE_FIRST_FREE_TID,
+					MVPP2_PE_LAST_FREE_TID);
+	if (tid < 0)
+		return tid;
+
+	pe.index = tid;
+
+	/* Clear tcam data before updating */
+	pe.tcam.byte[MVPP2_PRS_TCAM_DATA_BYTE(MVPP2_ETH_TYPE_LEN)] = 0x0;
+	pe.tcam.byte[MVPP2_PRS_TCAM_DATA_BYTE_EN(MVPP2_ETH_TYPE_LEN)] = 0x0;
+
+	mvpp2_prs_tcam_data_byte_set(&pe, MVPP2_ETH_TYPE_LEN,
+				     MVPP2_PRS_IPV4_HEAD,
+				     MVPP2_PRS_IPV4_HEAD_MASK);
+
+	/* Clear ri before updating */
+	pe.sram.word[MVPP2_PRS_SRAM_RI_WORD] = 0x0;
+	pe.sram.word[MVPP2_PRS_SRAM_RI_CTRL_WORD] = 0x0;
+	mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L3_IP4_OPT,
+				 MVPP2_PRS_RI_L3_PROTO_MASK);
+
+	/* Update shadow table and hw entry */
+	mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_L2);
+	priv->prs_shadow[pe.index].udf = MVPP2_PRS_UDF_L2_DEF;
+	priv->prs_shadow[pe.index].finish = false;
+	mvpp2_prs_shadow_ri_set(priv, pe.index, MVPP2_PRS_RI_L3_IP4_OPT,
+				MVPP2_PRS_RI_L3_PROTO_MASK);
+	mvpp2_prs_hw_write(priv, &pe);
+
+	/* Ethertype: IPv6 without options */
+	tid = mvpp2_prs_tcam_first_free(priv, MVPP2_PE_FIRST_FREE_TID,
+					MVPP2_PE_LAST_FREE_TID);
+	if (tid < 0)
+		return tid;
+
+	memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+	mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_L2);
+	pe.index = tid;
+
+	mvpp2_prs_match_etype(&pe, 0, ETH_P_IPV6);
+
+	/* Skip DIP of IPV6 header */
+	mvpp2_prs_sram_shift_set(&pe, MVPP2_ETH_TYPE_LEN + 8 +
+				 MVPP2_MAX_L3_ADDR_SIZE,
+				 MVPP2_PRS_SRAM_OP_SEL_SHIFT_ADD);
+	mvpp2_prs_sram_next_lu_set(&pe, MVPP2_PRS_LU_IP6);
+	mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L3_IP6,
+				 MVPP2_PRS_RI_L3_PROTO_MASK);
+	/* Set L3 offset */
+	mvpp2_prs_sram_offset_set(&pe, MVPP2_PRS_SRAM_UDF_TYPE_L3,
+				  MVPP2_ETH_TYPE_LEN,
+				  MVPP2_PRS_SRAM_OP_SEL_UDF_ADD);
+
+	mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_L2);
+	priv->prs_shadow[pe.index].udf = MVPP2_PRS_UDF_L2_DEF;
+	priv->prs_shadow[pe.index].finish = false;
+	mvpp2_prs_shadow_ri_set(priv, pe.index, MVPP2_PRS_RI_L3_IP6,
+				MVPP2_PRS_RI_L3_PROTO_MASK);
+	mvpp2_prs_hw_write(priv, &pe);
+
+	/* Default entry for MVPP2_PRS_LU_L2 - Unknown ethtype */
+	memset(&pe, 0, sizeof(struct mvpp2_prs_entry));
+	mvpp2_prs_tcam_lu_set(&pe, MVPP2_PRS_LU_L2);
+	pe.index = MVPP2_PE_ETH_TYPE_UN;
+
+	/* Unmask all ports */
+	mvpp2_prs_tcam_port_map_set(&pe, MVPP2_PRS_PORT_MASK);
+
+	/* Generate flow in the next iteration*/
+	mvpp2_prs_sram_bits_set(&pe, MVPP2_PRS_SRAM_LU_GEN_BIT, 1);
+	mvpp2_prs_sram_next_lu_set(&pe, MVPP2_PRS_LU_FLOWS);
+	mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L3_UN,
+				 MVPP2_PRS_RI_L3_PROTO_MASK);
+	/* Set L3 offset even it's unknown L3 */
+	mvpp2_prs_sram_offset_set(&pe, MVPP2_PRS_SRAM_UDF_TYPE_L3,
+				  MVPP2_ETH_TYPE_LEN,
+				  MVPP2_PRS_SRAM_OP_SEL_UDF_ADD);
+
+	/* Update shadow table and hw entry */
+	mvpp2_prs_shadow_set(priv, pe.index, MVPP2_PRS_LU_L2);
+	priv->prs_shadow[pe.index].udf = MVPP2_PRS_UDF_L2_DEF;
+	priv->prs_shadow[pe.index].finish = true;
+	mvpp2_prs_shadow_ri_set(priv, pe.index, MVPP2_PRS_RI_L3_UN,
+				MVPP2_PRS_RI_L3_PROTO_MASK);
+	mvpp2_prs_hw_write(priv, &pe);
+
+	return 0;
+}
+
+/* Parser default initialization */
+static int mvpp2_prs_default_init(struct udevice *dev,
+				  struct mvpp2 *priv)
+{
+	int err, index, i;
+
+	/* Enable tcam table */
+	mvpp2_write(priv, MVPP2_PRS_TCAM_CTRL_REG, MVPP2_PRS_TCAM_EN_MASK);
+
+	/* Clear all tcam and sram entries */
+	for (index = 0; index < MVPP2_PRS_TCAM_SRAM_SIZE; index++) {
+		mvpp2_write(priv, MVPP2_PRS_TCAM_IDX_REG, index);
+		for (i = 0; i < MVPP2_PRS_TCAM_WORDS; i++)
+			mvpp2_write(priv, MVPP2_PRS_TCAM_DATA_REG(i), 0);
+
+		mvpp2_write(priv, MVPP2_PRS_SRAM_IDX_REG, index);
+		for (i = 0; i < MVPP2_PRS_SRAM_WORDS; i++)
+			mvpp2_write(priv, MVPP2_PRS_SRAM_DATA_REG(i), 0);
+	}
+
+	/* Invalidate all tcam entries */
+	for (index = 0; index < MVPP2_PRS_TCAM_SRAM_SIZE; index++)
+		mvpp2_prs_hw_inv(priv, index);
+
+	priv->prs_shadow = devm_kcalloc(dev, MVPP2_PRS_TCAM_SRAM_SIZE,
+					sizeof(struct mvpp2_prs_shadow),
+					GFP_KERNEL);
+	if (!priv->prs_shadow)
+		return -ENOMEM;
+
+	/* Always start from lookup = 0 */
+	for (index = 0; index < MVPP2_MAX_PORTS; index++)
+		mvpp2_prs_hw_port_init(priv, index, MVPP2_PRS_LU_MH,
+				       MVPP2_PRS_PORT_LU_MAX, 0);
+
+	mvpp2_prs_def_flow_init(priv);
+
+	mvpp2_prs_mh_init(priv);
+
+	mvpp2_prs_mac_init(priv);
+
+	err = mvpp2_prs_etype_init(priv);
+	if (err)
+		return err;
+
+	return 0;
+}
+
+/* Compare MAC DA with tcam entry data */
+static bool mvpp2_prs_mac_range_equals(struct mvpp2_prs_entry *pe,
+				       const u8 *da, unsigned char *mask)
+{
+	unsigned char tcam_byte, tcam_mask;
+	int index;
+
+	for (index = 0; index < ETH_ALEN; index++) {
+		mvpp2_prs_tcam_data_byte_get(pe, index, &tcam_byte, &tcam_mask);
+		if (tcam_mask != mask[index])
+			return false;
+
+		if ((tcam_mask & tcam_byte) != (da[index] & mask[index]))
+			return false;
+	}
+
+	return true;
+}
+
+/* Find tcam entry with matched pair <MAC DA, port> */
+static struct mvpp2_prs_entry *
+mvpp2_prs_mac_da_range_find(struct mvpp2 *priv, int pmap, const u8 *da,
+			    unsigned char *mask, int udf_type)
+{
+	struct mvpp2_prs_entry *pe;
+	int tid;
+
+	pe = kzalloc(sizeof(*pe), GFP_KERNEL);
+	if (!pe)
+		return NULL;
+	mvpp2_prs_tcam_lu_set(pe, MVPP2_PRS_LU_MAC);
+
+	/* Go through the all entires with MVPP2_PRS_LU_MAC */
+	for (tid = MVPP2_PE_FIRST_FREE_TID;
+	     tid <= MVPP2_PE_LAST_FREE_TID; tid++) {
+		unsigned int entry_pmap;
+
+		if (!priv->prs_shadow[tid].valid ||
+		    (priv->prs_shadow[tid].lu != MVPP2_PRS_LU_MAC) ||
+		    (priv->prs_shadow[tid].udf != udf_type))
+			continue;
+
+		pe->index = tid;
+		mvpp2_prs_hw_read(priv, pe);
+		entry_pmap = mvpp2_prs_tcam_port_map_get(pe);
+
+		if (mvpp2_prs_mac_range_equals(pe, da, mask) &&
+		    entry_pmap == pmap)
+			return pe;
+	}
+	kfree(pe);
+
+	return NULL;
+}
+
+/* Update parser's mac da entry */
+static int mvpp2_prs_mac_da_accept(struct mvpp2 *priv, int port,
+				   const u8 *da, bool add)
+{
+	struct mvpp2_prs_entry *pe;
+	unsigned int pmap, len, ri;
+	unsigned char mask[ETH_ALEN] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
+	int tid;
+
+	/* Scan TCAM and see if entry with this <MAC DA, port> already exist */
+	pe = mvpp2_prs_mac_da_range_find(priv, (1 << port), da, mask,
+					 MVPP2_PRS_UDF_MAC_DEF);
+
+	/* No such entry */
+	if (!pe) {
+		if (!add)
+			return 0;
+
+		/* Create new TCAM entry */
+		/* Find first range mac entry*/
+		for (tid = MVPP2_PE_FIRST_FREE_TID;
+		     tid <= MVPP2_PE_LAST_FREE_TID; tid++)
+			if (priv->prs_shadow[tid].valid &&
+			    (priv->prs_shadow[tid].lu == MVPP2_PRS_LU_MAC) &&
+			    (priv->prs_shadow[tid].udf ==
+						       MVPP2_PRS_UDF_MAC_RANGE))
+				break;
+
+		/* Go through the all entries from first to last */
+		tid = mvpp2_prs_tcam_first_free(priv, MVPP2_PE_FIRST_FREE_TID,
+						tid - 1);
+		if (tid < 0)
+			return tid;
+
+		pe = kzalloc(sizeof(*pe), GFP_KERNEL);
+		if (!pe)
+			return -1;
+		mvpp2_prs_tcam_lu_set(pe, MVPP2_PRS_LU_MAC);
+		pe->index = tid;
+
+		/* Mask all ports */
+		mvpp2_prs_tcam_port_map_set(pe, 0);
+	}
+
+	/* Update port mask */
+	mvpp2_prs_tcam_port_set(pe, port, add);
+
+	/* Invalidate the entry if no ports are left enabled */
+	pmap = mvpp2_prs_tcam_port_map_get(pe);
+	if (pmap == 0) {
+		if (add) {
+			kfree(pe);
+			return -1;
+		}
+		mvpp2_prs_hw_inv(priv, pe->index);
+		priv->prs_shadow[pe->index].valid = false;
+		kfree(pe);
+		return 0;
+	}
+
+	/* Continue - set next lookup */
+	mvpp2_prs_sram_next_lu_set(pe, MVPP2_PRS_LU_DSA);
+
+	/* Set match on DA */
+	len = ETH_ALEN;
+	while (len--)
+		mvpp2_prs_tcam_data_byte_set(pe, len, da[len], 0xff);
+
+	/* Set result info bits */
+	ri = MVPP2_PRS_RI_L2_UCAST | MVPP2_PRS_RI_MAC_ME_MASK;
+
+	mvpp2_prs_sram_ri_update(pe, ri, MVPP2_PRS_RI_L2_CAST_MASK |
+				 MVPP2_PRS_RI_MAC_ME_MASK);
+	mvpp2_prs_shadow_ri_set(priv, pe->index, ri, MVPP2_PRS_RI_L2_CAST_MASK |
+				MVPP2_PRS_RI_MAC_ME_MASK);
+
+	/* Shift to ethertype */
+	mvpp2_prs_sram_shift_set(pe, 2 * ETH_ALEN,
+				 MVPP2_PRS_SRAM_OP_SEL_SHIFT_ADD);
+
+	/* Update shadow table and hw entry */
+	priv->prs_shadow[pe->index].udf = MVPP2_PRS_UDF_MAC_DEF;
+	mvpp2_prs_shadow_set(priv, pe->index, MVPP2_PRS_LU_MAC);
+	mvpp2_prs_hw_write(priv, pe);
+
+	kfree(pe);
+
+	return 0;
+}
+
+static int mvpp2_prs_update_mac_da(struct mvpp2_port *port, const u8 *da)
+{
+	int err;
+
+	/* Remove old parser entry */
+	err = mvpp2_prs_mac_da_accept(port->priv, port->id, port->dev_addr,
+				      false);
+	if (err)
+		return err;
+
+	/* Add new parser entry */
+	err = mvpp2_prs_mac_da_accept(port->priv, port->id, da, true);
+	if (err)
+		return err;
+
+	/* Set addr in the device */
+	memcpy(port->dev_addr, da, ETH_ALEN);
+
+	return 0;
+}
+
+/* Set prs flow for the port */
+static int mvpp2_prs_def_flow(struct mvpp2_port *port)
+{
+	struct mvpp2_prs_entry *pe;
+	int tid;
+
+	pe = mvpp2_prs_flow_find(port->priv, port->id);
+
+	/* Such entry not exist */
+	if (!pe) {
+		/* Go through the all entires from last to first */
+		tid = mvpp2_prs_tcam_first_free(port->priv,
+						MVPP2_PE_LAST_FREE_TID,
+					       MVPP2_PE_FIRST_FREE_TID);
+		if (tid < 0)
+			return tid;
+
+		pe = kzalloc(sizeof(*pe), GFP_KERNEL);
+		if (!pe)
+			return -ENOMEM;
+
+		mvpp2_prs_tcam_lu_set(pe, MVPP2_PRS_LU_FLOWS);
+		pe->index = tid;
+
+		/* Set flow ID*/
+		mvpp2_prs_sram_ai_update(pe, port->id, MVPP2_PRS_FLOW_ID_MASK);
+		mvpp2_prs_sram_bits_set(pe, MVPP2_PRS_SRAM_LU_DONE_BIT, 1);
+
+		/* Update shadow table */
+		mvpp2_prs_shadow_set(port->priv, pe->index, MVPP2_PRS_LU_FLOWS);
+	}
+
+	mvpp2_prs_tcam_port_map_set(pe, (1 << port->id));
+	mvpp2_prs_hw_write(port->priv, pe);
+	kfree(pe);
+
+	return 0;
+}
+
+/* Classifier configuration routines */
+
+/* Update classification flow table registers */
+static void mvpp2_cls_flow_write(struct mvpp2 *priv,
+				 struct mvpp2_cls_flow_entry *fe)
+{
+	mvpp2_write(priv, MVPP2_CLS_FLOW_INDEX_REG, fe->index);
+	mvpp2_write(priv, MVPP2_CLS_FLOW_TBL0_REG,  fe->data[0]);
+	mvpp2_write(priv, MVPP2_CLS_FLOW_TBL1_REG,  fe->data[1]);
+	mvpp2_write(priv, MVPP2_CLS_FLOW_TBL2_REG,  fe->data[2]);
+}
+
+/* Update classification lookup table register */
+static void mvpp2_cls_lookup_write(struct mvpp2 *priv,
+				   struct mvpp2_cls_lookup_entry *le)
+{
+	u32 val;
+
+	val = (le->way << MVPP2_CLS_LKP_INDEX_WAY_OFFS) | le->lkpid;
+	mvpp2_write(priv, MVPP2_CLS_LKP_INDEX_REG, val);
+	mvpp2_write(priv, MVPP2_CLS_LKP_TBL_REG, le->data);
+}
+
+/* Classifier default initialization */
+static void mvpp2_cls_init(struct mvpp2 *priv)
+{
+	struct mvpp2_cls_lookup_entry le;
+	struct mvpp2_cls_flow_entry fe;
+	int index;
+
+	/* Enable classifier */
+	mvpp2_write(priv, MVPP2_CLS_MODE_REG, MVPP2_CLS_MODE_ACTIVE_MASK);
+
+	/* Clear classifier flow table */
+	memset(&fe.data, 0, MVPP2_CLS_FLOWS_TBL_DATA_WORDS);
+	for (index = 0; index < MVPP2_CLS_FLOWS_TBL_SIZE; index++) {
+		fe.index = index;
+		mvpp2_cls_flow_write(priv, &fe);
+	}
+
+	/* Clear classifier lookup table */
+	le.data = 0;
+	for (index = 0; index < MVPP2_CLS_LKP_TBL_SIZE; index++) {
+		le.lkpid = index;
+		le.way = 0;
+		mvpp2_cls_lookup_write(priv, &le);
+
+		le.way = 1;
+		mvpp2_cls_lookup_write(priv, &le);
+	}
+}
+
+static void mvpp2_cls_port_config(struct mvpp2_port *port)
+{
+	struct mvpp2_cls_lookup_entry le;
+	u32 val;
+
+	/* Set way for the port */
+	val = mvpp2_read(port->priv, MVPP2_CLS_PORT_WAY_REG);
+	val &= ~MVPP2_CLS_PORT_WAY_MASK(port->id);
+	mvpp2_write(port->priv, MVPP2_CLS_PORT_WAY_REG, val);
+
+	/* Pick the entry to be accessed in lookup ID decoding table
+	 * according to the way and lkpid.
+	 */
+	le.lkpid = port->id;
+	le.way = 0;
+	le.data = 0;
+
+	/* Set initial CPU queue for receiving packets */
+	le.data &= ~MVPP2_CLS_LKP_TBL_RXQ_MASK;
+	le.data |= port->first_rxq;
+
+	/* Disable classification engines */
+	le.data &= ~MVPP2_CLS_LKP_TBL_LOOKUP_EN_MASK;
+
+	/* Update lookup ID table entry */
+	mvpp2_cls_lookup_write(port->priv, &le);
+}
+
+/* Set CPU queue number for oversize packets */
+static void mvpp2_cls_oversize_rxq_set(struct mvpp2_port *port)
+{
+	u32 val;
+
+	mvpp2_write(port->priv, MVPP2_CLS_OVERSIZE_RXQ_LOW_REG(port->id),
+		    port->first_rxq & MVPP2_CLS_OVERSIZE_RXQ_LOW_MASK);
+
+	mvpp2_write(port->priv, MVPP2_CLS_SWFWD_P2HQ_REG(port->id),
+		    (port->first_rxq >> MVPP2_CLS_OVERSIZE_RXQ_LOW_BITS));
+
+	val = mvpp2_read(port->priv, MVPP2_CLS_SWFWD_PCTRL_REG);
+	val |= MVPP2_CLS_SWFWD_PCTRL_MASK(port->id);
+	mvpp2_write(port->priv, MVPP2_CLS_SWFWD_PCTRL_REG, val);
+}
+
+/* Buffer Manager configuration routines */
+
+/* Create pool */
+static int mvpp2_bm_pool_create(struct udevice *dev,
+				struct mvpp2 *priv,
+				struct mvpp2_bm_pool *bm_pool, int size)
+{
+	u32 val;
+
+	bm_pool->virt_addr = buffer_loc.bm_pool[bm_pool->id];
+	bm_pool->phys_addr = (dma_addr_t)buffer_loc.bm_pool[bm_pool->id];
+	if (!bm_pool->virt_addr)
+		return -ENOMEM;
+
+	if (!IS_ALIGNED((u32)bm_pool->virt_addr, MVPP2_BM_POOL_PTR_ALIGN)) {
+		dev_err(&pdev->dev, "BM pool %d is not %d bytes aligned\n",
+			bm_pool->id, MVPP2_BM_POOL_PTR_ALIGN);
+		return -ENOMEM;
+	}
+
+	mvpp2_write(priv, MVPP2_BM_POOL_BASE_REG(bm_pool->id),
+		    bm_pool->phys_addr);
+	mvpp2_write(priv, MVPP2_BM_POOL_SIZE_REG(bm_pool->id), size);
+
+	val = mvpp2_read(priv, MVPP2_BM_POOL_CTRL_REG(bm_pool->id));
+	val |= MVPP2_BM_START_MASK;
+	mvpp2_write(priv, MVPP2_BM_POOL_CTRL_REG(bm_pool->id), val);
+
+	bm_pool->type = MVPP2_BM_FREE;
+	bm_pool->size = size;
+	bm_pool->pkt_size = 0;
+	bm_pool->buf_num = 0;
+
+	return 0;
+}
+
+/* Set pool buffer size */
+static void mvpp2_bm_pool_bufsize_set(struct mvpp2 *priv,
+				      struct mvpp2_bm_pool *bm_pool,
+				      int buf_size)
+{
+	u32 val;
+
+	bm_pool->buf_size = buf_size;
+
+	val = ALIGN(buf_size, 1 << MVPP2_POOL_BUF_SIZE_OFFSET);
+	mvpp2_write(priv, MVPP2_POOL_BUF_SIZE_REG(bm_pool->id), val);
+}
+
+/* Free all buffers from the pool */
+static void mvpp2_bm_bufs_free(struct udevice *dev, struct mvpp2 *priv,
+			       struct mvpp2_bm_pool *bm_pool)
+{
+	bm_pool->buf_num = 0;
+}
+
+/* Cleanup pool */
+static int mvpp2_bm_pool_destroy(struct udevice *dev,
+				 struct mvpp2 *priv,
+				 struct mvpp2_bm_pool *bm_pool)
+{
+	u32 val;
+
+	mvpp2_bm_bufs_free(dev, priv, bm_pool);
+	if (bm_pool->buf_num) {
+		dev_err(dev, "cannot free all buffers in pool %d\n", bm_pool->id);
+		return 0;
+	}
+
+	val = mvpp2_read(priv, MVPP2_BM_POOL_CTRL_REG(bm_pool->id));
+	val |= MVPP2_BM_STOP_MASK;
+	mvpp2_write(priv, MVPP2_BM_POOL_CTRL_REG(bm_pool->id), val);
+
+	return 0;
+}
+
+static int mvpp2_bm_pools_init(struct udevice *dev,
+			       struct mvpp2 *priv)
+{
+	int i, err, size;
+	struct mvpp2_bm_pool *bm_pool;
+
+	/* Create all pools with maximum size */
+	size = MVPP2_BM_POOL_SIZE_MAX;
+	for (i = 0; i < MVPP2_BM_POOLS_NUM; i++) {
+		bm_pool = &priv->bm_pools[i];
+		bm_pool->id = i;
+		err = mvpp2_bm_pool_create(dev, priv, bm_pool, size);
+		if (err)
+			goto err_unroll_pools;
+		mvpp2_bm_pool_bufsize_set(priv, bm_pool, 0);
+	}
+	return 0;
+
+err_unroll_pools:
+	dev_err(&pdev->dev, "failed to create BM pool %d, size %d\n", i, size);
+	for (i = i - 1; i >= 0; i--)
+		mvpp2_bm_pool_destroy(dev, priv, &priv->bm_pools[i]);
+	return err;
+}
+
+static int mvpp2_bm_init(struct udevice *dev, struct mvpp2 *priv)
+{
+	int i, err;
+
+	for (i = 0; i < MVPP2_BM_POOLS_NUM; i++) {
+		/* Mask BM all interrupts */
+		mvpp2_write(priv, MVPP2_BM_INTR_MASK_REG(i), 0);
+		/* Clear BM cause register */
+		mvpp2_write(priv, MVPP2_BM_INTR_CAUSE_REG(i), 0);
+	}
+
+	/* Allocate and initialize BM pools */
+	priv->bm_pools = devm_kcalloc(dev, MVPP2_BM_POOLS_NUM,
+				     sizeof(struct mvpp2_bm_pool), GFP_KERNEL);
+	if (!priv->bm_pools)
+		return -ENOMEM;
+
+	err = mvpp2_bm_pools_init(dev, priv);
+	if (err < 0)
+		return err;
+	return 0;
+}
+
+/* Attach long pool to rxq */
+static void mvpp2_rxq_long_pool_set(struct mvpp2_port *port,
+				    int lrxq, int long_pool)
+{
+	u32 val;
+	int prxq;
+
+	/* Get queue physical ID */
+	prxq = port->rxqs[lrxq]->id;
+
+	val = mvpp2_read(port->priv, MVPP2_RXQ_CONFIG_REG(prxq));
+	val &= ~MVPP2_RXQ_POOL_LONG_MASK;
+	val |= ((long_pool << MVPP2_RXQ_POOL_LONG_OFFS) &
+		    MVPP2_RXQ_POOL_LONG_MASK);
+
+	mvpp2_write(port->priv, MVPP2_RXQ_CONFIG_REG(prxq), val);
+}
+
+/* Set pool number in a BM cookie */
+static inline u32 mvpp2_bm_cookie_pool_set(u32 cookie, int pool)
+{
+	u32 bm;
+
+	bm = cookie & ~(0xFF << MVPP2_BM_COOKIE_POOL_OFFS);
+	bm |= ((pool & 0xFF) << MVPP2_BM_COOKIE_POOL_OFFS);
+
+	return bm;
+}
+
+/* Get pool number from a BM cookie */
+static inline int mvpp2_bm_cookie_pool_get(u32 cookie)
+{
+	return (cookie >> MVPP2_BM_COOKIE_POOL_OFFS) & 0xFF;
+}
+
+/* Release buffer to BM */
+static inline void mvpp2_bm_pool_put(struct mvpp2_port *port, int pool,
+				     u32 buf_phys_addr, u32 buf_virt_addr)
+{
+	mvpp2_write(port->priv, MVPP2_BM_VIRT_RLS_REG, buf_virt_addr);
+	mvpp2_write(port->priv, MVPP2_BM_PHY_RLS_REG(pool), buf_phys_addr);
+}
+
+/* Refill BM pool */
+static void mvpp2_pool_refill(struct mvpp2_port *port, u32 bm,
+			      u32 phys_addr, u32 cookie)
+{
+	int pool = mvpp2_bm_cookie_pool_get(bm);
+
+	mvpp2_bm_pool_put(port, pool, phys_addr, cookie);
+}
+
+/* Allocate buffers for the pool */
+static int mvpp2_bm_bufs_add(struct mvpp2_port *port,
+			     struct mvpp2_bm_pool *bm_pool, int buf_num)
+{
+	int i;
+	u32 bm;
+
+	if (buf_num < 0 ||
+	    (buf_num + bm_pool->buf_num > bm_pool->size)) {
+		netdev_err(port->dev,
+			   "cannot allocate %d buffers for pool %d\n",
+			   buf_num, bm_pool->id);
+		return 0;
+	}
+
+	bm = mvpp2_bm_cookie_pool_set(0, bm_pool->id);
+	for (i = 0; i < buf_num; i++) {
+		mvpp2_pool_refill(port, bm, (u32)buffer_loc.rx_buffer[i],
+				  (u32)buffer_loc.rx_buffer[i]);
+	}
+
+	/* Update BM driver with number of buffers added to pool */
+	bm_pool->buf_num += i;
+	bm_pool->in_use_thresh = bm_pool->buf_num / 4;
+
+	return i;
+}
+
+/* Notify the driver that BM pool is being used as specific type and return the
+ * pool pointer on success
+ */
+static struct mvpp2_bm_pool *
+mvpp2_bm_pool_use(struct mvpp2_port *port, int pool, enum mvpp2_bm_type type,
+		  int pkt_size)
+{
+	struct mvpp2_bm_pool *new_pool = &port->priv->bm_pools[pool];
+	int num;
+
+	if (new_pool->type != MVPP2_BM_FREE && new_pool->type != type) {
+		netdev_err(port->dev, "mixing pool types is forbidden\n");
+		return NULL;
+	}
+
+	if (new_pool->type == MVPP2_BM_FREE)
+		new_pool->type = type;
+
+	/* Allocate buffers in case BM pool is used as long pool, but packet
+	 * size doesn't match MTU or BM pool hasn't being used yet
+	 */
+	if (((type == MVPP2_BM_SWF_LONG) && (pkt_size > new_pool->pkt_size)) ||
+	    (new_pool->pkt_size == 0)) {
+		int pkts_num;
+
+		/* Set default buffer number or free all the buffers in case
+		 * the pool is not empty
+		 */
+		pkts_num = new_pool->buf_num;
+		if (pkts_num == 0)
+			pkts_num = type == MVPP2_BM_SWF_LONG ?
+				   MVPP2_BM_LONG_BUF_NUM :
+				   MVPP2_BM_SHORT_BUF_NUM;
+		else
+			mvpp2_bm_bufs_free(NULL,
+					   port->priv, new_pool);
+
+		new_pool->pkt_size = pkt_size;
+
+		/* Allocate buffers for this pool */
+		num = mvpp2_bm_bufs_add(port, new_pool, pkts_num);
+		if (num != pkts_num) {
+			dev_err(dev, "pool %d: %d of %d allocated\n",
+				new_pool->id, num, pkts_num);
+			return NULL;
+		}
+	}
+
+	mvpp2_bm_pool_bufsize_set(port->priv, new_pool,
+				  MVPP2_RX_BUF_SIZE(new_pool->pkt_size));
+
+	return new_pool;
+}
+
+/* Initialize pools for swf */
+static int mvpp2_swf_bm_pool_init(struct mvpp2_port *port)
+{
+	int rxq;
+
+	if (!port->pool_long) {
+		port->pool_long =
+		       mvpp2_bm_pool_use(port, MVPP2_BM_SWF_LONG_POOL(port->id),
+					 MVPP2_BM_SWF_LONG,
+					 port->pkt_size);
+		if (!port->pool_long)
+			return -ENOMEM;
+
+		port->pool_long->port_map |= (1 << port->id);
+
+		for (rxq = 0; rxq < rxq_number; rxq++)
+			mvpp2_rxq_long_pool_set(port, rxq, port->pool_long->id);
+	}
+
+	return 0;
+}
+
+/* Port configuration routines */
+
+static void mvpp2_port_mii_set(struct mvpp2_port *port)
+{
+	u32 val;
+
+	val = readl(port->base + MVPP2_GMAC_CTRL_2_REG);
+
+	switch (port->phy_interface) {
+	case PHY_INTERFACE_MODE_SGMII:
+		val |= MVPP2_GMAC_INBAND_AN_MASK;
+		break;
+	case PHY_INTERFACE_MODE_RGMII:
+		val |= MVPP2_GMAC_PORT_RGMII_MASK;
+	default:
+		val &= ~MVPP2_GMAC_PCS_ENABLE_MASK;
+	}
+
+	writel(val, port->base + MVPP2_GMAC_CTRL_2_REG);
+}
+
+static void mvpp2_port_fc_adv_enable(struct mvpp2_port *port)
+{
+	u32 val;
+
+	val = readl(port->base + MVPP2_GMAC_AUTONEG_CONFIG);
+	val |= MVPP2_GMAC_FC_ADV_EN;
+	writel(val, port->base + MVPP2_GMAC_AUTONEG_CONFIG);
+}
+
+static void mvpp2_port_enable(struct mvpp2_port *port)
+{
+	u32 val;
+
+	val = readl(port->base + MVPP2_GMAC_CTRL_0_REG);
+	val |= MVPP2_GMAC_PORT_EN_MASK;
+	val |= MVPP2_GMAC_MIB_CNTR_EN_MASK;
+	writel(val, port->base + MVPP2_GMAC_CTRL_0_REG);
+}
+
+static void mvpp2_port_disable(struct mvpp2_port *port)
+{
+	u32 val;
+
+	val = readl(port->base + MVPP2_GMAC_CTRL_0_REG);
+	val &= ~(MVPP2_GMAC_PORT_EN_MASK);
+	writel(val, port->base + MVPP2_GMAC_CTRL_0_REG);
+}
+
+/* Set IEEE 802.3x Flow Control Xon Packet Transmission Mode */
+static void mvpp2_port_periodic_xon_disable(struct mvpp2_port *port)
+{
+	u32 val;
+
+	val = readl(port->base + MVPP2_GMAC_CTRL_1_REG) &
+		    ~MVPP2_GMAC_PERIODIC_XON_EN_MASK;
+	writel(val, port->base + MVPP2_GMAC_CTRL_1_REG);
+}
+
+/* Configure loopback port */
+static void mvpp2_port_loopback_set(struct mvpp2_port *port)
+{
+	u32 val;
+
+	val = readl(port->base + MVPP2_GMAC_CTRL_1_REG);
+
+	if (port->speed == 1000)
+		val |= MVPP2_GMAC_GMII_LB_EN_MASK;
+	else
+		val &= ~MVPP2_GMAC_GMII_LB_EN_MASK;
+
+	if (port->phy_interface == PHY_INTERFACE_MODE_SGMII)
+		val |= MVPP2_GMAC_PCS_LB_EN_MASK;
+	else
+		val &= ~MVPP2_GMAC_PCS_LB_EN_MASK;
+
+	writel(val, port->base + MVPP2_GMAC_CTRL_1_REG);
+}
+
+static void mvpp2_port_reset(struct mvpp2_port *port)
+{
+	u32 val;
+
+	val = readl(port->base + MVPP2_GMAC_CTRL_2_REG) &
+		    ~MVPP2_GMAC_PORT_RESET_MASK;
+	writel(val, port->base + MVPP2_GMAC_CTRL_2_REG);
+
+	while (readl(port->base + MVPP2_GMAC_CTRL_2_REG) &
+	       MVPP2_GMAC_PORT_RESET_MASK)
+		continue;
+}
+
+/* Change maximum receive size of the port */
+static inline void mvpp2_gmac_max_rx_size_set(struct mvpp2_port *port)
+{
+	u32 val;
+
+	val = readl(port->base + MVPP2_GMAC_CTRL_0_REG);
+	val &= ~MVPP2_GMAC_MAX_RX_SIZE_MASK;
+	val |= (((port->pkt_size - MVPP2_MH_SIZE) / 2) <<
+		    MVPP2_GMAC_MAX_RX_SIZE_OFFS);
+	writel(val, port->base + MVPP2_GMAC_CTRL_0_REG);
+}
+
+/* Set defaults to the MVPP2 port */
+static void mvpp2_defaults_set(struct mvpp2_port *port)
+{
+	int tx_port_num, val, queue, ptxq, lrxq;
+
+	/* Configure port to loopback if needed */
+	if (port->flags & MVPP2_F_LOOPBACK)
+		mvpp2_port_loopback_set(port);
+
+	/* Update TX FIFO MIN Threshold */
+	val = readl(port->base + MVPP2_GMAC_PORT_FIFO_CFG_1_REG);
+	val &= ~MVPP2_GMAC_TX_FIFO_MIN_TH_ALL_MASK;
+	/* Min. TX threshold must be less than minimal packet length */
+	val |= MVPP2_GMAC_TX_FIFO_MIN_TH_MASK(64 - 4 - 2);
+	writel(val, port->base + MVPP2_GMAC_PORT_FIFO_CFG_1_REG);
+
+	/* Disable Legacy WRR, Disable EJP, Release from reset */
+	tx_port_num = mvpp2_egress_port(port);
+	mvpp2_write(port->priv, MVPP2_TXP_SCHED_PORT_INDEX_REG,
+		    tx_port_num);
+	mvpp2_write(port->priv, MVPP2_TXP_SCHED_CMD_1_REG, 0);
+
+	/* Close bandwidth for all queues */
+	for (queue = 0; queue < MVPP2_MAX_TXQ; queue++) {
+		ptxq = mvpp2_txq_phys(port->id, queue);
+		mvpp2_write(port->priv,
+			    MVPP2_TXQ_SCHED_TOKEN_CNTR_REG(ptxq), 0);
+	}
+
+	/* Set refill period to 1 usec, refill tokens
+	 * and bucket size to maximum
+	 */
+	mvpp2_write(port->priv, MVPP2_TXP_SCHED_PERIOD_REG, 0xc8);
+	val = mvpp2_read(port->priv, MVPP2_TXP_SCHED_REFILL_REG);
+	val &= ~MVPP2_TXP_REFILL_PERIOD_ALL_MASK;
+	val |= MVPP2_TXP_REFILL_PERIOD_MASK(1);
+	val |= MVPP2_TXP_REFILL_TOKENS_ALL_MASK;
+	mvpp2_write(port->priv, MVPP2_TXP_SCHED_REFILL_REG, val);
+	val = MVPP2_TXP_TOKEN_SIZE_MAX;
+	mvpp2_write(port->priv, MVPP2_TXP_SCHED_TOKEN_SIZE_REG, val);
+
+	/* Set MaximumLowLatencyPacketSize value to 256 */
+	mvpp2_write(port->priv, MVPP2_RX_CTRL_REG(port->id),
+		    MVPP2_RX_USE_PSEUDO_FOR_CSUM_MASK |
+		    MVPP2_RX_LOW_LATENCY_PKT_SIZE(256));
+
+	/* Enable Rx cache snoop */
+	for (lrxq = 0; lrxq < rxq_number; lrxq++) {
+		queue = port->rxqs[lrxq]->id;
+		val = mvpp2_read(port->priv, MVPP2_RXQ_CONFIG_REG(queue));
+		val |= MVPP2_SNOOP_PKT_SIZE_MASK |
+			   MVPP2_SNOOP_BUF_HDR_MASK;
+		mvpp2_write(port->priv, MVPP2_RXQ_CONFIG_REG(queue), val);
+	}
+}
+
+/* Enable/disable receiving packets */
+static void mvpp2_ingress_enable(struct mvpp2_port *port)
+{
+	u32 val;
+	int lrxq, queue;
+
+	for (lrxq = 0; lrxq < rxq_number; lrxq++) {
+		queue = port->rxqs[lrxq]->id;
+		val = mvpp2_read(port->priv, MVPP2_RXQ_CONFIG_REG(queue));
+		val &= ~MVPP2_RXQ_DISABLE_MASK;
+		mvpp2_write(port->priv, MVPP2_RXQ_CONFIG_REG(queue), val);
+	}
+}
+
+static void mvpp2_ingress_disable(struct mvpp2_port *port)
+{
+	u32 val;
+	int lrxq, queue;
+
+	for (lrxq = 0; lrxq < rxq_number; lrxq++) {
+		queue = port->rxqs[lrxq]->id;
+		val = mvpp2_read(port->priv, MVPP2_RXQ_CONFIG_REG(queue));
+		val |= MVPP2_RXQ_DISABLE_MASK;
+		mvpp2_write(port->priv, MVPP2_RXQ_CONFIG_REG(queue), val);
+	}
+}
+
+/* Enable transmit via physical egress queue
+ * - HW starts take descriptors from DRAM
+ */
+static void mvpp2_egress_enable(struct mvpp2_port *port)
+{
+	u32 qmap;
+	int queue;
+	int tx_port_num = mvpp2_egress_port(port);
+
+	/* Enable all initialized TXs. */
+	qmap = 0;
+	for (queue = 0; queue < txq_number; queue++) {
+		struct mvpp2_tx_queue *txq = port->txqs[queue];
+
+		if (txq->descs != NULL)
+			qmap |= (1 << queue);
+	}
+
+	mvpp2_write(port->priv, MVPP2_TXP_SCHED_PORT_INDEX_REG, tx_port_num);
+	mvpp2_write(port->priv, MVPP2_TXP_SCHED_Q_CMD_REG, qmap);
+}
+
+/* Disable transmit via physical egress queue
+ * - HW doesn't take descriptors from DRAM
+ */
+static void mvpp2_egress_disable(struct mvpp2_port *port)
+{
+	u32 reg_data;
+	int delay;
+	int tx_port_num = mvpp2_egress_port(port);
+
+	/* Issue stop command for active channels only */
+	mvpp2_write(port->priv, MVPP2_TXP_SCHED_PORT_INDEX_REG, tx_port_num);
+	reg_data = (mvpp2_read(port->priv, MVPP2_TXP_SCHED_Q_CMD_REG)) &
+		    MVPP2_TXP_SCHED_ENQ_MASK;
+	if (reg_data != 0)
+		mvpp2_write(port->priv, MVPP2_TXP_SCHED_Q_CMD_REG,
+			    (reg_data << MVPP2_TXP_SCHED_DISQ_OFFSET));
+
+	/* Wait for all Tx activity to terminate. */
+	delay = 0;
+	do {
+		if (delay >= MVPP2_TX_DISABLE_TIMEOUT_MSEC) {
+			netdev_warn(port->dev,
+				    "Tx stop timed out, status=0x%08x\n",
+				    reg_data);
+			break;
+		}
+		mdelay(1);
+		delay++;
+
+		/* Check port TX Command register that all
+		 * Tx queues are stopped
+		 */
+		reg_data = mvpp2_read(port->priv, MVPP2_TXP_SCHED_Q_CMD_REG);
+	} while (reg_data & MVPP2_TXP_SCHED_ENQ_MASK);
+}
+
+/* Rx descriptors helper methods */
+
+/* Get number of Rx descriptors occupied by received packets */
+static inline int
+mvpp2_rxq_received(struct mvpp2_port *port, int rxq_id)
+{
+	u32 val = mvpp2_read(port->priv, MVPP2_RXQ_STATUS_REG(rxq_id));
+
+	return val & MVPP2_RXQ_OCCUPIED_MASK;
+}
+
+/* Update Rx queue status with the number of occupied and available
+ * Rx descriptor slots.
+ */
+static inline void
+mvpp2_rxq_status_update(struct mvpp2_port *port, int rxq_id,
+			int used_count, int free_count)
+{
+	/* Decrement the number of used descriptors and increment count
+	 * increment the number of free descriptors.
+	 */
+	u32 val = used_count | (free_count << MVPP2_RXQ_NUM_NEW_OFFSET);
+
+	mvpp2_write(port->priv, MVPP2_RXQ_STATUS_UPDATE_REG(rxq_id), val);
+}
+
+/* Get pointer to next RX descriptor to be processed by SW */
+static inline struct mvpp2_rx_desc *
+mvpp2_rxq_next_desc_get(struct mvpp2_rx_queue *rxq)
+{
+	int rx_desc = rxq->next_desc_to_proc;
+
+	rxq->next_desc_to_proc = MVPP2_QUEUE_NEXT_DESC(rxq, rx_desc);
+	prefetch(rxq->descs + rxq->next_desc_to_proc);
+	return rxq->descs + rx_desc;
+}
+
+/* Set rx queue offset */
+static void mvpp2_rxq_offset_set(struct mvpp2_port *port,
+				 int prxq, int offset)
+{
+	u32 val;
+
+	/* Convert offset from bytes to units of 32 bytes */
+	offset = offset >> 5;
+
+	val = mvpp2_read(port->priv, MVPP2_RXQ_CONFIG_REG(prxq));
+	val &= ~MVPP2_RXQ_PACKET_OFFSET_MASK;
+
+	/* Offset is in */
+	val |= ((offset << MVPP2_RXQ_PACKET_OFFSET_OFFS) &
+		    MVPP2_RXQ_PACKET_OFFSET_MASK);
+
+	mvpp2_write(port->priv, MVPP2_RXQ_CONFIG_REG(prxq), val);
+}
+
+/* Obtain BM cookie information from descriptor */
+static u32 mvpp2_bm_cookie_build(struct mvpp2_rx_desc *rx_desc)
+{
+	int pool = (rx_desc->status & MVPP2_RXD_BM_POOL_ID_MASK) >>
+		   MVPP2_RXD_BM_POOL_ID_OFFS;
+	int cpu = smp_processor_id();
+
+	return ((pool & 0xFF) << MVPP2_BM_COOKIE_POOL_OFFS) |
+	       ((cpu & 0xFF) << MVPP2_BM_COOKIE_CPU_OFFS);
+}
+
+/* Tx descriptors helper methods */
+
+/* Get number of Tx descriptors waiting to be transmitted by HW */
+static int mvpp2_txq_pend_desc_num_get(struct mvpp2_port *port,
+				       struct mvpp2_tx_queue *txq)
+{
+	u32 val;
+
+	mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
+	val = mvpp2_read(port->priv, MVPP2_TXQ_PENDING_REG);
+
+	return val & MVPP2_TXQ_PENDING_MASK;
+}
+
+/* Get pointer to next Tx descriptor to be processed (send) by HW */
+static struct mvpp2_tx_desc *
+mvpp2_txq_next_desc_get(struct mvpp2_tx_queue *txq)
+{
+	int tx_desc = txq->next_desc_to_proc;
+
+	txq->next_desc_to_proc = MVPP2_QUEUE_NEXT_DESC(txq, tx_desc);
+	return txq->descs + tx_desc;
+}
+
+/* Update HW with number of aggregated Tx descriptors to be sent */
+static void mvpp2_aggr_txq_pend_desc_add(struct mvpp2_port *port, int pending)
+{
+	/* aggregated access - relevant TXQ number is written in TX desc */
+	mvpp2_write(port->priv, MVPP2_AGGR_TXQ_UPDATE_REG, pending);
+}
+
+/* Get number of sent descriptors and decrement counter.
+ * The number of sent descriptors is returned.
+ * Per-CPU access
+ */
+static inline int mvpp2_txq_sent_desc_proc(struct mvpp2_port *port,
+					   struct mvpp2_tx_queue *txq)
+{
+	u32 val;
+
+	/* Reading status reg resets transmitted descriptor counter */
+	val = mvpp2_read(port->priv, MVPP2_TXQ_SENT_REG(txq->id));
+
+	return (val & MVPP2_TRANSMITTED_COUNT_MASK) >>
+		MVPP2_TRANSMITTED_COUNT_OFFSET;
+}
+
+static void mvpp2_txq_sent_counter_clear(void *arg)
+{
+	struct mvpp2_port *port = arg;
+	int queue;
+
+	for (queue = 0; queue < txq_number; queue++) {
+		int id = port->txqs[queue]->id;
+
+		mvpp2_read(port->priv, MVPP2_TXQ_SENT_REG(id));
+	}
+}
+
+/* Set max sizes for Tx queues */
+static void mvpp2_txp_max_tx_size_set(struct mvpp2_port *port)
+{
+	u32	val, size, mtu;
+	int	txq, tx_port_num;
+
+	mtu = port->pkt_size * 8;
+	if (mtu > MVPP2_TXP_MTU_MAX)
+		mtu = MVPP2_TXP_MTU_MAX;
+
+	/* WA for wrong Token bucket update: Set MTU value = 3*real MTU value */
+	mtu = 3 * mtu;
+
+	/* Indirect access to registers */
+	tx_port_num = mvpp2_egress_port(port);
+	mvpp2_write(port->priv, MVPP2_TXP_SCHED_PORT_INDEX_REG, tx_port_num);
+
+	/* Set MTU */
+	val = mvpp2_read(port->priv, MVPP2_TXP_SCHED_MTU_REG);
+	val &= ~MVPP2_TXP_MTU_MAX;
+	val |= mtu;
+	mvpp2_write(port->priv, MVPP2_TXP_SCHED_MTU_REG, val);
+
+	/* TXP token size and all TXQs token size must be larger that MTU */
+	val = mvpp2_read(port->priv, MVPP2_TXP_SCHED_TOKEN_SIZE_REG);
+	size = val & MVPP2_TXP_TOKEN_SIZE_MAX;
+	if (size < mtu) {
+		size = mtu;
+		val &= ~MVPP2_TXP_TOKEN_SIZE_MAX;
+		val |= size;
+		mvpp2_write(port->priv, MVPP2_TXP_SCHED_TOKEN_SIZE_REG, val);
+	}
+
+	for (txq = 0; txq < txq_number; txq++) {
+		val = mvpp2_read(port->priv,
+				 MVPP2_TXQ_SCHED_TOKEN_SIZE_REG(txq));
+		size = val & MVPP2_TXQ_TOKEN_SIZE_MAX;
+
+		if (size < mtu) {
+			size = mtu;
+			val &= ~MVPP2_TXQ_TOKEN_SIZE_MAX;
+			val |= size;
+			mvpp2_write(port->priv,
+				    MVPP2_TXQ_SCHED_TOKEN_SIZE_REG(txq),
+				    val);
+		}
+	}
+}
+
+/* Free Tx queue skbuffs */
+static void mvpp2_txq_bufs_free(struct mvpp2_port *port,
+				struct mvpp2_tx_queue *txq,
+				struct mvpp2_txq_pcpu *txq_pcpu, int num)
+{
+	int i;
+
+	for (i = 0; i < num; i++)
+		mvpp2_txq_inc_get(txq_pcpu);
+}
+
+static inline struct mvpp2_rx_queue *mvpp2_get_rx_queue(struct mvpp2_port *port,
+							u32 cause)
+{
+	int queue = fls(cause) - 1;
+
+	return port->rxqs[queue];
+}
+
+static inline struct mvpp2_tx_queue *mvpp2_get_tx_queue(struct mvpp2_port *port,
+							u32 cause)
+{
+	int queue = fls(cause) - 1;
+
+	return port->txqs[queue];
+}
+
+/* Rx/Tx queue initialization/cleanup methods */
+
+/* Allocate and initialize descriptors for aggr TXQ */
+static int mvpp2_aggr_txq_init(struct udevice *dev,
+			       struct mvpp2_tx_queue *aggr_txq,
+			       int desc_num, int cpu,
+			       struct mvpp2 *priv)
+{
+	/* Allocate memory for TX descriptors */
+	aggr_txq->descs = buffer_loc.aggr_tx_descs;
+	aggr_txq->descs_phys = (dma_addr_t)buffer_loc.aggr_tx_descs;
+	if (!aggr_txq->descs)
+		return -ENOMEM;
+
+	/* Make sure descriptor address is cache line size aligned  */
+	BUG_ON(aggr_txq->descs !=
+	       PTR_ALIGN(aggr_txq->descs, MVPP2_CPU_D_CACHE_LINE_SIZE));
+
+	aggr_txq->last_desc = aggr_txq->size - 1;
+
+	/* Aggr TXQ no reset WA */
+	aggr_txq->next_desc_to_proc = mvpp2_read(priv,
+						 MVPP2_AGGR_TXQ_INDEX_REG(cpu));
+
+	/* Set Tx descriptors queue starting address */
+	/* indirect access */
+	mvpp2_write(priv, MVPP2_AGGR_TXQ_DESC_ADDR_REG(cpu),
+		    aggr_txq->descs_phys);
+	mvpp2_write(priv, MVPP2_AGGR_TXQ_DESC_SIZE_REG(cpu), desc_num);
+
+	return 0;
+}
+
+/* Create a specified Rx queue */
+static int mvpp2_rxq_init(struct mvpp2_port *port,
+			  struct mvpp2_rx_queue *rxq)
+
+{
+	rxq->size = port->rx_ring_size;
+
+	/* Allocate memory for RX descriptors */
+	rxq->descs = buffer_loc.rx_descs;
+	rxq->descs_phys = (dma_addr_t)buffer_loc.rx_descs;
+	if (!rxq->descs)
+		return -ENOMEM;
+
+	BUG_ON(rxq->descs !=
+	       PTR_ALIGN(rxq->descs, MVPP2_CPU_D_CACHE_LINE_SIZE));
+
+	rxq->last_desc = rxq->size - 1;
+
+	/* Zero occupied and non-occupied counters - direct access */
+	mvpp2_write(port->priv, MVPP2_RXQ_STATUS_REG(rxq->id), 0);
+
+	/* Set Rx descriptors queue starting address - indirect access */
+	mvpp2_write(port->priv, MVPP2_RXQ_NUM_REG, rxq->id);
+	mvpp2_write(port->priv, MVPP2_RXQ_DESC_ADDR_REG, rxq->descs_phys);
+	mvpp2_write(port->priv, MVPP2_RXQ_DESC_SIZE_REG, rxq->size);
+	mvpp2_write(port->priv, MVPP2_RXQ_INDEX_REG, 0);
+
+	/* Set Offset */
+	mvpp2_rxq_offset_set(port, rxq->id, NET_SKB_PAD);
+
+	/* Add number of descriptors ready for receiving packets */
+	mvpp2_rxq_status_update(port, rxq->id, 0, rxq->size);
+
+	return 0;
+}
+
+/* Push packets received by the RXQ to BM pool */
+static void mvpp2_rxq_drop_pkts(struct mvpp2_port *port,
+				struct mvpp2_rx_queue *rxq)
+{
+	int rx_received, i;
+
+	rx_received = mvpp2_rxq_received(port, rxq->id);
+	if (!rx_received)
+		return;
+
+	for (i = 0; i < rx_received; i++) {
+		struct mvpp2_rx_desc *rx_desc = mvpp2_rxq_next_desc_get(rxq);
+		u32 bm = mvpp2_bm_cookie_build(rx_desc);
+
+		mvpp2_pool_refill(port, bm, rx_desc->buf_phys_addr,
+				  rx_desc->buf_cookie);
+	}
+	mvpp2_rxq_status_update(port, rxq->id, rx_received, rx_received);
+}
+
+/* Cleanup Rx queue */
+static void mvpp2_rxq_deinit(struct mvpp2_port *port,
+			     struct mvpp2_rx_queue *rxq)
+{
+	mvpp2_rxq_drop_pkts(port, rxq);
+
+	rxq->descs             = NULL;
+	rxq->last_desc         = 0;
+	rxq->next_desc_to_proc = 0;
+	rxq->descs_phys        = 0;
+
+	/* Clear Rx descriptors queue starting address and size;
+	 * free descriptor number
+	 */
+	mvpp2_write(port->priv, MVPP2_RXQ_STATUS_REG(rxq->id), 0);
+	mvpp2_write(port->priv, MVPP2_RXQ_NUM_REG, rxq->id);
+	mvpp2_write(port->priv, MVPP2_RXQ_DESC_ADDR_REG, 0);
+	mvpp2_write(port->priv, MVPP2_RXQ_DESC_SIZE_REG, 0);
+}
+
+/* Create and initialize a Tx queue */
+static int mvpp2_txq_init(struct mvpp2_port *port,
+			  struct mvpp2_tx_queue *txq)
+{
+	u32 val;
+	int cpu, desc, desc_per_txq, tx_port_num;
+	struct mvpp2_txq_pcpu *txq_pcpu;
+
+	txq->size = port->tx_ring_size;
+
+	/* Allocate memory for Tx descriptors */
+	txq->descs = buffer_loc.tx_descs;
+	txq->descs_phys = (dma_addr_t)buffer_loc.tx_descs;
+	if (!txq->descs)
+		return -ENOMEM;
+
+	/* Make sure descriptor address is cache line size aligned  */
+	BUG_ON(txq->descs !=
+	       PTR_ALIGN(txq->descs, MVPP2_CPU_D_CACHE_LINE_SIZE));
+
+	txq->last_desc = txq->size - 1;
+
+	/* Set Tx descriptors queue starting address - indirect access */
+	mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
+	mvpp2_write(port->priv, MVPP2_TXQ_DESC_ADDR_REG, txq->descs_phys);
+	mvpp2_write(port->priv, MVPP2_TXQ_DESC_SIZE_REG, txq->size &
+					     MVPP2_TXQ_DESC_SIZE_MASK);
+	mvpp2_write(port->priv, MVPP2_TXQ_INDEX_REG, 0);
+	mvpp2_write(port->priv, MVPP2_TXQ_RSVD_CLR_REG,
+		    txq->id << MVPP2_TXQ_RSVD_CLR_OFFSET);
+	val = mvpp2_read(port->priv, MVPP2_TXQ_PENDING_REG);
+	val &= ~MVPP2_TXQ_PENDING_MASK;
+	mvpp2_write(port->priv, MVPP2_TXQ_PENDING_REG, val);
+
+	/* Calculate base address in prefetch buffer. We reserve 16 descriptors
+	 * for each existing TXQ.
+	 * TCONTS for PON port must be continuous from 0 to MVPP2_MAX_TCONT
+	 * GBE ports assumed to be continious from 0 to MVPP2_MAX_PORTS
+	 */
+	desc_per_txq = 16;
+	desc = (port->id * MVPP2_MAX_TXQ * desc_per_txq) +
+	       (txq->log_id * desc_per_txq);
+
+	mvpp2_write(port->priv, MVPP2_TXQ_PREF_BUF_REG,
+		    MVPP2_PREF_BUF_PTR(desc) | MVPP2_PREF_BUF_SIZE_16 |
+		    MVPP2_PREF_BUF_THRESH(desc_per_txq/2));
+
+	/* WRR / EJP configuration - indirect access */
+	tx_port_num = mvpp2_egress_port(port);
+	mvpp2_write(port->priv, MVPP2_TXP_SCHED_PORT_INDEX_REG, tx_port_num);
+
+	val = mvpp2_read(port->priv, MVPP2_TXQ_SCHED_REFILL_REG(txq->log_id));
+	val &= ~MVPP2_TXQ_REFILL_PERIOD_ALL_MASK;
+	val |= MVPP2_TXQ_REFILL_PERIOD_MASK(1);
+	val |= MVPP2_TXQ_REFILL_TOKENS_ALL_MASK;
+	mvpp2_write(port->priv, MVPP2_TXQ_SCHED_REFILL_REG(txq->log_id), val);
+
+	val = MVPP2_TXQ_TOKEN_SIZE_MAX;
+	mvpp2_write(port->priv, MVPP2_TXQ_SCHED_TOKEN_SIZE_REG(txq->log_id),
+		    val);
+
+	for_each_present_cpu(cpu) {
+		txq_pcpu = per_cpu_ptr(txq->pcpu, cpu);
+		txq_pcpu->size = txq->size;
+	}
+
+	return 0;
+}
+
+/* Free allocated TXQ resources */
+static void mvpp2_txq_deinit(struct mvpp2_port *port,
+			     struct mvpp2_tx_queue *txq)
+{
+	txq->descs             = NULL;
+	txq->last_desc         = 0;
+	txq->next_desc_to_proc = 0;
+	txq->descs_phys        = 0;
+
+	/* Set minimum bandwidth for disabled TXQs */
+	mvpp2_write(port->priv, MVPP2_TXQ_SCHED_TOKEN_CNTR_REG(txq->id), 0);
+
+	/* Set Tx descriptors queue starting address and size */
+	mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
+	mvpp2_write(port->priv, MVPP2_TXQ_DESC_ADDR_REG, 0);
+	mvpp2_write(port->priv, MVPP2_TXQ_DESC_SIZE_REG, 0);
+}
+
+/* Cleanup Tx ports */
+static void mvpp2_txq_clean(struct mvpp2_port *port, struct mvpp2_tx_queue *txq)
+{
+	struct mvpp2_txq_pcpu *txq_pcpu;
+	int delay, pending, cpu;
+	u32 val;
+
+	mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
+	val = mvpp2_read(port->priv, MVPP2_TXQ_PREF_BUF_REG);
+	val |= MVPP2_TXQ_DRAIN_EN_MASK;
+	mvpp2_write(port->priv, MVPP2_TXQ_PREF_BUF_REG, val);
+
+	/* The napi queue has been stopped so wait for all packets
+	 * to be transmitted.
+	 */
+	delay = 0;
+	do {
+		if (delay >= MVPP2_TX_PENDING_TIMEOUT_MSEC) {
+			netdev_warn(port->dev,
+				    "port %d: cleaning queue %d timed out\n",
+				    port->id, txq->log_id);
+			break;
+		}
+		mdelay(1);
+		delay++;
+
+		pending = mvpp2_txq_pend_desc_num_get(port, txq);
+	} while (pending);
+
+	val &= ~MVPP2_TXQ_DRAIN_EN_MASK;
+	mvpp2_write(port->priv, MVPP2_TXQ_PREF_BUF_REG, val);
+
+	for_each_present_cpu(cpu) {
+		txq_pcpu = per_cpu_ptr(txq->pcpu, cpu);
+
+		/* Release all packets */
+		mvpp2_txq_bufs_free(port, txq, txq_pcpu, txq_pcpu->count);
+
+		/* Reset queue */
+		txq_pcpu->count = 0;
+		txq_pcpu->txq_put_index = 0;
+		txq_pcpu->txq_get_index = 0;
+	}
+}
+
+/* Cleanup all Tx queues */
+static void mvpp2_cleanup_txqs(struct mvpp2_port *port)
+{
+	struct mvpp2_tx_queue *txq;
+	int queue;
+	u32 val;
+
+	val = mvpp2_read(port->priv, MVPP2_TX_PORT_FLUSH_REG);
+
+	/* Reset Tx ports and delete Tx queues */
+	val |= MVPP2_TX_PORT_FLUSH_MASK(port->id);
+	mvpp2_write(port->priv, MVPP2_TX_PORT_FLUSH_REG, val);
+
+	for (queue = 0; queue < txq_number; queue++) {
+		txq = port->txqs[queue];
+		mvpp2_txq_clean(port, txq);
+		mvpp2_txq_deinit(port, txq);
+	}
+
+	mvpp2_txq_sent_counter_clear(port);
+
+	val &= ~MVPP2_TX_PORT_FLUSH_MASK(port->id);
+	mvpp2_write(port->priv, MVPP2_TX_PORT_FLUSH_REG, val);
+}
+
+/* Cleanup all Rx queues */
+static void mvpp2_cleanup_rxqs(struct mvpp2_port *port)
+{
+	int queue;
+
+	for (queue = 0; queue < rxq_number; queue++)
+		mvpp2_rxq_deinit(port, port->rxqs[queue]);
+}
+
+/* Init all Rx queues for port */
+static int mvpp2_setup_rxqs(struct mvpp2_port *port)
+{
+	int queue, err;
+
+	for (queue = 0; queue < rxq_number; queue++) {
+		err = mvpp2_rxq_init(port, port->rxqs[queue]);
+		if (err)
+			goto err_cleanup;
+	}
+	return 0;
+
+err_cleanup:
+	mvpp2_cleanup_rxqs(port);
+	return err;
+}
+
+/* Init all tx queues for port */
+static int mvpp2_setup_txqs(struct mvpp2_port *port)
+{
+	struct mvpp2_tx_queue *txq;
+	int queue, err;
+
+	for (queue = 0; queue < txq_number; queue++) {
+		txq = port->txqs[queue];
+		err = mvpp2_txq_init(port, txq);
+		if (err)
+			goto err_cleanup;
+	}
+
+	mvpp2_txq_sent_counter_clear(port);
+	return 0;
+
+err_cleanup:
+	mvpp2_cleanup_txqs(port);
+	return err;
+}
+
+/* Adjust link */
+static void mvpp2_link_event(struct mvpp2_port *port)
+{
+	struct phy_device *phydev = port->phy_dev;
+	int status_change = 0;
+	u32 val;
+
+	if (phydev->link) {
+		if ((port->speed != phydev->speed) ||
+		    (port->duplex != phydev->duplex)) {
+			u32 val;
+
+			val = readl(port->base + MVPP2_GMAC_AUTONEG_CONFIG);
+			val &= ~(MVPP2_GMAC_CONFIG_MII_SPEED |
+				 MVPP2_GMAC_CONFIG_GMII_SPEED |
+				 MVPP2_GMAC_CONFIG_FULL_DUPLEX |
+				 MVPP2_GMAC_AN_SPEED_EN |
+				 MVPP2_GMAC_AN_DUPLEX_EN);
+
+			if (phydev->duplex)
+				val |= MVPP2_GMAC_CONFIG_FULL_DUPLEX;
+
+			if (phydev->speed == SPEED_1000)
+				val |= MVPP2_GMAC_CONFIG_GMII_SPEED;
+			else if (phydev->speed == SPEED_100)
+				val |= MVPP2_GMAC_CONFIG_MII_SPEED;
+
+			writel(val, port->base + MVPP2_GMAC_AUTONEG_CONFIG);
+
+			port->duplex = phydev->duplex;
+			port->speed  = phydev->speed;
+		}
+	}
+
+	if (phydev->link != port->link) {
+		if (!phydev->link) {
+			port->duplex = -1;
+			port->speed = 0;
+		}
+
+		port->link = phydev->link;
+		status_change = 1;
+	}
+
+	if (status_change) {
+		if (phydev->link) {
+			val = readl(port->base + MVPP2_GMAC_AUTONEG_CONFIG);
+			val |= (MVPP2_GMAC_FORCE_LINK_PASS |
+				MVPP2_GMAC_FORCE_LINK_DOWN);
+			writel(val, port->base + MVPP2_GMAC_AUTONEG_CONFIG);
+			mvpp2_egress_enable(port);
+			mvpp2_ingress_enable(port);
+		} else {
+			mvpp2_ingress_disable(port);
+			mvpp2_egress_disable(port);
+		}
+	}
+}
+
+/* Main RX/TX processing routines */
+
+/* Display more error info */
+static void mvpp2_rx_error(struct mvpp2_port *port,
+			   struct mvpp2_rx_desc *rx_desc)
+{
+	u32 status = rx_desc->status;
+
+	switch (status & MVPP2_RXD_ERR_CODE_MASK) {
+	case MVPP2_RXD_ERR_CRC:
+		netdev_err(port->dev, "bad rx status %08x (crc error), size=%d\n",
+			   status, rx_desc->data_size);
+		break;
+	case MVPP2_RXD_ERR_OVERRUN:
+		netdev_err(port->dev, "bad rx status %08x (overrun error), size=%d\n",
+			   status, rx_desc->data_size);
+		break;
+	case MVPP2_RXD_ERR_RESOURCE:
+		netdev_err(port->dev, "bad rx status %08x (resource error), size=%d\n",
+			   status, rx_desc->data_size);
+		break;
+	}
+}
+
+/* Reuse skb if possible, or allocate a new skb and add it to BM pool */
+static int mvpp2_rx_refill(struct mvpp2_port *port,
+			   struct mvpp2_bm_pool *bm_pool,
+			   u32 bm, u32 phys_addr)
+{
+	mvpp2_pool_refill(port, bm, phys_addr, phys_addr);
+	return 0;
+}
+
+/* Set hw internals when starting port */
+static void mvpp2_start_dev(struct mvpp2_port *port)
+{
+	mvpp2_gmac_max_rx_size_set(port);
+	mvpp2_txp_max_tx_size_set(port);
+
+	mvpp2_port_enable(port);
+}
+
+/* Set hw internals when stopping port */
+static void mvpp2_stop_dev(struct mvpp2_port *port)
+{
+	/* Stop new packets from arriving to RXQs */
+	mvpp2_ingress_disable(port);
+
+	mvpp2_egress_disable(port);
+	mvpp2_port_disable(port);
+}
+
+static int mvpp2_phy_connect(struct udevice *dev, struct mvpp2_port *port)
+{
+	struct phy_device *phy_dev;
+
+	if (!port->init || port->link == 0) {
+		phy_dev = phy_connect(port->priv->bus, port->phyaddr, dev,
+				      port->phy_interface);
+		port->phy_dev = phy_dev;
+		if (!phy_dev) {
+			netdev_err(port->dev, "cannot connect to phy\n");
+			return -ENODEV;
+		}
+		phy_dev->supported &= PHY_GBIT_FEATURES;
+		phy_dev->advertising = phy_dev->supported;
+
+		port->phy_dev = phy_dev;
+		port->link    = 0;
+		port->duplex  = 0;
+		port->speed   = 0;
+
+		phy_config(phy_dev);
+		phy_startup(phy_dev);
+		if (!phy_dev->link) {
+			printf("%s: No link\n", phy_dev->dev->name);
+			return -1;
+		}
+
+		port->init = 1;
+	} else {
+		mvpp2_egress_enable(port);
+		mvpp2_ingress_enable(port);
+	}
+
+	return 0;
+}
+
+static int mvpp2_open(struct udevice *dev, struct mvpp2_port *port)
+{
+	unsigned char mac_bcast[ETH_ALEN] = {
+			0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
+	int err;
+
+	err = mvpp2_prs_mac_da_accept(port->priv, port->id, mac_bcast, true);
+	if (err) {
+		netdev_err(dev, "mvpp2_prs_mac_da_accept BC failed\n");
+		return err;
+	}
+	err = mvpp2_prs_mac_da_accept(port->priv, port->id,
+				      port->dev_addr, true);
+	if (err) {
+		netdev_err(dev, "mvpp2_prs_mac_da_accept MC failed\n");
+		return err;
+	}
+	err = mvpp2_prs_def_flow(port);
+	if (err) {
+		netdev_err(dev, "mvpp2_prs_def_flow failed\n");
+		return err;
+	}
+
+	/* Allocate the Rx/Tx queues */
+	err = mvpp2_setup_rxqs(port);
+	if (err) {
+		netdev_err(port->dev, "cannot allocate Rx queues\n");
+		return err;
+	}
+
+	err = mvpp2_setup_txqs(port);
+	if (err) {
+		netdev_err(port->dev, "cannot allocate Tx queues\n");
+		return err;
+	}
+
+	err = mvpp2_phy_connect(dev, port);
+	if (err < 0)
+		return err;
+
+	mvpp2_link_event(port);
+
+	mvpp2_start_dev(port);
+
+	return 0;
+}
+
+/* No Device ops here in U-Boot */
+
+/* Driver initialization */
+
+static void mvpp2_port_power_up(struct mvpp2_port *port)
+{
+	mvpp2_port_mii_set(port);
+	mvpp2_port_periodic_xon_disable(port);
+	mvpp2_port_fc_adv_enable(port);
+	mvpp2_port_reset(port);
+}
+
+/* Initialize port HW */
+static int mvpp2_port_init(struct udevice *dev, struct mvpp2_port *port)
+{
+	struct mvpp2 *priv = port->priv;
+	struct mvpp2_txq_pcpu *txq_pcpu;
+	int queue, cpu, err;
+
+	if (port->first_rxq + rxq_number > MVPP2_RXQ_TOTAL_NUM)
+		return -EINVAL;
+
+	/* Disable port */
+	mvpp2_egress_disable(port);
+	mvpp2_port_disable(port);
+
+	port->txqs = devm_kcalloc(dev, txq_number, sizeof(*port->txqs),
+				  GFP_KERNEL);
+	if (!port->txqs)
+		return -ENOMEM;
+
+	/* Associate physical Tx queues to this port and initialize.
+	 * The mapping is predefined.
+	 */
+	for (queue = 0; queue < txq_number; queue++) {
+		int queue_phy_id = mvpp2_txq_phys(port->id, queue);
+		struct mvpp2_tx_queue *txq;
+
+		txq = devm_kzalloc(dev, sizeof(*txq), GFP_KERNEL);
+		if (!txq)
+			return -ENOMEM;
+
+		txq->pcpu = devm_kzalloc(dev, sizeof(struct mvpp2_txq_pcpu),
+					 GFP_KERNEL);
+		if (!txq->pcpu)
+			return -ENOMEM;
+
+		txq->id = queue_phy_id;
+		txq->log_id = queue;
+		txq->done_pkts_coal = MVPP2_TXDONE_COAL_PKTS_THRESH;
+		for_each_present_cpu(cpu) {
+			txq_pcpu = per_cpu_ptr(txq->pcpu, cpu);
+			txq_pcpu->cpu = cpu;
+		}
+
+		port->txqs[queue] = txq;
+	}
+
+	port->rxqs = devm_kcalloc(dev, rxq_number, sizeof(*port->rxqs),
+				  GFP_KERNEL);
+	if (!port->rxqs)
+		return -ENOMEM;
+
+	/* Allocate and initialize Rx queue for this port */
+	for (queue = 0; queue < rxq_number; queue++) {
+		struct mvpp2_rx_queue *rxq;
+
+		/* Map physical Rx queue to port's logical Rx queue */
+		rxq = devm_kzalloc(dev, sizeof(*rxq), GFP_KERNEL);
+		if (!rxq)
+			return -ENOMEM;
+		/* Map this Rx queue to a physical queue */
+		rxq->id = port->first_rxq + queue;
+		rxq->port = port->id;
+		rxq->logic_rxq = queue;
+
+		port->rxqs[queue] = rxq;
+	}
+
+	/* Configure Rx queue group interrupt for this port */
+	mvpp2_write(priv, MVPP2_ISR_RXQ_GROUP_REG(port->id), CONFIG_MV_ETH_RXQ);
+
+	/* Create Rx descriptor rings */
+	for (queue = 0; queue < rxq_number; queue++) {
+		struct mvpp2_rx_queue *rxq = port->rxqs[queue];
+
+		rxq->size = port->rx_ring_size;
+		rxq->pkts_coal = MVPP2_RX_COAL_PKTS;
+		rxq->time_coal = MVPP2_RX_COAL_USEC;
+	}
+
+	mvpp2_ingress_disable(port);
+
+	/* Port default configuration */
+	mvpp2_defaults_set(port);
+
+	/* Port's classifier configuration */
+	mvpp2_cls_oversize_rxq_set(port);
+	mvpp2_cls_port_config(port);
+
+	/* Provide an initial Rx packet size */
+	port->pkt_size = MVPP2_RX_PKT_SIZE(PKTSIZE_ALIGN);
+
+	/* Initialize pools for swf */
+	err = mvpp2_swf_bm_pool_init(port);
+	if (err)
+		return err;
+
+	return 0;
+}
+
+/* Ports initialization */
+static int mvpp2_port_probe(struct udevice *dev,
+			    struct mvpp2_port *port,
+			    int port_node,
+			    struct mvpp2 *priv,
+			    int *next_first_rxq)
+{
+	int phy_node;
+	u32 id;
+	u32 phyaddr;
+	const char *phy_mode_str;
+	int phy_mode = -1;
+	int priv_common_regs_num = 2;
+	int err;
+
+	phy_node = fdtdec_lookup_phandle(gd->fdt_blob, port_node, "phy");
+	if (phy_node < 0) {
+		dev_err(&pdev->dev, "missing phy\n");
+		return -ENODEV;
+	}
+
+	phy_mode_str = fdt_getprop(gd->fdt_blob, port_node, "phy-mode", NULL);
+	if (phy_mode_str)
+		phy_mode = phy_get_interface_by_name(phy_mode_str);
+	if (phy_mode == -1) {
+		dev_err(&pdev->dev, "incorrect phy mode\n");
+		return -EINVAL;
+	}
+
+	id = fdtdec_get_int(gd->fdt_blob, port_node, "port-id", -1);
+	if (id == -1) {
+		dev_err(&pdev->dev, "missing port-id value\n");
+		return -EINVAL;
+	}
+
+	phyaddr = fdtdec_get_int(gd->fdt_blob, phy_node, "reg", 0);
+
+	port->priv = priv;
+	port->id = id;
+	port->first_rxq = *next_first_rxq;
+	port->phy_node = phy_node;
+	port->phy_interface = phy_mode;
+	port->phyaddr = phyaddr;
+
+	port->base = (void __iomem *)dev_get_addr_index(dev->parent,
+							priv_common_regs_num
+							+ id);
+	if (IS_ERR(port->base))
+		return PTR_ERR(port->base);
+
+	port->tx_ring_size = MVPP2_MAX_TXD;
+	port->rx_ring_size = MVPP2_MAX_RXD;
+
+	err = mvpp2_port_init(dev, port);
+	if (err < 0) {
+		dev_err(&pdev->dev, "failed to init port %d\n", id);
+		return err;
+	}
+	mvpp2_port_power_up(port);
+
+	/* Increment the first Rx queue number to be used by the next port */
+	*next_first_rxq += CONFIG_MV_ETH_RXQ;
+	priv->port_list[id] = port;
+	return 0;
+}
+
+/* Initialize decoding windows */
+static void mvpp2_conf_mbus_windows(const struct mbus_dram_target_info *dram,
+				    struct mvpp2 *priv)
+{
+	u32 win_enable;
+	int i;
+
+	for (i = 0; i < 6; i++) {
+		mvpp2_write(priv, MVPP2_WIN_BASE(i), 0);
+		mvpp2_write(priv, MVPP2_WIN_SIZE(i), 0);
+
+		if (i < 4)
+			mvpp2_write(priv, MVPP2_WIN_REMAP(i), 0);
+	}
+
+	win_enable = 0;
+
+	for (i = 0; i < dram->num_cs; i++) {
+		const struct mbus_dram_window *cs = dram->cs + i;
+
+		mvpp2_write(priv, MVPP2_WIN_BASE(i),
+			    (cs->base & 0xffff0000) | (cs->mbus_attr << 8) |
+			    dram->mbus_dram_target_id);
+
+		mvpp2_write(priv, MVPP2_WIN_SIZE(i),
+			    (cs->size - 1) & 0xffff0000);
+
+		win_enable |= (1 << i);
+	}
+
+	mvpp2_write(priv, MVPP2_BASE_ADDR_ENABLE, win_enable);
+}
+
+/* Initialize Rx FIFO's */
+static void mvpp2_rx_fifo_init(struct mvpp2 *priv)
+{
+	int port;
+
+	for (port = 0; port < MVPP2_MAX_PORTS; port++) {
+		mvpp2_write(priv, MVPP2_RX_DATA_FIFO_SIZE_REG(port),
+			    MVPP2_RX_FIFO_PORT_DATA_SIZE);
+		mvpp2_write(priv, MVPP2_RX_ATTR_FIFO_SIZE_REG(port),
+			    MVPP2_RX_FIFO_PORT_ATTR_SIZE);
+	}
+
+	mvpp2_write(priv, MVPP2_RX_MIN_PKT_SIZE_REG,
+		    MVPP2_RX_FIFO_PORT_MIN_PKT);
+	mvpp2_write(priv, MVPP2_RX_FIFO_INIT_REG, 0x1);
+}
+
+/* Initialize network controller common part HW */
+static int mvpp2_init(struct udevice *dev, struct mvpp2 *priv)
+{
+	const struct mbus_dram_target_info *dram_target_info;
+	int err, i;
+	u32 val;
+
+	/* Checks for hardware constraints (U-Boot uses only one rxq) */
+	if ((rxq_number > MVPP2_MAX_RXQ) || (txq_number > MVPP2_MAX_TXQ)) {
+		dev_err(&pdev->dev, "invalid queue size parameter\n");
+		return -EINVAL;
+	}
+
+	/* MBUS windows configuration */
+	dram_target_info = mvebu_mbus_dram_info();
+	if (dram_target_info)
+		mvpp2_conf_mbus_windows(dram_target_info, priv);
+
+	/* Disable HW PHY polling */
+	val = readl(priv->lms_base + MVPP2_PHY_AN_CFG0_REG);
+	val |= MVPP2_PHY_AN_STOP_SMI0_MASK;
+	writel(val, priv->lms_base + MVPP2_PHY_AN_CFG0_REG);
+
+	/* Allocate and initialize aggregated TXQs */
+	priv->aggr_txqs = devm_kcalloc(dev, num_present_cpus(),
+				       sizeof(struct mvpp2_tx_queue),
+				       GFP_KERNEL);
+	if (!priv->aggr_txqs)
+		return -ENOMEM;
+
+	for_each_present_cpu(i) {
+		priv->aggr_txqs[i].id = i;
+		priv->aggr_txqs[i].size = MVPP2_AGGR_TXQ_SIZE;
+		err = mvpp2_aggr_txq_init(dev, &priv->aggr_txqs[i],
+					  MVPP2_AGGR_TXQ_SIZE, i, priv);
+		if (err < 0)
+			return err;
+	}
+
+	/* Rx Fifo Init */
+	mvpp2_rx_fifo_init(priv);
+
+	/* Reset Rx queue group interrupt configuration */
+	for (i = 0; i < MVPP2_MAX_PORTS; i++)
+		mvpp2_write(priv, MVPP2_ISR_RXQ_GROUP_REG(i),
+			    CONFIG_MV_ETH_RXQ);
+
+	writel(MVPP2_EXT_GLOBAL_CTRL_DEFAULT,
+	       priv->lms_base + MVPP2_MNG_EXTENDED_GLOBAL_CTRL_REG);
+
+	/* Allow cache snoop when transmiting packets */
+	mvpp2_write(priv, MVPP2_TX_SNOOP_REG, 0x1);
+
+	/* Buffer Manager initialization */
+	err = mvpp2_bm_init(dev, priv);
+	if (err < 0)
+		return err;
+
+	/* Parser default initialization */
+	err = mvpp2_prs_default_init(dev, priv);
+	if (err < 0)
+		return err;
+
+	/* Classifier default initialization */
+	mvpp2_cls_init(priv);
+
+	return 0;
+}
+
+/* SMI / MDIO functions */
+
+static int smi_wait_ready(struct mvpp2 *priv)
+{
+	u32 timeout = MVPP2_SMI_TIMEOUT;
+	u32 smi_reg;
+
+	/* wait till the SMI is not busy */
+	do {
+		/* read smi register */
+		smi_reg = readl(priv->lms_base + MVPP2_SMI);
+		if (timeout-- == 0) {
+			printf("Error: SMI busy timeout\n");
+			return -EFAULT;
+		}
+	} while (smi_reg & MVPP2_SMI_BUSY);
+
+	return 0;
+}
+
+/*
+ * mpp2_mdio_read - miiphy_read callback function.
+ *
+ * Returns 16bit phy register value, or 0xffff on error
+ */
+static int mpp2_mdio_read(struct mii_dev *bus, int addr, int devad, int reg)
+{
+	struct mvpp2 *priv = bus->priv;
+	u32 smi_reg;
+	u32 timeout;
+
+	/* check parameters */
+	if (addr > MVPP2_PHY_ADDR_MASK) {
+		printf("Error: Invalid PHY address %d\n", addr);
+		return -EFAULT;
+	}
+
+	if (reg > MVPP2_PHY_REG_MASK) {
+		printf("Err: Invalid register offset %d\n", reg);
+		return -EFAULT;
+	}
+
+	/* wait till the SMI is not busy */
+	if (smi_wait_ready(priv) < 0)
+		return -EFAULT;
+
+	/* fill the phy address and regiser offset and read opcode */
+	smi_reg = (addr << MVPP2_SMI_DEV_ADDR_OFFS)
+		| (reg << MVPP2_SMI_REG_ADDR_OFFS)
+		| MVPP2_SMI_OPCODE_READ;
+
+	/* write the smi register */
+	writel(smi_reg, priv->lms_base + MVPP2_SMI);
+
+	/* wait till read value is ready */
+	timeout = MVPP2_SMI_TIMEOUT;
+
+	do {
+		/* read smi register */
+		smi_reg = readl(priv->lms_base + MVPP2_SMI);
+		if (timeout-- == 0) {
+			printf("Err: SMI read ready timeout\n");
+			return -EFAULT;
+		}
+	} while (!(smi_reg & MVPP2_SMI_READ_VALID));
+
+	/* Wait for the data to update in the SMI register */
+	for (timeout = 0; timeout < MVPP2_SMI_TIMEOUT; timeout++)
+		;
+
+	return readl(priv->lms_base + MVPP2_SMI) & MVPP2_SMI_DATA_MASK;
+}
+
+/*
+ * mpp2_mdio_write - miiphy_write callback function.
+ *
+ * Returns 0 if write succeed, -EINVAL on bad parameters
+ * -ETIME on timeout
+ */
+static int mpp2_mdio_write(struct mii_dev *bus, int addr, int devad, int reg,
+			   u16 value)
+{
+	struct mvpp2 *priv = bus->priv;
+	u32 smi_reg;
+
+	/* check parameters */
+	if (addr > MVPP2_PHY_ADDR_MASK) {
+		printf("Error: Invalid PHY address %d\n", addr);
+		return -EFAULT;
+	}
+
+	if (reg > MVPP2_PHY_REG_MASK) {
+		printf("Err: Invalid register offset %d\n", reg);
+		return -EFAULT;
+	}
+
+	/* wait till the SMI is not busy */
+	if (smi_wait_ready(priv) < 0)
+		return -EFAULT;
+
+	/* fill the phy addr and reg offset and write opcode and data */
+	smi_reg = value << MVPP2_SMI_DATA_OFFS;
+	smi_reg |= (addr << MVPP2_SMI_DEV_ADDR_OFFS)
+		| (reg << MVPP2_SMI_REG_ADDR_OFFS);
+	smi_reg &= ~MVPP2_SMI_OPCODE_READ;
+
+	/* write the smi register */
+	writel(smi_reg, priv->lms_base + MVPP2_SMI);
+
+	return 0;
+}
+
+static int mvpp2_probe(struct udevice *dev)
+{
+	struct mvpp2_port *port = dev_get_priv(dev);
+	struct mvpp2 *priv;
+	struct mii_dev *bus;
+	void *bd_space;
+	int err;
+	u32 size = 0;
+	int i;
+
+	/*
+	 * This function is called multiple times. For each controller.
+	 * But we only need to do the main controller probing once. So
+	 * lets only do the port probing here, if called not for the
+	 * first time.
+	 */
+	if (buffer_loc.tx_descs) {
+		priv = buffer_loc.priv;
+		port->priv = priv;
+
+		err = mvpp2_port_probe(dev, port, dev->of_offset, priv,
+				       &buffer_loc.first_rxq);
+
+		return 0;
+	}
+
+	/*
+	 * U-Boot special buffer handling:
+	 *
+	 * Allocate buffer area for descs and rx_buffers. This is only
+	 * done once for all interfaces. As only one interface can
+	 * be active. Make this area DMA save by disabling the D-cache
+	 */
+
+	/* Align buffer area for descs and rx_buffers to 1MiB */
+	bd_space = memalign(1 << MMU_SECTION_SHIFT, BD_SPACE);
+	mmu_set_region_dcache_behaviour((u32)bd_space, BD_SPACE, DCACHE_OFF);
+
+	buffer_loc.aggr_tx_descs = (struct mvpp2_tx_desc *)bd_space;
+	size += MVPP2_AGGR_TXQ_SIZE * MVPP2_DESC_ALIGNED_SIZE;
+
+	buffer_loc.tx_descs = (struct mvpp2_tx_desc *)((u32)bd_space + size);
+	size += MVPP2_MAX_TXD * MVPP2_DESC_ALIGNED_SIZE;
+
+	buffer_loc.rx_descs = (struct mvpp2_rx_desc *)((u32)bd_space + size);
+	size += MVPP2_MAX_RXD * MVPP2_DESC_ALIGNED_SIZE;
+
+	for (i = 0; i < MVPP2_BM_POOLS_NUM; i++) {
+		buffer_loc.bm_pool[i] = (u32 *)((u32)bd_space + size);
+		size += MVPP2_BM_POOL_SIZE_MAX * sizeof(u32);
+	}
+
+	for (i = 0; i < MVPP2_BM_LONG_BUF_NUM; i++) {
+		buffer_loc.rx_buffer[i] = (u32 *)((u32)bd_space + size);
+		size += RX_BUFFER_SIZE;
+	}
+
+	/*
+	 * This is done only once, for the first controller that is
+	 * probed. Here the common structures are initialized.
+	 */
+	priv = calloc(1, sizeof(struct mvpp2));
+	if (!priv)
+		return -ENOMEM;
+
+	/* And save pointer to main mvpp2 struct */
+	port->priv = priv;
+	buffer_loc.priv = priv;
+
+	priv->base = (void *)dev_get_addr_index(dev->parent, 0);
+	if (IS_ERR(priv->base))
+		return PTR_ERR(priv->base);
+
+	priv->lms_base = (void *)dev_get_addr_index(dev->parent, 1);
+	if (IS_ERR(priv->lms_base))
+		return PTR_ERR(priv->lms_base);
+
+	/* Initialize network controller */
+	err = mvpp2_init(dev, priv);
+	if (err < 0) {
+		dev_err(&pdev->dev, "failed to initialize controller\n");
+		return err;
+	}
+
+	err = mvpp2_port_probe(dev, port, dev->of_offset, priv,
+			       &buffer_loc.first_rxq);
+
+	/*
+	 * Finally create and register the MDIO bus driver
+	 */
+	bus = mdio_alloc();
+	if (!bus) {
+		printf("Failed to allocate MDIO bus\n");
+		return -ENOMEM;
+	}
+
+	bus->read = mpp2_mdio_read;
+	bus->write = mpp2_mdio_write;
+	snprintf(bus->name, sizeof(bus->name), dev->name);
+	bus->priv = (void *)priv;
+	priv->bus = bus;
+
+	return mdio_register(bus);
+}
+
+static int mvpp2_recv(struct udevice *dev, int flags, uchar **packetp)
+{
+	struct mvpp2_port *port = dev_get_priv(dev);
+	struct mvpp2_rx_desc *rx_desc;
+	struct mvpp2_bm_pool *bm_pool;
+	dma_addr_t phys_addr;
+	u32 bm, rx_status;
+	int pool, rx_bytes, err;
+	int rx_received;
+	struct mvpp2_rx_queue *rxq;
+	u32 cause_rx_tx, cause_rx, cause_misc;
+	u8 *data;
+
+	cause_rx_tx = mvpp2_read(port->priv,
+				 MVPP2_ISR_RX_TX_CAUSE_REG(port->id));
+	cause_rx_tx &= ~MVPP2_CAUSE_TXQ_OCCUP_DESC_ALL_MASK;
+	cause_misc = cause_rx_tx & MVPP2_CAUSE_MISC_SUM_MASK;
+	if (!cause_rx_tx && !cause_misc)
+		return 0;
+
+	cause_rx = cause_rx_tx & MVPP2_CAUSE_RXQ_OCCUP_DESC_ALL_MASK;
+
+	/* Process RX packets */
+	cause_rx |= port->pending_cause_rx;
+	rxq = mvpp2_get_rx_queue(port, cause_rx);
+
+	/* Get number of received packets and clamp the to-do */
+	rx_received = mvpp2_rxq_received(port, rxq->id);
+
+	/* Return if no packets are received */
+	if (!rx_received)
+		return 0;
+
+	rx_desc = mvpp2_rxq_next_desc_get(rxq);
+	rx_status = rx_desc->status;
+	rx_bytes = rx_desc->data_size - MVPP2_MH_SIZE;
+	phys_addr = rx_desc->buf_phys_addr;
+
+	bm = mvpp2_bm_cookie_build(rx_desc);
+	pool = mvpp2_bm_cookie_pool_get(bm);
+	bm_pool = &port->priv->bm_pools[pool];
+
+	/* Check if buffer header is used */
+	if (rx_status & MVPP2_RXD_BUF_HDR)
+		return 0;
+
+	/* In case of an error, release the requested buffer pointer
+	 * to the Buffer Manager. This request process is controlled
+	 * by the hardware, and the information about the buffer is
+	 * comprised by the RX descriptor.
+	 */
+	if (rx_status & MVPP2_RXD_ERR_SUMMARY) {
+		mvpp2_rx_error(port, rx_desc);
+		/* Return the buffer to the pool */
+		mvpp2_pool_refill(port, bm, rx_desc->buf_phys_addr,
+				  rx_desc->buf_cookie);
+		return 0;
+	}
+
+	err = mvpp2_rx_refill(port, bm_pool, bm, phys_addr);
+	if (err) {
+		netdev_err(port->dev, "failed to refill BM pools\n");
+		return 0;
+	}
+
+	/* Update Rx queue management counters */
+	mb();
+	mvpp2_rxq_status_update(port, rxq->id, 1, 1);
+
+	/* give packet to stack - skip on first n bytes */
+	data = (u8 *)phys_addr + 2 + 32;
+
+	if (rx_bytes <= 0)
+		return 0;
+
+	/*
+	 * No cache invalidation needed here, since the rx_buffer's are
+	 * located in a uncached memory region
+	 */
+	*packetp = data;
+
+	return rx_bytes;
+}
+
+/* Drain Txq */
+static void mvpp2_txq_drain(struct mvpp2_port *port, struct mvpp2_tx_queue *txq,
+			    int enable)
+{
+	u32 val;
+
+	mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
+	val = mvpp2_read(port->priv, MVPP2_TXQ_PREF_BUF_REG);
+	if (enable)
+		val |= MVPP2_TXQ_DRAIN_EN_MASK;
+	else
+		val &= ~MVPP2_TXQ_DRAIN_EN_MASK;
+	mvpp2_write(port->priv, MVPP2_TXQ_PREF_BUF_REG, val);
+}
+
+static int mvpp2_send(struct udevice *dev, void *packet, int length)
+{
+	struct mvpp2_port *port = dev_get_priv(dev);
+	struct mvpp2_tx_queue *txq, *aggr_txq;
+	struct mvpp2_tx_desc *tx_desc;
+	int tx_done;
+	int timeout;
+
+	txq = port->txqs[0];
+	aggr_txq = &port->priv->aggr_txqs[smp_processor_id()];
+
+	/* Get a descriptor for the first part of the packet */
+	tx_desc = mvpp2_txq_next_desc_get(aggr_txq);
+	tx_desc->phys_txq = txq->id;
+	tx_desc->data_size = length;
+	tx_desc->packet_offset = (u32)packet & MVPP2_TX_DESC_ALIGN;
+	tx_desc->buf_phys_addr = (u32)packet & ~MVPP2_TX_DESC_ALIGN;
+	/* First and Last descriptor */
+	tx_desc->command = MVPP2_TXD_L4_CSUM_NOT | MVPP2_TXD_IP_CSUM_DISABLE
+		| MVPP2_TXD_F_DESC | MVPP2_TXD_L_DESC;
+
+	/* Flush tx data */
+	flush_dcache_range((u32)packet, (u32)packet + length);
+
+	/* Enable transmit */
+	mb();
+	mvpp2_aggr_txq_pend_desc_add(port, 1);
+
+	mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
+
+	timeout = 0;
+	do {
+		if (timeout++ > 10000) {
+			printf("timeout: packet not sent from aggregated to phys TXQ\n");
+			return 0;
+		}
+		tx_done = mvpp2_txq_pend_desc_num_get(port, txq);
+	} while (tx_done);
+
+	/* Enable TXQ drain */
+	mvpp2_txq_drain(port, txq, 1);
+
+	timeout = 0;
+	do {
+		if (timeout++ > 10000) {
+			printf("timeout: packet not sent\n");
+			return 0;
+		}
+		tx_done = mvpp2_txq_sent_desc_proc(port, txq);
+	} while (!tx_done);
+
+	/* Disable TXQ drain */
+	mvpp2_txq_drain(port, txq, 0);
+
+	return 0;
+}
+
+static int mvpp2_start(struct udevice *dev)
+{
+	struct eth_pdata *pdata = dev_get_platdata(dev);
+	struct mvpp2_port *port = dev_get_priv(dev);
+
+	/* Load current MAC address */
+	memcpy(port->dev_addr, pdata->enetaddr, ETH_ALEN);
+
+	/* Reconfigure parser accept the original MAC address */
+	mvpp2_prs_update_mac_da(port, port->dev_addr);
+
+	mvpp2_port_power_up(port);
+
+	mvpp2_open(dev, port);
+
+	return 0;
+}
+
+static void mvpp2_stop(struct udevice *dev)
+{
+	struct mvpp2_port *port = dev_get_priv(dev);
+
+	mvpp2_stop_dev(port);
+	mvpp2_cleanup_rxqs(port);
+	mvpp2_cleanup_txqs(port);
+}
+
+static const struct eth_ops mvpp2_ops = {
+	.start		= mvpp2_start,
+	.send		= mvpp2_send,
+	.recv		= mvpp2_recv,
+	.stop		= mvpp2_stop,
+};
+
+static struct driver mvpp2_driver = {
+	.name	= "mvpp2",
+	.id	= UCLASS_ETH,
+	.probe	= mvpp2_probe,
+	.ops	= &mvpp2_ops,
+	.priv_auto_alloc_size = sizeof(struct mvpp2_port),
+	.platdata_auto_alloc_size = sizeof(struct eth_pdata),
+};
+
+/*
+ * Use a MISC device to bind the n instances (child nodes) of the
+ * network base controller in UCLASS_ETH.
+ */
+static int mvpp2_base_bind(struct udevice *parent)
+{
+	const void *blob = gd->fdt_blob;
+	int node = parent->of_offset;
+	struct uclass_driver *drv;
+	struct udevice *dev;
+	struct eth_pdata *plat;
+	char *name;
+	int subnode;
+	u32 id;
+
+	/* Lookup eth driver */
+	drv = lists_uclass_lookup(UCLASS_ETH);
+	if (!drv) {
+		puts("Cannot find eth driver\n");
+		return -ENOENT;
+	}
+
+	fdt_for_each_subnode(blob, subnode, node) {
+		/* Skip disabled ports */
+		if (!fdtdec_get_is_enabled(blob, subnode))
+			continue;
+
+		plat = calloc(1, sizeof(*plat));
+		if (!plat)
+			return -ENOMEM;
+
+		id = fdtdec_get_int(blob, subnode, "port-id", -1);
+
+		name = calloc(1, 16);
+		sprintf(name, "mvpp2-%d", id);
+
+		/* Create child device UCLASS_ETH and bind it */
+		device_bind(parent, &mvpp2_driver, name, plat, subnode, &dev);
+		dev->of_offset = subnode;
+	}
+
+	return 0;
+}
+
+static const struct udevice_id mvpp2_ids[] = {
+	{ .compatible = "marvell,armada-375-pp2" },
+	{ }
+};
+
+U_BOOT_DRIVER(mvpp2_base) = {
+	.name	= "mvpp2_base",
+	.id	= UCLASS_MISC,
+	.of_match = mvpp2_ids,
+	.bind	= mvpp2_base_bind,
+};
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 3/6] dt-bindings: Add include/dt-bindings/phy/phy.h from Linux v4.4
  2016-03-15 16:35 [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375 Stefan Roese
  2016-03-15 16:35 ` [U-Boot] [PATCH 2/6] net: mvpp2.c: Add Marvell mvpp2 network driver " Stefan Roese
@ 2016-03-15 16:35 ` Stefan Roese
  2016-04-04 12:01   ` Stefan Roese
  2016-03-15 16:35 ` [U-Boot] [PATCH 4/6] arm: mvebu: Add basic support for the Marvell Armada 375 SoC Stefan Roese
                   ` (4 subsequent siblings)
  6 siblings, 1 reply; 16+ messages in thread
From: Stefan Roese @ 2016-03-15 16:35 UTC (permalink / raw)
  To: u-boot

This will be needed by the upcoming Marvell Armada 375 dts files.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Luka Perkov <luka.perkov@sartura.hr>
---
 include/dt-bindings/phy/phy.h | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 include/dt-bindings/phy/phy.h

diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h
new file mode 100644
index 0000000..6c90193
--- /dev/null
+++ b/include/dt-bindings/phy/phy.h
@@ -0,0 +1,19 @@
+/*
+ *
+ * This header provides constants for the phy framework
+ *
+ * Copyright (C) 2014 STMicroelectronics
+ * Author: Gabriel Fernandez <gabriel.fernandez@st.com>
+ * License terms:  GNU General Public License (GPL), version 2
+ */
+
+#ifndef _DT_BINDINGS_PHY
+#define _DT_BINDINGS_PHY
+
+#define PHY_NONE		0
+#define PHY_TYPE_SATA		1
+#define PHY_TYPE_PCIE		2
+#define PHY_TYPE_USB2		3
+#define PHY_TYPE_USB3		4
+
+#endif /* _DT_BINDINGS_PHY */
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 4/6] arm: mvebu: Add basic support for the Marvell Armada 375 SoC
  2016-03-15 16:35 [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375 Stefan Roese
  2016-03-15 16:35 ` [U-Boot] [PATCH 2/6] net: mvpp2.c: Add Marvell mvpp2 network driver " Stefan Roese
  2016-03-15 16:35 ` [U-Boot] [PATCH 3/6] dt-bindings: Add include/dt-bindings/phy/phy.h from Linux v4.4 Stefan Roese
@ 2016-03-15 16:35 ` Stefan Roese
  2016-04-04 12:01   ` Stefan Roese
  2016-03-15 16:35 ` [U-Boot] [PATCH 5/6] arm: mvebu: Add basic support for Armada 375 eval board db-88f6720 Stefan Roese
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 16+ messages in thread
From: Stefan Roese @ 2016-03-15 16:35 UTC (permalink / raw)
  To: u-boot

This patch adds basic support for the Armada 375. Please note that
currently the SerDes and DDR3 init code for the A375 is not
included / enabled. This will be done in a later, follow-up patch.

Right now, this A375 mainline U-Boot can only be used by chainloading
it via the original Marvell U-Boot. This can be done via this
command:

=> tftpboot 00800000 a375/u-boot-dtb.bin;go 00800000

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Luka Perkov <luka.perkov@sartura.hr>
---
 arch/arm/mach-mvebu/Makefile              |  1 +
 arch/arm/mach-mvebu/cpu.c                 | 64 +++++++++++++++++++++++++++++--
 arch/arm/mach-mvebu/include/mach/config.h |  5 ++-
 arch/arm/mach-mvebu/include/mach/cpu.h    |  5 +++
 arch/arm/mach-mvebu/include/mach/soc.h    | 19 ++++++++-
 arch/arm/mach-mvebu/spl.c                 |  3 ++
 6 files changed, 92 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
index b96b81b..ac009a3 100644
--- a/arch/arm/mach-mvebu/Makefile
+++ b/arch/arm/mach-mvebu/Makefile
@@ -15,6 +15,7 @@ else
 obj-y	= cpu.o
 obj-y	+= dram.o
 ifndef CONFIG_SPL_BUILD
+obj-$(CONFIG_ARMADA_375) += ../../../drivers/ddr/marvell/axp/xor.o
 obj-$(CONFIG_ARMADA_38X) += ../../../drivers/ddr/marvell/a38x/xor.o
 obj-$(CONFIG_ARMADA_XP) += ../../../drivers/ddr/marvell/axp/xor.o
 endif
diff --git a/arch/arm/mach-mvebu/cpu.c b/arch/arm/mach-mvebu/cpu.c
index 30b175c..9913802 100644
--- a/arch/arm/mach-mvebu/cpu.c
+++ b/arch/arm/mach-mvebu/cpu.c
@@ -54,17 +54,57 @@ int mvebu_soc_family(void)
 	case SOC_MV78260_ID:
 	case SOC_MV78460_ID:
 		return MVEBU_SOC_AXP;
+
+	case SOC_88F6720_ID:
+		return MVEBU_SOC_A375;
+
 	case SOC_88F6810_ID:
 	case SOC_88F6820_ID:
 	case SOC_88F6828_ID:
 		return MVEBU_SOC_A38X;
 	}
+
 	return MVEBU_SOC_UNKNOWN;
 }
 
 #if defined(CONFIG_DISPLAY_CPUINFO)
 
-#if defined(CONFIG_ARMADA_38X)
+#if defined(CONFIG_ARMADA_375)
+/* SAR frequency values for Armada 375 */
+static const struct sar_freq_modes sar_freq_tab[] = {
+	{  0,  0x0,  266,  133,  266 },
+	{  1,  0x0,  333,  167,  167 },
+	{  2,  0x0,  333,  167,  222 },
+	{  3,  0x0,  333,  167,  333 },
+	{  4,  0x0,  400,  200,  200 },
+	{  5,  0x0,  400,  200,  267 },
+	{  6,  0x0,  400,  200,  400 },
+	{  7,  0x0,  500,  250,  250 },
+	{  8,  0x0,  500,  250,  334 },
+	{  9,  0x0,  500,  250,  500 },
+	{ 10,  0x0,  533,  267,  267 },
+	{ 11,  0x0,  533,  267,  356 },
+	{ 12,  0x0,  533,  267,  533 },
+	{ 13,  0x0,  600,  300,  300 },
+	{ 14,  0x0,  600,  300,  400 },
+	{ 15,  0x0,  600,  300,  600 },
+	{ 16,  0x0,  666,  333,  333 },
+	{ 17,  0x0,  666,  333,  444 },
+	{ 18,  0x0,  666,  333,  666 },
+	{ 19,  0x0,  800,  400,  267 },
+	{ 20,  0x0,  800,  400,  400 },
+	{ 21,  0x0,  800,  400,  534 },
+	{ 22,  0x0,  900,  450,  300 },
+	{ 23,  0x0,  900,  450,  450 },
+	{ 24,  0x0,  900,  450,  600 },
+	{ 25,  0x0, 1000,  500,  500 },
+	{ 26,  0x0, 1000,  500,  667 },
+	{ 27,  0x0, 1000,  333,  500 },
+	{ 28,  0x0,  400,  400,  400 },
+	{ 29,  0x0, 1100,  550,  550 },
+	{ 0xff, 0xff,    0,   0,   0 }	/* 0xff marks end of array */
+};
+#elif defined(CONFIG_ARMADA_38X)
 /* SAR frequency values for Armada 38x */
 static const struct sar_freq_modes sar_freq_tab[] = {
 	{  0x0,  0x0,  666, 333, 333 },
@@ -98,9 +138,13 @@ void get_sar_freq(struct sar_freq_modes *sar_freq)
 	u32 freq;
 	int i;
 
+#if defined(CONFIG_ARMADA_375)
+	val = readl(CONFIG_SAR2_REG);	/* SAR - Sample At Reset */
+#else
 	val = readl(CONFIG_SAR_REG);	/* SAR - Sample At Reset */
+#endif
 	freq = (val & SAR_CPU_FREQ_MASK) >> SAR_CPU_FREQ_OFFS;
-#if !defined(CONFIG_ARMADA_38X)
+#if defined(SAR2_CPU_FREQ_MASK)
 	/*
 	 * Shift CPU0 clock frequency select bit from SAR2 register
 	 * into correct position
@@ -110,7 +154,7 @@ void get_sar_freq(struct sar_freq_modes *sar_freq)
 #endif
 	for (i = 0; sar_freq_tab[i].val != 0xff; i++) {
 		if (sar_freq_tab[i].val == freq) {
-#if defined(CONFIG_ARMADA_38X)
+#if defined(CONFIG_ARMADA_375) || defined(CONFIG_ARMADA_38X)
 			*sar_freq = sar_freq_tab[i];
 			return;
 #else
@@ -152,6 +196,9 @@ int print_cpuinfo(void)
 	case SOC_MV78460_ID:
 		puts("MV78460-");
 		break;
+	case SOC_88F6720_ID:
+		puts("MV88F6720-");
+		break;
 	case SOC_88F6810_ID:
 		puts("MV88F6810-");
 		break;
@@ -180,6 +227,17 @@ int print_cpuinfo(void)
 		}
 	}
 
+	if (mvebu_soc_family() == MVEBU_SOC_A375) {
+		switch (revid) {
+		case MV_88F67XX_A0_ID:
+			puts("A0");
+			break;
+		default:
+			printf("?? (%x)", revid);
+			break;
+		}
+	}
+
 	if (mvebu_soc_family() == MVEBU_SOC_A38X) {
 		switch (revid) {
 		case MV_88F68XX_Z1_ID:
diff --git a/arch/arm/mach-mvebu/include/mach/config.h b/arch/arm/mach-mvebu/include/mach/config.h
index cc1fc5f..b8a8c62 100644
--- a/arch/arm/mach-mvebu/include/mach/config.h
+++ b/arch/arm/mach-mvebu/include/mach/config.h
@@ -17,7 +17,8 @@
 
 #include <asm/arch/soc.h>
 
-#if defined(CONFIG_ARMADA_XP) || defined(CONFIG_ARMADA_38X)
+#if defined(CONFIG_ARMADA_XP) || defined(CONFIG_ARMADA_375) \
+	|| defined(CONFIG_ARMADA_38X)
 /*
  * Set this for the common xor register definitions needed in dram.c
  * for A38x as well here.
@@ -78,8 +79,10 @@
 #ifdef CONFIG_CMD_NET
 #define CONFIG_CMD_MII
 #define CONFIG_MII		/* expose smi ove miiphy interface */
+#if !defined(CONFIG_ARMADA_375)
 #define CONFIG_MVNETA		/* Enable Marvell Gbe Controller Driver */
 #define CONFIG_PHYLIB
+#endif
 #define CONFIG_ENV_OVERWRITE	/* ethaddr can be reprogrammed */
 #define CONFIG_PHY_GIGE		/* GbE speed/duplex detect */
 #define CONFIG_ARP_TIMEOUT	200
diff --git a/arch/arm/mach-mvebu/include/mach/cpu.h b/arch/arm/mach-mvebu/include/mach/cpu.h
index 017d55f..b71574d 100644
--- a/arch/arm/mach-mvebu/include/mach/cpu.h
+++ b/arch/arm/mach-mvebu/include/mach/cpu.h
@@ -58,6 +58,7 @@ enum cpu_attrib {
 
 enum {
 	MVEBU_SOC_AXP,
+	MVEBU_SOC_A375,
 	MVEBU_SOC_A38X,
 	MVEBU_SOC_UNKNOWN,
 };
@@ -86,7 +87,11 @@ struct mbus_win {
  * Ref: Datasheet sec:A.28
  */
 struct mvebu_system_registers {
+#if defined(CONFIG_ARMADA_375)
+	u8 pad1[0x54];
+#else
 	u8 pad1[0x60];
+#endif
 	u32 rstoutn_mask; /* 0x60 */
 	u32 sys_soft_rst; /* 0x64 */
 };
diff --git a/arch/arm/mach-mvebu/include/mach/soc.h b/arch/arm/mach-mvebu/include/mach/soc.h
index b317940..a12be2a 100644
--- a/arch/arm/mach-mvebu/include/mach/soc.h
+++ b/arch/arm/mach-mvebu/include/mach/soc.h
@@ -14,10 +14,14 @@
 #define SOC_MV78230_ID		0x7823
 #define SOC_MV78260_ID		0x7826
 #define SOC_MV78460_ID		0x7846
+#define SOC_88F6720_ID		0x6720
 #define SOC_88F6810_ID		0x6810
 #define SOC_88F6820_ID		0x6820
 #define SOC_88F6828_ID		0x6828
 
+/* A375 revisions */
+#define MV_88F67XX_A0_ID	0x3
+
 /* A38x revisions */
 #define MV_88F68XX_Z1_ID	0x0
 #define MV_88F68XX_A0_ID	0x4
@@ -106,7 +110,20 @@
 #define BOOTROM_ERR_MODE_MASK	(0xf << BOOTROM_ERR_MODE_OFFS)
 #define BOOTROM_ERR_MODE_UART	0x6
 
-#if defined(CONFIG_ARMADA_38X)
+#if defined(CONFIG_ARMADA_375)
+/* SAR values for Armada 375 */
+#define CONFIG_SAR_REG		(MVEBU_REGISTER(0xe8200))
+#define CONFIG_SAR2_REG		(MVEBU_REGISTER(0xe8204))
+
+#define SAR_CPU_FREQ_OFFS	17
+#define SAR_CPU_FREQ_MASK	(0x1f << SAR_CPU_FREQ_OFFS)
+
+#define BOOT_DEV_SEL_OFFS	3
+#define BOOT_DEV_SEL_MASK	(0x3f << BOOT_DEV_SEL_OFFS)
+
+#define BOOT_FROM_UART		0x30
+#define BOOT_FROM_SPI		0x38
+#elif defined(CONFIG_ARMADA_38X)
 /* SAR values for Armada 38x */
 #define CONFIG_SAR_REG		(MVEBU_REGISTER(0x18600))
 
diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
index 0879873..ac5bb2c 100644
--- a/arch/arm/mach-mvebu/spl.c
+++ b/arch/arm/mach-mvebu/spl.c
@@ -99,11 +99,14 @@ void board_init_f(ulong dummy)
 
 	timer_init();
 
+	/* Armada 375 does not support SerDes and DDR3 init yet */
+#if !defined(CONFIG_ARMADA_375)
 	/* First init the serdes PHY's */
 	serdes_phy_config();
 
 	/* Setup DDR */
 	ddr3_init();
+#endif
 
 	/*
 	 * Return to the BootROM to continue the Marvell xmodem
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 5/6] arm: mvebu: Add basic support for Armada 375 eval board db-88f6720
  2016-03-15 16:35 [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375 Stefan Roese
                   ` (2 preceding siblings ...)
  2016-03-15 16:35 ` [U-Boot] [PATCH 4/6] arm: mvebu: Add basic support for the Marvell Armada 375 SoC Stefan Roese
@ 2016-03-15 16:35 ` Stefan Roese
  2016-04-04 12:01   ` Stefan Roese
  2016-03-15 16:35 ` [U-Boot] [PATCH 6/6] arm: mvebu: Don't enable d-cache on A375 Stefan Roese
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 16+ messages in thread
From: Stefan Roese @ 2016-03-15 16:35 UTC (permalink / raw)
  To: u-boot

This patch adds basic support for the Marvell A375 eval board. Tested
are the following interfaces:
- I2C
- SPI
- SPI NOR
- Ethernet (mvpp2), port 0 & 1

Currently the A375 SerDes and DDR3 init code is not intergrated. So
the SPL U-Boot is not fully functional.

Right now, this A375 mainline U-Boot can only be used by chainloading
it via the original Marvell U-Boot. This can be done via this
command:

=> tftpboot 00800000 a375/u-boot-dtb.bin;go 00800000

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Luka Perkov <luka.perkov@sartura.hr>
---
 arch/arm/Kconfig                      |   2 +-
 arch/arm/dts/Makefile                 |   1 +
 arch/arm/dts/armada-375-db.dts        | 216 +++++++++++
 arch/arm/dts/armada-375.dtsi          | 658 ++++++++++++++++++++++++++++++++++
 arch/arm/mach-mvebu/Kconfig           |  12 +-
 board/Marvell/db-88f6720/MAINTAINERS  |   6 +
 board/Marvell/db-88f6720/Makefile     |   7 +
 board/Marvell/db-88f6720/db-88f6720.c |  91 +++++
 board/Marvell/db-88f6720/kwbimage.cfg |  12 +
 configs/db-88f6720_defconfig          |  28 ++
 include/configs/db-88f6720.h          | 120 +++++++
 11 files changed, 1151 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/dts/armada-375-db.dts
 create mode 100644 arch/arm/dts/armada-375.dtsi
 create mode 100644 board/Marvell/db-88f6720/MAINTAINERS
 create mode 100644 board/Marvell/db-88f6720/Makefile
 create mode 100644 board/Marvell/db-88f6720/db-88f6720.c
 create mode 100644 board/Marvell/db-88f6720/kwbimage.cfg
 create mode 100644 configs/db-88f6720_defconfig
 create mode 100644 include/configs/db-88f6720.h

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 653ecc8..26e4e7f 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -111,7 +111,7 @@ config KIRKWOOD
 	select CPU_ARM926EJS
 
 config ARCH_MVEBU
-	bool "Marvell MVEBU family (Armada XP/38x)"
+	bool "Marvell MVEBU family (Armada XP/375/38x)"
 	select CPU_V7
 	select SUPPORT_SPL
 	select OF_CONTROL
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 578038b..c37f24e 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -49,6 +49,7 @@ dtb-$(CONFIG_TEGRA) += tegra20-harmony.dtb \
 	tegra210-p2571.dtb
 
 dtb-$(CONFIG_ARCH_MVEBU) +=			\
+	armada-375-db.dtb			\
 	armada-388-clearfog.dtb			\
 	armada-388-gp.dtb			\
 	armada-xp-gp.dtb			\
diff --git a/arch/arm/dts/armada-375-db.dts b/arch/arm/dts/armada-375-db.dts
new file mode 100644
index 0000000..343349b
--- /dev/null
+++ b/arch/arm/dts/armada-375-db.dts
@@ -0,0 +1,216 @@
+/*
+ * Device Tree file for Marvell Armada 375 evaluation board
+ * (DB-88F6720)
+ *
+ *  Copyright (C) 2014 Marvell
+ *
+ * Gregory CLEMENT <gregory.clement@free-electrons.com>
+ * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+#include "armada-375.dtsi"
+
+/ {
+	model = "Marvell Armada 375 Development Board";
+	compatible = "marvell,a375-db", "marvell,armada375";
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	aliases {
+		/* So that mvebu u-boot can update the MAC addresses */
+		ethernet0 = &eth0;
+		ethernet1 = &eth1;
+		spi0 = &spi0;
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0x40000000>; /* 1 GB */
+	};
+
+	soc {
+		ranges = <MBUS_ID(0xf0, 0x01) 0 0xf1000000 0x100000
+			  MBUS_ID(0x01, 0x1d) 0 0xfff00000 0x100000
+			  MBUS_ID(0x09, 0x09) 0 0xf1100000 0x10000
+			  MBUS_ID(0x09, 0x05) 0 0xf1110000 0x10000>;
+
+		internal-regs {
+			spi at 10600 {
+				pinctrl-0 = <&spi0_pins>;
+				pinctrl-names = "default";
+				/*
+				 * SPI conflicts with NAND, so we disable it
+				 * here, and select NAND as the enabled device
+				 * by default.
+				 */
+				status = "okay";
+				u-boot,dm-pre-reloc;
+
+				spi-flash at 0 {
+					u-boot,dm-pre-reloc;
+					#address-cells = <1>;
+					#size-cells = <1>;
+					compatible = "n25q128a13", "jedec,spi-nor";
+					reg = <0>; /* Chip select 0 */
+					spi-max-frequency = <108000000>;
+				};
+			};
+
+			i2c at 11000 {
+				status = "okay";
+				clock-frequency = <100000>;
+				pinctrl-0 = <&i2c0_pins>;
+				pinctrl-names = "default";
+			};
+
+			i2c at 11100 {
+				status = "okay";
+				clock-frequency = <100000>;
+				pinctrl-0 = <&i2c1_pins>;
+				pinctrl-names = "default";
+			};
+
+			serial at 12000 {
+				u-boot,dm-pre-reloc;
+				status = "okay";
+			};
+
+			pinctrl {
+				sdio_st_pins: sdio-st-pins {
+					marvell,pins = "mpp44", "mpp45";
+					marvell,function = "gpio";
+				};
+			};
+
+			sata at a0000 {
+				status = "okay";
+				nr-ports = <2>;
+			};
+
+			nand: nand at d0000 {
+				pinctrl-0 = <&nand_pins>;
+				pinctrl-names = "default";
+				status = "okay";
+				num-cs = <1>;
+				marvell,nand-keep-config;
+				marvell,nand-enable-arbiter;
+				nand-on-flash-bbt;
+				nand-ecc-strength = <4>;
+				nand-ecc-step-size = <512>;
+
+				partition at 0 {
+					label = "U-Boot";
+					reg = <0 0x800000>;
+				};
+				partition at 800000 {
+					label = "Linux";
+					reg = <0x800000 0x800000>;
+				};
+				partition at 1000000 {
+					label = "Filesystem";
+					reg = <0x1000000 0x3f000000>;
+				};
+			};
+
+			usb at 54000 {
+				status = "okay";
+			};
+
+			usb3 at 58000 {
+				status = "okay";
+			};
+
+			mvsdio at d4000 {
+				pinctrl-0 = <&sdio_pins &sdio_st_pins>;
+				pinctrl-names = "default";
+				status = "okay";
+				cd-gpios = <&gpio1 12 GPIO_ACTIVE_HIGH>;
+				wp-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
+			};
+
+			mdio {
+				phy0: ethernet-phy at 0 {
+					reg = <0>;
+				};
+
+				phy3: ethernet-phy at 3 {
+					reg = <3>;
+				};
+			};
+
+			ethernet at f0000 {
+				status = "okay";
+
+				eth0 at c4000 {
+					status = "okay";
+					phy = <&phy0>;
+					phy-mode = "rgmii-id";
+				};
+
+				eth1 at c5000 {
+					status = "okay";
+					phy = <&phy3>;
+					phy-mode = "gmii";
+				};
+			};
+		};
+
+		pcie-controller {
+			status = "okay";
+			/*
+			 * The two PCIe units are accessible through
+			 * standard PCIe slots on the board.
+			 */
+			pcie at 1,0 {
+				/* Port 0, Lane 0 */
+				status = "okay";
+			};
+			pcie at 2,0 {
+				/* Port 1, Lane 0 */
+				status = "okay";
+			};
+		};
+	};
+};
diff --git a/arch/arm/dts/armada-375.dtsi b/arch/arm/dts/armada-375.dtsi
new file mode 100644
index 0000000..249c41c
--- /dev/null
+++ b/arch/arm/dts/armada-375.dtsi
@@ -0,0 +1,658 @@
+/*
+ * Device Tree Include file for Marvell Armada 375 family SoC
+ *
+ * Copyright (C) 2014 Marvell
+ *
+ * Gregory CLEMENT <gregory.clement@free-electrons.com>
+ * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "skeleton.dtsi"
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/phy/phy.h>
+
+#define MBUS_ID(target,attributes) (((target) << 24) | ((attributes) << 16))
+
+/ {
+	model = "Marvell Armada 375 family SoC";
+	compatible = "marvell,armada375";
+
+	aliases {
+		gpio0 = &gpio0;
+		gpio1 = &gpio1;
+		gpio2 = &gpio2;
+		serial0 = &uart0;
+		serial1 = &uart1;
+	};
+
+	clocks {
+		/* 2 GHz fixed main PLL */
+		mainpll: mainpll {
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <1000000000>;
+		};
+		/* 25 MHz reference crystal */
+		refclk: oscillator {
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <25000000>;
+		};
+	};
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		enable-method = "marvell,armada-375-smp";
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <0>;
+		};
+		cpu at 1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <1>;
+		};
+	};
+
+	pmu {
+		compatible = "arm,cortex-a9-pmu";
+		interrupts-extended = <&mpic 3>;
+	};
+
+	soc {
+		compatible = "marvell,armada375-mbus", "simple-bus";
+		u-boot,dm-pre-reloc;
+		#address-cells = <2>;
+		#size-cells = <1>;
+		controller = <&mbusc>;
+		interrupt-parent = <&gic>;
+		pcie-mem-aperture = <0xe0000000 0x8000000>;
+		pcie-io-aperture  = <0xe8000000 0x100000>;
+
+		bootrom {
+			compatible = "marvell,bootrom";
+			reg = <MBUS_ID(0x01, 0x1d) 0 0x100000>;
+		};
+
+		devbus-bootcs {
+			compatible = "marvell,mvebu-devbus";
+			reg = <MBUS_ID(0xf0, 0x01) 0x10400 0x8>;
+			ranges = <0 MBUS_ID(0x01, 0x2f) 0 0xffffffff>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			clocks = <&coreclk 0>;
+			status = "disabled";
+		};
+
+		devbus-cs0 {
+			compatible = "marvell,mvebu-devbus";
+			reg = <MBUS_ID(0xf0, 0x01) 0x10408 0x8>;
+			ranges = <0 MBUS_ID(0x01, 0x3e) 0 0xffffffff>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			clocks = <&coreclk 0>;
+			status = "disabled";
+		};
+
+		devbus-cs1 {
+			compatible = "marvell,mvebu-devbus";
+			reg = <MBUS_ID(0xf0, 0x01) 0x10410 0x8>;
+			ranges = <0 MBUS_ID(0x01, 0x3d) 0 0xffffffff>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			clocks = <&coreclk 0>;
+			status = "disabled";
+		};
+
+		devbus-cs2 {
+			compatible = "marvell,mvebu-devbus";
+			reg = <MBUS_ID(0xf0, 0x01) 0x10418 0x8>;
+			ranges = <0 MBUS_ID(0x01, 0x3b) 0 0xffffffff>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			clocks = <&coreclk 0>;
+			status = "disabled";
+		};
+
+		devbus-cs3 {
+			compatible = "marvell,mvebu-devbus";
+			reg = <MBUS_ID(0xf0, 0x01) 0x10420 0x8>;
+			ranges = <0 MBUS_ID(0x01, 0x37) 0 0xffffffff>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			clocks = <&coreclk 0>;
+			status = "disabled";
+		};
+
+		internal-regs {
+			compatible = "simple-bus";
+			u-boot,dm-pre-reloc;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>;
+
+			L2: cache-controller at 8000 {
+				compatible = "arm,pl310-cache";
+				reg = <0x8000 0x1000>;
+				cache-unified;
+				cache-level = <2>;
+				arm,double-linefill-incr = <1>;
+				arm,double-linefill-wrap = <0>;
+				arm,double-linefill = <1>;
+				prefetch-data = <1>;
+			};
+
+			scu at c000 {
+				compatible = "arm,cortex-a9-scu";
+				reg = <0xc000 0x58>;
+			};
+
+			timer at c600 {
+				compatible = "arm,cortex-a9-twd-timer";
+				reg = <0xc600 0x20>;
+				interrupts = <GIC_PPI 13 (IRQ_TYPE_EDGE_RISING | GIC_CPU_MASK_SIMPLE(2))>;
+				clocks = <&coreclk 2>;
+			};
+
+			gic: interrupt-controller at d000 {
+				compatible = "arm,cortex-a9-gic";
+				#interrupt-cells = <3>;
+				#size-cells = <0>;
+				interrupt-controller;
+				reg = <0xd000 0x1000>,
+				      <0xc100 0x100>;
+			};
+
+			mdio {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "marvell,orion-mdio";
+				reg = <0xc0054 0x4>;
+				clocks = <&gateclk 19>;
+			};
+
+			/* Network controller */
+			ethernet at f0000 {
+				compatible = "marvell,armada-375-pp2";
+				reg = <0xf0000 0xa000>, /* Packet Processor regs */
+				      <0xc0000 0x3060>, /* LMS regs */
+				      <0xc4000 0x100>,  /* eth0 regs */
+				      <0xc5000 0x100>;  /* eth1 regs */
+				clocks = <&gateclk 3>, <&gateclk 19>;
+				clock-names = "pp_clk", "gop_clk";
+				status = "disabled";
+
+				eth0: eth0 at c4000 {
+					interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
+					port-id = <0>;
+					status = "disabled";
+				};
+
+				eth1: eth1 at c5000 {
+					interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
+					port-id = <1>;
+					status = "disabled";
+				};
+			};
+
+			rtc at 10300 {
+				compatible = "marvell,orion-rtc";
+				reg = <0x10300 0x20>;
+				interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
+			spi0: spi at 10600 {
+				compatible = "marvell,armada-375-spi",
+						"marvell,orion-spi";
+				reg = <0x10600 0x50>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				cell-index = <0>;
+				interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&coreclk 0>;
+				status = "disabled";
+			};
+
+			spi1: spi at 10680 {
+				compatible = "marvell,armada-375-spi",
+						"marvell,orion-spi";
+				reg = <0x10680 0x50>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				cell-index = <1>;
+				interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&coreclk 0>;
+				status = "disabled";
+			};
+
+			i2c0: i2c at 11000 {
+				compatible = "marvell,mv64xxx-i2c";
+				reg = <0x11000 0x20>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
+				timeout-ms = <1000>;
+				clocks = <&coreclk 0>;
+				status = "disabled";
+			};
+
+			i2c1: i2c at 11100 {
+				compatible = "marvell,mv64xxx-i2c";
+				reg = <0x11100 0x20>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
+				timeout-ms = <1000>;
+				clocks = <&coreclk 0>;
+				status = "disabled";
+			};
+
+			uart0: serial at 12000 {
+				compatible = "snps,dw-apb-uart";
+				reg = <0x12000 0x100>;
+				reg-shift = <2>;
+				interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
+				reg-io-width = <1>;
+				clocks = <&coreclk 0>;
+				status = "disabled";
+			};
+
+			uart1: serial at 12100 {
+				compatible = "snps,dw-apb-uart";
+				reg = <0x12100 0x100>;
+				reg-shift = <2>;
+				interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
+				reg-io-width = <1>;
+				clocks = <&coreclk 0>;
+				status = "disabled";
+			};
+
+			pinctrl {
+				compatible = "marvell,mv88f6720-pinctrl";
+				reg = <0x18000 0x24>;
+
+				i2c0_pins: i2c0-pins {
+					marvell,pins = "mpp14",  "mpp15";
+					marvell,function = "i2c0";
+				};
+
+				i2c1_pins: i2c1-pins {
+					marvell,pins = "mpp61",  "mpp62";
+					marvell,function = "i2c1";
+				};
+
+				nand_pins: nand-pins {
+					marvell,pins = "mpp0", "mpp1", "mpp2",
+						"mpp3", "mpp4", "mpp5",
+						"mpp6", "mpp7", "mpp8",
+						"mpp9", "mpp10", "mpp11",
+						"mpp12", "mpp13";
+					marvell,function = "nand";
+				};
+
+				sdio_pins: sdio-pins {
+					marvell,pins = "mpp24",  "mpp25", "mpp26",
+						     "mpp27", "mpp28", "mpp29";
+					marvell,function = "sd";
+				};
+
+				spi0_pins: spi0-pins {
+					marvell,pins = "mpp0",  "mpp1", "mpp4",
+						     "mpp5", "mpp8", "mpp9";
+					marvell,function = "spi0";
+				};
+			};
+
+			gpio0: gpio at 18100 {
+				compatible = "marvell,orion-gpio";
+				reg = <0x18100 0x40>;
+				ngpios = <32>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
+			gpio1: gpio at 18140 {
+				compatible = "marvell,orion-gpio";
+				reg = <0x18140 0x40>;
+				ngpios = <32>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
+			gpio2: gpio at 18180 {
+				compatible = "marvell,orion-gpio";
+				reg = <0x18180 0x40>;
+				ngpios = <3>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
+			system-controller at 18200 {
+				compatible = "marvell,armada-375-system-controller";
+				reg = <0x18200 0x100>;
+			};
+
+			gateclk: clock-gating-control at 18220 {
+				compatible = "marvell,armada-375-gating-clock";
+				reg = <0x18220 0x4>;
+				clocks = <&coreclk 0>;
+				#clock-cells = <1>;
+			};
+
+			usbcluster: usb-cluster at 18400 {
+				compatible = "marvell,armada-375-usb-cluster";
+				reg = <0x18400 0x4>;
+				#phy-cells = <1>;
+			};
+
+			mbusc: mbus-controller at 20000 {
+				compatible = "marvell,mbus-controller";
+				reg = <0x20000 0x100>, <0x20180 0x20>;
+			};
+
+			mpic: interrupt-controller at 20a00 {
+				compatible = "marvell,mpic";
+				reg = <0x20a00 0x2d0>, <0x21070 0x58>;
+				#interrupt-cells = <1>;
+				#size-cells = <1>;
+				interrupt-controller;
+				msi-controller;
+				interrupts = <GIC_PPI 15 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
+			timer at 20300 {
+				compatible = "marvell,armada-375-timer", "marvell,armada-370-timer";
+				reg = <0x20300 0x30>, <0x21040 0x30>;
+				interrupts-extended = <&gic  GIC_SPI  8 IRQ_TYPE_LEVEL_HIGH>,
+						      <&gic  GIC_SPI  9 IRQ_TYPE_LEVEL_HIGH>,
+						      <&gic  GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>,
+						      <&gic  GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>,
+						      <&mpic 5>,
+						      <&mpic 6>;
+				clocks = <&coreclk 0>, <&refclk>;
+				clock-names = "nbclk", "fixed";
+			};
+
+			watchdog at 20300 {
+				compatible = "marvell,armada-375-wdt";
+				reg = <0x20300 0x34>, <0x20704 0x4>, <0x18254 0x4>;
+				clocks = <&coreclk 0>, <&refclk>;
+				clock-names = "nbclk", "fixed";
+			};
+
+			cpurst at 20800 {
+				compatible = "marvell,armada-370-cpu-reset";
+				reg = <0x20800 0x10>;
+			};
+
+			coherency-fabric at 21010 {
+				compatible = "marvell,armada-375-coherency-fabric";
+				reg = <0x21010 0x1c>;
+			};
+
+			usb at 50000 {
+				compatible = "marvell,orion-ehci";
+				reg = <0x50000 0x500>;
+				interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 18>;
+				phys = <&usbcluster PHY_TYPE_USB2>;
+				phy-names = "usb";
+				status = "disabled";
+			};
+
+			usb at 54000 {
+				compatible = "marvell,orion-ehci";
+				reg = <0x54000 0x500>;
+				interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 26>;
+				status = "disabled";
+			};
+
+			usb3 at 58000 {
+				compatible = "marvell,armada-375-xhci";
+				reg = <0x58000 0x20000>,<0x5b880 0x80>;
+				interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 16>;
+				phys = <&usbcluster PHY_TYPE_USB3>;
+				phy-names = "usb";
+				status = "disabled";
+			};
+
+			xor at 60800 {
+				compatible = "marvell,orion-xor";
+				reg = <0x60800 0x100
+				       0x60A00 0x100>;
+				clocks = <&gateclk 22>;
+				status = "okay";
+
+				xor00 {
+					interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
+					dmacap,memcpy;
+					dmacap,xor;
+				};
+				xor01 {
+					interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
+					dmacap,memcpy;
+					dmacap,xor;
+					dmacap,memset;
+				};
+			};
+
+			xor at 60900 {
+				compatible = "marvell,orion-xor";
+				reg = <0x60900 0x100
+				       0x60b00 0x100>;
+				clocks = <&gateclk 23>;
+				status = "okay";
+
+				xor10 {
+					interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>;
+					dmacap,memcpy;
+					dmacap,xor;
+				};
+				xor11 {
+					interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>;
+					dmacap,memcpy;
+					dmacap,xor;
+					dmacap,memset;
+				};
+			};
+
+			crypto at 90000 {
+				compatible = "marvell,armada-375-crypto";
+				reg = <0x90000 0x10000>;
+				reg-names = "regs";
+				interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 30>, <&gateclk 31>,
+					 <&gateclk 28>, <&gateclk 29>;
+				clock-names = "cesa0", "cesa1",
+					      "cesaz0", "cesaz1";
+				marvell,crypto-srams = <&crypto_sram0>,
+						       <&crypto_sram1>;
+				marvell,crypto-sram-size = <0x800>;
+			};
+
+			sata at a0000 {
+				compatible = "marvell,orion-sata";
+				reg = <0xa0000 0x5000>;
+				interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 14>, <&gateclk 20>;
+				clock-names = "0", "1";
+				status = "disabled";
+			};
+
+			nand at d0000 {
+				compatible = "marvell,armada370-nand";
+				reg = <0xd0000 0x54>;
+				#address-cells = <1>;
+				#size-cells = <1>;
+				interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 11>;
+				status = "disabled";
+			};
+
+			mvsdio at d4000 {
+				compatible = "marvell,orion-sdio";
+				reg = <0xd4000 0x200>;
+				interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&gateclk 17>;
+				bus-width = <4>;
+				cap-sdio-irq;
+				cap-sd-highspeed;
+				cap-mmc-highspeed;
+				status = "disabled";
+			};
+
+			thermal at e8078 {
+				compatible = "marvell,armada375-thermal";
+				reg = <0xe8078 0x4>, <0xe807c 0x8>;
+				status = "okay";
+			};
+
+			coreclk: mvebu-sar at e8204 {
+				compatible = "marvell,armada-375-core-clock";
+				reg = <0xe8204 0x04>;
+				#clock-cells = <1>;
+			};
+
+			coredivclk: corediv-clock at e8250 {
+				compatible = "marvell,armada-375-corediv-clock";
+				reg = <0xe8250 0xc>;
+				#clock-cells = <1>;
+				clocks = <&mainpll>;
+				clock-output-names = "nand";
+			};
+		};
+
+		pcie-controller {
+			compatible = "marvell,armada-370-pcie";
+			status = "disabled";
+			device_type = "pci";
+
+			#address-cells = <3>;
+			#size-cells = <2>;
+
+			msi-parent = <&mpic>;
+			bus-range = <0x00 0xff>;
+
+			ranges =
+			       <0x82000000 0 0x40000 MBUS_ID(0xf0, 0x01) 0x40000 0 0x00002000
+				0x82000000 0 0x44000 MBUS_ID(0xf0, 0x01) 0x44000 0 0x00002000
+				0x82000000 0x1 0       MBUS_ID(0x04, 0xe8) 0 1 0 /* Port 0 MEM */
+				0x81000000 0x1 0       MBUS_ID(0x04, 0xe0) 0 1 0 /* Port 0 IO  */
+				0x82000000 0x2 0       MBUS_ID(0x04, 0xd8) 0 1 0 /* Port 1 MEM */
+				0x81000000 0x2 0       MBUS_ID(0x04, 0xd0) 0 1 0 /* Port 1 IO  */>;
+
+			pcie at 1,0 {
+				device_type = "pci";
+				assigned-addresses = <0x82000800 0 0x40000 0 0x2000>;
+				reg = <0x0800 0 0 0 0>;
+				#address-cells = <3>;
+				#size-cells = <2>;
+				#interrupt-cells = <1>;
+				ranges = <0x82000000 0 0 0x82000000 0x1 0 1 0
+					  0x81000000 0 0 0x81000000 0x1 0 1 0>;
+				interrupt-map-mask = <0 0 0 0>;
+				interrupt-map = <0 0 0 0 &gic GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
+				marvell,pcie-port = <0>;
+				marvell,pcie-lane = <0>;
+				clocks = <&gateclk 5>;
+				status = "disabled";
+			};
+
+			pcie at 2,0 {
+				device_type = "pci";
+				assigned-addresses = <0x82000800 0 0x44000 0 0x2000>;
+				reg = <0x1000 0 0 0 0>;
+				#address-cells = <3>;
+				#size-cells = <2>;
+				#interrupt-cells = <1>;
+				ranges = <0x82000000 0 0 0x82000000 0x2 0 1 0
+					  0x81000000 0 0 0x81000000 0x2 0 1 0>;
+				interrupt-map-mask = <0 0 0 0>;
+				interrupt-map = <0 0 0 0 &gic GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
+				marvell,pcie-port = <0>;
+				marvell,pcie-lane = <1>;
+				clocks = <&gateclk 6>;
+				status = "disabled";
+			};
+
+		};
+
+		crypto_sram0: sa-sram0 {
+			compatible = "mmio-sram";
+			reg = <MBUS_ID(0x09, 0x09) 0 0x800>;
+			clocks = <&gateclk 30>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 MBUS_ID(0x09, 0x09) 0 0x800>;
+		};
+
+		crypto_sram1: sa-sram1 {
+			compatible = "mmio-sram";
+			reg = <MBUS_ID(0x09, 0x05) 0 0x800>;
+			clocks = <&gateclk 31>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 MBUS_ID(0x09, 0x05) 0 0x800>;
+		};
+	};
+};
diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
index 96a3313..220886a 100644
--- a/arch/arm/mach-mvebu/Kconfig
+++ b/arch/arm/mach-mvebu/Kconfig
@@ -1,5 +1,8 @@
 if ARCH_MVEBU
 
+config ARMADA_375
+	bool
+
 config ARMADA_38X
 	bool
 
@@ -23,13 +26,17 @@ config DB_88F6820_GP
 	select ARMADA_38X
 
 choice
-	prompt "Marvell MVEBU (Armada XP/38x) board select"
+	prompt "Marvell MVEBU (Armada XP/375/38x) board select"
 	optional
 
 config TARGET_CLEARFOG
 	bool "Support ClearFog"
 	select DB_88F6820_GP
 
+config TARGET_DB_88F6720
+	bool "Support DB-88F6720 Armada 375"
+	select ARMADA_375
+
 config TARGET_DB_88F6820_GP
 	bool "Support DB-88F6820-GP"
 	select DB_88F6820_GP
@@ -54,6 +61,7 @@ endchoice
 
 config SYS_BOARD
 	default "clearfog" if TARGET_CLEARFOG
+	default "db-88f6720" if TARGET_DB_88F6720
 	default "db-88f6820-gp" if TARGET_DB_88F6820_GP
 	default "db-mv784mp-gp" if TARGET_DB_MV784MP_GP
 	default "ds414" if TARGET_DS414
@@ -62,6 +70,7 @@ config SYS_BOARD
 
 config SYS_CONFIG_NAME
 	default "clearfog" if TARGET_CLEARFOG
+	default "db-88f6720" if TARGET_DB_88F6720
 	default "db-88f6820-gp" if TARGET_DB_88F6820_GP
 	default "db-mv784mp-gp" if TARGET_DB_MV784MP_GP
 	default "ds414" if TARGET_DS414
@@ -70,6 +79,7 @@ config SYS_CONFIG_NAME
 
 config SYS_VENDOR
 	default "Marvell" if TARGET_DB_MV784MP_GP
+	default "Marvell" if TARGET_DB_88F6720
 	default "Marvell" if TARGET_DB_88F6820_GP
 	default "solidrun" if TARGET_CLEARFOG
 	default "Synology" if TARGET_DS414
diff --git a/board/Marvell/db-88f6720/MAINTAINERS b/board/Marvell/db-88f6720/MAINTAINERS
new file mode 100644
index 0000000..a27d1c2
--- /dev/null
+++ b/board/Marvell/db-88f6720/MAINTAINERS
@@ -0,0 +1,6 @@
+DB_88F6720 BOARD
+M:	Stefan Roese <sr@denx.de>
+S:	Maintained
+F:	board/Marvell/db-88f6720/
+F:	include/configs/db-88f6720.h
+F:	configs/db-88f6720_defconfig
diff --git a/board/Marvell/db-88f6720/Makefile b/board/Marvell/db-88f6720/Makefile
new file mode 100644
index 0000000..7a5b512
--- /dev/null
+++ b/board/Marvell/db-88f6720/Makefile
@@ -0,0 +1,7 @@
+#
+# Copyright (C) 2016 Stefan Roese <sr@denx.de>
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y	:= db-88f6720.o
diff --git a/board/Marvell/db-88f6720/db-88f6720.c b/board/Marvell/db-88f6720/db-88f6720.c
new file mode 100644
index 0000000..b6e00f3
--- /dev/null
+++ b/board/Marvell/db-88f6720/db-88f6720.c
@@ -0,0 +1,91 @@
+/*
+ * Copyright (C) 2016 Stefan Roese <sr@denx.de>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#include <common.h>
+#include <miiphy.h>
+#include <netdev.h>
+#include <asm/io.h>
+#include <asm/arch/cpu.h>
+#include <asm/arch/soc.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+/*
+ * Those values and defines are taken from the Marvell U-Boot version
+ * "u-boot-2013.01-2014_T2.0" for the board Armada 375 DB-88F6720
+ */
+#define DB_88F6720_MPP0_7		0x00020020 /* SPI */
+#define DB_88F6720_MPP8_15		0x22000022 /* SPI , I2C */
+#define DB_88F6720_MPP16_23		0x22222222 /* UART, TDM*/
+#define DB_88F6720_MPP24_31		0x33333333 /* SDIO, SPI1*/
+#define DB_88F6720_MPP32_39		0x04403330 /* SPI1, External SMI */
+#define DB_88F6720_MPP40_47		0x22002044 /* UART1, GE0, SATA0 LED */
+#define DB_88F6720_MPP48_55		0x22222222 /* GE0 */
+#define DB_88F6720_MPP56_63		0x04444422 /* GE0 , LED_MATRIX, GPIO */
+#define DB_88F6720_MPP64_67		0x014	/* LED_MATRIX, SATA1 LED*/
+
+#define DB_88F6720_GPP_OUT_ENA_LOW	0xFFFFFFFF
+#define DB_88F6720_GPP_OUT_ENA_MID	0x7FFFFFFF
+#define DB_88F6720_GPP_OUT_ENA_HIGH	0xFFFFFFFF
+#define DB_88F6720_GPP_OUT_VAL_LOW	0x0
+#define DB_88F6720_GPP_OUT_VAL_MID	BIT(31)	/* SATA Power output enable */
+#define DB_88F6720_GPP_OUT_VAL_HIGH	0x0
+#define DB_88F6720_GPP_POL_LOW		0x0
+#define DB_88F6720_GPP_POL_MID		0x0
+#define DB_88F6720_GPP_POL_HIGH		0x0
+
+int board_early_init_f(void)
+{
+	/* Configure MPP */
+	writel(DB_88F6720_MPP0_7, MVEBU_MPP_BASE + 0x00);
+	writel(DB_88F6720_MPP8_15, MVEBU_MPP_BASE + 0x04);
+	writel(DB_88F6720_MPP16_23, MVEBU_MPP_BASE + 0x08);
+	writel(DB_88F6720_MPP24_31, MVEBU_MPP_BASE + 0x0c);
+	writel(DB_88F6720_MPP32_39, MVEBU_MPP_BASE + 0x10);
+	writel(DB_88F6720_MPP40_47, MVEBU_MPP_BASE + 0x14);
+	writel(DB_88F6720_MPP48_55, MVEBU_MPP_BASE + 0x18);
+	writel(DB_88F6720_MPP56_63, MVEBU_MPP_BASE + 0x1c);
+	writel(DB_88F6720_MPP64_67, MVEBU_MPP_BASE + 0x20);
+
+	/* Configure GPIO */
+	/* Set GPP Out value */
+	writel(DB_88F6720_GPP_OUT_VAL_LOW, MVEBU_GPIO0_BASE + 0x00);
+	writel(DB_88F6720_GPP_OUT_VAL_MID, MVEBU_GPIO1_BASE + 0x00);
+	writel(DB_88F6720_GPP_OUT_VAL_HIGH, MVEBU_GPIO2_BASE + 0x00);
+
+	/* Set GPP Polarity */
+	writel(DB_88F6720_GPP_POL_LOW, MVEBU_GPIO0_BASE + 0x0c);
+	writel(DB_88F6720_GPP_POL_MID, MVEBU_GPIO1_BASE + 0x0c);
+	writel(DB_88F6720_GPP_POL_HIGH, MVEBU_GPIO2_BASE + 0x0c);
+
+	/* Set GPP Out Enable */
+	writel(DB_88F6720_GPP_OUT_ENA_LOW, MVEBU_GPIO0_BASE + 0x04);
+	writel(DB_88F6720_GPP_OUT_ENA_MID, MVEBU_GPIO1_BASE + 0x04);
+	writel(DB_88F6720_GPP_OUT_ENA_HIGH, MVEBU_GPIO2_BASE + 0x04);
+
+	return 0;
+}
+
+int board_init(void)
+{
+	/* adress of boot parameters */
+	gd->bd->bi_boot_params = mvebu_sdram_bar(0) + 0x100;
+
+	return 0;
+}
+
+int checkboard(void)
+{
+	puts("Board: Marvell DB-88F6720\n");
+
+	return 0;
+}
+
+int board_eth_init(bd_t *bis)
+{
+	cpu_eth_init(bis); /* Built in controller(s) come first */
+	return pci_eth_init(bis);
+}
diff --git a/board/Marvell/db-88f6720/kwbimage.cfg b/board/Marvell/db-88f6720/kwbimage.cfg
new file mode 100644
index 0000000..1f748db
--- /dev/null
+++ b/board/Marvell/db-88f6720/kwbimage.cfg
@@ -0,0 +1,12 @@
+#
+# Copyright (C) 2014 Stefan Roese <sr@denx.de>
+#
+
+# Armada XP uses version 1 image format
+VERSION		1
+
+# Boot Media configurations
+BOOT_FROM	spi
+
+# Binary Header (bin_hdr) with DDR3 training code
+BINARY spl/u-boot-spl-dtb.bin 0000005b 00000068
diff --git a/configs/db-88f6720_defconfig b/configs/db-88f6720_defconfig
new file mode 100644
index 0000000..75bc1f0
--- /dev/null
+++ b/configs/db-88f6720_defconfig
@@ -0,0 +1,28 @@
+CONFIG_ARM=y
+CONFIG_ARCH_MVEBU=y
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_TARGET_DB_88F6720=y
+CONFIG_DEFAULT_DEVICE_TREE="armada-375-db"
+# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+CONFIG_SPL=y
+# CONFIG_CMD_IMLS is not set
+# CONFIG_CMD_FLASH is not set
+CONFIG_CMD_USB=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_SPL_OF_TRANSLATE=y
+CONFIG_MISC=y
+CONFIG_NAND_PXA3XX=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_MACRONIX=y
+CONFIG_SPI_FLASH_STMICRO=y
+CONFIG_MVPP2=y
+CONFIG_DEBUG_UART=y
+CONFIG_DEBUG_UART_BASE=0xf1012000
+CONFIG_DEBUG_UART_CLOCK=250000000
+CONFIG_DEBUG_UART_SHIFT=2
+CONFIG_SYS_NS16550=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_STORAGE=y
diff --git a/include/configs/db-88f6720.h b/include/configs/db-88f6720.h
new file mode 100644
index 0000000..7f19334
--- /dev/null
+++ b/include/configs/db-88f6720.h
@@ -0,0 +1,120 @@
+/*
+ * Copyright (C) 2016 Stefan Roese <sr@denx.de>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef _CONFIG_DB_88F6720_H
+#define _CONFIG_DB_88F6720_H
+
+/*
+ * High Level Configuration Options (easy to change)
+ */
+#define CONFIG_DISPLAY_BOARDINFO_LATE
+
+/*
+ * TEXT_BASE needs to be below 16MiB, since this area is scrubbed
+ * for DDR ECC byte filling in the SPL before loading the main
+ * U-Boot into it.
+ */
+#define	CONFIG_SYS_TEXT_BASE	0x00800000
+#define CONFIG_SYS_TCLK		200000000	/* 200MHz */
+
+/*
+ * Commands configuration
+ */
+#define CONFIG_SYS_NO_FLASH		/* Declare no flash (NOR/SPI) */
+#define CONFIG_CMD_CACHE
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_EXT2
+#define CONFIG_CMD_EXT4
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_FS_GENERIC
+#define CONFIG_CMD_I2C
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_SF
+#define CONFIG_CMD_SPI
+#define CONFIG_CMD_TFTPPUT
+#define CONFIG_CMD_TIME
+
+/* I2C */
+#define CONFIG_SYS_I2C
+#define CONFIG_SYS_I2C_MVTWSI
+#define CONFIG_I2C_MVTWSI_BASE0		MVEBU_TWSI_BASE
+#define CONFIG_SYS_I2C_SLAVE		0x0
+#define CONFIG_SYS_I2C_SPEED		100000
+
+/* USB/EHCI configuration */
+#define CONFIG_EHCI_IS_TDI
+#define CONFIG_USB_MAX_CONTROLLER_COUNT 3
+
+/* SPI NOR flash default params, used by sf commands */
+#define CONFIG_SF_DEFAULT_SPEED		1000000
+#define CONFIG_SF_DEFAULT_MODE		SPI_MODE_3
+
+/* Environment in SPI NOR flash */
+#define CONFIG_ENV_IS_IN_SPI_FLASH
+#define CONFIG_ENV_OFFSET		(1 << 20) /* 1MiB in */
+#define CONFIG_ENV_SIZE			(64 << 10) /* 64KiB */
+#define CONFIG_ENV_SECT_SIZE		(64 << 10) /* 64KiB sectors */
+
+#define CONFIG_PHY_MARVELL		/* there is a marvell phy */
+#define PHY_ANEG_TIMEOUT	8000	/* PHY needs a longer aneg time */
+
+#define CONFIG_SYS_CONSOLE_INFO_QUIET	/* don't print console @ startup */
+#define CONFIG_SYS_ALT_MEMTEST
+
+/* Additional FS support/configuration */
+#define CONFIG_SUPPORT_VFAT
+
+/*
+ * mv-common.h should be defined after CMD configs since it used them
+ * to enable certain macros
+ */
+#include "mv-common.h"
+
+/*
+ * Memory layout while starting into the bin_hdr via the
+ * BootROM:
+ *
+ * 0x4000.4000 - 0x4003.4000	headers space (192KiB)
+ * 0x4000.4030			bin_hdr start address
+ * 0x4003.4000 - 0x4004.7c00	BootROM memory allocations (15KiB)
+ * 0x4007.fffc			BootROM stack top
+ *
+ * The address space between 0x4007.fffc and 0x400f.fff is not locked in
+ * L2 cache thus cannot be used.
+ */
+
+/* SPL */
+/* Defines for SPL */
+#define CONFIG_SPL_FRAMEWORK
+#define CONFIG_SPL_TEXT_BASE		0x40004030
+#define CONFIG_SPL_MAX_SIZE		((128 << 10) - 0x4030)
+
+#define CONFIG_SPL_BSS_START_ADDR	(0x40000000 + (128 << 10))
+#define CONFIG_SPL_BSS_MAX_SIZE		(16 << 10)
+
+#ifdef CONFIG_SPL_BUILD
+#define CONFIG_SYS_MALLOC_SIMPLE
+#endif
+
+#define CONFIG_SPL_STACK		(0x40000000 + ((192 - 16) << 10))
+#define CONFIG_SPL_BOOTROM_SAVE		(CONFIG_SPL_STACK + 4)
+
+#define CONFIG_SPL_LIBCOMMON_SUPPORT
+#define CONFIG_SPL_LIBGENERIC_SUPPORT
+#define CONFIG_SPL_SERIAL_SUPPORT
+#define CONFIG_SPL_I2C_SUPPORT
+
+/* SPL related SPI defines */
+#define CONFIG_SPL_SPI_SUPPORT
+#define CONFIG_SPL_SPI_FLASH_SUPPORT
+#define CONFIG_SPL_SPI_LOAD
+#define CONFIG_SPL_SPI_BUS		0
+#define CONFIG_SPL_SPI_CS		0
+#define CONFIG_SYS_SPI_U_BOOT_OFFS	0x20000
+#define CONFIG_SYS_U_BOOT_OFFS		CONFIG_SYS_SPI_U_BOOT_OFFS
+
+#endif /* _CONFIG_DB_88F6720_H */
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 6/6] arm: mvebu: Don't enable d-cache on A375
  2016-03-15 16:35 [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375 Stefan Roese
                   ` (3 preceding siblings ...)
  2016-03-15 16:35 ` [U-Boot] [PATCH 5/6] arm: mvebu: Add basic support for Armada 375 eval board db-88f6720 Stefan Roese
@ 2016-03-15 16:35 ` Stefan Roese
  2016-04-04 12:02   ` Stefan Roese
  2016-03-15 17:55 ` [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375 Jagan Teki
  2016-04-04 12:00 ` Stefan Roese
  6 siblings, 1 reply; 16+ messages in thread
From: Stefan Roese @ 2016-03-15 16:35 UTC (permalink / raw)
  To: u-boot

Armada 375 still has some problems with d-cache enabled in the ethernet
driver (mvpp2). So lets keep the d-cache disabled until this is solved.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Luka Perkov <luka.perkov@sartura.hr>
---
 arch/arm/mach-mvebu/cpu.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-mvebu/cpu.c b/arch/arm/mach-mvebu/cpu.c
index 9913802..fd66f59 100644
--- a/arch/arm/mach-mvebu/cpu.c
+++ b/arch/arm/mach-mvebu/cpu.c
@@ -536,8 +536,15 @@ void enable_caches(void)
 	/* Avoid problem with e.g. neta ethernet driver */
 	invalidate_dcache_all();
 
-	/* Enable D-cache. I-cache is already enabled in start.S */
-	dcache_enable();
+	/*
+	 * Armada 375 still has some problems with d-cache enabled in the
+	 * ethernet driver (mvpp2). So lets keep the d-cache disabled
+	 * until this is solved.
+	 */
+	if (mvebu_soc_family() != MVEBU_SOC_A375) {
+		/* Enable D-cache. I-cache is already enabled in start.S */
+		dcache_enable();
+	}
 }
 
 void v7_outer_cache_enable(void)
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375
  2016-03-15 16:35 [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375 Stefan Roese
                   ` (4 preceding siblings ...)
  2016-03-15 16:35 ` [U-Boot] [PATCH 6/6] arm: mvebu: Don't enable d-cache on A375 Stefan Roese
@ 2016-03-15 17:55 ` Jagan Teki
  2016-04-04 12:00 ` Stefan Roese
  6 siblings, 0 replies; 16+ messages in thread
From: Jagan Teki @ 2016-03-15 17:55 UTC (permalink / raw)
  To: u-boot

On 15 March 2016 at 22:05, Stefan Roese <sr@denx.de> wrote:
> This enables this driver for the Marvell Armada 375 SoC.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> Cc: Jagan Teki <jteki@openedev.com>

Reviewed-by: Jagan Teki <jteki@openedev.com>

-- 
Jagan.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 2/6] net: mvpp2.c: Add Marvell mvpp2 network driver for Armada 375
  2016-03-15 16:35 ` [U-Boot] [PATCH 2/6] net: mvpp2.c: Add Marvell mvpp2 network driver " Stefan Roese
@ 2016-03-18 14:29   ` Stefan Roese
  2016-03-22 19:10   ` Joe Hershberger
  1 sibling, 0 replies; 16+ messages in thread
From: Stefan Roese @ 2016-03-18 14:29 UTC (permalink / raw)
  To: u-boot

Hi Joe,

On 15.03.2016 17:35, Stefan Roese wrote:
> This patch adds support for the mvpp2 ethernet controller which is integrated
> in the Marvell Armada 375 SoC. This port is based on the Linux driver (v4.4),
> which has been stripped of the in U-Boot unused portions.
>
> Tested on the Marvell Armada 375 eval board db-88f6720.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> Cc: Joe Hershberger <joe.hershberger@gmail.com>

Joe, did you have the time to take a look at this driver implementation?
If you have no objections, I would like to push this via the marvell /
mvebu git tree into mainline to avoid merge conflicts.

So please let me know what you think.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 2/6] net: mvpp2.c: Add Marvell mvpp2 network driver for Armada 375
  2016-03-15 16:35 ` [U-Boot] [PATCH 2/6] net: mvpp2.c: Add Marvell mvpp2 network driver " Stefan Roese
  2016-03-18 14:29   ` Stefan Roese
@ 2016-03-22 19:10   ` Joe Hershberger
  2016-03-23  6:39     ` Stefan Roese
  1 sibling, 1 reply; 16+ messages in thread
From: Joe Hershberger @ 2016-03-22 19:10 UTC (permalink / raw)
  To: u-boot

Hit Stefan,

Sorry for the delay.

On Tue, Mar 15, 2016 at 11:35 AM, Stefan Roese <sr@denx.de> wrote:
> This patch adds support for the mvpp2 ethernet controller which is integrated
> in the Marvell Armada 375 SoC. This port is based on the Linux driver (v4.4),
> which has been stripped of the in U-Boot unused portions.
>
> Tested on the Marvell Armada 375 eval board db-88f6720.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> Cc: Joe Hershberger <joe.hershberger@gmail.com>
> ---
>  drivers/net/Kconfig  |    8 +
>  drivers/net/Makefile |    1 +
>  drivers/net/mvpp2.c  | 4222 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 4231 insertions(+)
>  create mode 100644 drivers/net/mvpp2.c
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index bc2f51d..bcb4c96 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -94,6 +94,14 @@ config ETH_DESIGNWARE
>           100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
>           provide the PHY (physical media interface).
>
> +config MVPP2
> +       bool "Marvell Armada 375 network interface support"
> +       depends on ARMADA_375
> +       select PHYLIB
> +       help
> +         This driver supports the network interface units in the
> +         Marvell ARMADA 375 SoC.
> +
>  config PCH_GBE
>         bool "Intel Platform Controller Hub EG20T GMAC driver"
>         depends on DM_ETH && DM_PCI
> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> index 33a81ee..fbedd04 100644
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -42,6 +42,7 @@ obj-$(CONFIG_MPC5xxx_FEC) += mpc5xxx_fec.o
>  obj-$(CONFIG_MPC512x_FEC) += mpc512x_fec.o
>  obj-$(CONFIG_MVGBE) += mvgbe.o
>  obj-$(CONFIG_MVNETA) += mvneta.o
> +obj-$(CONFIG_MVPP2) += mvpp2.o
>  obj-$(CONFIG_NATSEMI) += natsemi.o
>  obj-$(CONFIG_DRIVER_NE2000) += ne2000.o ne2000_base.o
>  obj-$(CONFIG_DRIVER_AX88796L) += ax88796.o ne2000_base.o
> diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
> new file mode 100644
> index 0000000..09dfc7e
> --- /dev/null
> +++ b/drivers/net/mvpp2.c
> @@ -0,0 +1,4222 @@
> +/*
> + * Driver for Marvell PPv2 network controller for Armada 375 SoC.
> + *
> + * Copyright (C) 2014 Marvell
> + *
> + * Marcin Wojtas <mw@semihalf.com>
> + *
> + * U-Boot version:
> + * Copyright (C) 2016 Stefan Roese <sr@denx.de>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <common.h>
> +#include <dm.h>
> +#include <dm/device-internal.h>
> +#include <dm/lists.h>
> +#include <net.h>
> +#include <netdev.h>
> +#include <config.h>
> +#include <malloc.h>
> +#include <asm/io.h>
> +#include <asm/errno.h>
> +#include <phy.h>
> +#include <miiphy.h>
> +#include <watchdog.h>
> +#include <asm/arch/cpu.h>
> +#include <asm/arch/soc.h>
> +#include <linux/compat.h>
> +#include <linux/mbus.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +#if !defined(CONFIG_PHYLIB)
> +# error Marvell mvpp2 requires PHYLIB
> +#endif

This isn't needed since you "select" PHYLIB in the Kconfig.

> +
> +/* Some linux -> U-Boot compatibility stuff */
> +#define netdev_err(dev, fmt, args...)          \
> +       printf(fmt, ##args)
> +#define netdev_warn(dev, fmt, args...)         \
> +       printf(fmt, ##args)
> +#define netdev_info(dev, fmt, args...)         \
> +       printf(fmt, ##args)
> +#define netdev_dbg(dev, fmt, args...)          \
> +       printf(fmt, ##args)
> +
> +#define ETH_ALEN       6               /* Octets in one ethernet addr  */
> +
> +#define ETH_P_IP       0x0800          /* Internet Protocol packet     */

Already available in include/net.h as PROT_IP

> +#define ETH_P_PPP_SES  0x8864          /* PPPoE session messages       */

Add this to include/net.h as PROT_PPP_SES

> +#define ETH_P_ARP      0x0806          /* Address Resolution packet    */

Already available in include/net.h as PROT_ARP

> +#define ETH_P_IPV6     0x86DD          /* IPv6 over bluebook           */

Add this to include/net.h as PROT_IPV6

> +
> +#define __verify_pcpu_ptr(ptr)                                         \
> +do {                                                                   \
> +       const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL;    \
> +       (void)__vpp_verify;                                             \
> +} while (0)
> +
> +#define VERIFY_PERCPU_PTR(__p)                                         \
> +({                                                                     \
> +       __verify_pcpu_ptr(__p);                                         \
> +       (typeof(*(__p)) __kernel __force *)(__p);                       \
> +})
> +
> +#define per_cpu_ptr(ptr, cpu)  ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
> +#define smp_processor_id()     0
> +#define num_present_cpus()     1
> +#define for_each_present_cpu(cpu)                      \
> +       for ((cpu) = 0; (cpu) < 1; (cpu)++)
> +
> +#define NET_SKB_PAD    max(32, MVPP2_CPU_D_CACHE_LINE_SIZE)
> +
> +#define CONFIG_NR_CPUS         1
> +#define ETH_HLEN               14      /* Total octets in header */

Already available in include/net.h as ETHER_HDR_SIZE.

> +
> +/* 2(HW hdr) 14(MAC hdr) 4(CRC) 32(extra for cache prefetch) */
> +#define WRAP                   (2 + ETH_HLEN + 4 + 32)
> +#define MTU                    1500
> +#define RX_BUFFER_SIZE         (ALIGN(MTU + WRAP, ARCH_DMA_MINALIGN))

<snip - constants>

> +/*
> + * Page table entries are set to 1MB, or multiples of 1MB
> + * (not < 1MB). driver uses less bd's so use 1MB bdspace.
> + */
> +#define BD_SPACE       (1 << 20)

It would be great if this long list of constants lived in a header
file instead of the top of the source.

> +
> +/* Utility/helper methods */
> +
> +static void mvpp2_write(struct mvpp2 *priv, u32 offset, u32 data)
> +{
> +       writel(data, priv->base + offset);
> +}
> +
> +static u32 mvpp2_read(struct mvpp2 *priv, u32 offset)
> +{
> +       return readl(priv->base + offset);
> +}
> +

<snip>

> +
> +/* Set hw internals when starting port */
> +static void mvpp2_start_dev(struct mvpp2_port *port)
> +{
> +       mvpp2_gmac_max_rx_size_set(port);
> +       mvpp2_txp_max_tx_size_set(port);
> +
> +       mvpp2_port_enable(port);
> +}
> +
> +/* Set hw internals when stopping port */
> +static void mvpp2_stop_dev(struct mvpp2_port *port)
> +{
> +       /* Stop new packets from arriving to RXQs */
> +       mvpp2_ingress_disable(port);
> +
> +       mvpp2_egress_disable(port);
> +       mvpp2_port_disable(port);
> +}
> +
> +static int mvpp2_phy_connect(struct udevice *dev, struct mvpp2_port *port)
> +{
> +       struct phy_device *phy_dev;
> +
> +       if (!port->init || port->link == 0) {
> +               phy_dev = phy_connect(port->priv->bus, port->phyaddr, dev,
> +                                     port->phy_interface);
> +               port->phy_dev = phy_dev;
> +               if (!phy_dev) {
> +                       netdev_err(port->dev, "cannot connect to phy\n");
> +                       return -ENODEV;
> +               }
> +               phy_dev->supported &= PHY_GBIT_FEATURES;
> +               phy_dev->advertising = phy_dev->supported;
> +
> +               port->phy_dev = phy_dev;
> +               port->link    = 0;
> +               port->duplex  = 0;
> +               port->speed   = 0;
> +
> +               phy_config(phy_dev);
> +               phy_startup(phy_dev);
> +               if (!phy_dev->link) {
> +                       printf("%s: No link\n", phy_dev->dev->name);
> +                       return -1;
> +               }
> +
> +               port->init = 1;
> +       } else {
> +               mvpp2_egress_enable(port);
> +               mvpp2_ingress_enable(port);
> +       }
> +
> +       return 0;
> +}
> +
> +static int mvpp2_open(struct udevice *dev, struct mvpp2_port *port)
> +{
> +       unsigned char mac_bcast[ETH_ALEN] = {
> +                       0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
> +       int err;
> +
> +       err = mvpp2_prs_mac_da_accept(port->priv, port->id, mac_bcast, true);
> +       if (err) {
> +               netdev_err(dev, "mvpp2_prs_mac_da_accept BC failed\n");
> +               return err;
> +       }
> +       err = mvpp2_prs_mac_da_accept(port->priv, port->id,
> +                                     port->dev_addr, true);
> +       if (err) {
> +               netdev_err(dev, "mvpp2_prs_mac_da_accept MC failed\n");
> +               return err;
> +       }
> +       err = mvpp2_prs_def_flow(port);
> +       if (err) {
> +               netdev_err(dev, "mvpp2_prs_def_flow failed\n");
> +               return err;
> +       }
> +
> +       /* Allocate the Rx/Tx queues */
> +       err = mvpp2_setup_rxqs(port);
> +       if (err) {
> +               netdev_err(port->dev, "cannot allocate Rx queues\n");
> +               return err;
> +       }
> +
> +       err = mvpp2_setup_txqs(port);
> +       if (err) {
> +               netdev_err(port->dev, "cannot allocate Tx queues\n");
> +               return err;
> +       }
> +
> +       err = mvpp2_phy_connect(dev, port);
> +       if (err < 0)
> +               return err;
> +
> +       mvpp2_link_event(port);
> +
> +       mvpp2_start_dev(port);
> +
> +       return 0;
> +}
> +
> +/* No Device ops here in U-Boot */
> +
> +/* Driver initialization */
> +
> +static void mvpp2_port_power_up(struct mvpp2_port *port)
> +{
> +       mvpp2_port_mii_set(port);
> +       mvpp2_port_periodic_xon_disable(port);
> +       mvpp2_port_fc_adv_enable(port);
> +       mvpp2_port_reset(port);
> +}
> +
> +/* Initialize port HW */
> +static int mvpp2_port_init(struct udevice *dev, struct mvpp2_port *port)
> +{
> +       struct mvpp2 *priv = port->priv;
> +       struct mvpp2_txq_pcpu *txq_pcpu;
> +       int queue, cpu, err;
> +
> +       if (port->first_rxq + rxq_number > MVPP2_RXQ_TOTAL_NUM)
> +               return -EINVAL;
> +
> +       /* Disable port */
> +       mvpp2_egress_disable(port);
> +       mvpp2_port_disable(port);
> +
> +       port->txqs = devm_kcalloc(dev, txq_number, sizeof(*port->txqs),
> +                                 GFP_KERNEL);
> +       if (!port->txqs)
> +               return -ENOMEM;
> +
> +       /* Associate physical Tx queues to this port and initialize.
> +        * The mapping is predefined.
> +        */
> +       for (queue = 0; queue < txq_number; queue++) {
> +               int queue_phy_id = mvpp2_txq_phys(port->id, queue);
> +               struct mvpp2_tx_queue *txq;
> +
> +               txq = devm_kzalloc(dev, sizeof(*txq), GFP_KERNEL);
> +               if (!txq)
> +                       return -ENOMEM;
> +
> +               txq->pcpu = devm_kzalloc(dev, sizeof(struct mvpp2_txq_pcpu),
> +                                        GFP_KERNEL);
> +               if (!txq->pcpu)
> +                       return -ENOMEM;
> +
> +               txq->id = queue_phy_id;
> +               txq->log_id = queue;
> +               txq->done_pkts_coal = MVPP2_TXDONE_COAL_PKTS_THRESH;
> +               for_each_present_cpu(cpu) {
> +                       txq_pcpu = per_cpu_ptr(txq->pcpu, cpu);
> +                       txq_pcpu->cpu = cpu;
> +               }
> +
> +               port->txqs[queue] = txq;
> +       }
> +
> +       port->rxqs = devm_kcalloc(dev, rxq_number, sizeof(*port->rxqs),
> +                                 GFP_KERNEL);
> +       if (!port->rxqs)
> +               return -ENOMEM;
> +
> +       /* Allocate and initialize Rx queue for this port */
> +       for (queue = 0; queue < rxq_number; queue++) {
> +               struct mvpp2_rx_queue *rxq;
> +
> +               /* Map physical Rx queue to port's logical Rx queue */
> +               rxq = devm_kzalloc(dev, sizeof(*rxq), GFP_KERNEL);
> +               if (!rxq)
> +                       return -ENOMEM;
> +               /* Map this Rx queue to a physical queue */
> +               rxq->id = port->first_rxq + queue;
> +               rxq->port = port->id;
> +               rxq->logic_rxq = queue;
> +
> +               port->rxqs[queue] = rxq;
> +       }
> +
> +       /* Configure Rx queue group interrupt for this port */
> +       mvpp2_write(priv, MVPP2_ISR_RXQ_GROUP_REG(port->id), CONFIG_MV_ETH_RXQ);
> +
> +       /* Create Rx descriptor rings */
> +       for (queue = 0; queue < rxq_number; queue++) {
> +               struct mvpp2_rx_queue *rxq = port->rxqs[queue];
> +
> +               rxq->size = port->rx_ring_size;
> +               rxq->pkts_coal = MVPP2_RX_COAL_PKTS;
> +               rxq->time_coal = MVPP2_RX_COAL_USEC;
> +       }
> +
> +       mvpp2_ingress_disable(port);
> +
> +       /* Port default configuration */
> +       mvpp2_defaults_set(port);
> +
> +       /* Port's classifier configuration */
> +       mvpp2_cls_oversize_rxq_set(port);
> +       mvpp2_cls_port_config(port);
> +
> +       /* Provide an initial Rx packet size */
> +       port->pkt_size = MVPP2_RX_PKT_SIZE(PKTSIZE_ALIGN);
> +
> +       /* Initialize pools for swf */
> +       err = mvpp2_swf_bm_pool_init(port);
> +       if (err)
> +               return err;
> +
> +       return 0;
> +}
> +
> +/* Ports initialization */
> +static int mvpp2_port_probe(struct udevice *dev,
> +                           struct mvpp2_port *port,
> +                           int port_node,
> +                           struct mvpp2 *priv,
> +                           int *next_first_rxq)
> +{
> +       int phy_node;
> +       u32 id;
> +       u32 phyaddr;
> +       const char *phy_mode_str;
> +       int phy_mode = -1;
> +       int priv_common_regs_num = 2;
> +       int err;
> +
> +       phy_node = fdtdec_lookup_phandle(gd->fdt_blob, port_node, "phy");
> +       if (phy_node < 0) {
> +               dev_err(&pdev->dev, "missing phy\n");
> +               return -ENODEV;
> +       }
> +
> +       phy_mode_str = fdt_getprop(gd->fdt_blob, port_node, "phy-mode", NULL);
> +       if (phy_mode_str)
> +               phy_mode = phy_get_interface_by_name(phy_mode_str);
> +       if (phy_mode == -1) {
> +               dev_err(&pdev->dev, "incorrect phy mode\n");
> +               return -EINVAL;
> +       }
> +
> +       id = fdtdec_get_int(gd->fdt_blob, port_node, "port-id", -1);
> +       if (id == -1) {
> +               dev_err(&pdev->dev, "missing port-id value\n");
> +               return -EINVAL;
> +       }
> +
> +       phyaddr = fdtdec_get_int(gd->fdt_blob, phy_node, "reg", 0);
> +
> +       port->priv = priv;
> +       port->id = id;
> +       port->first_rxq = *next_first_rxq;
> +       port->phy_node = phy_node;
> +       port->phy_interface = phy_mode;
> +       port->phyaddr = phyaddr;
> +
> +       port->base = (void __iomem *)dev_get_addr_index(dev->parent,
> +                                                       priv_common_regs_num
> +                                                       + id);
> +       if (IS_ERR(port->base))
> +               return PTR_ERR(port->base);
> +
> +       port->tx_ring_size = MVPP2_MAX_TXD;
> +       port->rx_ring_size = MVPP2_MAX_RXD;
> +
> +       err = mvpp2_port_init(dev, port);
> +       if (err < 0) {
> +               dev_err(&pdev->dev, "failed to init port %d\n", id);
> +               return err;
> +       }
> +       mvpp2_port_power_up(port);
> +
> +       /* Increment the first Rx queue number to be used by the next port */
> +       *next_first_rxq += CONFIG_MV_ETH_RXQ;
> +       priv->port_list[id] = port;
> +       return 0;
> +}
> +
> +/* Initialize decoding windows */
> +static void mvpp2_conf_mbus_windows(const struct mbus_dram_target_info *dram,
> +                                   struct mvpp2 *priv)
> +{
> +       u32 win_enable;
> +       int i;
> +
> +       for (i = 0; i < 6; i++) {
> +               mvpp2_write(priv, MVPP2_WIN_BASE(i), 0);
> +               mvpp2_write(priv, MVPP2_WIN_SIZE(i), 0);
> +
> +               if (i < 4)
> +                       mvpp2_write(priv, MVPP2_WIN_REMAP(i), 0);
> +       }
> +
> +       win_enable = 0;
> +
> +       for (i = 0; i < dram->num_cs; i++) {
> +               const struct mbus_dram_window *cs = dram->cs + i;
> +
> +               mvpp2_write(priv, MVPP2_WIN_BASE(i),
> +                           (cs->base & 0xffff0000) | (cs->mbus_attr << 8) |
> +                           dram->mbus_dram_target_id);
> +
> +               mvpp2_write(priv, MVPP2_WIN_SIZE(i),
> +                           (cs->size - 1) & 0xffff0000);
> +
> +               win_enable |= (1 << i);
> +       }
> +
> +       mvpp2_write(priv, MVPP2_BASE_ADDR_ENABLE, win_enable);
> +}
> +
> +/* Initialize Rx FIFO's */
> +static void mvpp2_rx_fifo_init(struct mvpp2 *priv)
> +{
> +       int port;
> +
> +       for (port = 0; port < MVPP2_MAX_PORTS; port++) {
> +               mvpp2_write(priv, MVPP2_RX_DATA_FIFO_SIZE_REG(port),
> +                           MVPP2_RX_FIFO_PORT_DATA_SIZE);
> +               mvpp2_write(priv, MVPP2_RX_ATTR_FIFO_SIZE_REG(port),
> +                           MVPP2_RX_FIFO_PORT_ATTR_SIZE);
> +       }
> +
> +       mvpp2_write(priv, MVPP2_RX_MIN_PKT_SIZE_REG,
> +                   MVPP2_RX_FIFO_PORT_MIN_PKT);
> +       mvpp2_write(priv, MVPP2_RX_FIFO_INIT_REG, 0x1);
> +}
> +
> +/* Initialize network controller common part HW */
> +static int mvpp2_init(struct udevice *dev, struct mvpp2 *priv)
> +{
> +       const struct mbus_dram_target_info *dram_target_info;
> +       int err, i;
> +       u32 val;
> +
> +       /* Checks for hardware constraints (U-Boot uses only one rxq) */
> +       if ((rxq_number > MVPP2_MAX_RXQ) || (txq_number > MVPP2_MAX_TXQ)) {
> +               dev_err(&pdev->dev, "invalid queue size parameter\n");
> +               return -EINVAL;
> +       }
> +
> +       /* MBUS windows configuration */
> +       dram_target_info = mvebu_mbus_dram_info();
> +       if (dram_target_info)
> +               mvpp2_conf_mbus_windows(dram_target_info, priv);
> +
> +       /* Disable HW PHY polling */
> +       val = readl(priv->lms_base + MVPP2_PHY_AN_CFG0_REG);
> +       val |= MVPP2_PHY_AN_STOP_SMI0_MASK;
> +       writel(val, priv->lms_base + MVPP2_PHY_AN_CFG0_REG);
> +
> +       /* Allocate and initialize aggregated TXQs */
> +       priv->aggr_txqs = devm_kcalloc(dev, num_present_cpus(),
> +                                      sizeof(struct mvpp2_tx_queue),
> +                                      GFP_KERNEL);
> +       if (!priv->aggr_txqs)
> +               return -ENOMEM;
> +
> +       for_each_present_cpu(i) {
> +               priv->aggr_txqs[i].id = i;
> +               priv->aggr_txqs[i].size = MVPP2_AGGR_TXQ_SIZE;
> +               err = mvpp2_aggr_txq_init(dev, &priv->aggr_txqs[i],
> +                                         MVPP2_AGGR_TXQ_SIZE, i, priv);
> +               if (err < 0)
> +                       return err;
> +       }
> +
> +       /* Rx Fifo Init */
> +       mvpp2_rx_fifo_init(priv);
> +
> +       /* Reset Rx queue group interrupt configuration */
> +       for (i = 0; i < MVPP2_MAX_PORTS; i++)
> +               mvpp2_write(priv, MVPP2_ISR_RXQ_GROUP_REG(i),
> +                           CONFIG_MV_ETH_RXQ);
> +
> +       writel(MVPP2_EXT_GLOBAL_CTRL_DEFAULT,
> +              priv->lms_base + MVPP2_MNG_EXTENDED_GLOBAL_CTRL_REG);
> +
> +       /* Allow cache snoop when transmiting packets */
> +       mvpp2_write(priv, MVPP2_TX_SNOOP_REG, 0x1);
> +
> +       /* Buffer Manager initialization */
> +       err = mvpp2_bm_init(dev, priv);
> +       if (err < 0)
> +               return err;
> +
> +       /* Parser default initialization */
> +       err = mvpp2_prs_default_init(dev, priv);
> +       if (err < 0)
> +               return err;
> +
> +       /* Classifier default initialization */
> +       mvpp2_cls_init(priv);
> +
> +       return 0;
> +}
> +
> +/* SMI / MDIO functions */
> +
> +static int smi_wait_ready(struct mvpp2 *priv)
> +{
> +       u32 timeout = MVPP2_SMI_TIMEOUT;
> +       u32 smi_reg;
> +
> +       /* wait till the SMI is not busy */
> +       do {
> +               /* read smi register */
> +               smi_reg = readl(priv->lms_base + MVPP2_SMI);
> +               if (timeout-- == 0) {
> +                       printf("Error: SMI busy timeout\n");
> +                       return -EFAULT;
> +               }
> +       } while (smi_reg & MVPP2_SMI_BUSY);
> +
> +       return 0;
> +}
> +
> +/*
> + * mpp2_mdio_read - miiphy_read callback function.
> + *
> + * Returns 16bit phy register value, or 0xffff on error
> + */
> +static int mpp2_mdio_read(struct mii_dev *bus, int addr, int devad, int reg)
> +{
> +       struct mvpp2 *priv = bus->priv;
> +       u32 smi_reg;
> +       u32 timeout;
> +
> +       /* check parameters */
> +       if (addr > MVPP2_PHY_ADDR_MASK) {
> +               printf("Error: Invalid PHY address %d\n", addr);
> +               return -EFAULT;
> +       }
> +
> +       if (reg > MVPP2_PHY_REG_MASK) {
> +               printf("Err: Invalid register offset %d\n", reg);
> +               return -EFAULT;
> +       }
> +
> +       /* wait till the SMI is not busy */
> +       if (smi_wait_ready(priv) < 0)
> +               return -EFAULT;
> +
> +       /* fill the phy address and regiser offset and read opcode */
> +       smi_reg = (addr << MVPP2_SMI_DEV_ADDR_OFFS)
> +               | (reg << MVPP2_SMI_REG_ADDR_OFFS)
> +               | MVPP2_SMI_OPCODE_READ;
> +
> +       /* write the smi register */
> +       writel(smi_reg, priv->lms_base + MVPP2_SMI);
> +
> +       /* wait till read value is ready */
> +       timeout = MVPP2_SMI_TIMEOUT;
> +
> +       do {
> +               /* read smi register */
> +               smi_reg = readl(priv->lms_base + MVPP2_SMI);
> +               if (timeout-- == 0) {
> +                       printf("Err: SMI read ready timeout\n");
> +                       return -EFAULT;
> +               }
> +       } while (!(smi_reg & MVPP2_SMI_READ_VALID));
> +
> +       /* Wait for the data to update in the SMI register */
> +       for (timeout = 0; timeout < MVPP2_SMI_TIMEOUT; timeout++)
> +               ;
> +
> +       return readl(priv->lms_base + MVPP2_SMI) & MVPP2_SMI_DATA_MASK;
> +}
> +
> +/*
> + * mpp2_mdio_write - miiphy_write callback function.
> + *
> + * Returns 0 if write succeed, -EINVAL on bad parameters
> + * -ETIME on timeout
> + */
> +static int mpp2_mdio_write(struct mii_dev *bus, int addr, int devad, int reg,
> +                          u16 value)
> +{
> +       struct mvpp2 *priv = bus->priv;
> +       u32 smi_reg;
> +
> +       /* check parameters */
> +       if (addr > MVPP2_PHY_ADDR_MASK) {
> +               printf("Error: Invalid PHY address %d\n", addr);
> +               return -EFAULT;
> +       }
> +
> +       if (reg > MVPP2_PHY_REG_MASK) {
> +               printf("Err: Invalid register offset %d\n", reg);
> +               return -EFAULT;
> +       }
> +
> +       /* wait till the SMI is not busy */
> +       if (smi_wait_ready(priv) < 0)
> +               return -EFAULT;
> +
> +       /* fill the phy addr and reg offset and write opcode and data */
> +       smi_reg = value << MVPP2_SMI_DATA_OFFS;
> +       smi_reg |= (addr << MVPP2_SMI_DEV_ADDR_OFFS)
> +               | (reg << MVPP2_SMI_REG_ADDR_OFFS);
> +       smi_reg &= ~MVPP2_SMI_OPCODE_READ;
> +
> +       /* write the smi register */
> +       writel(smi_reg, priv->lms_base + MVPP2_SMI);
> +
> +       return 0;
> +}
> +
> +static int mvpp2_probe(struct udevice *dev)
> +{
> +       struct mvpp2_port *port = dev_get_priv(dev);
> +       struct mvpp2 *priv;
> +       struct mii_dev *bus;
> +       void *bd_space;
> +       int err;
> +       u32 size = 0;
> +       int i;
> +
> +       /*
> +        * This function is called multiple times. For each controller.
> +        * But we only need to do the main controller probing once. So
> +        * lets only do the port probing here, if called not for the
> +        * first time.
> +        */
> +       if (buffer_loc.tx_descs) {
> +               priv = buffer_loc.priv;
> +               port->priv = priv;
> +
> +               err = mvpp2_port_probe(dev, port, dev->of_offset, priv,
> +                                      &buffer_loc.first_rxq);
> +
> +               return 0;
> +       }
> +
> +       /*
> +        * U-Boot special buffer handling:
> +        *
> +        * Allocate buffer area for descs and rx_buffers. This is only
> +        * done once for all interfaces. As only one interface can
> +        * be active. Make this area DMA save by disabling the D-cache

DMA save -> DMA-safe

> +        */
> +
> +       /* Align buffer area for descs and rx_buffers to 1MiB */
> +       bd_space = memalign(1 << MMU_SECTION_SHIFT, BD_SPACE);
> +       mmu_set_region_dcache_behaviour((u32)bd_space, BD_SPACE, DCACHE_OFF);
> +
> +       buffer_loc.aggr_tx_descs = (struct mvpp2_tx_desc *)bd_space;
> +       size += MVPP2_AGGR_TXQ_SIZE * MVPP2_DESC_ALIGNED_SIZE;
> +
> +       buffer_loc.tx_descs = (struct mvpp2_tx_desc *)((u32)bd_space + size);
> +       size += MVPP2_MAX_TXD * MVPP2_DESC_ALIGNED_SIZE;
> +
> +       buffer_loc.rx_descs = (struct mvpp2_rx_desc *)((u32)bd_space + size);
> +       size += MVPP2_MAX_RXD * MVPP2_DESC_ALIGNED_SIZE;
> +
> +       for (i = 0; i < MVPP2_BM_POOLS_NUM; i++) {
> +               buffer_loc.bm_pool[i] = (u32 *)((u32)bd_space + size);
> +               size += MVPP2_BM_POOL_SIZE_MAX * sizeof(u32);
> +       }
> +
> +       for (i = 0; i < MVPP2_BM_LONG_BUF_NUM; i++) {
> +               buffer_loc.rx_buffer[i] = (u32 *)((u32)bd_space + size);
> +               size += RX_BUFFER_SIZE;
> +       }
> +
> +       /*
> +        * This is done only once, for the first controller that is
> +        * probed. Here the common structures are initialized.
> +        */

Any reason this isn't in the probe function for the MISC class parent driver?

> +       priv = calloc(1, sizeof(struct mvpp2));
> +       if (!priv)
> +               return -ENOMEM;
> +
> +       /* And save pointer to main mvpp2 struct */
> +       port->priv = priv;
> +       buffer_loc.priv = priv;
> +
> +       priv->base = (void *)dev_get_addr_index(dev->parent, 0);
> +       if (IS_ERR(priv->base))
> +               return PTR_ERR(priv->base);
> +
> +       priv->lms_base = (void *)dev_get_addr_index(dev->parent, 1);
> +       if (IS_ERR(priv->lms_base))
> +               return PTR_ERR(priv->lms_base);
> +
> +       /* Initialize network controller */
> +       err = mvpp2_init(dev, priv);
> +       if (err < 0) {
> +               dev_err(&pdev->dev, "failed to initialize controller\n");
> +               return err;
> +       }
> +
> +       err = mvpp2_port_probe(dev, port, dev->of_offset, priv,
> +                              &buffer_loc.first_rxq);
> +
> +       /*
> +        * Finally create and register the MDIO bus driver
> +        */
> +       bus = mdio_alloc();
> +       if (!bus) {
> +               printf("Failed to allocate MDIO bus\n");
> +               return -ENOMEM;
> +       }
> +
> +       bus->read = mpp2_mdio_read;
> +       bus->write = mpp2_mdio_write;
> +       snprintf(bus->name, sizeof(bus->name), dev->name);
> +       bus->priv = (void *)priv;
> +       priv->bus = bus;
> +
> +       return mdio_register(bus);
> +}
> +
> +static int mvpp2_recv(struct udevice *dev, int flags, uchar **packetp)
> +{
> +       struct mvpp2_port *port = dev_get_priv(dev);
> +       struct mvpp2_rx_desc *rx_desc;
> +       struct mvpp2_bm_pool *bm_pool;
> +       dma_addr_t phys_addr;
> +       u32 bm, rx_status;
> +       int pool, rx_bytes, err;
> +       int rx_received;
> +       struct mvpp2_rx_queue *rxq;
> +       u32 cause_rx_tx, cause_rx, cause_misc;
> +       u8 *data;
> +
> +       cause_rx_tx = mvpp2_read(port->priv,
> +                                MVPP2_ISR_RX_TX_CAUSE_REG(port->id));
> +       cause_rx_tx &= ~MVPP2_CAUSE_TXQ_OCCUP_DESC_ALL_MASK;
> +       cause_misc = cause_rx_tx & MVPP2_CAUSE_MISC_SUM_MASK;
> +       if (!cause_rx_tx && !cause_misc)
> +               return 0;
> +
> +       cause_rx = cause_rx_tx & MVPP2_CAUSE_RXQ_OCCUP_DESC_ALL_MASK;
> +
> +       /* Process RX packets */
> +       cause_rx |= port->pending_cause_rx;
> +       rxq = mvpp2_get_rx_queue(port, cause_rx);
> +
> +       /* Get number of received packets and clamp the to-do */
> +       rx_received = mvpp2_rxq_received(port, rxq->id);
> +
> +       /* Return if no packets are received */
> +       if (!rx_received)
> +               return 0;
> +
> +       rx_desc = mvpp2_rxq_next_desc_get(rxq);
> +       rx_status = rx_desc->status;
> +       rx_bytes = rx_desc->data_size - MVPP2_MH_SIZE;
> +       phys_addr = rx_desc->buf_phys_addr;
> +
> +       bm = mvpp2_bm_cookie_build(rx_desc);
> +       pool = mvpp2_bm_cookie_pool_get(bm);
> +       bm_pool = &port->priv->bm_pools[pool];
> +
> +       /* Check if buffer header is used */
> +       if (rx_status & MVPP2_RXD_BUF_HDR)
> +               return 0;
> +
> +       /* In case of an error, release the requested buffer pointer
> +        * to the Buffer Manager. This request process is controlled
> +        * by the hardware, and the information about the buffer is
> +        * comprised by the RX descriptor.
> +        */
> +       if (rx_status & MVPP2_RXD_ERR_SUMMARY) {
> +               mvpp2_rx_error(port, rx_desc);
> +               /* Return the buffer to the pool */
> +               mvpp2_pool_refill(port, bm, rx_desc->buf_phys_addr,
> +                                 rx_desc->buf_cookie);
> +               return 0;
> +       }
> +
> +       err = mvpp2_rx_refill(port, bm_pool, bm, phys_addr);
> +       if (err) {
> +               netdev_err(port->dev, "failed to refill BM pools\n");
> +               return 0;
> +       }
> +
> +       /* Update Rx queue management counters */
> +       mb();
> +       mvpp2_rxq_status_update(port, rxq->id, 1, 1);
> +
> +       /* give packet to stack - skip on first n bytes */
> +       data = (u8 *)phys_addr + 2 + 32;
> +
> +       if (rx_bytes <= 0)
> +               return 0;
> +
> +       /*
> +        * No cache invalidation needed here, since the rx_buffer's are
> +        * located in a uncached memory region
> +        */
> +       *packetp = data;
> +
> +       return rx_bytes;
> +}
> +
> +/* Drain Txq */
> +static void mvpp2_txq_drain(struct mvpp2_port *port, struct mvpp2_tx_queue *txq,
> +                           int enable)
> +{
> +       u32 val;
> +
> +       mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
> +       val = mvpp2_read(port->priv, MVPP2_TXQ_PREF_BUF_REG);
> +       if (enable)
> +               val |= MVPP2_TXQ_DRAIN_EN_MASK;
> +       else
> +               val &= ~MVPP2_TXQ_DRAIN_EN_MASK;
> +       mvpp2_write(port->priv, MVPP2_TXQ_PREF_BUF_REG, val);
> +}
> +
> +static int mvpp2_send(struct udevice *dev, void *packet, int length)
> +{
> +       struct mvpp2_port *port = dev_get_priv(dev);
> +       struct mvpp2_tx_queue *txq, *aggr_txq;
> +       struct mvpp2_tx_desc *tx_desc;
> +       int tx_done;
> +       int timeout;
> +
> +       txq = port->txqs[0];
> +       aggr_txq = &port->priv->aggr_txqs[smp_processor_id()];
> +
> +       /* Get a descriptor for the first part of the packet */
> +       tx_desc = mvpp2_txq_next_desc_get(aggr_txq);
> +       tx_desc->phys_txq = txq->id;
> +       tx_desc->data_size = length;
> +       tx_desc->packet_offset = (u32)packet & MVPP2_TX_DESC_ALIGN;
> +       tx_desc->buf_phys_addr = (u32)packet & ~MVPP2_TX_DESC_ALIGN;
> +       /* First and Last descriptor */
> +       tx_desc->command = MVPP2_TXD_L4_CSUM_NOT | MVPP2_TXD_IP_CSUM_DISABLE
> +               | MVPP2_TXD_F_DESC | MVPP2_TXD_L_DESC;
> +
> +       /* Flush tx data */
> +       flush_dcache_range((u32)packet, (u32)packet + length);
> +
> +       /* Enable transmit */
> +       mb();
> +       mvpp2_aggr_txq_pend_desc_add(port, 1);
> +
> +       mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
> +
> +       timeout = 0;
> +       do {
> +               if (timeout++ > 10000) {
> +                       printf("timeout: packet not sent from aggregated to phys TXQ\n");
> +                       return 0;
> +               }
> +               tx_done = mvpp2_txq_pend_desc_num_get(port, txq);
> +       } while (tx_done);
> +
> +       /* Enable TXQ drain */
> +       mvpp2_txq_drain(port, txq, 1);
> +
> +       timeout = 0;
> +       do {
> +               if (timeout++ > 10000) {
> +                       printf("timeout: packet not sent\n");
> +                       return 0;
> +               }
> +               tx_done = mvpp2_txq_sent_desc_proc(port, txq);
> +       } while (!tx_done);
> +
> +       /* Disable TXQ drain */
> +       mvpp2_txq_drain(port, txq, 0);
> +
> +       return 0;
> +}
> +
> +static int mvpp2_start(struct udevice *dev)
> +{
> +       struct eth_pdata *pdata = dev_get_platdata(dev);
> +       struct mvpp2_port *port = dev_get_priv(dev);
> +
> +       /* Load current MAC address */
> +       memcpy(port->dev_addr, pdata->enetaddr, ETH_ALEN);
> +
> +       /* Reconfigure parser accept the original MAC address */
> +       mvpp2_prs_update_mac_da(port, port->dev_addr);
> +
> +       mvpp2_port_power_up(port);
> +
> +       mvpp2_open(dev, port);
> +
> +       return 0;
> +}
> +
> +static void mvpp2_stop(struct udevice *dev)
> +{
> +       struct mvpp2_port *port = dev_get_priv(dev);
> +
> +       mvpp2_stop_dev(port);
> +       mvpp2_cleanup_rxqs(port);
> +       mvpp2_cleanup_txqs(port);
> +}
> +
> +static const struct eth_ops mvpp2_ops = {
> +       .start          = mvpp2_start,
> +       .send           = mvpp2_send,
> +       .recv           = mvpp2_recv,
> +       .stop           = mvpp2_stop,
> +};
> +
> +static struct driver mvpp2_driver = {
> +       .name   = "mvpp2",
> +       .id     = UCLASS_ETH,
> +       .probe  = mvpp2_probe,
> +       .ops    = &mvpp2_ops,
> +       .priv_auto_alloc_size = sizeof(struct mvpp2_port),
> +       .platdata_auto_alloc_size = sizeof(struct eth_pdata),
> +};
> +
> +/*
> + * Use a MISC device to bind the n instances (child nodes) of the
> + * network base controller in UCLASS_ETH.
> + */
> +static int mvpp2_base_bind(struct udevice *parent)
> +{
> +       const void *blob = gd->fdt_blob;
> +       int node = parent->of_offset;
> +       struct uclass_driver *drv;
> +       struct udevice *dev;
> +       struct eth_pdata *plat;
> +       char *name;
> +       int subnode;
> +       u32 id;
> +
> +       /* Lookup eth driver */
> +       drv = lists_uclass_lookup(UCLASS_ETH);
> +       if (!drv) {
> +               puts("Cannot find eth driver\n");
> +               return -ENOENT;
> +       }
> +
> +       fdt_for_each_subnode(blob, subnode, node) {
> +               /* Skip disabled ports */
> +               if (!fdtdec_get_is_enabled(blob, subnode))
> +                       continue;
> +
> +               plat = calloc(1, sizeof(*plat));
> +               if (!plat)
> +                       return -ENOMEM;
> +
> +               id = fdtdec_get_int(blob, subnode, "port-id", -1);
> +
> +               name = calloc(1, 16);
> +               sprintf(name, "mvpp2-%d", id);
> +
> +               /* Create child device UCLASS_ETH and bind it */
> +               device_bind(parent, &mvpp2_driver, name, plat, subnode, &dev);
> +               dev->of_offset = subnode;
> +       }
> +
> +       return 0;
> +}
> +
> +static const struct udevice_id mvpp2_ids[] = {
> +       { .compatible = "marvell,armada-375-pp2" },
> +       { }
> +};
> +
> +U_BOOT_DRIVER(mvpp2_base) = {
> +       .name   = "mvpp2_base",
> +       .id     = UCLASS_MISC,
> +       .of_match = mvpp2_ids,
> +       .bind   = mvpp2_base_bind,
> +};
> --
> 2.7.3
>

Mostly looks good to me.

-Joe

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 2/6] net: mvpp2.c: Add Marvell mvpp2 network driver for Armada 375
  2016-03-22 19:10   ` Joe Hershberger
@ 2016-03-23  6:39     ` Stefan Roese
  2016-03-25 21:04       ` Joe Hershberger
  0 siblings, 1 reply; 16+ messages in thread
From: Stefan Roese @ 2016-03-23  6:39 UTC (permalink / raw)
  To: u-boot

Hi Joe,

On 22.03.2016 20:10, Joe Hershberger wrote:
> Sorry for the delay.

No problem. Thanks for the review.

> On Tue, Mar 15, 2016 at 11:35 AM, Stefan Roese <sr@denx.de> wrote:
>> This patch adds support for the mvpp2 ethernet controller which is integrated
>> in the Marvell Armada 375 SoC. This port is based on the Linux driver (v4.4),
>> which has been stripped of the in U-Boot unused portions.
>>
>> Tested on the Marvell Armada 375 eval board db-88f6720.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Luka Perkov <luka.perkov@sartura.hr>
>> Cc: Joe Hershberger <joe.hershberger@gmail.com>
>> ---
>>   drivers/net/Kconfig  |    8 +
>>   drivers/net/Makefile |    1 +
>>   drivers/net/mvpp2.c  | 4222 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 4231 insertions(+)
>>   create mode 100644 drivers/net/mvpp2.c
>>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index bc2f51d..bcb4c96 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -94,6 +94,14 @@ config ETH_DESIGNWARE
>>            100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
>>            provide the PHY (physical media interface).
>>
>> +config MVPP2
>> +       bool "Marvell Armada 375 network interface support"
>> +       depends on ARMADA_375
>> +       select PHYLIB
>> +       help
>> +         This driver supports the network interface units in the
>> +         Marvell ARMADA 375 SoC.
>> +
>>   config PCH_GBE
>>          bool "Intel Platform Controller Hub EG20T GMAC driver"
>>          depends on DM_ETH && DM_PCI
>> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
>> index 33a81ee..fbedd04 100644
>> --- a/drivers/net/Makefile
>> +++ b/drivers/net/Makefile
>> @@ -42,6 +42,7 @@ obj-$(CONFIG_MPC5xxx_FEC) += mpc5xxx_fec.o
>>   obj-$(CONFIG_MPC512x_FEC) += mpc512x_fec.o
>>   obj-$(CONFIG_MVGBE) += mvgbe.o
>>   obj-$(CONFIG_MVNETA) += mvneta.o
>> +obj-$(CONFIG_MVPP2) += mvpp2.o
>>   obj-$(CONFIG_NATSEMI) += natsemi.o
>>   obj-$(CONFIG_DRIVER_NE2000) += ne2000.o ne2000_base.o
>>   obj-$(CONFIG_DRIVER_AX88796L) += ax88796.o ne2000_base.o
>> diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
>> new file mode 100644
>> index 0000000..09dfc7e
>> --- /dev/null
>> +++ b/drivers/net/mvpp2.c
>> @@ -0,0 +1,4222 @@
>> +/*
>> + * Driver for Marvell PPv2 network controller for Armada 375 SoC.
>> + *
>> + * Copyright (C) 2014 Marvell
>> + *
>> + * Marcin Wojtas <mw@semihalf.com>
>> + *
>> + * U-Boot version:
>> + * Copyright (C) 2016 Stefan Roese <sr@denx.de>
>> + *
>> + * This file is licensed under the terms of the GNU General Public
>> + * License version 2. This program is licensed "as is" without any
>> + * warranty of any kind, whether express or implied.
>> + */
>> +
>> +#include <common.h>
>> +#include <dm.h>
>> +#include <dm/device-internal.h>
>> +#include <dm/lists.h>
>> +#include <net.h>
>> +#include <netdev.h>
>> +#include <config.h>
>> +#include <malloc.h>
>> +#include <asm/io.h>
>> +#include <asm/errno.h>
>> +#include <phy.h>
>> +#include <miiphy.h>
>> +#include <watchdog.h>
>> +#include <asm/arch/cpu.h>
>> +#include <asm/arch/soc.h>
>> +#include <linux/compat.h>
>> +#include <linux/mbus.h>
>> +
>> +DECLARE_GLOBAL_DATA_PTR;
>> +
>> +#if !defined(CONFIG_PHYLIB)
>> +# error Marvell mvpp2 requires PHYLIB
>> +#endif
>
> This isn't needed since you "select" PHYLIB in the Kconfig.

Good catch. Removed in v2.

>> +
>> +/* Some linux -> U-Boot compatibility stuff */
>> +#define netdev_err(dev, fmt, args...)          \
>> +       printf(fmt, ##args)
>> +#define netdev_warn(dev, fmt, args...)         \
>> +       printf(fmt, ##args)
>> +#define netdev_info(dev, fmt, args...)         \
>> +       printf(fmt, ##args)
>> +#define netdev_dbg(dev, fmt, args...)          \
>> +       printf(fmt, ##args)
>> +
>> +#define ETH_ALEN       6               /* Octets in one ethernet addr  */
>> +
>> +#define ETH_P_IP       0x0800          /* Internet Protocol packet     */
>
> Already available in include/net.h as PROT_IP
>
>> +#define ETH_P_PPP_SES  0x8864          /* PPPoE session messages       */
>
> Add this to include/net.h as PROT_PPP_SES
>
>> +#define ETH_P_ARP      0x0806          /* Address Resolution packet    */
>
> Already available in include/net.h as PROT_ARP
>
>> +#define ETH_P_IPV6     0x86DD          /* IPv6 over bluebook           */
>
> Add this to include/net.h as PROT_IPV6

Changed to use these U-Boot defines instead. Thanks.

Does it perhaps make sense to globally change all those U-Boot defines
to the Linux ones instead?

>> +
>> +#define __verify_pcpu_ptr(ptr)                                         \
>> +do {                                                                   \
>> +       const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL;    \
>> +       (void)__vpp_verify;                                             \
>> +} while (0)
>> +
>> +#define VERIFY_PERCPU_PTR(__p)                                         \
>> +({                                                                     \
>> +       __verify_pcpu_ptr(__p);                                         \
>> +       (typeof(*(__p)) __kernel __force *)(__p);                       \
>> +})
>> +
>> +#define per_cpu_ptr(ptr, cpu)  ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); })
>> +#define smp_processor_id()     0
>> +#define num_present_cpus()     1
>> +#define for_each_present_cpu(cpu)                      \
>> +       for ((cpu) = 0; (cpu) < 1; (cpu)++)
>> +
>> +#define NET_SKB_PAD    max(32, MVPP2_CPU_D_CACHE_LINE_SIZE)
>> +
>> +#define CONFIG_NR_CPUS         1
>> +#define ETH_HLEN               14      /* Total octets in header */
>
> Already available in include/net.h as ETHER_HDR_SIZE.
>
>> +
>> +/* 2(HW hdr) 14(MAC hdr) 4(CRC) 32(extra for cache prefetch) */
>> +#define WRAP                   (2 + ETH_HLEN + 4 + 32)
>> +#define MTU                    1500
>> +#define RX_BUFFER_SIZE         (ALIGN(MTU + WRAP, ARCH_DMA_MINALIGN))
>
> <snip - constants>
>
>> +/*
>> + * Page table entries are set to 1MB, or multiples of 1MB
>> + * (not < 1MB). driver uses less bd's so use 1MB bdspace.
>> + */
>> +#define BD_SPACE       (1 << 20)
>
> It would be great if this long list of constants lived in a header
> file instead of the top of the source.

I'm not a big fan of using headers, when the macros / defines etc
are only referenced by this one file. Additionally, the original
Linux driver also includes all this in the C file. So it makes
syncing easier. I would like to keep it in one file.

>> +
>> +/* Utility/helper methods */
>> +
>> +static void mvpp2_write(struct mvpp2 *priv, u32 offset, u32 data)
>> +{
>> +       writel(data, priv->base + offset);
>> +}
>> +
>> +static u32 mvpp2_read(struct mvpp2 *priv, u32 offset)
>> +{
>> +       return readl(priv->base + offset);
>> +}
>> +
>
> <snip>
>
>> +
>> +/* Set hw internals when starting port */
>> +static void mvpp2_start_dev(struct mvpp2_port *port)
>> +{
>> +       mvpp2_gmac_max_rx_size_set(port);
>> +       mvpp2_txp_max_tx_size_set(port);
>> +
>> +       mvpp2_port_enable(port);
>> +}
>> +
>> +/* Set hw internals when stopping port */
>> +static void mvpp2_stop_dev(struct mvpp2_port *port)
>> +{
>> +       /* Stop new packets from arriving to RXQs */
>> +       mvpp2_ingress_disable(port);
>> +
>> +       mvpp2_egress_disable(port);
>> +       mvpp2_port_disable(port);
>> +}
>> +
>> +static int mvpp2_phy_connect(struct udevice *dev, struct mvpp2_port *port)
>> +{
>> +       struct phy_device *phy_dev;
>> +
>> +       if (!port->init || port->link == 0) {
>> +               phy_dev = phy_connect(port->priv->bus, port->phyaddr, dev,
>> +                                     port->phy_interface);
>> +               port->phy_dev = phy_dev;
>> +               if (!phy_dev) {
>> +                       netdev_err(port->dev, "cannot connect to phy\n");
>> +                       return -ENODEV;
>> +               }
>> +               phy_dev->supported &= PHY_GBIT_FEATURES;
>> +               phy_dev->advertising = phy_dev->supported;
>> +
>> +               port->phy_dev = phy_dev;
>> +               port->link    = 0;
>> +               port->duplex  = 0;
>> +               port->speed   = 0;
>> +
>> +               phy_config(phy_dev);
>> +               phy_startup(phy_dev);
>> +               if (!phy_dev->link) {
>> +                       printf("%s: No link\n", phy_dev->dev->name);
>> +                       return -1;
>> +               }
>> +
>> +               port->init = 1;
>> +       } else {
>> +               mvpp2_egress_enable(port);
>> +               mvpp2_ingress_enable(port);
>> +       }
>> +
>> +       return 0;
>> +}
>> +
>> +static int mvpp2_open(struct udevice *dev, struct mvpp2_port *port)
>> +{
>> +       unsigned char mac_bcast[ETH_ALEN] = {
>> +                       0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
>> +       int err;
>> +
>> +       err = mvpp2_prs_mac_da_accept(port->priv, port->id, mac_bcast, true);
>> +       if (err) {
>> +               netdev_err(dev, "mvpp2_prs_mac_da_accept BC failed\n");
>> +               return err;
>> +       }
>> +       err = mvpp2_prs_mac_da_accept(port->priv, port->id,
>> +                                     port->dev_addr, true);
>> +       if (err) {
>> +               netdev_err(dev, "mvpp2_prs_mac_da_accept MC failed\n");
>> +               return err;
>> +       }
>> +       err = mvpp2_prs_def_flow(port);
>> +       if (err) {
>> +               netdev_err(dev, "mvpp2_prs_def_flow failed\n");
>> +               return err;
>> +       }
>> +
>> +       /* Allocate the Rx/Tx queues */
>> +       err = mvpp2_setup_rxqs(port);
>> +       if (err) {
>> +               netdev_err(port->dev, "cannot allocate Rx queues\n");
>> +               return err;
>> +       }
>> +
>> +       err = mvpp2_setup_txqs(port);
>> +       if (err) {
>> +               netdev_err(port->dev, "cannot allocate Tx queues\n");
>> +               return err;
>> +       }
>> +
>> +       err = mvpp2_phy_connect(dev, port);
>> +       if (err < 0)
>> +               return err;
>> +
>> +       mvpp2_link_event(port);
>> +
>> +       mvpp2_start_dev(port);
>> +
>> +       return 0;
>> +}
>> +
>> +/* No Device ops here in U-Boot */
>> +
>> +/* Driver initialization */
>> +
>> +static void mvpp2_port_power_up(struct mvpp2_port *port)
>> +{
>> +       mvpp2_port_mii_set(port);
>> +       mvpp2_port_periodic_xon_disable(port);
>> +       mvpp2_port_fc_adv_enable(port);
>> +       mvpp2_port_reset(port);
>> +}
>> +
>> +/* Initialize port HW */
>> +static int mvpp2_port_init(struct udevice *dev, struct mvpp2_port *port)
>> +{
>> +       struct mvpp2 *priv = port->priv;
>> +       struct mvpp2_txq_pcpu *txq_pcpu;
>> +       int queue, cpu, err;
>> +
>> +       if (port->first_rxq + rxq_number > MVPP2_RXQ_TOTAL_NUM)
>> +               return -EINVAL;
>> +
>> +       /* Disable port */
>> +       mvpp2_egress_disable(port);
>> +       mvpp2_port_disable(port);
>> +
>> +       port->txqs = devm_kcalloc(dev, txq_number, sizeof(*port->txqs),
>> +                                 GFP_KERNEL);
>> +       if (!port->txqs)
>> +               return -ENOMEM;
>> +
>> +       /* Associate physical Tx queues to this port and initialize.
>> +        * The mapping is predefined.
>> +        */
>> +       for (queue = 0; queue < txq_number; queue++) {
>> +               int queue_phy_id = mvpp2_txq_phys(port->id, queue);
>> +               struct mvpp2_tx_queue *txq;
>> +
>> +               txq = devm_kzalloc(dev, sizeof(*txq), GFP_KERNEL);
>> +               if (!txq)
>> +                       return -ENOMEM;
>> +
>> +               txq->pcpu = devm_kzalloc(dev, sizeof(struct mvpp2_txq_pcpu),
>> +                                        GFP_KERNEL);
>> +               if (!txq->pcpu)
>> +                       return -ENOMEM;
>> +
>> +               txq->id = queue_phy_id;
>> +               txq->log_id = queue;
>> +               txq->done_pkts_coal = MVPP2_TXDONE_COAL_PKTS_THRESH;
>> +               for_each_present_cpu(cpu) {
>> +                       txq_pcpu = per_cpu_ptr(txq->pcpu, cpu);
>> +                       txq_pcpu->cpu = cpu;
>> +               }
>> +
>> +               port->txqs[queue] = txq;
>> +       }
>> +
>> +       port->rxqs = devm_kcalloc(dev, rxq_number, sizeof(*port->rxqs),
>> +                                 GFP_KERNEL);
>> +       if (!port->rxqs)
>> +               return -ENOMEM;
>> +
>> +       /* Allocate and initialize Rx queue for this port */
>> +       for (queue = 0; queue < rxq_number; queue++) {
>> +               struct mvpp2_rx_queue *rxq;
>> +
>> +               /* Map physical Rx queue to port's logical Rx queue */
>> +               rxq = devm_kzalloc(dev, sizeof(*rxq), GFP_KERNEL);
>> +               if (!rxq)
>> +                       return -ENOMEM;
>> +               /* Map this Rx queue to a physical queue */
>> +               rxq->id = port->first_rxq + queue;
>> +               rxq->port = port->id;
>> +               rxq->logic_rxq = queue;
>> +
>> +               port->rxqs[queue] = rxq;
>> +       }
>> +
>> +       /* Configure Rx queue group interrupt for this port */
>> +       mvpp2_write(priv, MVPP2_ISR_RXQ_GROUP_REG(port->id), CONFIG_MV_ETH_RXQ);
>> +
>> +       /* Create Rx descriptor rings */
>> +       for (queue = 0; queue < rxq_number; queue++) {
>> +               struct mvpp2_rx_queue *rxq = port->rxqs[queue];
>> +
>> +               rxq->size = port->rx_ring_size;
>> +               rxq->pkts_coal = MVPP2_RX_COAL_PKTS;
>> +               rxq->time_coal = MVPP2_RX_COAL_USEC;
>> +       }
>> +
>> +       mvpp2_ingress_disable(port);
>> +
>> +       /* Port default configuration */
>> +       mvpp2_defaults_set(port);
>> +
>> +       /* Port's classifier configuration */
>> +       mvpp2_cls_oversize_rxq_set(port);
>> +       mvpp2_cls_port_config(port);
>> +
>> +       /* Provide an initial Rx packet size */
>> +       port->pkt_size = MVPP2_RX_PKT_SIZE(PKTSIZE_ALIGN);
>> +
>> +       /* Initialize pools for swf */
>> +       err = mvpp2_swf_bm_pool_init(port);
>> +       if (err)
>> +               return err;
>> +
>> +       return 0;
>> +}
>> +
>> +/* Ports initialization */
>> +static int mvpp2_port_probe(struct udevice *dev,
>> +                           struct mvpp2_port *port,
>> +                           int port_node,
>> +                           struct mvpp2 *priv,
>> +                           int *next_first_rxq)
>> +{
>> +       int phy_node;
>> +       u32 id;
>> +       u32 phyaddr;
>> +       const char *phy_mode_str;
>> +       int phy_mode = -1;
>> +       int priv_common_regs_num = 2;
>> +       int err;
>> +
>> +       phy_node = fdtdec_lookup_phandle(gd->fdt_blob, port_node, "phy");
>> +       if (phy_node < 0) {
>> +               dev_err(&pdev->dev, "missing phy\n");
>> +               return -ENODEV;
>> +       }
>> +
>> +       phy_mode_str = fdt_getprop(gd->fdt_blob, port_node, "phy-mode", NULL);
>> +       if (phy_mode_str)
>> +               phy_mode = phy_get_interface_by_name(phy_mode_str);
>> +       if (phy_mode == -1) {
>> +               dev_err(&pdev->dev, "incorrect phy mode\n");
>> +               return -EINVAL;
>> +       }
>> +
>> +       id = fdtdec_get_int(gd->fdt_blob, port_node, "port-id", -1);
>> +       if (id == -1) {
>> +               dev_err(&pdev->dev, "missing port-id value\n");
>> +               return -EINVAL;
>> +       }
>> +
>> +       phyaddr = fdtdec_get_int(gd->fdt_blob, phy_node, "reg", 0);
>> +
>> +       port->priv = priv;
>> +       port->id = id;
>> +       port->first_rxq = *next_first_rxq;
>> +       port->phy_node = phy_node;
>> +       port->phy_interface = phy_mode;
>> +       port->phyaddr = phyaddr;
>> +
>> +       port->base = (void __iomem *)dev_get_addr_index(dev->parent,
>> +                                                       priv_common_regs_num
>> +                                                       + id);
>> +       if (IS_ERR(port->base))
>> +               return PTR_ERR(port->base);
>> +
>> +       port->tx_ring_size = MVPP2_MAX_TXD;
>> +       port->rx_ring_size = MVPP2_MAX_RXD;
>> +
>> +       err = mvpp2_port_init(dev, port);
>> +       if (err < 0) {
>> +               dev_err(&pdev->dev, "failed to init port %d\n", id);
>> +               return err;
>> +       }
>> +       mvpp2_port_power_up(port);
>> +
>> +       /* Increment the first Rx queue number to be used by the next port */
>> +       *next_first_rxq += CONFIG_MV_ETH_RXQ;
>> +       priv->port_list[id] = port;
>> +       return 0;
>> +}
>> +
>> +/* Initialize decoding windows */
>> +static void mvpp2_conf_mbus_windows(const struct mbus_dram_target_info *dram,
>> +                                   struct mvpp2 *priv)
>> +{
>> +       u32 win_enable;
>> +       int i;
>> +
>> +       for (i = 0; i < 6; i++) {
>> +               mvpp2_write(priv, MVPP2_WIN_BASE(i), 0);
>> +               mvpp2_write(priv, MVPP2_WIN_SIZE(i), 0);
>> +
>> +               if (i < 4)
>> +                       mvpp2_write(priv, MVPP2_WIN_REMAP(i), 0);
>> +       }
>> +
>> +       win_enable = 0;
>> +
>> +       for (i = 0; i < dram->num_cs; i++) {
>> +               const struct mbus_dram_window *cs = dram->cs + i;
>> +
>> +               mvpp2_write(priv, MVPP2_WIN_BASE(i),
>> +                           (cs->base & 0xffff0000) | (cs->mbus_attr << 8) |
>> +                           dram->mbus_dram_target_id);
>> +
>> +               mvpp2_write(priv, MVPP2_WIN_SIZE(i),
>> +                           (cs->size - 1) & 0xffff0000);
>> +
>> +               win_enable |= (1 << i);
>> +       }
>> +
>> +       mvpp2_write(priv, MVPP2_BASE_ADDR_ENABLE, win_enable);
>> +}
>> +
>> +/* Initialize Rx FIFO's */
>> +static void mvpp2_rx_fifo_init(struct mvpp2 *priv)
>> +{
>> +       int port;
>> +
>> +       for (port = 0; port < MVPP2_MAX_PORTS; port++) {
>> +               mvpp2_write(priv, MVPP2_RX_DATA_FIFO_SIZE_REG(port),
>> +                           MVPP2_RX_FIFO_PORT_DATA_SIZE);
>> +               mvpp2_write(priv, MVPP2_RX_ATTR_FIFO_SIZE_REG(port),
>> +                           MVPP2_RX_FIFO_PORT_ATTR_SIZE);
>> +       }
>> +
>> +       mvpp2_write(priv, MVPP2_RX_MIN_PKT_SIZE_REG,
>> +                   MVPP2_RX_FIFO_PORT_MIN_PKT);
>> +       mvpp2_write(priv, MVPP2_RX_FIFO_INIT_REG, 0x1);
>> +}
>> +
>> +/* Initialize network controller common part HW */
>> +static int mvpp2_init(struct udevice *dev, struct mvpp2 *priv)
>> +{
>> +       const struct mbus_dram_target_info *dram_target_info;
>> +       int err, i;
>> +       u32 val;
>> +
>> +       /* Checks for hardware constraints (U-Boot uses only one rxq) */
>> +       if ((rxq_number > MVPP2_MAX_RXQ) || (txq_number > MVPP2_MAX_TXQ)) {
>> +               dev_err(&pdev->dev, "invalid queue size parameter\n");
>> +               return -EINVAL;
>> +       }
>> +
>> +       /* MBUS windows configuration */
>> +       dram_target_info = mvebu_mbus_dram_info();
>> +       if (dram_target_info)
>> +               mvpp2_conf_mbus_windows(dram_target_info, priv);
>> +
>> +       /* Disable HW PHY polling */
>> +       val = readl(priv->lms_base + MVPP2_PHY_AN_CFG0_REG);
>> +       val |= MVPP2_PHY_AN_STOP_SMI0_MASK;
>> +       writel(val, priv->lms_base + MVPP2_PHY_AN_CFG0_REG);
>> +
>> +       /* Allocate and initialize aggregated TXQs */
>> +       priv->aggr_txqs = devm_kcalloc(dev, num_present_cpus(),
>> +                                      sizeof(struct mvpp2_tx_queue),
>> +                                      GFP_KERNEL);
>> +       if (!priv->aggr_txqs)
>> +               return -ENOMEM;
>> +
>> +       for_each_present_cpu(i) {
>> +               priv->aggr_txqs[i].id = i;
>> +               priv->aggr_txqs[i].size = MVPP2_AGGR_TXQ_SIZE;
>> +               err = mvpp2_aggr_txq_init(dev, &priv->aggr_txqs[i],
>> +                                         MVPP2_AGGR_TXQ_SIZE, i, priv);
>> +               if (err < 0)
>> +                       return err;
>> +       }
>> +
>> +       /* Rx Fifo Init */
>> +       mvpp2_rx_fifo_init(priv);
>> +
>> +       /* Reset Rx queue group interrupt configuration */
>> +       for (i = 0; i < MVPP2_MAX_PORTS; i++)
>> +               mvpp2_write(priv, MVPP2_ISR_RXQ_GROUP_REG(i),
>> +                           CONFIG_MV_ETH_RXQ);
>> +
>> +       writel(MVPP2_EXT_GLOBAL_CTRL_DEFAULT,
>> +              priv->lms_base + MVPP2_MNG_EXTENDED_GLOBAL_CTRL_REG);
>> +
>> +       /* Allow cache snoop when transmiting packets */
>> +       mvpp2_write(priv, MVPP2_TX_SNOOP_REG, 0x1);
>> +
>> +       /* Buffer Manager initialization */
>> +       err = mvpp2_bm_init(dev, priv);
>> +       if (err < 0)
>> +               return err;
>> +
>> +       /* Parser default initialization */
>> +       err = mvpp2_prs_default_init(dev, priv);
>> +       if (err < 0)
>> +               return err;
>> +
>> +       /* Classifier default initialization */
>> +       mvpp2_cls_init(priv);
>> +
>> +       return 0;
>> +}
>> +
>> +/* SMI / MDIO functions */
>> +
>> +static int smi_wait_ready(struct mvpp2 *priv)
>> +{
>> +       u32 timeout = MVPP2_SMI_TIMEOUT;
>> +       u32 smi_reg;
>> +
>> +       /* wait till the SMI is not busy */
>> +       do {
>> +               /* read smi register */
>> +               smi_reg = readl(priv->lms_base + MVPP2_SMI);
>> +               if (timeout-- == 0) {
>> +                       printf("Error: SMI busy timeout\n");
>> +                       return -EFAULT;
>> +               }
>> +       } while (smi_reg & MVPP2_SMI_BUSY);
>> +
>> +       return 0;
>> +}
>> +
>> +/*
>> + * mpp2_mdio_read - miiphy_read callback function.
>> + *
>> + * Returns 16bit phy register value, or 0xffff on error
>> + */
>> +static int mpp2_mdio_read(struct mii_dev *bus, int addr, int devad, int reg)
>> +{
>> +       struct mvpp2 *priv = bus->priv;
>> +       u32 smi_reg;
>> +       u32 timeout;
>> +
>> +       /* check parameters */
>> +       if (addr > MVPP2_PHY_ADDR_MASK) {
>> +               printf("Error: Invalid PHY address %d\n", addr);
>> +               return -EFAULT;
>> +       }
>> +
>> +       if (reg > MVPP2_PHY_REG_MASK) {
>> +               printf("Err: Invalid register offset %d\n", reg);
>> +               return -EFAULT;
>> +       }
>> +
>> +       /* wait till the SMI is not busy */
>> +       if (smi_wait_ready(priv) < 0)
>> +               return -EFAULT;
>> +
>> +       /* fill the phy address and regiser offset and read opcode */
>> +       smi_reg = (addr << MVPP2_SMI_DEV_ADDR_OFFS)
>> +               | (reg << MVPP2_SMI_REG_ADDR_OFFS)
>> +               | MVPP2_SMI_OPCODE_READ;
>> +
>> +       /* write the smi register */
>> +       writel(smi_reg, priv->lms_base + MVPP2_SMI);
>> +
>> +       /* wait till read value is ready */
>> +       timeout = MVPP2_SMI_TIMEOUT;
>> +
>> +       do {
>> +               /* read smi register */
>> +               smi_reg = readl(priv->lms_base + MVPP2_SMI);
>> +               if (timeout-- == 0) {
>> +                       printf("Err: SMI read ready timeout\n");
>> +                       return -EFAULT;
>> +               }
>> +       } while (!(smi_reg & MVPP2_SMI_READ_VALID));
>> +
>> +       /* Wait for the data to update in the SMI register */
>> +       for (timeout = 0; timeout < MVPP2_SMI_TIMEOUT; timeout++)
>> +               ;
>> +
>> +       return readl(priv->lms_base + MVPP2_SMI) & MVPP2_SMI_DATA_MASK;
>> +}
>> +
>> +/*
>> + * mpp2_mdio_write - miiphy_write callback function.
>> + *
>> + * Returns 0 if write succeed, -EINVAL on bad parameters
>> + * -ETIME on timeout
>> + */
>> +static int mpp2_mdio_write(struct mii_dev *bus, int addr, int devad, int reg,
>> +                          u16 value)
>> +{
>> +       struct mvpp2 *priv = bus->priv;
>> +       u32 smi_reg;
>> +
>> +       /* check parameters */
>> +       if (addr > MVPP2_PHY_ADDR_MASK) {
>> +               printf("Error: Invalid PHY address %d\n", addr);
>> +               return -EFAULT;
>> +       }
>> +
>> +       if (reg > MVPP2_PHY_REG_MASK) {
>> +               printf("Err: Invalid register offset %d\n", reg);
>> +               return -EFAULT;
>> +       }
>> +
>> +       /* wait till the SMI is not busy */
>> +       if (smi_wait_ready(priv) < 0)
>> +               return -EFAULT;
>> +
>> +       /* fill the phy addr and reg offset and write opcode and data */
>> +       smi_reg = value << MVPP2_SMI_DATA_OFFS;
>> +       smi_reg |= (addr << MVPP2_SMI_DEV_ADDR_OFFS)
>> +               | (reg << MVPP2_SMI_REG_ADDR_OFFS);
>> +       smi_reg &= ~MVPP2_SMI_OPCODE_READ;
>> +
>> +       /* write the smi register */
>> +       writel(smi_reg, priv->lms_base + MVPP2_SMI);
>> +
>> +       return 0;
>> +}
>> +
>> +static int mvpp2_probe(struct udevice *dev)
>> +{
>> +       struct mvpp2_port *port = dev_get_priv(dev);
>> +       struct mvpp2 *priv;
>> +       struct mii_dev *bus;
>> +       void *bd_space;
>> +       int err;
>> +       u32 size = 0;
>> +       int i;
>> +
>> +       /*
>> +        * This function is called multiple times. For each controller.
>> +        * But we only need to do the main controller probing once. So
>> +        * lets only do the port probing here, if called not for the
>> +        * first time.
>> +        */
>> +       if (buffer_loc.tx_descs) {
>> +               priv = buffer_loc.priv;
>> +               port->priv = priv;
>> +
>> +               err = mvpp2_port_probe(dev, port, dev->of_offset, priv,
>> +                                      &buffer_loc.first_rxq);
>> +
>> +               return 0;
>> +       }
>> +
>> +       /*
>> +        * U-Boot special buffer handling:
>> +        *
>> +        * Allocate buffer area for descs and rx_buffers. This is only
>> +        * done once for all interfaces. As only one interface can
>> +        * be active. Make this area DMA save by disabling the D-cache
>
> DMA save -> DMA-safe

Fixed.

>> +        */
>> +
>> +       /* Align buffer area for descs and rx_buffers to 1MiB */
>> +       bd_space = memalign(1 << MMU_SECTION_SHIFT, BD_SPACE);
>> +       mmu_set_region_dcache_behaviour((u32)bd_space, BD_SPACE, DCACHE_OFF);
>> +
>> +       buffer_loc.aggr_tx_descs = (struct mvpp2_tx_desc *)bd_space;
>> +       size += MVPP2_AGGR_TXQ_SIZE * MVPP2_DESC_ALIGNED_SIZE;
>> +
>> +       buffer_loc.tx_descs = (struct mvpp2_tx_desc *)((u32)bd_space + size);
>> +       size += MVPP2_MAX_TXD * MVPP2_DESC_ALIGNED_SIZE;
>> +
>> +       buffer_loc.rx_descs = (struct mvpp2_rx_desc *)((u32)bd_space + size);
>> +       size += MVPP2_MAX_RXD * MVPP2_DESC_ALIGNED_SIZE;
>> +
>> +       for (i = 0; i < MVPP2_BM_POOLS_NUM; i++) {
>> +               buffer_loc.bm_pool[i] = (u32 *)((u32)bd_space + size);
>> +               size += MVPP2_BM_POOL_SIZE_MAX * sizeof(u32);
>> +       }
>> +
>> +       for (i = 0; i < MVPP2_BM_LONG_BUF_NUM; i++) {
>> +               buffer_loc.rx_buffer[i] = (u32 *)((u32)bd_space + size);
>> +               size += RX_BUFFER_SIZE;
>> +       }
>> +
>> +       /*
>> +        * This is done only once, for the first controller that is
>> +        * probed. Here the common structures are initialized.
>> +        */
>
> Any reason this isn't in the probe function for the MISC class parent driver?

Not really. I've moved most of this into the new probe function
of the parent driver. Looks much cleaner this may. Thanks.

>> +       priv = calloc(1, sizeof(struct mvpp2));
>> +       if (!priv)
>> +               return -ENOMEM;
>> +
>> +       /* And save pointer to main mvpp2 struct */
>> +       port->priv = priv;
>> +       buffer_loc.priv = priv;
>> +
>> +       priv->base = (void *)dev_get_addr_index(dev->parent, 0);
>> +       if (IS_ERR(priv->base))
>> +               return PTR_ERR(priv->base);
>> +
>> +       priv->lms_base = (void *)dev_get_addr_index(dev->parent, 1);
>> +       if (IS_ERR(priv->lms_base))
>> +               return PTR_ERR(priv->lms_base);
>> +
>> +       /* Initialize network controller */
>> +       err = mvpp2_init(dev, priv);
>> +       if (err < 0) {
>> +               dev_err(&pdev->dev, "failed to initialize controller\n");
>> +               return err;
>> +       }
>> +
>> +       err = mvpp2_port_probe(dev, port, dev->of_offset, priv,
>> +                              &buffer_loc.first_rxq);
>> +
>> +       /*
>> +        * Finally create and register the MDIO bus driver
>> +        */
>> +       bus = mdio_alloc();
>> +       if (!bus) {
>> +               printf("Failed to allocate MDIO bus\n");
>> +               return -ENOMEM;
>> +       }
>> +
>> +       bus->read = mpp2_mdio_read;
>> +       bus->write = mpp2_mdio_write;
>> +       snprintf(bus->name, sizeof(bus->name), dev->name);
>> +       bus->priv = (void *)priv;
>> +       priv->bus = bus;
>> +
>> +       return mdio_register(bus);
>> +}
>> +
>> +static int mvpp2_recv(struct udevice *dev, int flags, uchar **packetp)
>> +{
>> +       struct mvpp2_port *port = dev_get_priv(dev);
>> +       struct mvpp2_rx_desc *rx_desc;
>> +       struct mvpp2_bm_pool *bm_pool;
>> +       dma_addr_t phys_addr;
>> +       u32 bm, rx_status;
>> +       int pool, rx_bytes, err;
>> +       int rx_received;
>> +       struct mvpp2_rx_queue *rxq;
>> +       u32 cause_rx_tx, cause_rx, cause_misc;
>> +       u8 *data;
>> +
>> +       cause_rx_tx = mvpp2_read(port->priv,
>> +                                MVPP2_ISR_RX_TX_CAUSE_REG(port->id));
>> +       cause_rx_tx &= ~MVPP2_CAUSE_TXQ_OCCUP_DESC_ALL_MASK;
>> +       cause_misc = cause_rx_tx & MVPP2_CAUSE_MISC_SUM_MASK;
>> +       if (!cause_rx_tx && !cause_misc)
>> +               return 0;
>> +
>> +       cause_rx = cause_rx_tx & MVPP2_CAUSE_RXQ_OCCUP_DESC_ALL_MASK;
>> +
>> +       /* Process RX packets */
>> +       cause_rx |= port->pending_cause_rx;
>> +       rxq = mvpp2_get_rx_queue(port, cause_rx);
>> +
>> +       /* Get number of received packets and clamp the to-do */
>> +       rx_received = mvpp2_rxq_received(port, rxq->id);
>> +
>> +       /* Return if no packets are received */
>> +       if (!rx_received)
>> +               return 0;
>> +
>> +       rx_desc = mvpp2_rxq_next_desc_get(rxq);
>> +       rx_status = rx_desc->status;
>> +       rx_bytes = rx_desc->data_size - MVPP2_MH_SIZE;
>> +       phys_addr = rx_desc->buf_phys_addr;
>> +
>> +       bm = mvpp2_bm_cookie_build(rx_desc);
>> +       pool = mvpp2_bm_cookie_pool_get(bm);
>> +       bm_pool = &port->priv->bm_pools[pool];
>> +
>> +       /* Check if buffer header is used */
>> +       if (rx_status & MVPP2_RXD_BUF_HDR)
>> +               return 0;
>> +
>> +       /* In case of an error, release the requested buffer pointer
>> +        * to the Buffer Manager. This request process is controlled
>> +        * by the hardware, and the information about the buffer is
>> +        * comprised by the RX descriptor.
>> +        */
>> +       if (rx_status & MVPP2_RXD_ERR_SUMMARY) {
>> +               mvpp2_rx_error(port, rx_desc);
>> +               /* Return the buffer to the pool */
>> +               mvpp2_pool_refill(port, bm, rx_desc->buf_phys_addr,
>> +                                 rx_desc->buf_cookie);
>> +               return 0;
>> +       }
>> +
>> +       err = mvpp2_rx_refill(port, bm_pool, bm, phys_addr);
>> +       if (err) {
>> +               netdev_err(port->dev, "failed to refill BM pools\n");
>> +               return 0;
>> +       }
>> +
>> +       /* Update Rx queue management counters */
>> +       mb();
>> +       mvpp2_rxq_status_update(port, rxq->id, 1, 1);
>> +
>> +       /* give packet to stack - skip on first n bytes */
>> +       data = (u8 *)phys_addr + 2 + 32;
>> +
>> +       if (rx_bytes <= 0)
>> +               return 0;
>> +
>> +       /*
>> +        * No cache invalidation needed here, since the rx_buffer's are
>> +        * located in a uncached memory region
>> +        */
>> +       *packetp = data;
>> +
>> +       return rx_bytes;
>> +}
>> +
>> +/* Drain Txq */
>> +static void mvpp2_txq_drain(struct mvpp2_port *port, struct mvpp2_tx_queue *txq,
>> +                           int enable)
>> +{
>> +       u32 val;
>> +
>> +       mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
>> +       val = mvpp2_read(port->priv, MVPP2_TXQ_PREF_BUF_REG);
>> +       if (enable)
>> +               val |= MVPP2_TXQ_DRAIN_EN_MASK;
>> +       else
>> +               val &= ~MVPP2_TXQ_DRAIN_EN_MASK;
>> +       mvpp2_write(port->priv, MVPP2_TXQ_PREF_BUF_REG, val);
>> +}
>> +
>> +static int mvpp2_send(struct udevice *dev, void *packet, int length)
>> +{
>> +       struct mvpp2_port *port = dev_get_priv(dev);
>> +       struct mvpp2_tx_queue *txq, *aggr_txq;
>> +       struct mvpp2_tx_desc *tx_desc;
>> +       int tx_done;
>> +       int timeout;
>> +
>> +       txq = port->txqs[0];
>> +       aggr_txq = &port->priv->aggr_txqs[smp_processor_id()];
>> +
>> +       /* Get a descriptor for the first part of the packet */
>> +       tx_desc = mvpp2_txq_next_desc_get(aggr_txq);
>> +       tx_desc->phys_txq = txq->id;
>> +       tx_desc->data_size = length;
>> +       tx_desc->packet_offset = (u32)packet & MVPP2_TX_DESC_ALIGN;
>> +       tx_desc->buf_phys_addr = (u32)packet & ~MVPP2_TX_DESC_ALIGN;
>> +       /* First and Last descriptor */
>> +       tx_desc->command = MVPP2_TXD_L4_CSUM_NOT | MVPP2_TXD_IP_CSUM_DISABLE
>> +               | MVPP2_TXD_F_DESC | MVPP2_TXD_L_DESC;
>> +
>> +       /* Flush tx data */
>> +       flush_dcache_range((u32)packet, (u32)packet + length);
>> +
>> +       /* Enable transmit */
>> +       mb();
>> +       mvpp2_aggr_txq_pend_desc_add(port, 1);
>> +
>> +       mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
>> +
>> +       timeout = 0;
>> +       do {
>> +               if (timeout++ > 10000) {
>> +                       printf("timeout: packet not sent from aggregated to phys TXQ\n");
>> +                       return 0;
>> +               }
>> +               tx_done = mvpp2_txq_pend_desc_num_get(port, txq);
>> +       } while (tx_done);
>> +
>> +       /* Enable TXQ drain */
>> +       mvpp2_txq_drain(port, txq, 1);
>> +
>> +       timeout = 0;
>> +       do {
>> +               if (timeout++ > 10000) {
>> +                       printf("timeout: packet not sent\n");
>> +                       return 0;
>> +               }
>> +               tx_done = mvpp2_txq_sent_desc_proc(port, txq);
>> +       } while (!tx_done);
>> +
>> +       /* Disable TXQ drain */
>> +       mvpp2_txq_drain(port, txq, 0);
>> +
>> +       return 0;
>> +}
>> +
>> +static int mvpp2_start(struct udevice *dev)
>> +{
>> +       struct eth_pdata *pdata = dev_get_platdata(dev);
>> +       struct mvpp2_port *port = dev_get_priv(dev);
>> +
>> +       /* Load current MAC address */
>> +       memcpy(port->dev_addr, pdata->enetaddr, ETH_ALEN);
>> +
>> +       /* Reconfigure parser accept the original MAC address */
>> +       mvpp2_prs_update_mac_da(port, port->dev_addr);
>> +
>> +       mvpp2_port_power_up(port);
>> +
>> +       mvpp2_open(dev, port);
>> +
>> +       return 0;
>> +}
>> +
>> +static void mvpp2_stop(struct udevice *dev)
>> +{
>> +       struct mvpp2_port *port = dev_get_priv(dev);
>> +
>> +       mvpp2_stop_dev(port);
>> +       mvpp2_cleanup_rxqs(port);
>> +       mvpp2_cleanup_txqs(port);
>> +}
>> +
>> +static const struct eth_ops mvpp2_ops = {
>> +       .start          = mvpp2_start,
>> +       .send           = mvpp2_send,
>> +       .recv           = mvpp2_recv,
>> +       .stop           = mvpp2_stop,
>> +};
>> +
>> +static struct driver mvpp2_driver = {
>> +       .name   = "mvpp2",
>> +       .id     = UCLASS_ETH,
>> +       .probe  = mvpp2_probe,
>> +       .ops    = &mvpp2_ops,
>> +       .priv_auto_alloc_size = sizeof(struct mvpp2_port),
>> +       .platdata_auto_alloc_size = sizeof(struct eth_pdata),
>> +};
>> +
>> +/*
>> + * Use a MISC device to bind the n instances (child nodes) of the
>> + * network base controller in UCLASS_ETH.
>> + */
>> +static int mvpp2_base_bind(struct udevice *parent)
>> +{
>> +       const void *blob = gd->fdt_blob;
>> +       int node = parent->of_offset;
>> +       struct uclass_driver *drv;
>> +       struct udevice *dev;
>> +       struct eth_pdata *plat;
>> +       char *name;
>> +       int subnode;
>> +       u32 id;
>> +
>> +       /* Lookup eth driver */
>> +       drv = lists_uclass_lookup(UCLASS_ETH);
>> +       if (!drv) {
>> +               puts("Cannot find eth driver\n");
>> +               return -ENOENT;
>> +       }
>> +
>> +       fdt_for_each_subnode(blob, subnode, node) {
>> +               /* Skip disabled ports */
>> +               if (!fdtdec_get_is_enabled(blob, subnode))
>> +                       continue;
>> +
>> +               plat = calloc(1, sizeof(*plat));
>> +               if (!plat)
>> +                       return -ENOMEM;
>> +
>> +               id = fdtdec_get_int(blob, subnode, "port-id", -1);
>> +
>> +               name = calloc(1, 16);
>> +               sprintf(name, "mvpp2-%d", id);
>> +
>> +               /* Create child device UCLASS_ETH and bind it */
>> +               device_bind(parent, &mvpp2_driver, name, plat, subnode, &dev);
>> +               dev->of_offset = subnode;
>> +       }
>> +
>> +       return 0;
>> +}
>> +
>> +static const struct udevice_id mvpp2_ids[] = {
>> +       { .compatible = "marvell,armada-375-pp2" },
>> +       { }
>> +};
>> +
>> +U_BOOT_DRIVER(mvpp2_base) = {
>> +       .name   = "mvpp2_base",
>> +       .id     = UCLASS_MISC,
>> +       .of_match = mvpp2_ids,
>> +       .bind   = mvpp2_base_bind,
>> +};
>> --
>> 2.7.3
>>
>
> Mostly looks good to me.

Thanks for the review. v2 coming shortly...

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 2/6] net: mvpp2.c: Add Marvell mvpp2 network driver for Armada 375
  2016-03-23  6:39     ` Stefan Roese
@ 2016-03-25 21:04       ` Joe Hershberger
  0 siblings, 0 replies; 16+ messages in thread
From: Joe Hershberger @ 2016-03-25 21:04 UTC (permalink / raw)
  To: u-boot

Hi Stefan,

On Wed, Mar 23, 2016 at 1:39 AM, Stefan Roese <sr@denx.de> wrote:
> Hi Joe,
>
> On 22.03.2016 20:10, Joe Hershberger wrote:
>>
>> Sorry for the delay.
>
>
> No problem. Thanks for the review.
>
>
>> On Tue, Mar 15, 2016 at 11:35 AM, Stefan Roese <sr@denx.de> wrote:
>>>
>>> This patch adds support for the mvpp2 ethernet controller which is
>>> integrated
>>> in the Marvell Armada 375 SoC. This port is based on the Linux driver
>>> (v4.4),
>>> which has been stripped of the in U-Boot unused portions.
>>>
>>> Tested on the Marvell Armada 375 eval board db-88f6720.
>>>
>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>> Cc: Luka Perkov <luka.perkov@sartura.hr>
>>> Cc: Joe Hershberger <joe.hershberger@gmail.com>
>>> ---
>>>   drivers/net/Kconfig  |    8 +
>>>   drivers/net/Makefile |    1 +
>>>   drivers/net/mvpp2.c  | 4222
>>> ++++++++++++++++++++++++++++++++++++++++++++++++++
>>>   3 files changed, 4231 insertions(+)
>>>   create mode 100644 drivers/net/mvpp2.c
>>>
>>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>>> index bc2f51d..bcb4c96 100644
>>> --- a/drivers/net/Kconfig
>>> +++ b/drivers/net/Kconfig
>>> @@ -94,6 +94,14 @@ config ETH_DESIGNWARE
>>>            100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
>>>            provide the PHY (physical media interface).
>>>
>>> +config MVPP2
>>> +       bool "Marvell Armada 375 network interface support"
>>> +       depends on ARMADA_375
>>> +       select PHYLIB
>>> +       help
>>> +         This driver supports the network interface units in the
>>> +         Marvell ARMADA 375 SoC.
>>> +
>>>   config PCH_GBE
>>>          bool "Intel Platform Controller Hub EG20T GMAC driver"
>>>          depends on DM_ETH && DM_PCI
>>> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
>>> index 33a81ee..fbedd04 100644
>>> --- a/drivers/net/Makefile
>>> +++ b/drivers/net/Makefile
>>> @@ -42,6 +42,7 @@ obj-$(CONFIG_MPC5xxx_FEC) += mpc5xxx_fec.o
>>>   obj-$(CONFIG_MPC512x_FEC) += mpc512x_fec.o
>>>   obj-$(CONFIG_MVGBE) += mvgbe.o
>>>   obj-$(CONFIG_MVNETA) += mvneta.o
>>> +obj-$(CONFIG_MVPP2) += mvpp2.o
>>>   obj-$(CONFIG_NATSEMI) += natsemi.o
>>>   obj-$(CONFIG_DRIVER_NE2000) += ne2000.o ne2000_base.o
>>>   obj-$(CONFIG_DRIVER_AX88796L) += ax88796.o ne2000_base.o
>>> diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
>>> new file mode 100644
>>> index 0000000..09dfc7e
>>> --- /dev/null
>>> +++ b/drivers/net/mvpp2.c
>>> @@ -0,0 +1,4222 @@
>>> +/*
>>> + * Driver for Marvell PPv2 network controller for Armada 375 SoC.
>>> + *
>>> + * Copyright (C) 2014 Marvell
>>> + *
>>> + * Marcin Wojtas <mw@semihalf.com>
>>> + *
>>> + * U-Boot version:
>>> + * Copyright (C) 2016 Stefan Roese <sr@denx.de>
>>> + *
>>> + * This file is licensed under the terms of the GNU General Public
>>> + * License version 2. This program is licensed "as is" without any
>>> + * warranty of any kind, whether express or implied.
>>> + */
>>> +
>>> +#include <common.h>
>>> +#include <dm.h>
>>> +#include <dm/device-internal.h>
>>> +#include <dm/lists.h>
>>> +#include <net.h>
>>> +#include <netdev.h>
>>> +#include <config.h>
>>> +#include <malloc.h>
>>> +#include <asm/io.h>
>>> +#include <asm/errno.h>
>>> +#include <phy.h>
>>> +#include <miiphy.h>
>>> +#include <watchdog.h>
>>> +#include <asm/arch/cpu.h>
>>> +#include <asm/arch/soc.h>
>>> +#include <linux/compat.h>
>>> +#include <linux/mbus.h>
>>> +
>>> +DECLARE_GLOBAL_DATA_PTR;
>>> +
>>> +#if !defined(CONFIG_PHYLIB)
>>> +# error Marvell mvpp2 requires PHYLIB
>>> +#endif
>>
>>
>> This isn't needed since you "select" PHYLIB in the Kconfig.
>
>
> Good catch. Removed in v2.
>
>>> +
>>> +/* Some linux -> U-Boot compatibility stuff */
>>> +#define netdev_err(dev, fmt, args...)          \
>>> +       printf(fmt, ##args)
>>> +#define netdev_warn(dev, fmt, args...)         \
>>> +       printf(fmt, ##args)
>>> +#define netdev_info(dev, fmt, args...)         \
>>> +       printf(fmt, ##args)
>>> +#define netdev_dbg(dev, fmt, args...)          \
>>> +       printf(fmt, ##args)
>>> +
>>> +#define ETH_ALEN       6               /* Octets in one ethernet addr
>>> */
>>> +
>>> +#define ETH_P_IP       0x0800          /* Internet Protocol packet
>>> */
>>
>>
>> Already available in include/net.h as PROT_IP
>>
>>> +#define ETH_P_PPP_SES  0x8864          /* PPPoE session messages
>>> */
>>
>>
>> Add this to include/net.h as PROT_PPP_SES
>>
>>> +#define ETH_P_ARP      0x0806          /* Address Resolution packet
>>> */
>>
>>
>> Already available in include/net.h as PROT_ARP
>>
>>> +#define ETH_P_IPV6     0x86DD          /* IPv6 over bluebook
>>> */
>>
>>
>> Add this to include/net.h as PROT_IPV6
>
>
> Changed to use these U-Boot defines instead. Thanks.
>
> Does it perhaps make sense to globally change all those U-Boot defines
> to the Linux ones instead?

That sounds like a good idea to me.

>>> +
>>> +#define __verify_pcpu_ptr(ptr)                                         \
>>> +do {                                                                   \
>>> +       const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL;    \
>>> +       (void)__vpp_verify;                                             \
>>> +} while (0)
>>> +
>>> +#define VERIFY_PERCPU_PTR(__p)                                         \
>>> +({                                                                     \
>>> +       __verify_pcpu_ptr(__p);                                         \
>>> +       (typeof(*(__p)) __kernel __force *)(__p);                       \
>>> +})
>>> +
>>> +#define per_cpu_ptr(ptr, cpu)  ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr);
>>> })
>>> +#define smp_processor_id()     0
>>> +#define num_present_cpus()     1
>>> +#define for_each_present_cpu(cpu)                      \
>>> +       for ((cpu) = 0; (cpu) < 1; (cpu)++)
>>> +
>>> +#define NET_SKB_PAD    max(32, MVPP2_CPU_D_CACHE_LINE_SIZE)
>>> +
>>> +#define CONFIG_NR_CPUS         1
>>> +#define ETH_HLEN               14      /* Total octets in header */
>>
>>
>> Already available in include/net.h as ETHER_HDR_SIZE.
>>
>>> +
>>> +/* 2(HW hdr) 14(MAC hdr) 4(CRC) 32(extra for cache prefetch) */
>>> +#define WRAP                   (2 + ETH_HLEN + 4 + 32)
>>> +#define MTU                    1500
>>> +#define RX_BUFFER_SIZE         (ALIGN(MTU + WRAP, ARCH_DMA_MINALIGN))
>>
>>
>> <snip - constants>
>>
>>> +/*
>>> + * Page table entries are set to 1MB, or multiples of 1MB
>>> + * (not < 1MB). driver uses less bd's so use 1MB bdspace.
>>> + */
>>> +#define BD_SPACE       (1 << 20)
>>
>>
>> It would be great if this long list of constants lived in a header
>> file instead of the top of the source.
>
>
> I'm not a big fan of using headers, when the macros / defines etc
> are only referenced by this one file. Additionally, the original
> Linux driver also includes all this in the C file. So it makes
> syncing easier. I would like to keep it in one file.

OK.

>
>>> +
>>> +/* Utility/helper methods */
>>> +
>>> +static void mvpp2_write(struct mvpp2 *priv, u32 offset, u32 data)
>>> +{
>>> +       writel(data, priv->base + offset);
>>> +}
>>> +
>>> +static u32 mvpp2_read(struct mvpp2 *priv, u32 offset)
>>> +{
>>> +       return readl(priv->base + offset);
>>> +}
>>> +
>>
>>
>> <snip>
>>
>>> +
>>> +/* Set hw internals when starting port */
>>> +static void mvpp2_start_dev(struct mvpp2_port *port)
>>> +{
>>> +       mvpp2_gmac_max_rx_size_set(port);
>>> +       mvpp2_txp_max_tx_size_set(port);
>>> +
>>> +       mvpp2_port_enable(port);
>>> +}
>>> +
>>> +/* Set hw internals when stopping port */
>>> +static void mvpp2_stop_dev(struct mvpp2_port *port)
>>> +{
>>> +       /* Stop new packets from arriving to RXQs */
>>> +       mvpp2_ingress_disable(port);
>>> +
>>> +       mvpp2_egress_disable(port);
>>> +       mvpp2_port_disable(port);
>>> +}
>>> +
>>> +static int mvpp2_phy_connect(struct udevice *dev, struct mvpp2_port
>>> *port)
>>> +{
>>> +       struct phy_device *phy_dev;
>>> +
>>> +       if (!port->init || port->link == 0) {
>>> +               phy_dev = phy_connect(port->priv->bus, port->phyaddr,
>>> dev,
>>> +                                     port->phy_interface);
>>> +               port->phy_dev = phy_dev;
>>> +               if (!phy_dev) {
>>> +                       netdev_err(port->dev, "cannot connect to phy\n");
>>> +                       return -ENODEV;
>>> +               }
>>> +               phy_dev->supported &= PHY_GBIT_FEATURES;
>>> +               phy_dev->advertising = phy_dev->supported;
>>> +
>>> +               port->phy_dev = phy_dev;
>>> +               port->link    = 0;
>>> +               port->duplex  = 0;
>>> +               port->speed   = 0;
>>> +
>>> +               phy_config(phy_dev);
>>> +               phy_startup(phy_dev);
>>> +               if (!phy_dev->link) {
>>> +                       printf("%s: No link\n", phy_dev->dev->name);
>>> +                       return -1;
>>> +               }
>>> +
>>> +               port->init = 1;
>>> +       } else {
>>> +               mvpp2_egress_enable(port);
>>> +               mvpp2_ingress_enable(port);
>>> +       }
>>> +
>>> +       return 0;
>>> +}
>>> +
>>> +static int mvpp2_open(struct udevice *dev, struct mvpp2_port *port)
>>> +{
>>> +       unsigned char mac_bcast[ETH_ALEN] = {
>>> +                       0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
>>> +       int err;
>>> +
>>> +       err = mvpp2_prs_mac_da_accept(port->priv, port->id, mac_bcast,
>>> true);
>>> +       if (err) {
>>> +               netdev_err(dev, "mvpp2_prs_mac_da_accept BC failed\n");
>>> +               return err;
>>> +       }
>>> +       err = mvpp2_prs_mac_da_accept(port->priv, port->id,
>>> +                                     port->dev_addr, true);
>>> +       if (err) {
>>> +               netdev_err(dev, "mvpp2_prs_mac_da_accept MC failed\n");
>>> +               return err;
>>> +       }
>>> +       err = mvpp2_prs_def_flow(port);
>>> +       if (err) {
>>> +               netdev_err(dev, "mvpp2_prs_def_flow failed\n");
>>> +               return err;
>>> +       }
>>> +
>>> +       /* Allocate the Rx/Tx queues */
>>> +       err = mvpp2_setup_rxqs(port);
>>> +       if (err) {
>>> +               netdev_err(port->dev, "cannot allocate Rx queues\n");
>>> +               return err;
>>> +       }
>>> +
>>> +       err = mvpp2_setup_txqs(port);
>>> +       if (err) {
>>> +               netdev_err(port->dev, "cannot allocate Tx queues\n");
>>> +               return err;
>>> +       }
>>> +
>>> +       err = mvpp2_phy_connect(dev, port);
>>> +       if (err < 0)
>>> +               return err;
>>> +
>>> +       mvpp2_link_event(port);
>>> +
>>> +       mvpp2_start_dev(port);
>>> +
>>> +       return 0;
>>> +}
>>> +
>>> +/* No Device ops here in U-Boot */
>>> +
>>> +/* Driver initialization */
>>> +
>>> +static void mvpp2_port_power_up(struct mvpp2_port *port)
>>> +{
>>> +       mvpp2_port_mii_set(port);
>>> +       mvpp2_port_periodic_xon_disable(port);
>>> +       mvpp2_port_fc_adv_enable(port);
>>> +       mvpp2_port_reset(port);
>>> +}
>>> +
>>> +/* Initialize port HW */
>>> +static int mvpp2_port_init(struct udevice *dev, struct mvpp2_port *port)
>>> +{
>>> +       struct mvpp2 *priv = port->priv;
>>> +       struct mvpp2_txq_pcpu *txq_pcpu;
>>> +       int queue, cpu, err;
>>> +
>>> +       if (port->first_rxq + rxq_number > MVPP2_RXQ_TOTAL_NUM)
>>> +               return -EINVAL;
>>> +
>>> +       /* Disable port */
>>> +       mvpp2_egress_disable(port);
>>> +       mvpp2_port_disable(port);
>>> +
>>> +       port->txqs = devm_kcalloc(dev, txq_number, sizeof(*port->txqs),
>>> +                                 GFP_KERNEL);
>>> +       if (!port->txqs)
>>> +               return -ENOMEM;
>>> +
>>> +       /* Associate physical Tx queues to this port and initialize.
>>> +        * The mapping is predefined.
>>> +        */
>>> +       for (queue = 0; queue < txq_number; queue++) {
>>> +               int queue_phy_id = mvpp2_txq_phys(port->id, queue);
>>> +               struct mvpp2_tx_queue *txq;
>>> +
>>> +               txq = devm_kzalloc(dev, sizeof(*txq), GFP_KERNEL);
>>> +               if (!txq)
>>> +                       return -ENOMEM;
>>> +
>>> +               txq->pcpu = devm_kzalloc(dev, sizeof(struct
>>> mvpp2_txq_pcpu),
>>> +                                        GFP_KERNEL);
>>> +               if (!txq->pcpu)
>>> +                       return -ENOMEM;
>>> +
>>> +               txq->id = queue_phy_id;
>>> +               txq->log_id = queue;
>>> +               txq->done_pkts_coal = MVPP2_TXDONE_COAL_PKTS_THRESH;
>>> +               for_each_present_cpu(cpu) {
>>> +                       txq_pcpu = per_cpu_ptr(txq->pcpu, cpu);
>>> +                       txq_pcpu->cpu = cpu;
>>> +               }
>>> +
>>> +               port->txqs[queue] = txq;
>>> +       }
>>> +
>>> +       port->rxqs = devm_kcalloc(dev, rxq_number, sizeof(*port->rxqs),
>>> +                                 GFP_KERNEL);
>>> +       if (!port->rxqs)
>>> +               return -ENOMEM;
>>> +
>>> +       /* Allocate and initialize Rx queue for this port */
>>> +       for (queue = 0; queue < rxq_number; queue++) {
>>> +               struct mvpp2_rx_queue *rxq;
>>> +
>>> +               /* Map physical Rx queue to port's logical Rx queue */
>>> +               rxq = devm_kzalloc(dev, sizeof(*rxq), GFP_KERNEL);
>>> +               if (!rxq)
>>> +                       return -ENOMEM;
>>> +               /* Map this Rx queue to a physical queue */
>>> +               rxq->id = port->first_rxq + queue;
>>> +               rxq->port = port->id;
>>> +               rxq->logic_rxq = queue;
>>> +
>>> +               port->rxqs[queue] = rxq;
>>> +       }
>>> +
>>> +       /* Configure Rx queue group interrupt for this port */
>>> +       mvpp2_write(priv, MVPP2_ISR_RXQ_GROUP_REG(port->id),
>>> CONFIG_MV_ETH_RXQ);
>>> +
>>> +       /* Create Rx descriptor rings */
>>> +       for (queue = 0; queue < rxq_number; queue++) {
>>> +               struct mvpp2_rx_queue *rxq = port->rxqs[queue];
>>> +
>>> +               rxq->size = port->rx_ring_size;
>>> +               rxq->pkts_coal = MVPP2_RX_COAL_PKTS;
>>> +               rxq->time_coal = MVPP2_RX_COAL_USEC;
>>> +       }
>>> +
>>> +       mvpp2_ingress_disable(port);
>>> +
>>> +       /* Port default configuration */
>>> +       mvpp2_defaults_set(port);
>>> +
>>> +       /* Port's classifier configuration */
>>> +       mvpp2_cls_oversize_rxq_set(port);
>>> +       mvpp2_cls_port_config(port);
>>> +
>>> +       /* Provide an initial Rx packet size */
>>> +       port->pkt_size = MVPP2_RX_PKT_SIZE(PKTSIZE_ALIGN);
>>> +
>>> +       /* Initialize pools for swf */
>>> +       err = mvpp2_swf_bm_pool_init(port);
>>> +       if (err)
>>> +               return err;
>>> +
>>> +       return 0;
>>> +}
>>> +
>>> +/* Ports initialization */
>>> +static int mvpp2_port_probe(struct udevice *dev,
>>> +                           struct mvpp2_port *port,
>>> +                           int port_node,
>>> +                           struct mvpp2 *priv,
>>> +                           int *next_first_rxq)
>>> +{
>>> +       int phy_node;
>>> +       u32 id;
>>> +       u32 phyaddr;
>>> +       const char *phy_mode_str;
>>> +       int phy_mode = -1;
>>> +       int priv_common_regs_num = 2;
>>> +       int err;
>>> +
>>> +       phy_node = fdtdec_lookup_phandle(gd->fdt_blob, port_node, "phy");
>>> +       if (phy_node < 0) {
>>> +               dev_err(&pdev->dev, "missing phy\n");
>>> +               return -ENODEV;
>>> +       }
>>> +
>>> +       phy_mode_str = fdt_getprop(gd->fdt_blob, port_node, "phy-mode",
>>> NULL);
>>> +       if (phy_mode_str)
>>> +               phy_mode = phy_get_interface_by_name(phy_mode_str);
>>> +       if (phy_mode == -1) {
>>> +               dev_err(&pdev->dev, "incorrect phy mode\n");
>>> +               return -EINVAL;
>>> +       }
>>> +
>>> +       id = fdtdec_get_int(gd->fdt_blob, port_node, "port-id", -1);
>>> +       if (id == -1) {
>>> +               dev_err(&pdev->dev, "missing port-id value\n");
>>> +               return -EINVAL;
>>> +       }
>>> +
>>> +       phyaddr = fdtdec_get_int(gd->fdt_blob, phy_node, "reg", 0);
>>> +
>>> +       port->priv = priv;
>>> +       port->id = id;
>>> +       port->first_rxq = *next_first_rxq;
>>> +       port->phy_node = phy_node;
>>> +       port->phy_interface = phy_mode;
>>> +       port->phyaddr = phyaddr;
>>> +
>>> +       port->base = (void __iomem *)dev_get_addr_index(dev->parent,
>>> +
>>> priv_common_regs_num
>>> +                                                       + id);
>>> +       if (IS_ERR(port->base))
>>> +               return PTR_ERR(port->base);
>>> +
>>> +       port->tx_ring_size = MVPP2_MAX_TXD;
>>> +       port->rx_ring_size = MVPP2_MAX_RXD;
>>> +
>>> +       err = mvpp2_port_init(dev, port);
>>> +       if (err < 0) {
>>> +               dev_err(&pdev->dev, "failed to init port %d\n", id);
>>> +               return err;
>>> +       }
>>> +       mvpp2_port_power_up(port);
>>> +
>>> +       /* Increment the first Rx queue number to be used by the next
>>> port */
>>> +       *next_first_rxq += CONFIG_MV_ETH_RXQ;
>>> +       priv->port_list[id] = port;
>>> +       return 0;
>>> +}
>>> +
>>> +/* Initialize decoding windows */
>>> +static void mvpp2_conf_mbus_windows(const struct mbus_dram_target_info
>>> *dram,
>>> +                                   struct mvpp2 *priv)
>>> +{
>>> +       u32 win_enable;
>>> +       int i;
>>> +
>>> +       for (i = 0; i < 6; i++) {
>>> +               mvpp2_write(priv, MVPP2_WIN_BASE(i), 0);
>>> +               mvpp2_write(priv, MVPP2_WIN_SIZE(i), 0);
>>> +
>>> +               if (i < 4)
>>> +                       mvpp2_write(priv, MVPP2_WIN_REMAP(i), 0);
>>> +       }
>>> +
>>> +       win_enable = 0;
>>> +
>>> +       for (i = 0; i < dram->num_cs; i++) {
>>> +               const struct mbus_dram_window *cs = dram->cs + i;
>>> +
>>> +               mvpp2_write(priv, MVPP2_WIN_BASE(i),
>>> +                           (cs->base & 0xffff0000) | (cs->mbus_attr <<
>>> 8) |
>>> +                           dram->mbus_dram_target_id);
>>> +
>>> +               mvpp2_write(priv, MVPP2_WIN_SIZE(i),
>>> +                           (cs->size - 1) & 0xffff0000);
>>> +
>>> +               win_enable |= (1 << i);
>>> +       }
>>> +
>>> +       mvpp2_write(priv, MVPP2_BASE_ADDR_ENABLE, win_enable);
>>> +}
>>> +
>>> +/* Initialize Rx FIFO's */
>>> +static void mvpp2_rx_fifo_init(struct mvpp2 *priv)
>>> +{
>>> +       int port;
>>> +
>>> +       for (port = 0; port < MVPP2_MAX_PORTS; port++) {
>>> +               mvpp2_write(priv, MVPP2_RX_DATA_FIFO_SIZE_REG(port),
>>> +                           MVPP2_RX_FIFO_PORT_DATA_SIZE);
>>> +               mvpp2_write(priv, MVPP2_RX_ATTR_FIFO_SIZE_REG(port),
>>> +                           MVPP2_RX_FIFO_PORT_ATTR_SIZE);
>>> +       }
>>> +
>>> +       mvpp2_write(priv, MVPP2_RX_MIN_PKT_SIZE_REG,
>>> +                   MVPP2_RX_FIFO_PORT_MIN_PKT);
>>> +       mvpp2_write(priv, MVPP2_RX_FIFO_INIT_REG, 0x1);
>>> +}
>>> +
>>> +/* Initialize network controller common part HW */
>>> +static int mvpp2_init(struct udevice *dev, struct mvpp2 *priv)
>>> +{
>>> +       const struct mbus_dram_target_info *dram_target_info;
>>> +       int err, i;
>>> +       u32 val;
>>> +
>>> +       /* Checks for hardware constraints (U-Boot uses only one rxq) */
>>> +       if ((rxq_number > MVPP2_MAX_RXQ) || (txq_number > MVPP2_MAX_TXQ))
>>> {
>>> +               dev_err(&pdev->dev, "invalid queue size parameter\n");
>>> +               return -EINVAL;
>>> +       }
>>> +
>>> +       /* MBUS windows configuration */
>>> +       dram_target_info = mvebu_mbus_dram_info();
>>> +       if (dram_target_info)
>>> +               mvpp2_conf_mbus_windows(dram_target_info, priv);
>>> +
>>> +       /* Disable HW PHY polling */
>>> +       val = readl(priv->lms_base + MVPP2_PHY_AN_CFG0_REG);
>>> +       val |= MVPP2_PHY_AN_STOP_SMI0_MASK;
>>> +       writel(val, priv->lms_base + MVPP2_PHY_AN_CFG0_REG);
>>> +
>>> +       /* Allocate and initialize aggregated TXQs */
>>> +       priv->aggr_txqs = devm_kcalloc(dev, num_present_cpus(),
>>> +                                      sizeof(struct mvpp2_tx_queue),
>>> +                                      GFP_KERNEL);
>>> +       if (!priv->aggr_txqs)
>>> +               return -ENOMEM;
>>> +
>>> +       for_each_present_cpu(i) {
>>> +               priv->aggr_txqs[i].id = i;
>>> +               priv->aggr_txqs[i].size = MVPP2_AGGR_TXQ_SIZE;
>>> +               err = mvpp2_aggr_txq_init(dev, &priv->aggr_txqs[i],
>>> +                                         MVPP2_AGGR_TXQ_SIZE, i, priv);
>>> +               if (err < 0)
>>> +                       return err;
>>> +       }
>>> +
>>> +       /* Rx Fifo Init */
>>> +       mvpp2_rx_fifo_init(priv);
>>> +
>>> +       /* Reset Rx queue group interrupt configuration */
>>> +       for (i = 0; i < MVPP2_MAX_PORTS; i++)
>>> +               mvpp2_write(priv, MVPP2_ISR_RXQ_GROUP_REG(i),
>>> +                           CONFIG_MV_ETH_RXQ);
>>> +
>>> +       writel(MVPP2_EXT_GLOBAL_CTRL_DEFAULT,
>>> +              priv->lms_base + MVPP2_MNG_EXTENDED_GLOBAL_CTRL_REG);
>>> +
>>> +       /* Allow cache snoop when transmiting packets */
>>> +       mvpp2_write(priv, MVPP2_TX_SNOOP_REG, 0x1);
>>> +
>>> +       /* Buffer Manager initialization */
>>> +       err = mvpp2_bm_init(dev, priv);
>>> +       if (err < 0)
>>> +               return err;
>>> +
>>> +       /* Parser default initialization */
>>> +       err = mvpp2_prs_default_init(dev, priv);
>>> +       if (err < 0)
>>> +               return err;
>>> +
>>> +       /* Classifier default initialization */
>>> +       mvpp2_cls_init(priv);
>>> +
>>> +       return 0;
>>> +}
>>> +
>>> +/* SMI / MDIO functions */
>>> +
>>> +static int smi_wait_ready(struct mvpp2 *priv)
>>> +{
>>> +       u32 timeout = MVPP2_SMI_TIMEOUT;
>>> +       u32 smi_reg;
>>> +
>>> +       /* wait till the SMI is not busy */
>>> +       do {
>>> +               /* read smi register */
>>> +               smi_reg = readl(priv->lms_base + MVPP2_SMI);
>>> +               if (timeout-- == 0) {
>>> +                       printf("Error: SMI busy timeout\n");
>>> +                       return -EFAULT;
>>> +               }
>>> +       } while (smi_reg & MVPP2_SMI_BUSY);
>>> +
>>> +       return 0;
>>> +}
>>> +
>>> +/*
>>> + * mpp2_mdio_read - miiphy_read callback function.
>>> + *
>>> + * Returns 16bit phy register value, or 0xffff on error
>>> + */
>>> +static int mpp2_mdio_read(struct mii_dev *bus, int addr, int devad, int
>>> reg)
>>> +{
>>> +       struct mvpp2 *priv = bus->priv;
>>> +       u32 smi_reg;
>>> +       u32 timeout;
>>> +
>>> +       /* check parameters */
>>> +       if (addr > MVPP2_PHY_ADDR_MASK) {
>>> +               printf("Error: Invalid PHY address %d\n", addr);
>>> +               return -EFAULT;
>>> +       }
>>> +
>>> +       if (reg > MVPP2_PHY_REG_MASK) {
>>> +               printf("Err: Invalid register offset %d\n", reg);
>>> +               return -EFAULT;
>>> +       }
>>> +
>>> +       /* wait till the SMI is not busy */
>>> +       if (smi_wait_ready(priv) < 0)
>>> +               return -EFAULT;
>>> +
>>> +       /* fill the phy address and regiser offset and read opcode */
>>> +       smi_reg = (addr << MVPP2_SMI_DEV_ADDR_OFFS)
>>> +               | (reg << MVPP2_SMI_REG_ADDR_OFFS)
>>> +               | MVPP2_SMI_OPCODE_READ;
>>> +
>>> +       /* write the smi register */
>>> +       writel(smi_reg, priv->lms_base + MVPP2_SMI);
>>> +
>>> +       /* wait till read value is ready */
>>> +       timeout = MVPP2_SMI_TIMEOUT;
>>> +
>>> +       do {
>>> +               /* read smi register */
>>> +               smi_reg = readl(priv->lms_base + MVPP2_SMI);
>>> +               if (timeout-- == 0) {
>>> +                       printf("Err: SMI read ready timeout\n");
>>> +                       return -EFAULT;
>>> +               }
>>> +       } while (!(smi_reg & MVPP2_SMI_READ_VALID));
>>> +
>>> +       /* Wait for the data to update in the SMI register */
>>> +       for (timeout = 0; timeout < MVPP2_SMI_TIMEOUT; timeout++)
>>> +               ;
>>> +
>>> +       return readl(priv->lms_base + MVPP2_SMI) & MVPP2_SMI_DATA_MASK;
>>> +}
>>> +
>>> +/*
>>> + * mpp2_mdio_write - miiphy_write callback function.
>>> + *
>>> + * Returns 0 if write succeed, -EINVAL on bad parameters
>>> + * -ETIME on timeout
>>> + */
>>> +static int mpp2_mdio_write(struct mii_dev *bus, int addr, int devad, int
>>> reg,
>>> +                          u16 value)
>>> +{
>>> +       struct mvpp2 *priv = bus->priv;
>>> +       u32 smi_reg;
>>> +
>>> +       /* check parameters */
>>> +       if (addr > MVPP2_PHY_ADDR_MASK) {
>>> +               printf("Error: Invalid PHY address %d\n", addr);
>>> +               return -EFAULT;
>>> +       }
>>> +
>>> +       if (reg > MVPP2_PHY_REG_MASK) {
>>> +               printf("Err: Invalid register offset %d\n", reg);
>>> +               return -EFAULT;
>>> +       }
>>> +
>>> +       /* wait till the SMI is not busy */
>>> +       if (smi_wait_ready(priv) < 0)
>>> +               return -EFAULT;
>>> +
>>> +       /* fill the phy addr and reg offset and write opcode and data */
>>> +       smi_reg = value << MVPP2_SMI_DATA_OFFS;
>>> +       smi_reg |= (addr << MVPP2_SMI_DEV_ADDR_OFFS)
>>> +               | (reg << MVPP2_SMI_REG_ADDR_OFFS);
>>> +       smi_reg &= ~MVPP2_SMI_OPCODE_READ;
>>> +
>>> +       /* write the smi register */
>>> +       writel(smi_reg, priv->lms_base + MVPP2_SMI);
>>> +
>>> +       return 0;
>>> +}
>>> +
>>> +static int mvpp2_probe(struct udevice *dev)
>>> +{
>>> +       struct mvpp2_port *port = dev_get_priv(dev);
>>> +       struct mvpp2 *priv;
>>> +       struct mii_dev *bus;
>>> +       void *bd_space;
>>> +       int err;
>>> +       u32 size = 0;
>>> +       int i;
>>> +
>>> +       /*
>>> +        * This function is called multiple times. For each controller.
>>> +        * But we only need to do the main controller probing once. So
>>> +        * lets only do the port probing here, if called not for the
>>> +        * first time.
>>> +        */
>>> +       if (buffer_loc.tx_descs) {
>>> +               priv = buffer_loc.priv;
>>> +               port->priv = priv;
>>> +
>>> +               err = mvpp2_port_probe(dev, port, dev->of_offset, priv,
>>> +                                      &buffer_loc.first_rxq);
>>> +
>>> +               return 0;
>>> +       }
>>> +
>>> +       /*
>>> +        * U-Boot special buffer handling:
>>> +        *
>>> +        * Allocate buffer area for descs and rx_buffers. This is only
>>> +        * done once for all interfaces. As only one interface can
>>> +        * be active. Make this area DMA save by disabling the D-cache
>>
>>
>> DMA save -> DMA-safe
>
>
> Fixed.
>
>
>>> +        */
>>> +
>>> +       /* Align buffer area for descs and rx_buffers to 1MiB */
>>> +       bd_space = memalign(1 << MMU_SECTION_SHIFT, BD_SPACE);
>>> +       mmu_set_region_dcache_behaviour((u32)bd_space, BD_SPACE,
>>> DCACHE_OFF);
>>> +
>>> +       buffer_loc.aggr_tx_descs = (struct mvpp2_tx_desc *)bd_space;
>>> +       size += MVPP2_AGGR_TXQ_SIZE * MVPP2_DESC_ALIGNED_SIZE;
>>> +
>>> +       buffer_loc.tx_descs = (struct mvpp2_tx_desc *)((u32)bd_space +
>>> size);
>>> +       size += MVPP2_MAX_TXD * MVPP2_DESC_ALIGNED_SIZE;
>>> +
>>> +       buffer_loc.rx_descs = (struct mvpp2_rx_desc *)((u32)bd_space +
>>> size);
>>> +       size += MVPP2_MAX_RXD * MVPP2_DESC_ALIGNED_SIZE;
>>> +
>>> +       for (i = 0; i < MVPP2_BM_POOLS_NUM; i++) {
>>> +               buffer_loc.bm_pool[i] = (u32 *)((u32)bd_space + size);
>>> +               size += MVPP2_BM_POOL_SIZE_MAX * sizeof(u32);
>>> +       }
>>> +
>>> +       for (i = 0; i < MVPP2_BM_LONG_BUF_NUM; i++) {
>>> +               buffer_loc.rx_buffer[i] = (u32 *)((u32)bd_space + size);
>>> +               size += RX_BUFFER_SIZE;
>>> +       }
>>> +
>>> +       /*
>>> +        * This is done only once, for the first controller that is
>>> +        * probed. Here the common structures are initialized.
>>> +        */
>>
>>
>> Any reason this isn't in the probe function for the MISC class parent
>> driver?
>
>
> Not really. I've moved most of this into the new probe function
> of the parent driver. Looks much cleaner this may. Thanks.
>
>
>>> +       priv = calloc(1, sizeof(struct mvpp2));
>>> +       if (!priv)
>>> +               return -ENOMEM;
>>> +
>>> +       /* And save pointer to main mvpp2 struct */
>>> +       port->priv = priv;
>>> +       buffer_loc.priv = priv;
>>> +
>>> +       priv->base = (void *)dev_get_addr_index(dev->parent, 0);
>>> +       if (IS_ERR(priv->base))
>>> +               return PTR_ERR(priv->base);
>>> +
>>> +       priv->lms_base = (void *)dev_get_addr_index(dev->parent, 1);
>>> +       if (IS_ERR(priv->lms_base))
>>> +               return PTR_ERR(priv->lms_base);
>>> +
>>> +       /* Initialize network controller */
>>> +       err = mvpp2_init(dev, priv);
>>> +       if (err < 0) {
>>> +               dev_err(&pdev->dev, "failed to initialize controller\n");
>>> +               return err;
>>> +       }
>>> +
>>> +       err = mvpp2_port_probe(dev, port, dev->of_offset, priv,
>>> +                              &buffer_loc.first_rxq);
>>> +
>>> +       /*
>>> +        * Finally create and register the MDIO bus driver
>>> +        */
>>> +       bus = mdio_alloc();
>>> +       if (!bus) {
>>> +               printf("Failed to allocate MDIO bus\n");
>>> +               return -ENOMEM;
>>> +       }
>>> +
>>> +       bus->read = mpp2_mdio_read;
>>> +       bus->write = mpp2_mdio_write;
>>> +       snprintf(bus->name, sizeof(bus->name), dev->name);
>>> +       bus->priv = (void *)priv;
>>> +       priv->bus = bus;
>>> +
>>> +       return mdio_register(bus);
>>> +}
>>> +
>>> +static int mvpp2_recv(struct udevice *dev, int flags, uchar **packetp)
>>> +{
>>> +       struct mvpp2_port *port = dev_get_priv(dev);
>>> +       struct mvpp2_rx_desc *rx_desc;
>>> +       struct mvpp2_bm_pool *bm_pool;
>>> +       dma_addr_t phys_addr;
>>> +       u32 bm, rx_status;
>>> +       int pool, rx_bytes, err;
>>> +       int rx_received;
>>> +       struct mvpp2_rx_queue *rxq;
>>> +       u32 cause_rx_tx, cause_rx, cause_misc;
>>> +       u8 *data;
>>> +
>>> +       cause_rx_tx = mvpp2_read(port->priv,
>>> +                                MVPP2_ISR_RX_TX_CAUSE_REG(port->id));
>>> +       cause_rx_tx &= ~MVPP2_CAUSE_TXQ_OCCUP_DESC_ALL_MASK;
>>> +       cause_misc = cause_rx_tx & MVPP2_CAUSE_MISC_SUM_MASK;
>>> +       if (!cause_rx_tx && !cause_misc)
>>> +               return 0;
>>> +
>>> +       cause_rx = cause_rx_tx & MVPP2_CAUSE_RXQ_OCCUP_DESC_ALL_MASK;
>>> +
>>> +       /* Process RX packets */
>>> +       cause_rx |= port->pending_cause_rx;
>>> +       rxq = mvpp2_get_rx_queue(port, cause_rx);
>>> +
>>> +       /* Get number of received packets and clamp the to-do */
>>> +       rx_received = mvpp2_rxq_received(port, rxq->id);
>>> +
>>> +       /* Return if no packets are received */
>>> +       if (!rx_received)
>>> +               return 0;
>>> +
>>> +       rx_desc = mvpp2_rxq_next_desc_get(rxq);
>>> +       rx_status = rx_desc->status;
>>> +       rx_bytes = rx_desc->data_size - MVPP2_MH_SIZE;
>>> +       phys_addr = rx_desc->buf_phys_addr;
>>> +
>>> +       bm = mvpp2_bm_cookie_build(rx_desc);
>>> +       pool = mvpp2_bm_cookie_pool_get(bm);
>>> +       bm_pool = &port->priv->bm_pools[pool];
>>> +
>>> +       /* Check if buffer header is used */
>>> +       if (rx_status & MVPP2_RXD_BUF_HDR)
>>> +               return 0;
>>> +
>>> +       /* In case of an error, release the requested buffer pointer
>>> +        * to the Buffer Manager. This request process is controlled
>>> +        * by the hardware, and the information about the buffer is
>>> +        * comprised by the RX descriptor.
>>> +        */
>>> +       if (rx_status & MVPP2_RXD_ERR_SUMMARY) {
>>> +               mvpp2_rx_error(port, rx_desc);
>>> +               /* Return the buffer to the pool */
>>> +               mvpp2_pool_refill(port, bm, rx_desc->buf_phys_addr,
>>> +                                 rx_desc->buf_cookie);
>>> +               return 0;
>>> +       }
>>> +
>>> +       err = mvpp2_rx_refill(port, bm_pool, bm, phys_addr);
>>> +       if (err) {
>>> +               netdev_err(port->dev, "failed to refill BM pools\n");
>>> +               return 0;
>>> +       }
>>> +
>>> +       /* Update Rx queue management counters */
>>> +       mb();
>>> +       mvpp2_rxq_status_update(port, rxq->id, 1, 1);
>>> +
>>> +       /* give packet to stack - skip on first n bytes */
>>> +       data = (u8 *)phys_addr + 2 + 32;
>>> +
>>> +       if (rx_bytes <= 0)
>>> +               return 0;
>>> +
>>> +       /*
>>> +        * No cache invalidation needed here, since the rx_buffer's are
>>> +        * located in a uncached memory region
>>> +        */
>>> +       *packetp = data;
>>> +
>>> +       return rx_bytes;
>>> +}
>>> +
>>> +/* Drain Txq */
>>> +static void mvpp2_txq_drain(struct mvpp2_port *port, struct
>>> mvpp2_tx_queue *txq,
>>> +                           int enable)
>>> +{
>>> +       u32 val;
>>> +
>>> +       mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
>>> +       val = mvpp2_read(port->priv, MVPP2_TXQ_PREF_BUF_REG);
>>> +       if (enable)
>>> +               val |= MVPP2_TXQ_DRAIN_EN_MASK;
>>> +       else
>>> +               val &= ~MVPP2_TXQ_DRAIN_EN_MASK;
>>> +       mvpp2_write(port->priv, MVPP2_TXQ_PREF_BUF_REG, val);
>>> +}
>>> +
>>> +static int mvpp2_send(struct udevice *dev, void *packet, int length)
>>> +{
>>> +       struct mvpp2_port *port = dev_get_priv(dev);
>>> +       struct mvpp2_tx_queue *txq, *aggr_txq;
>>> +       struct mvpp2_tx_desc *tx_desc;
>>> +       int tx_done;
>>> +       int timeout;
>>> +
>>> +       txq = port->txqs[0];
>>> +       aggr_txq = &port->priv->aggr_txqs[smp_processor_id()];
>>> +
>>> +       /* Get a descriptor for the first part of the packet */
>>> +       tx_desc = mvpp2_txq_next_desc_get(aggr_txq);
>>> +       tx_desc->phys_txq = txq->id;
>>> +       tx_desc->data_size = length;
>>> +       tx_desc->packet_offset = (u32)packet & MVPP2_TX_DESC_ALIGN;
>>> +       tx_desc->buf_phys_addr = (u32)packet & ~MVPP2_TX_DESC_ALIGN;
>>> +       /* First and Last descriptor */
>>> +       tx_desc->command = MVPP2_TXD_L4_CSUM_NOT |
>>> MVPP2_TXD_IP_CSUM_DISABLE
>>> +               | MVPP2_TXD_F_DESC | MVPP2_TXD_L_DESC;
>>> +
>>> +       /* Flush tx data */
>>> +       flush_dcache_range((u32)packet, (u32)packet + length);
>>> +
>>> +       /* Enable transmit */
>>> +       mb();
>>> +       mvpp2_aggr_txq_pend_desc_add(port, 1);
>>> +
>>> +       mvpp2_write(port->priv, MVPP2_TXQ_NUM_REG, txq->id);
>>> +
>>> +       timeout = 0;
>>> +       do {
>>> +               if (timeout++ > 10000) {
>>> +                       printf("timeout: packet not sent from aggregated
>>> to phys TXQ\n");
>>> +                       return 0;
>>> +               }
>>> +               tx_done = mvpp2_txq_pend_desc_num_get(port, txq);
>>> +       } while (tx_done);
>>> +
>>> +       /* Enable TXQ drain */
>>> +       mvpp2_txq_drain(port, txq, 1);
>>> +
>>> +       timeout = 0;
>>> +       do {
>>> +               if (timeout++ > 10000) {
>>> +                       printf("timeout: packet not sent\n");
>>> +                       return 0;
>>> +               }
>>> +               tx_done = mvpp2_txq_sent_desc_proc(port, txq);
>>> +       } while (!tx_done);
>>> +
>>> +       /* Disable TXQ drain */
>>> +       mvpp2_txq_drain(port, txq, 0);
>>> +
>>> +       return 0;
>>> +}
>>> +
>>> +static int mvpp2_start(struct udevice *dev)
>>> +{
>>> +       struct eth_pdata *pdata = dev_get_platdata(dev);
>>> +       struct mvpp2_port *port = dev_get_priv(dev);
>>> +
>>> +       /* Load current MAC address */
>>> +       memcpy(port->dev_addr, pdata->enetaddr, ETH_ALEN);
>>> +
>>> +       /* Reconfigure parser accept the original MAC address */
>>> +       mvpp2_prs_update_mac_da(port, port->dev_addr);
>>> +
>>> +       mvpp2_port_power_up(port);
>>> +
>>> +       mvpp2_open(dev, port);
>>> +
>>> +       return 0;
>>> +}
>>> +
>>> +static void mvpp2_stop(struct udevice *dev)
>>> +{
>>> +       struct mvpp2_port *port = dev_get_priv(dev);
>>> +
>>> +       mvpp2_stop_dev(port);
>>> +       mvpp2_cleanup_rxqs(port);
>>> +       mvpp2_cleanup_txqs(port);
>>> +}
>>> +
>>> +static const struct eth_ops mvpp2_ops = {
>>> +       .start          = mvpp2_start,
>>> +       .send           = mvpp2_send,
>>> +       .recv           = mvpp2_recv,
>>> +       .stop           = mvpp2_stop,
>>> +};
>>> +
>>> +static struct driver mvpp2_driver = {
>>> +       .name   = "mvpp2",
>>> +       .id     = UCLASS_ETH,
>>> +       .probe  = mvpp2_probe,
>>> +       .ops    = &mvpp2_ops,
>>> +       .priv_auto_alloc_size = sizeof(struct mvpp2_port),
>>> +       .platdata_auto_alloc_size = sizeof(struct eth_pdata),
>>> +};
>>> +
>>> +/*
>>> + * Use a MISC device to bind the n instances (child nodes) of the
>>> + * network base controller in UCLASS_ETH.
>>> + */
>>> +static int mvpp2_base_bind(struct udevice *parent)
>>> +{
>>> +       const void *blob = gd->fdt_blob;
>>> +       int node = parent->of_offset;
>>> +       struct uclass_driver *drv;
>>> +       struct udevice *dev;
>>> +       struct eth_pdata *plat;
>>> +       char *name;
>>> +       int subnode;
>>> +       u32 id;
>>> +
>>> +       /* Lookup eth driver */
>>> +       drv = lists_uclass_lookup(UCLASS_ETH);
>>> +       if (!drv) {
>>> +               puts("Cannot find eth driver\n");
>>> +               return -ENOENT;
>>> +       }
>>> +
>>> +       fdt_for_each_subnode(blob, subnode, node) {
>>> +               /* Skip disabled ports */
>>> +               if (!fdtdec_get_is_enabled(blob, subnode))
>>> +                       continue;
>>> +
>>> +               plat = calloc(1, sizeof(*plat));
>>> +               if (!plat)
>>> +                       return -ENOMEM;
>>> +
>>> +               id = fdtdec_get_int(blob, subnode, "port-id", -1);
>>> +
>>> +               name = calloc(1, 16);
>>> +               sprintf(name, "mvpp2-%d", id);
>>> +
>>> +               /* Create child device UCLASS_ETH and bind it */
>>> +               device_bind(parent, &mvpp2_driver, name, plat, subnode,
>>> &dev);
>>> +               dev->of_offset = subnode;
>>> +       }
>>> +
>>> +       return 0;
>>> +}
>>> +
>>> +static const struct udevice_id mvpp2_ids[] = {
>>> +       { .compatible = "marvell,armada-375-pp2" },
>>> +       { }
>>> +};
>>> +
>>> +U_BOOT_DRIVER(mvpp2_base) = {
>>> +       .name   = "mvpp2_base",
>>> +       .id     = UCLASS_MISC,
>>> +       .of_match = mvpp2_ids,
>>> +       .bind   = mvpp2_base_bind,
>>> +};
>>> --
>>> 2.7.3
>>>
>>
>> Mostly looks good to me.
>
>
> Thanks for the review. v2 coming shortly...
>
> Thanks,
> Stefan
>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375
  2016-03-15 16:35 [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375 Stefan Roese
                   ` (5 preceding siblings ...)
  2016-03-15 17:55 ` [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375 Jagan Teki
@ 2016-04-04 12:00 ` Stefan Roese
  6 siblings, 0 replies; 16+ messages in thread
From: Stefan Roese @ 2016-04-04 12:00 UTC (permalink / raw)
  To: u-boot

On 15.03.2016 17:35, Stefan Roese wrote:
> This enables this driver for the Marvell Armada 375 SoC.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> Cc: Jagan Teki <jteki@openedev.com>

Applied to u-boot-marvell/master.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 3/6] dt-bindings: Add include/dt-bindings/phy/phy.h from Linux v4.4
  2016-03-15 16:35 ` [U-Boot] [PATCH 3/6] dt-bindings: Add include/dt-bindings/phy/phy.h from Linux v4.4 Stefan Roese
@ 2016-04-04 12:01   ` Stefan Roese
  0 siblings, 0 replies; 16+ messages in thread
From: Stefan Roese @ 2016-04-04 12:01 UTC (permalink / raw)
  To: u-boot

On 15.03.2016 17:35, Stefan Roese wrote:
> This will be needed by the upcoming Marvell Armada 375 dts files.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Luka Perkov <luka.perkov@sartura.hr>

Applied to u-boot-marvell/master.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 4/6] arm: mvebu: Add basic support for the Marvell Armada 375 SoC
  2016-03-15 16:35 ` [U-Boot] [PATCH 4/6] arm: mvebu: Add basic support for the Marvell Armada 375 SoC Stefan Roese
@ 2016-04-04 12:01   ` Stefan Roese
  0 siblings, 0 replies; 16+ messages in thread
From: Stefan Roese @ 2016-04-04 12:01 UTC (permalink / raw)
  To: u-boot

On 15.03.2016 17:35, Stefan Roese wrote:
> This patch adds basic support for the Armada 375. Please note that
> currently the SerDes and DDR3 init code for the A375 is not
> included / enabled. This will be done in a later, follow-up patch.
>
> Right now, this A375 mainline U-Boot can only be used by chainloading
> it via the original Marvell U-Boot. This can be done via this
> command:
>
> => tftpboot 00800000 a375/u-boot-dtb.bin;go 00800000
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Luka Perkov <luka.perkov@sartura.hr>

Applied to u-boot-marvell/master.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 5/6] arm: mvebu: Add basic support for Armada 375 eval board db-88f6720
  2016-03-15 16:35 ` [U-Boot] [PATCH 5/6] arm: mvebu: Add basic support for Armada 375 eval board db-88f6720 Stefan Roese
@ 2016-04-04 12:01   ` Stefan Roese
  0 siblings, 0 replies; 16+ messages in thread
From: Stefan Roese @ 2016-04-04 12:01 UTC (permalink / raw)
  To: u-boot

On 15.03.2016 17:35, Stefan Roese wrote:
> This patch adds basic support for the Marvell A375 eval board. Tested
> are the following interfaces:
> - I2C
> - SPI
> - SPI NOR
> - Ethernet (mvpp2), port 0 & 1
>
> Currently the A375 SerDes and DDR3 init code is not intergrated. So
> the SPL U-Boot is not fully functional.
>
> Right now, this A375 mainline U-Boot can only be used by chainloading
> it via the original Marvell U-Boot. This can be done via this
> command:
>
> => tftpboot 00800000 a375/u-boot-dtb.bin;go 00800000
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Luka Perkov <luka.perkov@sartura.hr>

Applied to u-boot-marvell/master.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [U-Boot] [PATCH 6/6] arm: mvebu: Don't enable d-cache on A375
  2016-03-15 16:35 ` [U-Boot] [PATCH 6/6] arm: mvebu: Don't enable d-cache on A375 Stefan Roese
@ 2016-04-04 12:02   ` Stefan Roese
  0 siblings, 0 replies; 16+ messages in thread
From: Stefan Roese @ 2016-04-04 12:02 UTC (permalink / raw)
  To: u-boot

On 15.03.2016 17:35, Stefan Roese wrote:
> Armada 375 still has some problems with d-cache enabled in the ethernet
> driver (mvpp2). So lets keep the d-cache disabled until this is solved.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Luka Perkov <luka.perkov@sartura.hr>

Applied to u-boot-marvell/master.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2016-04-04 12:02 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-15 16:35 [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375 Stefan Roese
2016-03-15 16:35 ` [U-Boot] [PATCH 2/6] net: mvpp2.c: Add Marvell mvpp2 network driver " Stefan Roese
2016-03-18 14:29   ` Stefan Roese
2016-03-22 19:10   ` Joe Hershberger
2016-03-23  6:39     ` Stefan Roese
2016-03-25 21:04       ` Joe Hershberger
2016-03-15 16:35 ` [U-Boot] [PATCH 3/6] dt-bindings: Add include/dt-bindings/phy/phy.h from Linux v4.4 Stefan Roese
2016-04-04 12:01   ` Stefan Roese
2016-03-15 16:35 ` [U-Boot] [PATCH 4/6] arm: mvebu: Add basic support for the Marvell Armada 375 SoC Stefan Roese
2016-04-04 12:01   ` Stefan Roese
2016-03-15 16:35 ` [U-Boot] [PATCH 5/6] arm: mvebu: Add basic support for Armada 375 eval board db-88f6720 Stefan Roese
2016-04-04 12:01   ` Stefan Roese
2016-03-15 16:35 ` [U-Boot] [PATCH 6/6] arm: mvebu: Don't enable d-cache on A375 Stefan Roese
2016-04-04 12:02   ` Stefan Roese
2016-03-15 17:55 ` [U-Boot] [PATCH 1/6] spi: kirkwood_spi.c: Add compatible match ID for Armada 375 Jagan Teki
2016-04-04 12:00 ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox