From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] rpi: remove redundant board files
Date: Mon, 4 Apr 2016 09:36:35 -0600 [thread overview]
Message-ID: <57028A03.7080803@wwwdotorg.org> (raw)
In-Reply-To: <570139B3.70704@suse.de>
On 04/03/2016 09:41 AM, Andreas F?rber wrote:
> Am 03.04.2016 um 05:56 schrieb Stephen Warren:
>> Now that rpi_*defconfig and Kconfig rather than the config header file,
>
> "rpi*_defconfig"?
Both regexes match the same set of files at present, but I prefer the
one I wrote, since it guarantees that it only matches the word "rpi" at
the start, not "rpi" followed by anything, which perhaps makes it
slightly less likely to accidentally match any other board in the future.
> Also the sentence seems to be missing a verb - "Now that we use ..."?
>
>> provide the identify of the build, we don't need to separate config
"provide" is the verb. There should have been a command after "Kconfig"
in the first line, or the comma before "provide" could be removed.
next prev parent reply other threads:[~2016-04-04 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 3:56 [U-Boot] [PATCH] rpi: remove redundant board files Stephen Warren
2016-04-03 14:46 ` Tom Rini
2016-04-03 15:41 ` Andreas Färber
2016-04-04 15:36 ` Stephen Warren [this message]
2016-04-04 15:46 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57028A03.7080803@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox