From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Mon, 4 Apr 2016 20:06:48 +0200 Subject: [U-Boot] [PATCH] test/py: Add support for loading image via tftp to specified location In-Reply-To: <56FD50CF.2060100@wwwdotorg.org> References: <56FD50CF.2060100@wwwdotorg.org> Message-ID: <5702AD38.1070702@xilinx.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 31.3.2016 18:31, Stephen Warren wrote: > On 03/31/2016 02:32 AM, Michal Simek wrote: >> For example this setting: >> >> env__net_tftp_readable_file = { >> "fn": "ep108/image.ub", >> "addr": "0x10000000", > > Why not remove the quotes, so the value is an integer already... > > Could you please add the "addr" field into the example at the top of > test_net.py too? > >> diff --git a/test/py/tests/test_net.py b/test/py/tests/test_net.py > >> + addr = int(addr,16) > > There should be a space after the comma. > > ... but removing the quotes as I mentioned above would allow removing > this int() call altogether. All added to v2 and sent. Thanks, Michal