From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Enable CMD_GPIO on all sunxi boards
Date: Tue, 5 Apr 2016 11:52:17 +0200 [thread overview]
Message-ID: <57038AD1.8010507@redhat.com> (raw)
In-Reply-To: <1459849596.1749.7.camel@hellion.org.uk>
Hi,
On 05-04-16 11:46, Ian Campbell wrote:
> On Sun, 2016-04-03 at 09:43 +0200, Hans de Goede wrote:
>> We have CONFIG_CMD_GPIO=y in almost all sunxi boards, but after
>> its Kconfig conversion it has ended up missing on some recently
>> added boards.
>
> The "almost all" is entirely down to the accidental omissions, right?
Right.
> i.e. are no boards where GPIO support is deliberately disabled I think
> (because all SoCs have them and it'd be practically impossible to build
> a system without using at least one of them).
>
>
>> Simply select it for ARCH_SUNXI, so that we get it on all
>> sunxi boards for both a consistent user experience and simpler
>> defconfig files.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Regardless of the question above (which is just curiosity really):
>
> Acked-by: Ian Campbell <ijc@hellion.org.uk>
>
Thanks for the reviews.
Regards,
Hans
prev parent reply other threads:[~2016-04-05 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 7:43 [U-Boot] [PATCH] sunxi: Enable CMD_GPIO on all sunxi boards Hans de Goede
2016-04-05 9:46 ` Ian Campbell
2016-04-05 9:52 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57038AD1.8010507@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox