public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/8] usb: gadget: Move CONFIG_USB_GADGET_VBUS_DRAW to Kconfig
Date: Tue, 5 Apr 2016 11:35:54 -0600	[thread overview]
Message-ID: <5703F77A.5010407@wwwdotorg.org> (raw)
In-Reply-To: <1459874197-14460-2-git-send-email-semen.protsenko@linaro.org>

On 04/05/2016 10:36 AM, Semen Protsenko wrote:
> From: Sam Protsenko <semen.protsenko@linaro.org>
>
> The description was borrowed from kernel, but allowed range was changed
> from 2..500 to 0..500, because some boards require this option to be 0.

Do they /require/ the value to be 0, or simply currently have it set to 
0 because whoever set the value in U-Boot wasn't aware that a value of 0 
could cause issues with some hosts?

I'd be tempted to keep the same range as the Linux kernel and bump all 
boards up to a minimum value of 2. Presumably there's some good reason 
the kernel chose a minimum of 2, and in practice I expect increasing all 
boards to 2 isn't going to make any negative difference.

> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig

> +config USB_GADGET_VBUS_DRAW
> +	int "Maximum VBUS Power usage (2-500 mA)"
> +	range 0 500
> +	default 2
> +	help
> +	   Some devices need to draw power from USB when they are
> +	   configured, perhaps to operate circuitry or to recharge
> +	   batteries.  This is in addition to any local power supply,
> +	   such as an AC adapter or batteries.
> +
> +	   Enter the maximum power your device draws through USB, in
> +	   milliAmperes.  The permitted range of values is 2 - 500 mA;
> +	   0 mA would be legal, but can make some hosts misbehave.

In particular, I'm thinking of that last sentence.

  reply	other threads:[~2016-04-05 17:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 16:36 [U-Boot] [PATCH 0/8] usb: Move DWC3 and some gadget options to Kconfig Semen Protsenko
2016-04-05 16:36 ` [U-Boot] [PATCH 1/8] usb: gadget: Move CONFIG_USB_GADGET_VBUS_DRAW " Semen Protsenko
2016-04-05 17:35   ` Stephen Warren [this message]
2016-04-05 19:45     ` Marek Vasut
2016-04-07 11:31       ` Soeren Moch
2016-04-07 15:14     ` Sam Protsenko
2016-04-05 16:36 ` [U-Boot] [PATCH 2/8] usb: gadget: Add CONFIG_USB_GADGET_DUALSPEED " Semen Protsenko
2016-04-05 17:39   ` Stephen Warren
2016-04-05 16:36 ` [U-Boot] [PATCH 3/8] usb: dwc3: Move CONFIG_USB_DWC3 " Semen Protsenko
2016-04-05 16:36 ` [U-Boot] [PATCH 4/8] usb: gadget: Move CONFIG_USB_GADGET_DOWNLOAD " Semen Protsenko
2016-04-05 16:36 ` [U-Boot] [PATCH 5/8] usb: dwc3: Move CONFIG_USB_DWC3_GADGET/HOST " Semen Protsenko
2016-04-05 16:36 ` [U-Boot] [PATCH 6/8] usb: dwc3: Move CONFIG_USB_DWC3_OMAP " Semen Protsenko
2016-04-05 16:36 ` [U-Boot] [PATCH 7/8] usb: dwc3: Move CONFIG_USB_DWC3_PHY_* " Semen Protsenko
2016-04-05 16:36 ` [U-Boot] [PATCH 8/8] usb: gadget Move: CONFIG_G_DNL_* " Semen Protsenko
2016-04-05 19:44 ` [U-Boot] [PATCH 0/8] usb: Move DWC3 and some gadget options " Marek Vasut
2016-04-07 14:57   ` Sam Protsenko
2016-04-06 13:59 ` Lukasz Majewski
2016-04-06 17:11   ` Michal Simek
2016-04-07  6:43     ` Lukasz Majewski
2016-04-07  6:53       ` Michal Simek
2016-04-07  8:22         ` Lukasz Majewski
2016-04-07 10:31           ` Michal Simek
2016-04-11 11:24 ` Lukasz Majewski
2016-04-11 12:56   ` Sam Protsenko
2016-04-11 13:23     ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5703F77A.5010407@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox