From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks
Date: Wed, 06 Apr 2016 12:52:58 +0200 [thread overview]
Message-ID: <5704EA8A.2080309@denx.de> (raw)
In-Reply-To: <CAM7GXokrKdGKgSXHsXXvfiYX1Ojt1s7pzohgdQptxXGjGACOBQ@mail.gmail.com>
On 04/06/2016 07:20 AM, Steve Rae wrote:
>
> On Apr 5, 2016 3:08 PM, "Marek Vasut" <marex@denx.de
> <mailto:marex@denx.de>> wrote:
>>
>> On 04/04/2016 10:30 PM, Steve Rae wrote:
>> > Hi Marek,
>> >
>> > On Mon, Apr 4, 2016 at 1:02 PM, Marek Vasut <marex@denx.de
> <mailto:marex@denx.de>> wrote:
>> >>
>> >> On 04/04/2016 09:59 PM, Steve Rae wrote:
>> >>> Turn on the USB OTG clocks.
>> >>>
>> >>> Signed-off-by: Steve Rae <srae@broadcom.com
> <mailto:srae@broadcom.com>>
>> >>> ---
>> >>>
>> >>> drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
>> >>> 1 file changed, 4 insertions(+)
>> >>>
>> >>> diff --git a/drivers/usb/gadget/bcm_udc_otg_phy.c
> b/drivers/usb/gadget/bcm_udc_otg_phy.c
>> >>> index 10b2e13..877f162 100644
>> >>> --- a/drivers/usb/gadget/bcm_udc_otg_phy.c
>> >>> +++ b/drivers/usb/gadget/bcm_udc_otg_phy.c
>> >>> @@ -8,12 +8,16 @@
>> >>> #include <common.h>
>> >>> #include <asm/io.h>
>> >>> #include <asm/arch/sysmap.h>
>> >>> +#include <asm/kona-common/clk.h>
>> >>>
>> >>> #include "dwc2_udc_otg_priv.h"
>> >>> #include "bcm_udc_otg.h"
>> >>>
>> >>> void otg_phy_init(struct dwc2_udc *dev)
>> >>> {
>> >>> + /* turn on the USB OTG clocks */
>> >>> + clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
>> >>
>> >> I _think_ this driver is used on RPi too, did you compile test it
> there?
>> >
>> > no, it is not - the only place this is used is:
>> > drivers/usb/gadget/Makefile:obj-$(CONFIG_USB_GADGET_BCM_UDC_OTG_PHY)
>> > += bcm_udc_otg_phy.o
>> > include/configs/bcm28155_ap.h:#define
> CONFIG_USB_GADGET_BCM_UDC_OTG_PHY
>>
>> Got it, thanks for checking.
>>
>> Do you want me to pick this up via u-boot-usb or shall this go via some
>> other tree as a series ?
>>
> I don't have any preference - what is the best way to get my outstanding
> patches applied?
Since the other two patches are quite unrelated, I will just pick this
one and let the bcm maintainer pick the rest.
Best regards,
Marek Vasut
prev parent reply other threads:[~2016-04-06 10:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 19:59 [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks Steve Rae
2016-04-04 19:59 ` [U-Boot] [PATCH 2/3] bcm281xx: enable CONFIG_OF_LIBFDT Steve Rae
2016-04-21 11:20 ` [U-Boot] [U-Boot,2/3] " Tom Rini
2016-04-04 19:59 ` [U-Boot] [PATCH 3/3] bcm281xx: save ENV to MMC Steve Rae
2016-04-21 11:20 ` [U-Boot] [U-Boot,3/3] " Tom Rini
2016-04-04 20:02 ` [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks Marek Vasut
2016-04-04 20:30 ` Steve Rae
2016-04-05 22:07 ` Marek Vasut
2016-04-06 5:20 ` Steve Rae
2016-04-06 10:52 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5704EA8A.2080309@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox