* [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks
@ 2016-04-04 19:59 Steve Rae
2016-04-04 19:59 ` [U-Boot] [PATCH 2/3] bcm281xx: enable CONFIG_OF_LIBFDT Steve Rae
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Steve Rae @ 2016-04-04 19:59 UTC (permalink / raw)
To: u-boot
Turn on the USB OTG clocks.
Signed-off-by: Steve Rae <srae@broadcom.com>
---
drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/gadget/bcm_udc_otg_phy.c b/drivers/usb/gadget/bcm_udc_otg_phy.c
index 10b2e13..877f162 100644
--- a/drivers/usb/gadget/bcm_udc_otg_phy.c
+++ b/drivers/usb/gadget/bcm_udc_otg_phy.c
@@ -8,12 +8,16 @@
#include <common.h>
#include <asm/io.h>
#include <asm/arch/sysmap.h>
+#include <asm/kona-common/clk.h>
#include "dwc2_udc_otg_priv.h"
#include "bcm_udc_otg.h"
void otg_phy_init(struct dwc2_udc *dev)
{
+ /* turn on the USB OTG clocks */
+ clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
+
/* set Phy to driving mode */
wfld_clear(HSOTG_CTRL_BASE_ADDR + HSOTG_CTRL_PHY_P1CTL_OFFSET,
HSOTG_CTRL_PHY_P1CTL_NON_DRIVING_MASK);
--
1.8.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/3] bcm281xx: enable CONFIG_OF_LIBFDT
2016-04-04 19:59 [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks Steve Rae
@ 2016-04-04 19:59 ` Steve Rae
2016-04-21 11:20 ` [U-Boot] [U-Boot,2/3] " Tom Rini
2016-04-04 19:59 ` [U-Boot] [PATCH 3/3] bcm281xx: save ENV to MMC Steve Rae
2016-04-04 20:02 ` [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks Marek Vasut
2 siblings, 1 reply; 10+ messages in thread
From: Steve Rae @ 2016-04-04 19:59 UTC (permalink / raw)
To: u-boot
set the Kconfig parameter: CONFIG_OF_LIBFDT
Signed-off-by: Steve Rae <srae@broadcom.com>
---
configs/bcm28155_ap_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/bcm28155_ap_defconfig b/configs/bcm28155_ap_defconfig
index ba57944..538647d 100644
--- a/configs/bcm28155_ap_defconfig
+++ b/configs/bcm28155_ap_defconfig
@@ -9,3 +9,4 @@ CONFIG_CMD_GPIO=y
CONFIG_SYS_NS16550=y
CONFIG_USB=y
CONFIG_USB_GADGET=y
+CONFIG_OF_LIBFDT=y
--
1.8.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 3/3] bcm281xx: save ENV to MMC
2016-04-04 19:59 [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks Steve Rae
2016-04-04 19:59 ` [U-Boot] [PATCH 2/3] bcm281xx: enable CONFIG_OF_LIBFDT Steve Rae
@ 2016-04-04 19:59 ` Steve Rae
2016-04-21 11:20 ` [U-Boot] [U-Boot,3/3] " Tom Rini
2016-04-04 20:02 ` [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks Marek Vasut
2 siblings, 1 reply; 10+ messages in thread
From: Steve Rae @ 2016-04-04 19:59 UTC (permalink / raw)
To: u-boot
Enable saving ENV to MMC for the bcm281xx boards.
Signed-off-by: Steve Rae <srae@broadcom.com>
---
include/configs/bcm28155_ap.h | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/configs/bcm28155_ap.h b/include/configs/bcm28155_ap.h
index f1e8ed1..2b8e324 100644
--- a/include/configs/bcm28155_ap.h
+++ b/include/configs/bcm28155_ap.h
@@ -88,8 +88,11 @@
#define CONFIG_BAUDRATE 115200
-#define CONFIG_ENV_SIZE 0x10000
-#define CONFIG_ENV_IS_NOWHERE
+/* must fit into GPT:u-boot-env partition */
+#define CONFIG_ENV_IS_IN_MMC
+#define CONFIG_SYS_MMC_ENV_DEV 0
+#define CONFIG_ENV_OFFSET (0x00011a00 * 512)
+#define CONFIG_ENV_SIZE (8 * 512)
#define CONFIG_SYS_NO_FLASH /* Not using NAND/NOR unmanaged flash */
--
1.8.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks
2016-04-04 19:59 [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks Steve Rae
2016-04-04 19:59 ` [U-Boot] [PATCH 2/3] bcm281xx: enable CONFIG_OF_LIBFDT Steve Rae
2016-04-04 19:59 ` [U-Boot] [PATCH 3/3] bcm281xx: save ENV to MMC Steve Rae
@ 2016-04-04 20:02 ` Marek Vasut
2016-04-04 20:30 ` Steve Rae
2 siblings, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2016-04-04 20:02 UTC (permalink / raw)
To: u-boot
On 04/04/2016 09:59 PM, Steve Rae wrote:
> Turn on the USB OTG clocks.
>
> Signed-off-by: Steve Rae <srae@broadcom.com>
> ---
>
> drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/gadget/bcm_udc_otg_phy.c b/drivers/usb/gadget/bcm_udc_otg_phy.c
> index 10b2e13..877f162 100644
> --- a/drivers/usb/gadget/bcm_udc_otg_phy.c
> +++ b/drivers/usb/gadget/bcm_udc_otg_phy.c
> @@ -8,12 +8,16 @@
> #include <common.h>
> #include <asm/io.h>
> #include <asm/arch/sysmap.h>
> +#include <asm/kona-common/clk.h>
>
> #include "dwc2_udc_otg_priv.h"
> #include "bcm_udc_otg.h"
>
> void otg_phy_init(struct dwc2_udc *dev)
> {
> + /* turn on the USB OTG clocks */
> + clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
I _think_ this driver is used on RPi too, did you compile test it there?
> /* set Phy to driving mode */
> wfld_clear(HSOTG_CTRL_BASE_ADDR + HSOTG_CTRL_PHY_P1CTL_OFFSET,
> HSOTG_CTRL_PHY_P1CTL_NON_DRIVING_MASK);
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks
2016-04-04 20:02 ` [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks Marek Vasut
@ 2016-04-04 20:30 ` Steve Rae
2016-04-05 22:07 ` Marek Vasut
0 siblings, 1 reply; 10+ messages in thread
From: Steve Rae @ 2016-04-04 20:30 UTC (permalink / raw)
To: u-boot
Hi Marek,
On Mon, Apr 4, 2016 at 1:02 PM, Marek Vasut <marex@denx.de> wrote:
>
> On 04/04/2016 09:59 PM, Steve Rae wrote:
> > Turn on the USB OTG clocks.
> >
> > Signed-off-by: Steve Rae <srae@broadcom.com>
> > ---
> >
> > drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/usb/gadget/bcm_udc_otg_phy.c b/drivers/usb/gadget/bcm_udc_otg_phy.c
> > index 10b2e13..877f162 100644
> > --- a/drivers/usb/gadget/bcm_udc_otg_phy.c
> > +++ b/drivers/usb/gadget/bcm_udc_otg_phy.c
> > @@ -8,12 +8,16 @@
> > #include <common.h>
> > #include <asm/io.h>
> > #include <asm/arch/sysmap.h>
> > +#include <asm/kona-common/clk.h>
> >
> > #include "dwc2_udc_otg_priv.h"
> > #include "bcm_udc_otg.h"
> >
> > void otg_phy_init(struct dwc2_udc *dev)
> > {
> > + /* turn on the USB OTG clocks */
> > + clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
>
> I _think_ this driver is used on RPi too, did you compile test it there?
no, it is not - the only place this is used is:
drivers/usb/gadget/Makefile:obj-$(CONFIG_USB_GADGET_BCM_UDC_OTG_PHY)
+= bcm_udc_otg_phy.o
include/configs/bcm28155_ap.h:#define CONFIG_USB_GADGET_BCM_UDC_OTG_PHY
Thanks, Steve
PS.
"rpi" and "rpi_2" both build successfully....
>
>
> > /* set Phy to driving mode */
> > wfld_clear(HSOTG_CTRL_BASE_ADDR + HSOTG_CTRL_PHY_P1CTL_OFFSET,
> > HSOTG_CTRL_PHY_P1CTL_NON_DRIVING_MASK);
> >
>
>
> --
> Best regards,
> Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks
2016-04-04 20:30 ` Steve Rae
@ 2016-04-05 22:07 ` Marek Vasut
2016-04-06 5:20 ` Steve Rae
0 siblings, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2016-04-05 22:07 UTC (permalink / raw)
To: u-boot
On 04/04/2016 10:30 PM, Steve Rae wrote:
> Hi Marek,
>
> On Mon, Apr 4, 2016 at 1:02 PM, Marek Vasut <marex@denx.de> wrote:
>>
>> On 04/04/2016 09:59 PM, Steve Rae wrote:
>>> Turn on the USB OTG clocks.
>>>
>>> Signed-off-by: Steve Rae <srae@broadcom.com>
>>> ---
>>>
>>> drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/usb/gadget/bcm_udc_otg_phy.c b/drivers/usb/gadget/bcm_udc_otg_phy.c
>>> index 10b2e13..877f162 100644
>>> --- a/drivers/usb/gadget/bcm_udc_otg_phy.c
>>> +++ b/drivers/usb/gadget/bcm_udc_otg_phy.c
>>> @@ -8,12 +8,16 @@
>>> #include <common.h>
>>> #include <asm/io.h>
>>> #include <asm/arch/sysmap.h>
>>> +#include <asm/kona-common/clk.h>
>>>
>>> #include "dwc2_udc_otg_priv.h"
>>> #include "bcm_udc_otg.h"
>>>
>>> void otg_phy_init(struct dwc2_udc *dev)
>>> {
>>> + /* turn on the USB OTG clocks */
>>> + clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
>>
>> I _think_ this driver is used on RPi too, did you compile test it there?
>
> no, it is not - the only place this is used is:
> drivers/usb/gadget/Makefile:obj-$(CONFIG_USB_GADGET_BCM_UDC_OTG_PHY)
> += bcm_udc_otg_phy.o
> include/configs/bcm28155_ap.h:#define CONFIG_USB_GADGET_BCM_UDC_OTG_PHY
Got it, thanks for checking.
Do you want me to pick this up via u-boot-usb or shall this go via some
other tree as a series ?
> Thanks, Steve
> PS.
> "rpi" and "rpi_2" both build successfully....
>
>>
>>
>>> /* set Phy to driving mode */
>>> wfld_clear(HSOTG_CTRL_BASE_ADDR + HSOTG_CTRL_PHY_P1CTL_OFFSET,
>>> HSOTG_CTRL_PHY_P1CTL_NON_DRIVING_MASK);
>>>
>>
>>
>> --
>> Best regards,
>> Marek Vasut
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks
2016-04-05 22:07 ` Marek Vasut
@ 2016-04-06 5:20 ` Steve Rae
2016-04-06 10:52 ` Marek Vasut
0 siblings, 1 reply; 10+ messages in thread
From: Steve Rae @ 2016-04-06 5:20 UTC (permalink / raw)
To: u-boot
On Apr 5, 2016 3:08 PM, "Marek Vasut" <marex@denx.de> wrote:
>
> On 04/04/2016 10:30 PM, Steve Rae wrote:
> > Hi Marek,
> >
> > On Mon, Apr 4, 2016 at 1:02 PM, Marek Vasut <marex@denx.de> wrote:
> >>
> >> On 04/04/2016 09:59 PM, Steve Rae wrote:
> >>> Turn on the USB OTG clocks.
> >>>
> >>> Signed-off-by: Steve Rae <srae@broadcom.com>
> >>> ---
> >>>
> >>> drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
> >>> 1 file changed, 4 insertions(+)
> >>>
> >>> diff --git a/drivers/usb/gadget/bcm_udc_otg_phy.c
b/drivers/usb/gadget/bcm_udc_otg_phy.c
> >>> index 10b2e13..877f162 100644
> >>> --- a/drivers/usb/gadget/bcm_udc_otg_phy.c
> >>> +++ b/drivers/usb/gadget/bcm_udc_otg_phy.c
> >>> @@ -8,12 +8,16 @@
> >>> #include <common.h>
> >>> #include <asm/io.h>
> >>> #include <asm/arch/sysmap.h>
> >>> +#include <asm/kona-common/clk.h>
> >>>
> >>> #include "dwc2_udc_otg_priv.h"
> >>> #include "bcm_udc_otg.h"
> >>>
> >>> void otg_phy_init(struct dwc2_udc *dev)
> >>> {
> >>> + /* turn on the USB OTG clocks */
> >>> + clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
> >>
> >> I _think_ this driver is used on RPi too, did you compile test it
there?
> >
> > no, it is not - the only place this is used is:
> > drivers/usb/gadget/Makefile:obj-$(CONFIG_USB_GADGET_BCM_UDC_OTG_PHY)
> > += bcm_udc_otg_phy.o
> > include/configs/bcm28155_ap.h:#define
CONFIG_USB_GADGET_BCM_UDC_OTG_PHY
>
> Got it, thanks for checking.
>
> Do you want me to pick this up via u-boot-usb or shall this go via some
> other tree as a series ?
>
I don't have any preference - what is the best way to get my outstanding
patches applied?
Thanks, Steve
> > Thanks, Steve
> > PS.
> > "rpi" and "rpi_2" both build successfully....
> >
> >>
> >>
> >>> /* set Phy to driving mode */
> >>> wfld_clear(HSOTG_CTRL_BASE_ADDR + HSOTG_CTRL_PHY_P1CTL_OFFSET,
> >>> HSOTG_CTRL_PHY_P1CTL_NON_DRIVING_MASK);
> >>>
> >>
> >>
> >> --
> >> Best regards,
> >> Marek Vasut
>
>
> --
> Best regards,
> Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks
2016-04-06 5:20 ` Steve Rae
@ 2016-04-06 10:52 ` Marek Vasut
0 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2016-04-06 10:52 UTC (permalink / raw)
To: u-boot
On 04/06/2016 07:20 AM, Steve Rae wrote:
>
> On Apr 5, 2016 3:08 PM, "Marek Vasut" <marex@denx.de
> <mailto:marex@denx.de>> wrote:
>>
>> On 04/04/2016 10:30 PM, Steve Rae wrote:
>> > Hi Marek,
>> >
>> > On Mon, Apr 4, 2016 at 1:02 PM, Marek Vasut <marex@denx.de
> <mailto:marex@denx.de>> wrote:
>> >>
>> >> On 04/04/2016 09:59 PM, Steve Rae wrote:
>> >>> Turn on the USB OTG clocks.
>> >>>
>> >>> Signed-off-by: Steve Rae <srae@broadcom.com
> <mailto:srae@broadcom.com>>
>> >>> ---
>> >>>
>> >>> drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
>> >>> 1 file changed, 4 insertions(+)
>> >>>
>> >>> diff --git a/drivers/usb/gadget/bcm_udc_otg_phy.c
> b/drivers/usb/gadget/bcm_udc_otg_phy.c
>> >>> index 10b2e13..877f162 100644
>> >>> --- a/drivers/usb/gadget/bcm_udc_otg_phy.c
>> >>> +++ b/drivers/usb/gadget/bcm_udc_otg_phy.c
>> >>> @@ -8,12 +8,16 @@
>> >>> #include <common.h>
>> >>> #include <asm/io.h>
>> >>> #include <asm/arch/sysmap.h>
>> >>> +#include <asm/kona-common/clk.h>
>> >>>
>> >>> #include "dwc2_udc_otg_priv.h"
>> >>> #include "bcm_udc_otg.h"
>> >>>
>> >>> void otg_phy_init(struct dwc2_udc *dev)
>> >>> {
>> >>> + /* turn on the USB OTG clocks */
>> >>> + clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
>> >>
>> >> I _think_ this driver is used on RPi too, did you compile test it
> there?
>> >
>> > no, it is not - the only place this is used is:
>> > drivers/usb/gadget/Makefile:obj-$(CONFIG_USB_GADGET_BCM_UDC_OTG_PHY)
>> > += bcm_udc_otg_phy.o
>> > include/configs/bcm28155_ap.h:#define
> CONFIG_USB_GADGET_BCM_UDC_OTG_PHY
>>
>> Got it, thanks for checking.
>>
>> Do you want me to pick this up via u-boot-usb or shall this go via some
>> other tree as a series ?
>>
> I don't have any preference - what is the best way to get my outstanding
> patches applied?
Since the other two patches are quite unrelated, I will just pick this
one and let the bcm maintainer pick the rest.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [U-Boot,2/3] bcm281xx: enable CONFIG_OF_LIBFDT
2016-04-04 19:59 ` [U-Boot] [PATCH 2/3] bcm281xx: enable CONFIG_OF_LIBFDT Steve Rae
@ 2016-04-21 11:20 ` Tom Rini
0 siblings, 0 replies; 10+ messages in thread
From: Tom Rini @ 2016-04-21 11:20 UTC (permalink / raw)
To: u-boot
On Mon, Apr 04, 2016 at 12:59:44PM -0700, Steve Rae wrote:
> set the Kconfig parameter: CONFIG_OF_LIBFDT
>
> Signed-off-by: Steve Rae <srae@broadcom.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160421/b94a743c/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [U-Boot,3/3] bcm281xx: save ENV to MMC
2016-04-04 19:59 ` [U-Boot] [PATCH 3/3] bcm281xx: save ENV to MMC Steve Rae
@ 2016-04-21 11:20 ` Tom Rini
0 siblings, 0 replies; 10+ messages in thread
From: Tom Rini @ 2016-04-21 11:20 UTC (permalink / raw)
To: u-boot
On Mon, Apr 04, 2016 at 12:59:45PM -0700, Steve Rae wrote:
> Enable saving ENV to MMC for the bcm281xx boards.
>
> Signed-off-by: Steve Rae <srae@broadcom.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160421/c56b9dcf/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-04-21 11:20 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-04 19:59 [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks Steve Rae
2016-04-04 19:59 ` [U-Boot] [PATCH 2/3] bcm281xx: enable CONFIG_OF_LIBFDT Steve Rae
2016-04-21 11:20 ` [U-Boot] [U-Boot,2/3] " Tom Rini
2016-04-04 19:59 ` [U-Boot] [PATCH 3/3] bcm281xx: save ENV to MMC Steve Rae
2016-04-21 11:20 ` [U-Boot] [U-Boot,3/3] " Tom Rini
2016-04-04 20:02 ` [U-Boot] [PATCH 1/3] usb: bcm_udc_otg: enable clocks Marek Vasut
2016-04-04 20:30 ` Steve Rae
2016-04-05 22:07 ` Marek Vasut
2016-04-06 5:20 ` Steve Rae
2016-04-06 10:52 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox