From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 6 Apr 2016 15:42:49 +0200 Subject: [U-Boot] [PATCH v2] kirkwood_nand: claim MPP pins on the fly In-Reply-To: References: <1454369709-5459-1-git-send-email-judge.packham@gmail.com> <56F3A80C.9020706@denx.de> Message-ID: <57051259.8040309@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05.04.2016 00:48, Scott Wood wrote: > On 03/24/2016 03:40 AM, Stefan Roese wrote: >> On 02.02.2016 00:35, Chris Packham wrote: >>> Claim the MPP pins for the NAND flash controller only when it's actually >>> being used. This allows the pins to be shared with the SPI interface >>> which already supports an equivalent on-access MPP reconfiguration. >>> >>> Reviewed-by: Mark Tomlinson >>> Signed-off-by: Chris Packham >>> --- >>> I haven't wrapped this with a configuration option because I think it >>> should be safe to enable by default. It will either re-apply the same >>> MPP configuration that has already been done in the board init or put >>> the MPP pins into the correct mode to access NAND. >>> >>> I've only got access to one kirkwood based board with NAND flash so I'd >>> appreciate some feedback from someone with access to a few different >>> boards. >>> >>> From the datasheets I have access to it looks like there is only one >>> possible MPP configuration for NF_IO[0-7] so that is what I've >>> implemented. I'm not aware of anything using this driver that needs a >>> different MPP config. >>> >>> Changes in v2: >>> - make nand_config static const >> >> Scott, are you okay with this patch in v2? > > Yes. > Acked-by: Scott Wood > >> If yes, will you pull it? >> Or should I include it in a marvell pull request? > > Go ahead. Applied to u-boot-marvell/master. Thanks, Stefan