public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/5] tools/env: pass arguments as parameters not global structure
Date: Wed, 6 Apr 2016 16:25:52 +0200	[thread overview]
Message-ID: <57051C70.6030207@denx.de> (raw)
In-Reply-To: <1459890822-11382-1-git-send-email-andreas.fenkart@digitalstrom.com>

Hi Andreas,

On 05/04/2016 23:13, Andreas Fenkart wrote:
> u-boot tools can be built as a library (ibubootenv.a). Passing arguments
> to the library using global structures is not a good interface.
> 
> Andreas Fenkart (5):
>   tools/env: make env_aes_cbc_crypt re-entrant
>   tools/env: remove 'extern' from function prototype in fw_env.h
>   tools/env: fw_printenv pass value_only as argument
>   tools/env: compute size of usable area only once
>   tools/env: no global variable sharing between application and library
> 
>  tools/env/fw_env.c      | 95 ++++++++++++++++++++++++++-----------------------
>  tools/env/fw_env.h      | 31 ++++++----------
>  tools/env/fw_env_main.c | 28 +++++++++------
>  3 files changed, 78 insertions(+), 76 deletions(-)
> 

I can confirm that series fixes building an external program using the
env tools as environment. Thanks for fixing it !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      parent reply	other threads:[~2016-04-06 14:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 21:13 [U-Boot] [PATCH 0/5] tools/env: pass arguments as parameters not global structure Andreas Fenkart
2016-04-05 21:13 ` [U-Boot] [PATCH 1/5] tools/env: make env_aes_cbc_crypt re-entrant Andreas Fenkart
2016-04-06 11:29   ` Stefano Babic
2016-04-05 21:13 ` [U-Boot] [PATCH 2/5] tools/env: remove 'extern' from function prototype in fw_env.h Andreas Fenkart
2016-04-05 21:13 ` [U-Boot] [PATCH 3/5] tools/env: fw_printenv pass value_only as argument Andreas Fenkart
2016-04-05 21:13 ` [U-Boot] [PATCH 4/5] tools/env: compute size of usable area only once Andreas Fenkart
2016-04-05 21:13 ` [U-Boot] [PATCH 5/5] tools/env: no global variable sharing between application and library Andreas Fenkart
2016-05-30 17:59   ` [U-Boot] [U-Boot, " Tom Rini
2016-04-06 14:25 ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57051C70.6030207@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox