From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/1] mpc85xx: Enable pre-relocation malloc for MPC85xx
Date: Wed, 6 Apr 2016 13:37:02 -0700 [thread overview]
Message-ID: <5705736E.8000405@nxp.com> (raw)
In-Reply-To: <1459861537-9766-1-git-send-email-mario.six@gdsys.cc>
On 04/05/2016 06:06 AM, Mario Six wrote:
> To enable DM on MPC85xx, we need pre-relocation malloc, which is
> implemented in this patch.
>
> We also make sure that the IVORs are always 4-aligned on e500 to prevent
> alignment exceptions caused by code changes in start.S.
>
> Signed-off-by: Mario Six <mario.six@gdsys.cc>
> Cc: York Sun <york.sun@nxp.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>
> v3:
> - Add comment regarding gd zeroing
> - Unconditionally zero out initial RAM during startup
>
> v2:
> - Correct IVOR alignment and remove nop hack
> - Add sanity check for length of malloc area
>
>
> arch/powerpc/cpu/mpc85xx/cpu_init_early.c | 8 +-------
> arch/powerpc/cpu/mpc85xx/start.S | 30 ++++++++++++++++++++++++++++++
> include/ppc_asm.tmpl | 3 +++
> 3 files changed, 34 insertions(+), 7 deletions(-)
>
> diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> index 235a635..85b4112 100644
> --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> @@ -82,7 +82,6 @@ void setup_ifc(void)
> void cpu_init_early_f(void *fdt)
> {
> u32 mas0, mas1, mas2, mas3, mas7;
> - int i;
> #ifdef CONFIG_SYS_FSL_ERRATUM_P1010_A003549
> ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);
> #endif
> @@ -95,12 +94,7 @@ void cpu_init_early_f(void *fdt)
> /* Pointer is writable since we allocated a register for it */
> gd = (gd_t *) (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_GBL_DATA_OFFSET);
>
> - /*
> - * Clear initial global data
> - * we don't use memset so we can share this code with NAND_SPL
> - */
> - for (i = 0; i < sizeof(gd_t); i++)
> - ((char *)gd)[i] = 0;
> + /* gd area was zeroed during startup */
>
> #ifdef CONFIG_QEMU_E500
> /*
> diff --git a/arch/powerpc/cpu/mpc85xx/start.S b/arch/powerpc/cpu/mpc85xx/start.S
> index d867e2a..82a151a 100644
> --- a/arch/powerpc/cpu/mpc85xx/start.S
> +++ b/arch/powerpc/cpu/mpc85xx/start.S
> @@ -1152,6 +1152,36 @@ _start_cont:
> /* Setup the stack in initial RAM,could be L2-as-SRAM or L1 dcache*/
> lis r3,(CONFIG_SYS_INIT_RAM_ADDR)@h
> ori r3,r3,((CONFIG_SYS_INIT_SP_OFFSET-16)&~0xf)@l /* Align to 16 */
> +
> +#ifdef CONFIG_SYS_MALLOC_F_LEN
> +
> +#if CONFIG_SYS_MALLOC_F_LEN + GENERATED_GBL_DATA_SIZE > CONFIG_SYS_INIT_RAM_SIZE
> +#error "CONFIG_SYS_MALLOC_F_LEN too large to fit into initial RAM."
> +#endif
> +
> + /* Leave 16+ byte for back chain termination and NULL return address */
> + subi r3,r3,((CONFIG_SYS_MALLOC_F_LEN+16+15)&~0xf)
> +#endif
> +
> + /* End of RAM */
> + lis r4,(CONFIG_SYS_INIT_RAM_ADDR)@h
> + ori r4,r4,(CONFIG_SYS_INIT_RAM_SIZE)@l
> +
CONFIG_SYS_INIT_RAM_SIZE is not defined for some platforms, for example
P1010RDB, C29XPCIE, BSC9132QDS. I will send out a patch to fix.
York
next prev parent reply other threads:[~2016-04-06 20:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 6:52 [U-Boot] [RFC v1 PATCH 1/1] mpc85xx: Enable pre-relocation malloc for MPC85xx Mario Six
2016-03-30 15:44 ` York Sun
2016-03-31 6:29 ` Mario Six
2016-03-31 16:23 ` York Sun
2016-04-01 7:40 ` Mario Six
2016-04-01 8:12 ` [U-Boot] [PATCH v2 " Mario Six
2016-04-01 17:10 ` York Sun
2016-04-04 10:01 ` Mario Six
2016-04-04 16:04 ` York Sun
2016-04-05 12:55 ` Mario Six
2016-04-05 13:05 ` [U-Boot] [PATCH v3 " Mario Six
2016-04-06 20:37 ` York Sun [this message]
2016-04-06 20:59 ` York Sun
2016-04-07 6:06 ` Mario Six
2016-04-08 22:47 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5705736E.8000405@nxp.com \
--to=york.sun@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox