From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Date: Fri, 8 Apr 2016 07:05:29 -0500 Subject: [U-Boot] [uboot][PATCH v3 1/2] net: phy: dp83867: Add device tree bindings and documentation In-Reply-To: <570778FD.7060804@xilinx.com> References: <1459942680-18696-1-git-send-email-dmurphy@ti.com> <5705E5DA.1050208@ti.com> <570684AD.1080704@ti.com> <570778FD.7060804@xilinx.com> Message-ID: <57079E89.6050705@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/08/2016 04:25 AM, Michal Simek wrote: > On 7.4.2016 18:02, Dan Murphy wrote: >> Mugunthan >> >> On 04/06/2016 11:45 PM, Mugunthan V N wrote: >>> On Wednesday 06 April 2016 05:07 PM, Dan Murphy wrote: >>>> Add the device tree bindings and the accompanying documentation >>>> for the TI DP83867 Giga bit ethernet phy driver. >>>> >>>> The original document was from: >>>> [commit 2a10154abcb75ad0d7b6bfea6210ac743ec60897 from the Linux kernel] >>>> >>>> Signed-off-by: Dan Murphy >>>> --- >>>> >>>> v3 - Modify the binding to the kernel changed int -> internal for the delay - https://patchwork.ozlabs.org/patch/606595/ >>>> >>>> doc/device-tree-bindings/net/ti,dp83867.txt | 29 ++++++++++++++++++++++++ >>>> include/dt-bindings/net/ti-dp83867.h | 35 +++++++++++++++++++++++++++++ >>>> 2 files changed, 64 insertions(+) >>>> create mode 100644 doc/device-tree-bindings/net/ti,dp83867.txt >>>> create mode 100644 include/dt-bindings/net/ti-dp83867.h >>>> >>>> diff --git a/doc/device-tree-bindings/net/ti,dp83867.txt b/doc/device-tree-bindings/net/ti,dp83867.txt >>>> new file mode 100644 >>>> index 0000000..0ec009c >>>> --- /dev/null >>>> +++ b/doc/device-tree-bindings/net/ti,dp83867.txt >>>> @@ -0,0 +1,29 @@ >>>> +* Texas Instruments - dp83867 Giga bit ethernet phy >>>> + >>>> +Required properties: >>>> + - ti,rx-internal-delay - RGMII Recieve Clock Delay - see dt-bindings/net/ti-dp83867.h >>>> + for applicable values >>>> + - ti,tx-internal-delay - RGMII Transmit Clock Delay - see dt-bindings/net/ti-dp83867.h >>>> + for applicable values >>>> + - ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h >>>> + for applicable values >>>> + >>>> +Default child nodes are standard Ethernet PHY device >>>> +nodes as described in doc/devicetree/bindings/net/ethernet.txt >>>> + >>>> +Example: >>>> + >>>> +&mac { >>>> + pinctrl-0 = <&davinci_mdio_default>; >>>> + pinctrl-1 = <&davinci_mdio_sleep>; >>>> + status = "okay"; >>>> + >>>> + ti,rx_internal_delay = ; >>>> + ti,tx_internal_delay = ; >>>> + ti,fifo_depth = ; >>>> + >>>> +}; >>> This example should in phy node and not in mac node as per the linux >>> commmit mentioned above? >> Are you saying that the code should look like this >> >> &mac { >> pinctrl-0 = <&davinci_mdio_default>; >> pinctrl-1 = <&davinci_mdio_sleep>; >> status = "okay"; >> phy-handle = <ðernet_phy>; >> >> ethernet_phy: ethernet-phy at 0 { >> reg = <0>; >> ti,rx_int_delay = ; >> ti,tx_int_delay = ; >> ti,fifo_depth = ; >> }; >> >> This is the way it is in the kernel. > First of all. Please rebase your 2/2 on the top of current branch. > sgmii support was added recently. Yeah I had a feeling that I was going to need to do that. > > Here is what I use on zynqmp. > http://lists.denx.de/pipermail/u-boot/2016-April/250866.html > And it reflects the description above. OK the zync_gem supports phy-handle. cpsw does not. Looks like I have to add a patch to cpsw. Dan > > Thanks, > Michal -- ------------------ Dan Murphy