public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] gpio: mvebu_gpio: Add missing out value set to gpio_direction_output()
@ 2016-04-07  5:41 Stefan Roese
  2016-04-08 14:54 ` Kevin Smith
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Roese @ 2016-04-07  5:41 UTC (permalink / raw)
  To: u-boot

This patch adds the missing configuration of the output value to the
gpio_direction_output() function. Without this, calling
gpio_direction_output() does not set the out-value at all and only
configures the gpio as output.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Kevin Smith <kevin.smith@elecsyscorp.com>
---
 drivers/gpio/mvebu_gpio.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpio/mvebu_gpio.c b/drivers/gpio/mvebu_gpio.c
index 9564ce2..75dc73e 100644
--- a/drivers/gpio/mvebu_gpio.c
+++ b/drivers/gpio/mvebu_gpio.c
@@ -43,6 +43,10 @@ static int mvebu_gpio_direction_output(struct udevice *dev, unsigned gpio,
 	struct mvebu_gpio_priv *priv = dev_get_priv(dev);
 	struct mvebu_gpio_regs *regs = priv->regs;
 
+	if (value)
+		setbits_le32(&regs->data_out, BIT(gpio));
+	else
+		clrbits_le32(&regs->data_out, BIT(gpio));
 	clrbits_le32(&regs->io_conf, BIT(gpio));
 
 	return 0;
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] gpio: mvebu_gpio: Add missing out value set to gpio_direction_output()
  2016-04-07  5:41 [U-Boot] [PATCH] gpio: mvebu_gpio: Add missing out value set to gpio_direction_output() Stefan Roese
@ 2016-04-08 14:54 ` Kevin Smith
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Smith @ 2016-04-08 14:54 UTC (permalink / raw)
  To: u-boot

On 04/07/2016 12:41 AM, Stefan Roese wrote:
> This patch adds the missing configuration of the output value to the
> gpio_direction_output() function. Without this, calling
> gpio_direction_output() does not set the out-value at all and only
> configures the gpio as output.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Kevin Smith <kevin.smith@elecsyscorp.com>
> ---
>   drivers/gpio/mvebu_gpio.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpio/mvebu_gpio.c b/drivers/gpio/mvebu_gpio.c
> index 9564ce2..75dc73e 100644
> --- a/drivers/gpio/mvebu_gpio.c
> +++ b/drivers/gpio/mvebu_gpio.c
> @@ -43,6 +43,10 @@ static int mvebu_gpio_direction_output(struct udevice *dev, unsigned gpio,
>   	struct mvebu_gpio_priv *priv = dev_get_priv(dev);
>   	struct mvebu_gpio_regs *regs = priv->regs;
>   
> +	if (value)
> +		setbits_le32(&regs->data_out, BIT(gpio));
> +	else
> +		clrbits_le32(&regs->data_out, BIT(gpio));
>   	clrbits_le32(&regs->io_conf, BIT(gpio));
>   
>   	return 0;
Reviewed-by: Kevin Smith <kevin.smith@elecsyscorp.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-08 14:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-07  5:41 [U-Boot] [PATCH] gpio: mvebu_gpio: Add missing out value set to gpio_direction_output() Stefan Roese
2016-04-08 14:54 ` Kevin Smith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox