From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Smith Date: Fri, 8 Apr 2016 14:54:03 +0000 Subject: [U-Boot] [PATCH] gpio: mvebu_gpio: Add missing out value set to gpio_direction_output() In-Reply-To: <1460007660-11740-1-git-send-email-sr@denx.de> References: <1460007660-11740-1-git-send-email-sr@denx.de> Message-ID: <5707C609.6050109@elecsyscorp.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/07/2016 12:41 AM, Stefan Roese wrote: > This patch adds the missing configuration of the output value to the > gpio_direction_output() function. Without this, calling > gpio_direction_output() does not set the out-value at all and only > configures the gpio as output. > > Signed-off-by: Stefan Roese > Cc: Kevin Smith > --- > drivers/gpio/mvebu_gpio.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpio/mvebu_gpio.c b/drivers/gpio/mvebu_gpio.c > index 9564ce2..75dc73e 100644 > --- a/drivers/gpio/mvebu_gpio.c > +++ b/drivers/gpio/mvebu_gpio.c > @@ -43,6 +43,10 @@ static int mvebu_gpio_direction_output(struct udevice *dev, unsigned gpio, > struct mvebu_gpio_priv *priv = dev_get_priv(dev); > struct mvebu_gpio_regs *regs = priv->regs; > > + if (value) > + setbits_le32(®s->data_out, BIT(gpio)); > + else > + clrbits_le32(®s->data_out, BIT(gpio)); > clrbits_le32(®s->io_conf, BIT(gpio)); > > return 0; Reviewed-by: Kevin Smith