From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Fri, 8 Apr 2016 10:29:31 -0600
Subject: [U-Boot] [PATCH 2/3] tests: py: dfu: Add functionality to set
 different u-boot's dfu env variable
In-Reply-To: <1460130291-24223-2-git-send-email-l.majewski@samsung.com>
References: <1460130291-24223-1-git-send-email-l.majewski@samsung.com>
 <1460130291-24223-2-git-send-email-l.majewski@samsung.com>
Message-ID: <5707DC6B.1050905@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 04/08/2016 09:44 AM, Lukasz Majewski wrote:
> By default (on almost all systems) the dfu env variable, which defines
> available alt settings, is named as "dfu_alt_info".
>
> However on some platforms (i.e. Odroid XU3), the 'dfu_alt_info' is concatenated
> from other variables - namely 'dfu_alt_boot' and 'dfu_alt_system' at run time
> (when one types 'dfu 0 mmc 0' for first time).
>
> 'dfu_alt_boot' describes alt settings which depend on boot medium - for example
> boot loader's LBA sectors which are different on eMMC and SD card because of e.g.
> MBR/GPT.
>
> 'dfu_alt_system' describes board agnostic alt settings - like rootfs, kernel.
> On such system we can only append/modify this env variable.
>
> Because of the above, we must have way to modify other than "dfu_ale_info"
> variable to perform tests.

> diff --git a/test/py/tests/test_dfu.py b/test/py/tests/test_dfu.py

> +        # Optional values.
> +        # Those values are necessary on boards like Odroid XU3, where
> +        # - dfu alt info env variable is concatenated from boot medium dependent
> +        #   (dfu_alt_boot) and user defined (dfu_alt_system) variables
> +        "alt_info_env_name": "dfu_alt_system",

The previous value is also optional. I'd suggest simply prefixing each 
optional value with the same text as already used:

         # This value is optional.