public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric@nelint.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 2/2] mmc: add support for block device cache
Date: Sun, 10 Apr 2016 07:31:47 -0700	[thread overview]
Message-ID: <570A63D3.6060608@nelint.com> (raw)
In-Reply-To: <CAPnjgZ32e-YGbP7w-J9Uy8MXUmqLxphozZTKjo7PN1WW_miXRA@mail.gmail.com>

Hi Simon,

On 04/09/2016 10:55 AM, Simon Glass wrote:
> On 20 March 2016 at 16:54, Eric Nelson <eric@nelint.com> wrote:
>> On 03/20/2016 03:13 PM, Tom Rini wrote:
>>> On Sun, Mar 20, 2016 at 12:35:53PM -0700, Eric Nelson wrote:
>>>> On 03/17/2016 02:23 PM, Stephen Warren wrote:
>>>>> On 03/16/2016 03:40 PM, Eric Nelson wrote:
>>>>>> Signed-off-by: Eric Nelson <eric@nelint.com>
>>>>>
>>>>> Patch description.
>>>>>
>>>>>> ---
>>>>>>   drivers/mmc/mmc.c       | 10 +++++++++-
>>>>>>   drivers/mmc/mmc_write.c |  7 +++++++
>>>>>
>>>>> Presumably it makes sense for the cache to work for IDE, SATA, USB,
>>>>> SCSI, ... too. I wonder if it's possible to put this code somewhere more
>>>>> central than mmc*.c so it automatically applies to
>>>>> dev_desc->block_read() (see include/part.h). Perhaps not since each
>>>>> implementation supplies its own block_read function directly, so the
>>>>> cache calls do need to be duplicated everywhere.
>>>>>
>>>>
>>>> Yeah. I haven't found a spot that would allow interception of
>>>> the various block_read/write functions.
>>>
>>> Shouldn't DM also help here?
>>
>> I haven't yet looked, but this may be true.
>>
>> I'm seeing some build breakage on master surrounding the use
>> of DM though.
>>
>> If I select DM and BLK on top of nitrogen6q_defconfig, I get
>> lots of build errors.
>>
>> I want to get a V2 RFC patch out before digging through the
>> details of that.
> 
> I'm about to send out a series that rationalises the block devices a
> bit. In the meantime, see u-boot-dm/blkb-working for some MMC ideas.
> 

I figured things out and sent V2 and V3 versions of these patches.

Tom applied V3 to master, though I do still have three patches to
address Stephen's review pending:

http://lists.denx.de/pipermail/u-boot/2016-April/thread.html#250331

https://patchwork.ozlabs.org/patch/605421/
https://patchwork.ozlabs.org/patch/605420/
https://patchwork.ozlabs.org/patch/605422/

Regards,


Eric

  reply	other threads:[~2016-04-10 14:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 18:42 [U-Boot] ext4 and caching Eric Nelson
2016-03-16 21:40 ` [U-Boot] [RFC PATCH 0/2] simple cache layer for block devices Eric Nelson
2016-03-16 21:40   ` [U-Boot] [RFC PATCH 1/2] add block device cache Eric Nelson
2016-03-17 21:16     ` Stephen Warren
2016-03-17 21:33       ` Eric Nelson
2016-03-17 21:41         ` Stephen Warren
2016-03-20 22:13         ` Tom Rini
2016-03-20 22:51           ` Eric Nelson
2016-03-16 21:40   ` [U-Boot] [RFC PATCH 2/2] mmc: add support for " Eric Nelson
2016-03-17 21:23     ` Stephen Warren
2016-03-20 19:35       ` Eric Nelson
2016-03-20 22:13         ` Tom Rini
2016-03-20 22:54           ` Eric Nelson
2016-03-21 18:31             ` Eric Nelson
2016-03-26  0:11               ` Eric Nelson
2016-04-09 17:55             ` Simon Glass
2016-04-10 14:31               ` Eric Nelson [this message]
2016-03-21 14:27         ` Eric Nelson
2016-03-19 15:42 ` [U-Boot] ext4 and caching Ioan Nicu
2016-03-20 15:02   ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570A63D3.6060608@nelint.com \
    --to=eric@nelint.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox