From: Vignesh R <vigneshr@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dm: spi: Read default speed, mode values from DT
Date: Mon, 11 Apr 2016 11:31:30 +0530 [thread overview]
Message-ID: <570B3DBA.5080709@ti.com> (raw)
In-Reply-To: <570B3A97.5050908@ti.com>
On 04/11/2016 11:18 AM, Mugunthan V N wrote:
> On Monday 11 April 2016 10:12 AM, Vignesh R wrote:
>>
>>
>> On 04/09/2016 01:15 AM, Tom Rini wrote:
>>> On Thu, Apr 07, 2016 at 09:02:26PM +0530, Vignesh R wrote:
>>>
>>>> In case of DT boot, don't read default speed and mode for SPI from
>>>> CONFIG_*, instead read from DT node. This will make sure that boards
>>>> with multiple SPI/QSPI controllers can be probed at different
>>>> bus frequencies and modes.
>>>>
>>>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>>>> ---
>>>> cmd/sf.c | 2 ++
>>>> drivers/spi/spi-uclass.c | 8 ++++++--
>>>> 2 files changed, 8 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/cmd/sf.c b/cmd/sf.c
>>>> index 42862d9d921a..4c40d5104422 100644
>>>> --- a/cmd/sf.c
>>>> +++ b/cmd/sf.c
>>>> @@ -88,6 +88,8 @@ static int do_spi_flash_probe(int argc, char * const argv[])
>>>> #ifdef CONFIG_DM_SPI_FLASH
>>>> struct udevice *new, *bus_dev;
>>>> int ret;
>>>> + /* In DM mode defaults wiil be taken from DT */
>>>> + speed = -1, mode = -1;
>
> speed and mode are uint and it is assigned with -1 which is not making
> sense. Assigning 0 will be a better option.
Ah, thanks! I will fix this up in the next version.
--
Regards
Vignesh
prev parent reply other threads:[~2016-04-11 6:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 15:32 [U-Boot] [PATCH] dm: spi: Read default speed, mode values from DT Vignesh R
2016-04-08 19:45 ` Tom Rini
2016-04-11 4:42 ` Vignesh R
2016-04-11 5:48 ` Mugunthan V N
2016-04-11 6:01 ` Vignesh R [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570B3DBA.5080709@ti.com \
--to=vigneshr@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox