From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vignesh R Date: Mon, 11 Apr 2016 11:31:30 +0530 Subject: [U-Boot] [PATCH] dm: spi: Read default speed, mode values from DT In-Reply-To: <570B3A97.5050908@ti.com> References: <1460043146-27918-1-git-send-email-vigneshr@ti.com> <20160408194546.GM23166@bill-the-cat> <570B2B24.9090903@ti.com> <570B3A97.5050908@ti.com> Message-ID: <570B3DBA.5080709@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/11/2016 11:18 AM, Mugunthan V N wrote: > On Monday 11 April 2016 10:12 AM, Vignesh R wrote: >> >> >> On 04/09/2016 01:15 AM, Tom Rini wrote: >>> On Thu, Apr 07, 2016 at 09:02:26PM +0530, Vignesh R wrote: >>> >>>> In case of DT boot, don't read default speed and mode for SPI from >>>> CONFIG_*, instead read from DT node. This will make sure that boards >>>> with multiple SPI/QSPI controllers can be probed at different >>>> bus frequencies and modes. >>>> >>>> Signed-off-by: Vignesh R >>>> --- >>>> cmd/sf.c | 2 ++ >>>> drivers/spi/spi-uclass.c | 8 ++++++-- >>>> 2 files changed, 8 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/cmd/sf.c b/cmd/sf.c >>>> index 42862d9d921a..4c40d5104422 100644 >>>> --- a/cmd/sf.c >>>> +++ b/cmd/sf.c >>>> @@ -88,6 +88,8 @@ static int do_spi_flash_probe(int argc, char * const argv[]) >>>> #ifdef CONFIG_DM_SPI_FLASH >>>> struct udevice *new, *bus_dev; >>>> int ret; >>>> + /* In DM mode defaults wiil be taken from DT */ >>>> + speed = -1, mode = -1; > > speed and mode are uint and it is assigned with -1 which is not making > sense. Assigning 0 will be a better option. Ah, thanks! I will fix this up in the next version. -- Regards Vignesh