From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Mon, 11 Apr 2016 09:06:57 +0200 Subject: [U-Boot] [uboot] [PATCH 7/7] net: phy: dp83867: Add SGMII helper for configuration In-Reply-To: <1460131707-8496-7-git-send-email-dmurphy@ti.com> References: <1460131707-8496-1-git-send-email-dmurphy@ti.com> <1460131707-8496-7-git-send-email-dmurphy@ti.com> Message-ID: <570B4D11.2080605@xilinx.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 8.4.2016 18:08, Dan Murphy wrote: > The code assumed that if the interface is not RGMII configured > then it must be SGMII configured. This device has the ability > to support most of the MII interfaces. Therefore add the > helper for SGMII and only configure the device if the interface is > configured for SGMII. > > Signed-off-by: Dan Murphy > --- > drivers/net/phy/ti.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c > index d503eef..4402c52 100644 > --- a/drivers/net/phy/ti.c > +++ b/drivers/net/phy/ti.c > @@ -219,7 +219,7 @@ static int dp83867_config(struct phy_device *phydev) > (dp83867->fifo_depth << DP83867_PHYCR_FIFO_DEPTH_SHIFT)); > if (ret) > goto err_out; > - } else { > + } else if (phy_interface_is_sgmii(phydev)) { > phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR, > (BMCR_ANENABLE | BMCR_FULLDPLX | BMCR_SPEED1000)); > > Reviewed-by: Michal Simek Thanks, Michal